- 23 Nov, 2017 11 commits
-
-
Georg Neis authored
The typer's ToNumber (and thus ToInteger etc.) returns type None when the input type is BigInt, but we weren't quite ready for that in a few places. R=jarin@chromium.org Bug: v8:7121 Change-Id: Ib12c726338f1ec3dfb9ba5cf54b00cc8d1351a89 Reviewed-on: https://chromium-review.googlesource.com/785130 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#49604}
-
Ross McIlroy authored
Adds some additional RCS counters to correctly account background compilation to the background thread. Also adds a ParseBackgroundProgram as a top-level event for background parsing since otherwise only pre-parsing was being tracked. Perf Sheriffs: Note this is likely to increase the Parse-Background bucket in v8.runtime_stats benchmarks as it now accounts all background parsing correclty. BUG=v8:5203 Change-Id: I6ff614b725d85b0bc1901a7bf0e2bac8de1f7cff Reviewed-on: https://chromium-review.googlesource.com/786237Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49603}
-
Toon Verwaest authored
Bug: Change-Id: I4577db5ae6b9623815969deb03b311bd3b550d75 Reviewed-on: https://chromium-review.googlesource.com/787310Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#49602}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: Ia2ff836fc5b8bba42d9abe74c2387c26a63ad048 Reviewed-on: https://chromium-review.googlesource.com/782499Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michał Majewski <majeski@google.com> Cr-Commit-Position: refs/heads/master@{#49601}
-
Ross McIlroy authored
Previously the ScriptCompiler event for compiling streaming sources was not attaching the runtime trace events to the trace event, which meant the runtime call stats for these were being lost. Perf Sheriffs: This is likely to cause perf regressions in v8.runtime_stats benchmarks because it will start attributing additional events we were losing before. BUG=v8:5203 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I0ef9a10951dc976fb0415ae7b5a91c16e1968ae5 Reviewed-on: https://chromium-review.googlesource.com/786551Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49600}
-
Peter Marshall authored
The tsan skips were getting a bit spread all over the place. Added a section for them below msan and asan to keep things together, where the only cause for skipping the test is tsan. Bug: v8:7093 Change-Id: I606c3ab2f23e4159c12c1e81d28e855412158f15 Reviewed-on: https://chromium-review.googlesource.com/785810 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9c1e28b..61930fd Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/461b345..505de88 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/37921f1..2ffb57b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: If3d0fab2ffad0813e2e60b43f5cee0ad88102cc9 Reviewed-on: https://chromium-review.googlesource.com/786215Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#49598}
-
Alexey Kozyatinskiy authored
.. and bumped version to 1.3! R=dgozman@chromium.org,pfeldman@chromium.org,caseq@chhromium.org,alph@chromium.org,yangguo@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7ece84949fe6078c0777f95ddee1a17dc573c538 Reviewed-on: https://chromium-review.googlesource.com/783272 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#49597}
-
Alexey Kozyatinskiy authored
This roll includes: - [inspector_protocol] fix protocol compatibility check TBR=pfeldman@chromium.org Bug: none Change-Id: If0ae447c2a9cd09c6d3873be57cf1fa6245f618d Reviewed-on: https://chromium-review.googlesource.com/786811Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49596}
-
Alexey Kozyatinskiy authored
If async stack is longer then max depth, we add externalParent as id, client can fetch next max depth async stacks by Debugger.getStackTrace. R=dgozman@chromium.org Bug: chromium:778796 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I89d461e672251f03fb239f4f16ae3b0374fce766 Reviewed-on: https://chromium-review.googlesource.com/776242 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#49595}
-
Alexey Kozyatinskiy authored
If protocol client needs to make step-into async call: - pause before async call using any Debugger agent capabilities, - call Debugger.stepInto with breakOnAsyncCall flag, - wait for Debugger.paused event, this event will contain asyncCallStackTrace if async call is scheduled, - call Debugger.pauseOnAsyncCall on each known target, - resume execution in current debugger by Debugger.resume. Bug: chromium:778796 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I40c56278e7b1ceafc3bf81608b8ca6716c2b3168 Reviewed-on: https://chromium-review.googlesource.com/773573 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
- 22 Nov, 2017 29 commits
-
-
Mircea Trofin authored
Disabling while investigating referenced bug. Bug: chromium:787976 Change-Id: I0388d8902f40e3b2f3759542befd3c6c20b6da38 Reviewed-on: https://chromium-review.googlesource.com/786325 Commit-Queue: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#49593}
-
Bill Budge authored
- Removes TODO implying that moving a 32 bit immediate to a stack slot doesn't require the use of kScratchRegister. While movl can be used to store a 32 bit immediate to memory, it doesn't zero extend leaving part of the slot uninitialized. Bug: Change-Id: I0ebc873b752d508753b624e0b5e262193a568c2b Reviewed-on: https://chromium-review.googlesource.com/784193Reviewed-by:
Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#49592}
-
Alexey Kozyatinskiy authored
Sometimes we need to capture stack trace on one debugger and use it later as a parent stack on another debugger (e.g. worker.postMessage). This CL includes following addition to our protocol and v8-inspector.h: - added Runtime.StackTraceId, this id represents stack trace captured on debugger with given id, - protocol client can fetch Runtime.StackTrace by Runtime.StacKTraceId using Debugger.getStackTrace method, - externalParent field is added to Debugger.paused event, it may contain external parent stack trace, - V8Inspector::storeCurrentStackTrace captures current stack trace and returns V8StackTraceId for embedder this id can be used as argument for V8Inspector::externalAsyncTaskStarted and V8Inspector::externalAsyncTaskFinished method. Any async stack trace captured between these calls will get passed external stack trace as external parent. These methods are designed to be called on different debuggers. If async task is scheduled and started on one debugger user should continue to use asyncTask* API, - Debugger.enable methods returns unique debuggerId. TBR=dgozman@chromium.org,jgruber@chromium.org Bug: chromium:778796 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I2c1a2b2e30ed69ccb61d10f08686f4edb09f50e4 Reviewed-on: https://chromium-review.googlesource.com/786274 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: -
Junliang Yan authored
Port fdb067dc Original Commit Message: This CL introduces those codegen changes necessary for JIT-ing using the WasmCodeManager. R=mtrofin@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Iee9f4f63fe28ab2d25b4b37d10e44a7a1337c7e0 Reviewed-on: https://chromium-review.googlesource.com/783877 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#49590}
-
Igor Sheludko authored
Bug: v8:5799 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Iff62cf07d85b48975d7a21da388bbf6addeb56f1 Reviewed-on: https://chromium-review.googlesource.com/781633 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#49589}
-
Junliang Yan authored
Port a087abb0 Original Commit Message: There's not really a point in passing the resume_mode as parameter to the ResumeGenerator builtin. Instead we could as well just store the mode to the generator object directly. immediately so we don't need to move it there later. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jbarboza@ca.ibm.com BUG= LOG=N Change-Id: I85d064dad444443fa7ba9d6801e32e4048676ceb Reviewed-on: https://chromium-review.googlesource.com/783792Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Bill Budge authored
Bug: v8:6928 Change-Id: Ie414566a8286e0ccb54447828aea660e13bafb94 Reviewed-on: https://chromium-review.googlesource.com/783632Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49587}
-
Bill Budge authored
- Change VirtualMemory to match OS memory concepts. Rename Release Free, ReleasePartial to Release. - Adds comments to make the semantics clear. Right now V8 munmaps on POSIX, making address space available, while on Windows it is only possible to decommit. Bug: chromium:756050 Change-Id: I6ba04d857ab9e1ca1f273e9e766e0825e67210cc Reviewed-on: https://chromium-review.googlesource.com/783513Reviewed-by:
-
Toon Verwaest authored
[interpreter] DYNAMIC_GLOBAL needs to walk the context chain starting from current_scope, not closure_scope The main reason why we currently don't see this fail is that block-scopes always appear to have an extension: the scope info object is stored there. Bug: Change-Id: I38f0c15387e235eeea9a57c95af0d9eb185dad2a Reviewed-on: https://chromium-review.googlesource.com/785951 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49585}
-
Clemens Hammacher authored
This reverts commit 3a41b697. Reason for revert: Break msvc: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20msvc/builds/250 Original change's description: > [inspector] introduced stackTraceId and externalAsyncTask API > > Sometimes we need to capture stack trace on one debugger and use it > later as a parent stack on another debugger (e.g. worker.postMessage). > > This CL includes following addition to our protocol and v8-inspector.h: > - added Runtime.StackTraceId, this id represents stack trace captured > on debugger with given id, > - protocol client can fetch Runtime.StackTrace by > Runtime.StacKTraceId using Debugger.getStackTrace method, > - externalParent field is added to Debugger.paused event, it may > contain external parent stack trace, > - V8Inspector::storeCurrentStackTrace captures current stack trace > and returns V8StackTraceId for embedder this id can be used as > argument for V8Inspector::externalAsyncTaskStarted and > V8Inspector::externalAsyncTaskFinished method. Any async stack > trace captured between these calls will get passed external stack > trace as external parent. These methods are designed to be called > on different debuggers. If async task is scheduled and started on > one debugger user should continue to use asyncTask* API, > - Debugger.enable methods returns unique debuggerId. > > Bug: chromium:778796 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng > Change-Id: I16aba0d04bfcea90f3e187e635a0588c92354539 > Reviewed-on: https://chromium-review.googlesource.com/754183 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49582} TBR=dgozman@chromium.org,pfeldman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,jgruber@chromium.org Change-Id: I9b52354fa0841e5148596cf594317f2e5fe508ea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:778796 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/786152Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49584}
-
Igor Sheludko authored
This CL ensures that elements kind transitions don't cause silent mutable-to-constant or any-to-class-type migrations of in-place generalizable fields. Bug: v8:5495, chromium:783132 Change-Id: Ie60224db62bd45d27148ae0469c7af5a3fe944fd Reviewed-on: https://chromium-review.googlesource.com/785190Reviewed-by:
-
Alexey Kozyatinskiy authored
Sometimes we need to capture stack trace on one debugger and use it later as a parent stack on another debugger (e.g. worker.postMessage). This CL includes following addition to our protocol and v8-inspector.h: - added Runtime.StackTraceId, this id represents stack trace captured on debugger with given id, - protocol client can fetch Runtime.StackTrace by Runtime.StacKTraceId using Debugger.getStackTrace method, - externalParent field is added to Debugger.paused event, it may contain external parent stack trace, - V8Inspector::storeCurrentStackTrace captures current stack trace and returns V8StackTraceId for embedder this id can be used as argument for V8Inspector::externalAsyncTaskStarted and V8Inspector::externalAsyncTaskFinished method. Any async stack trace captured between these calls will get passed external stack trace as external parent. These methods are designed to be called on different debuggers. If async task is scheduled and started on one debugger user should continue to use asyncTask* API, - Debugger.enable methods returns unique debuggerId. Bug: chromium:778796 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I16aba0d04bfcea90f3e187e635a0588c92354539 Reviewed-on: https://chromium-review.googlesource.com/754183Reviewed-by:Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Change-Id: Ieac2714fe9ef787543f2955137178b74fede845a Reviewed-on: https://chromium-review.googlesource.com/781861 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#49581}
-
Mircea Trofin authored
Identify wasm-to-wasm wrappers separately from wasm-to-js ones. Bug: Change-Id: I853ed8fb999297f8a951ebb0e5be1c99bfacc18c Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/782680Reviewed-by:
-
jgruber authored
This test used to run 10M loop iterations to trigger OSR. Let's run 5 instead and trigger OSR manually through the runtime. Bug: v8:7093 Change-Id: Ie0cdb9389ca465bf433e81a17fa60c300edc3e29 Reviewed-on: https://chromium-review.googlesource.com/785693 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I767e5b0fa2bfef73feb3e0bc568c00d22424afa8 Reviewed-on: https://chromium-review.googlesource.com/782560Reviewed-by:
-
Camillo Bruni authored
Bug: chromium:787780 Change-Id: I05f441dc1334a20849fb5afdee8211640f48f6d3 Reviewed-on: https://chromium-review.googlesource.com/785672Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I867f8c92454d5f10a5f22002361bf8cc053dc174 Reviewed-on: https://chromium-review.googlesource.com/782119 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Peter Marshall authored
The test is flaky due to huge string allocation. Bug: v8:7093 Change-Id: I2f17eb8b96b569d84a1f5c9549753fd0ab7fee89 Reviewed-on: https://chromium-review.googlesource.com/785351 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=machenbach@chromium.org BUG=v8:7106 Change-Id: I4064368a3452cc9b6b0ce219e67a9825b1092926 Reviewed-on: https://chromium-review.googlesource.com/785391Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#49574}
-
jgruber authored
These tests can take up to 10 minutes on bots. Split them up to increase parallelism. Bug: v8:7093 Change-Id: Iabfd34a7f2476d4add51da807f2e987e8d1153c9 Reviewed-on: https://chromium-review.googlesource.com/785411Reviewed-by:
-
Clemens Hammacher authored
Arm64 is the only platform where Labels cannot be moved, because the assembler keeps track of pointers to Labels. On all other platforms, there is no need to heap-allocate the Labels. R=titzer@chromium.org Bug: v8:6600 Change-Id: I4e98203890a8c426afa8a1db21e31f30bab892fa Reviewed-on: https://chromium-review.googlesource.com/783210Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49572}
-
Daniel Clifford authored
Bug: chromium:784080 Change-Id: I38c539435d867f6abb80218457e5b5a982e34817 Reviewed-on: https://chromium-review.googlesource.com/785210Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#49571}
-
Clemens Hammacher authored
The Label class currently allows to be copied on all platforms except for arm64, where it can not be copied or moved. This allows too much though: Copying a label even on another platform than arm64 might fail if the label was linked already, because only one of the copies will be bound later, and the other will fire a DCHECK error in its destructor. This CL changes the restriction to never allow to copy construct or assign a Label, but allow move construction and move assignment on all platforms except arm64. This will allow to place Labels in containers, as will be done in Liftoff (except for arm64, where it still needs to be allocated on the heap). R=mstarzinger@chromium.org Bug: v8:6600 Change-Id: Ic1234c2d233317eed6a3d537c13faed2c701fe13 Reviewed-on: https://chromium-review.googlesource.com/783190 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Bug: v8:7113 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I64d41ac2344d1974867647b8c32a9fae384b724a Reviewed-on: https://chromium-review.googlesource.com/784833 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:780749 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I4c993e2147494795402f141049eed30801dfb913 Reviewed-on: https://chromium-review.googlesource.com/782519Reviewed-by:
-
Andreas Haas authored
R=titzer@chromium.org Change-Id: I18a4bcdb002d63c0d5476ce4ff3edd466489b518 Reviewed-on: https://chromium-review.googlesource.com/785092Reviewed-by:
-
Michael Lippautz authored
Users should migrate to using the versions on Isolate. Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I4fe956a4210308701f343a3a681d9d6f1b1f2d2b Reviewed-on: https://chromium-review.googlesource.com/784832Reviewed-by:
-
Michael Achenbach authored
This reverts commit 9cbb2ed4. Reason for revert: Causes flakiness, see http://shortn/_FEVutYBGP7 Original change's description: > [heap] Removed keep-one-unused-page concept in sweeper. > > This works because we pool regular non-executable pages on a lower level. Executable pages are currently not supported by the pooling mechanism. If this regresses we should fix it. > > Change-Id: Ief3484d59f1f1f4bc63f8e718482e4174bedc012 > Reviewed-on: https://chromium-review.googlesource.com/778939 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49536} TBR=hpayer@chromium.org,mlippautz@chromium.org Change-Id: If46fe713f1b1440246803e110838a3958f21dcdf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/785090Reviewed-by:
-
