- 09 May, 2019 35 commits
-
-
Milad Farazmand authored
<limits> header is needed to compile successfully on PPC. Needed for std::numeric_limits Change-Id: Ice2d3c6416dec4ff09d15a20fcba9659239faa09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601729Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#61392}
-
Maciej Goszczycki authored
Bug: chromium:957934 Change-Id: Ia1ce5f6150b7f862b38f4c135236b154a1b02d6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594564Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Cr-Commit-Position: refs/heads/master@{#61391}
-
Joshua Litt authored
Per 262, yield* for async generators is supposed to Await the input value. #sec-generator-function-definitions-runtime-semantics-evaluation Section 14.4.13, yield *, 7.c.iii.1 Bug: v8:9051 Change-Id: Ie1e829309fe78683a9ff0adf816208c2bf0bb524 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600508 Commit-Queue: Joshua Litt <joshualitt@google.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#61390}
-
Z Duong Nguyen-Huu authored
Refactor CheckHasTrapResult as well. Spec: https://tc39.github.io/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-hasproperty-p Bug: v8:6664 Change-Id: Ic9bacbd21bb329e354ebd08b61d9e60a94534d0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601895 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#61389}
-
Adam Klein authored
This reverts commit 652e32f9. Reason for revert: speculative revert due to flaky test failures: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20nosnap%20-%20debug/23920 Original change's description: > [heap] Make trampoline CodeDataContainers immutable and deduplicate them > > Moves all trampoline CodeDataContainers to read-only space, making them > immutable. Containers with no 'kind specific flags' set or 'promise > rejection' flag are deduplicated by replacing them with the new canonical > CodeDataContainers roots. > > This saves around 36KB from the snapshot. > > RO_SPACE NEW_SPACE OLD_SPACE CODE_SPACE MAP_SPACE LO_SPACE > old 32048 0 225944 149280 20240 0 > new 32120 0 189344 149280 20240 0 > > > Bug: v8:7464 > Change-Id: Iedd538a86311ef501cd88c90ec75e1308195762f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601257 > Commit-Queue: Maciej Goszczycki <goszczycki@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61378} TBR=ulan@chromium.org,delphick@chromium.org,goszczycki@google.com Change-Id: Ifaf9987bc3770f9e80701e8d011ab19da5c747ca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7464 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1602877Reviewed-by:
-
Joyee Cheung authored
This patch implements the declarations of private methods, the access of private methods would be left to a future patch. When a private methods declaration is encountered, we now: - Create a brand symbol during class evaluation and store it in the context. - Create the closures for the private methods - Load the brand from the context and store it in the instance in the constructor. Design: https://docs.google.com/document/d/1T-Ql6HOIH2U_8YjWkwK2rTfywwb7b3Qe8d3jkz72KwA/edit# Bug: v8:8330 Change-Id: I2d695cbdc8a7367ddc7620d627b318f779d36150 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1568708 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#61387}
-
Maya Lekova authored
Bug: v8:7790 Change-Id: I9d1853a65ad5430e5bc38727ebf9fcd6aa40c819 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599605 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#61386}
-
Igor Sheludko authored
This is a first step towards unification of Object and MaybeObject definitions. Having an TaggedImpl template will simplify adding compressed variants of Object and MaybeObject which is required for avoiding unnecessary value decompression in tight value copying loops and write barrier implementations. Bug: v8:7703, v8:9183 Change-Id: I4c1931c22359533d50cf4a2c7f1339dd55c0c707 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588460Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#61385}
-
Tamer Tas authored
When retries succeed, the perfrunner masks the timeouts. This CL exposes those failures. R=sergiyb@chromium.org Bug: chromium:841700 Change-Id: Ia69a191e84fd994bd25deb2d7019f7acf11db45c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1602695Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#61384}
-
Maciej Goszczycki authored
Bug: v8:7464 Change-Id: Id191c185ebe811a7e8830cbdfd7751ee4f7b6060 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1602693Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Cr-Commit-Position: refs/heads/master@{#61383}
-
Mythri A authored
Bug: v8:8394 Change-Id: Ica3e1bfc1b272ad0e5e45cc0cae870a30822b624 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601265Reviewed-by:
-
Maya Lekova authored
This reverts commit f2e65226. Reason for revert: Speculative revert, seems to break GC stress bot and block LKGR - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/25701 Original change's description: > Reland "[compiler] Don't collect source positions for the top frame" > > Fixed crashes by adding missing call to EnsureSourcePositionsAvailable, > which requires clearing and restoring the pending exception. > > > While most source positions were not collected even throwing exceptions, > > the top frame still was always collected as it was used to initialize > > the JSMessageObject. This skips even that frame, by storing the > > SharedFunctionInfo and bytecode offset in the JSMessageObject allowing > > it to lazily evaluate the actual source position. > > > > Also adds tests to test-api.cc that test each of the source position > > functions in isolation to ensure that they don't rely on previous > > invocations to call the source collection function. > > > > Since no source positions are now collected at the point when an > > exception is thrown, the mjsunit/stack-traces-overflow now passes again > > with the flag enabled. (cctest/test-cpu-profiler/Inlining2 is now the > > only failure). > > Bug: v8:8510 > Change-Id: Ifa5fe31d3db34a6c6d6a9cef3d646ad620dabd81 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601270 > Commit-Queue: Dan Elphick <delphick@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61372} TBR=ulan@chromium.org,rmcilroy@chromium.org,delphick@chromium.org Change-Id: Ie590df6c308b38836afc5d417d03d2a63260bcb2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8510 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1602692Reviewed-by:
-
Santiago Aboy Solanes authored
Started as a cleanup of my own CLs but I noticed there were some checks that I could update as well. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703, v8:9183 Change-Id: I19092347e33324c24ff4396fa35c40a311c45799 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594557 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#61380}
-
Clemens Hammacher authored
The function body decoder stored popped arguments in a field of the decoder class, which is a non-obvious side channel. This CL refactors this to return the popped vector directly instead. In local benchmarks, this has no measurable performance impact. R=titzer@chromium.org Bug: v8:9183 Change-Id: I79b28e349e3009b9f01be25f116c4085ca569ca7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596732Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#61379}
-
Maciej Goszczycki authored
Moves all trampoline CodeDataContainers to read-only space, making them immutable. Containers with no 'kind specific flags' set or 'promise rejection' flag are deduplicated by replacing them with the new canonical CodeDataContainers roots. This saves around 36KB from the snapshot. RO_SPACE NEW_SPACE OLD_SPACE CODE_SPACE MAP_SPACE LO_SPACE old 32048 0 225944 149280 20240 0 new 32120 0 189344 149280 20240 0 Bug: v8:7464 Change-Id: Iedd538a86311ef501cd88c90ec75e1308195762f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601257 Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by: -
Santiago Aboy Solanes authored
Since we updated the access builders, in particular AccessBuilder::ForMap(), the StoreField from CSA's OptimizedStoreMap was missing the corresponding ChangeTaggedPointerToCompressedPointer node. Tests were passing, but it was failing to compile with verify CSA enabled. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: I0ddb03eb2ba19b55f9b9cef4eef94e32bc84ef18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601506 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Mythri A authored
Moved tests for IIFEs/top level code to AllocationSiteCreationForIIFE. It is not possible to use %EnsureFeedbackVector for these tests. They just turn the lazy_feedback_allocation flag to false. Bug: v8:8394 Change-Id: Id18cb43bf350efc1a26d04b9c3fce4f638dbda84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601507 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Change-Id: Ie9606382c19723c3eae935b463d1bd31e52529fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601424Reviewed-by:
-
Michael Starzinger authored
This fixes the source position printed in the stack trace for exceptions rethrown from within Wasm code. This only affects the message propagated to the console, not the trace stored as part of the exception object. Note that there still is a more fundamental issues with preserving the original message of a caught exception and funneling it through to each rethrow site, which is still missing. This change just makes sure that the interpreter and TurboFan are consistent. R=clemensh@chromium.org TEST=message/fail/wasm-exception-rethrow BUG=v8:8091 Change-Id: Iac04149ded3c54f5b23faeb83b1228081bbd3dfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598754Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61374}
-
Dan Elphick authored
Removes: * ReturnValue::Set(Persistent) * String::NewFromUtf8/NewFromTwoByte/NewExternal overloads that returned Locals instead of MaybeLocal * String::NewStringType Now that the old String overloads are gone, the new ones can now have a default parameter for NewStringType matching the old overloads. Bug: v8:7289, v8:7281, v8:9183 Change-Id: If66e6d587ac778e015c281b376a9b4d6093f6ec3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591605Reviewed-by:
-
Dan Elphick authored
Fixed crashes by adding missing call to EnsureSourcePositionsAvailable, which requires clearing and restoring the pending exception. > While most source positions were not collected even throwing exceptions, > the top frame still was always collected as it was used to initialize > the JSMessageObject. This skips even that frame, by storing the > SharedFunctionInfo and bytecode offset in the JSMessageObject allowing > it to lazily evaluate the actual source position. > > Also adds tests to test-api.cc that test each of the source position > functions in isolation to ensure that they don't rely on previous > invocations to call the source collection function. > > Since no source positions are now collected at the point when an > exception is thrown, the mjsunit/stack-traces-overflow now passes again > with the flag enabled. (cctest/test-cpu-profiler/Inlining2 is now the > only failure). Bug: v8:8510 Change-Id: Ifa5fe31d3db34a6c6d6a9cef3d646ad620dabd81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601270 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Going back on https://chromium-review.googlesource.com/c/v8/v8/+/1480382 since now 'tagged' means 'full tagged' again. I am keeping the access builder since that seems useful to have (as opposed to building the access builder in the implementation). Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703, v8:9206 Change-Id: I7c38b090190aa1c3e91c5ab9f729588aeae2dc1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594439 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Sergiy Belozorov authored
R=machenbach@chromium.org, tmrts@chromium.org Bug: chromium:880724 Change-Id: I2b8ede244fa09868eef384b967223a3788ddd2a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581180 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61370}
-
Michael Achenbach authored
NOTRY=true Bug: v8:9217 Change-Id: I9e7a834ec7a19b1d1a4469b6024e08e21b5c1921 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599603 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
Paolo Severini authored
The original CL title was updated to reflect CL contents. The --win64-unwinding-info flag still exists but it is set by default. This is a reland of efd8c2d9 Original change's description: > Remove --win64-unwinding-info flag and always generate unwind info on Win/x64 > > The generation of unwind info to enable stack walking on Windows/x64 > (https://chromium-review.googlesource.com/c/v8/v8/+/1469329) was implemented > behind a temporary flag, in order to coordinate these changes with the > corresponding changes in Chromium. > > The required changes to Chromium > (https://chromium-review.googlesource.com/c/chromium/src/+/1474703) have also > been merged, so we can now remove the flag and enable the generation of stack > unwinding info by default on Windows/x64. > > Bug: v8:3598 > Change-Id: I88814aaeabecc007f5262227aa0681a1d16156d5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1573138 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Paolo Severini <paolosev@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#61020} Bug: v8:3598, chromium:958035 Change-Id: Ie53b39f3bb31567797a61e5110685284c266c1f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599596 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Yang Guo authored
This reverts commit 4faf5a7f. Reason for revert: change of plans. Original change's description: > Add more OWNERS for DevTools protocol definitions > > R=alph@chromium.org > > Change-Id: I615b9274cd0f6128d3f2377ef9dacb6aa1980446 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601494 > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61365} TBR=dgozman@chromium.org,alph@chromium.org,pfeldman@chromium.org,yangguo@chromium.org Change-Id: Ida51f3b315d020abe0b34dceb4e54f7d92971035 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601501Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61367}
-
Peter Marshall authored
We pretty much always want tracing data as a JSON file. Implement a Consumer which converts protos to the JSON trace events format. This duplicates a lot of the internals of TraceWriter in trace-writer.cc but we will remove that eventually. Cq-Include-Trybots: luci.v8.try:v8_linux64_perfetto_dbg_ng Bug: v8:8339 Change-Id: I85f86562f1b3c4d24ecd755413d1c3f88b292adb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541042 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Yang Guo authored
R=alph@chromium.org Change-Id: I615b9274cd0f6128d3f2377ef9dacb6aa1980446 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601494Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61365}
-
Seth Brenith authored
Gcov builds such as https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20gcov%20coverage/18276 are failing because they can't find std::copy_if. Including the right header fixes it. Change-Id: I3f0e3fabfe1b32cc4492aee64d2b9f23fa4afdcb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600431Reviewed-by:
-
Maya Lekova authored
This reverts commit 2b24cd03. Reason for revert: Causes layout test failures https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/275121 and https://ci.chromium.org/p/chromium/builders/try/win7-rel/86354 Original change's description: > [heap] Skip read-only space in Heap::Contains > > Bug: v8:7464 > Change-Id: I27e82cdf0f8cc56ff68dcfaecab9644fe74916c7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559861 > Commit-Queue: Maciej Goszczycki <goszczycki@google.com> > Reviewed-by: Dan Elphick <delphick@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61350} TBR=ulan@chromium.org,delphick@chromium.org,goszczycki@google.com Change-Id: I13cc09dd44a10bad854fa861b6e43149babb1b5e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7464 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601498Reviewed-by:
-
Dan Elphick authored
Puts back source position collection for inlined functions when concurrent inlining is not enabled. Bug: v8:8510 Change-Id: I8e8a7ef15c0854b1e37299a007303b3213988cf6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601266 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
The implementation of the method is long gone, just the declaration was left for some reason. Bug: v8:9183 Change-Id: Id68fc6afa63c3663769f9d8e0a6bc1a7a3aa5e35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601497 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Z Duong Nguyen-Huu authored
Bug: v8:8996 Change-Id: I63ae821086c42c14a317e866fb4f0f799f4c4f7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1597555 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#61360}
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/63246bb..cfe8887 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d376ad0..4e921e4 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f8847c1..09e818b Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e7f0b4c..43d3bb8 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/ae4b77d..3a162e7 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Ib4ed22461db8ae917a66a1a1799ed09336b685c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601580Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#61359}
-
tzik authored
A DCHECK in LookupIterator::name hits when we add a indexed property, as it requires a named property. This replaces it with GetName to avoid the failure. Bug: chromium:959727 Change-Id: I1e98b313ec9257db80460a34d691016acbceb3c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1597372 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
- 08 May, 2019 5 commits
-
-
Frank Tang authored
Bug: v8:7729 Change-Id: Ide6422a9315f56ada584156124037039ea591086 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600368Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#61357}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/ba013cf7f..2682ab57c Bug: v8:7834 Change-Id: I918c223d7fee5d70f9ca645a44eb23e03ef745c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600367Reviewed-by:
-
Johannes Henkel authored
This will allow me to reuse the routines for the inspector_protocol/encoding/encoding_test, rather than copy them. I've already verified that this works. Change-Id: I5b61e4f48c2d00d9d0a5305c9790093c66b3c765 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600360 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: v8:9093 Change-Id: If899e36d4fbef711118ff8d7730ff9acd118d8b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599600Reviewed-by:
-
Aleksei Koziatinskii authored
There are two possible type: - scriptParsed - breakpoint for any script, - scriptWithSourceMapParsed - breakpoint for script with sourceMappingURL. When one of the breakpoints is set then for each matched script we add breakpoint on call to top level function of that script. Node: https://github.com/nodejs/node/issues/24687 R=dgozman@chromium.org Bug: chromium:887384,chromium:724793,chromium:882909 Change-Id: I9c08b2a2a5ba7006adfedd85fc92ae191517af00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1354245Reviewed-by:
-
