- 05 Mar, 2019 11 commits
-
-
Junliang Yan authored
Port 9c7b6e1e Original Commit Message: This is the implementation of crrev.com/c/766371 for arm. Original description: Add the ability to return (multiple) return values on the stack: - Extend stack frames with a new buffer region for return slots. This region is located at the end of a caller's frame such that its slots can be indexed as caller frame slots in a callee (located beyond its parameters) and assigned return values. - Adjust stack frame constructon and deconstruction accordingly. - Extend linkage computation to support register plus stack returns. - Reserve return slots in caller frame when respective calls occur. - Introduce and generate architecture instructions ('peek') for reading back results from return slots in the caller. - Aggressive tests. - Some minor clean-up. R=ahaas@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, miladfar@ca.ibm.com BUG= LOG=N Change-Id: I83df1af8c49f6d6c5b529db599fce61a1da2490d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1496549Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60032}
-
Ben L. Titzer authored
When a function is exported from a WebAssembly module, it is implicitly wrapped in a WasmExportedFunction. For functions that were imports into this module, the exported function appears like other Wasm function, e.g. can be used in tables. When that exported function was re-imported to another module, the logic to compute the import kind mistakenly assumed the exported function was indeed originally a Wasm function and tried to call it directly, instead of treating it like an imported JS function. R=ahaas@chromium.org BUG=v8:8947 Change-Id: Ib8fac81fbe0f49c50cfbfb2e69d9bb60aef91fcc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503632 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: v8:8945 Change-Id: I2ee060c03496bbcb388d82fd05ecc61658047f98 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503633Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60030}
-
Hannes Payer authored
Bug: v8:8945 Change-Id: I4e5f08a722e83fd8b4accb066eca50242a116a6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503452Reviewed-by:
-
Ulan Degenbaev authored
This allows us to change the page size without affecting Scavenger heuristics and performance. Bug: chromium:852420 Change-Id: Idcff4296e88e16f9af0ee6ecd00c63d789866fd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1499494 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60028}
-
Tobias Tebbi authored
Bug: chromium:937649 Change-Id: I13c64a7cab7a6f1668c546114610006d0d6b91ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1501052Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#60027}
-
Pierre Langlois authored
The `TurboAssembler::CallRecordWriteStub()` method which generates out-of-line code to call the write barrier would push and pop arguments to move them to different registers. Let's use `mov` instructions instead, making sure we handle overlapping registers. Change-Id: Ideb654cd558e984ccb90c7cf44b1c2c49f1c5b50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1499496 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL changes the language server to store file paths as URIs and decodes them on-demand during compilation. For now, this will eliminate the need for an URI encoding function. R=tebbi@chromium.org Bug: v8:8880 Change-Id: If79f635cb60035f58712c1458ecca3bfa23a6e47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1502992 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#60025}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9e80056..80892bf Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b3bee2e..ccc2908 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e9e89e3..cf661ac Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/5ec7f0c..efecb0b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id94d65fceb3dad447e57c9cf27905e325c484330 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1501468Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60024}
-
Bill Ticehurst authored
Launching Python scripts can fail on Windows if the Python executable isn't given as the first argument to the shell. This change adds the path of the current Python executable, as per the behavior of v8gen.py Change-Id: Iedaf57bcafc4c6aa6ebb89e945ee967cf393da04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497522Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#60023}
-
Deepti Gandluri authored
This reverts commit 821bc649. Reason for revert: Fails on ARM hardware :( https://ci.chromium.org/p/v8/builders/ci/V8%20Arm%20-%20debug/9271 Original change's description: > [wasm simd] Fix F32x4 Min and Max > > - Fix F32x4 tests to save results in globals, so they can be checked > in C++ code. Perform correct checks in case of NaNs. > - Fix ia32, x64 implementations of F32x4Min, F32x4Max to correctly > deal with NaNs. > - Enable tests for all float values on all platforms, except skip > denormalized results on ARM, and skip extreme values for reciprocal, > reciprocal square root approximation opcodes. > - Disable Min, Max test for interpreter (see v8:8425) since it doesn't > handle NaNs correctly. > - Fix vmin, vmax implementations in ARM simulator. > > Bug: v8:8639 > Change-Id: I87e188e3cb078f09fdacfd9955f426c20a11bf64 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495897 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60021} TBR=bbudge@chromium.org,gdeepti@chromium.org Change-Id: Ib0dc8395ff86263fe0c02faa53d90c7da46b50a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8639 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1501732Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60022}
-
- 04 Mar, 2019 29 commits
-
-
Bill Budge authored
- Fix F32x4 tests to save results in globals, so they can be checked in C++ code. Perform correct checks in case of NaNs. - Fix ia32, x64 implementations of F32x4Min, F32x4Max to correctly deal with NaNs. - Enable tests for all float values on all platforms, except skip denormalized results on ARM, and skip extreme values for reciprocal, reciprocal square root approximation opcodes. - Disable Min, Max test for interpreter (see v8:8425) since it doesn't handle NaNs correctly. - Fix vmin, vmax implementations in ARM simulator. Bug: v8:8639 Change-Id: I87e188e3cb078f09fdacfd9955f426c20a11bf64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495897 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Ben Smith authored
Passive elements have a different binary format, where the contents are instructions instead of function indexes: 0xd0 0x0b -> (ref.null) 0xd2 var:x 0x0b -> (ref.func x) Bug: v8:8891 Change-Id: Ie7e8efe7b5acdf99622880dd97d28d3c13744dff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497516 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by: -
Deepti Gandluri authored
Change-Id: I092fff31b9cffef673f6929a510b3e643ab0ee29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1496274Reviewed-by:
-
Yang Guo authored
This reverts commit f8a67670. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/25576 I don't think I've seen MSAN being flaky. Chances are that the change to SFI's object layout indeed left some field uninitialized. Original change's description: > Remove builtin-function-id in SFI > > builtin_function_id corresponded to BuiltinFunctionId (a manually maintained list of 'interesting' functionsmainly used during optimization). With this change, we nuke builtin-function-id in favor of builtin-id and 8 bits is freed up in SFI. > > Bug: v8:6993 > Change-Id: Iee9b539475bc6531c9aa65b1904d1402a9ef30db > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495898 > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60017} TBR=ulan@chromium.org,jgruber@chromium.org,leszeks@chromium.org,bmeurer@chromium.org,duongn@microsoft.com Change-Id: Ic3964ce182ddbd7ef529ddb8b78b9bdfb1be7887 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6993 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1499500Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#60018}
-
Z Duong Nguyen-Huu authored
builtin_function_id corresponded to BuiltinFunctionId (a manually maintained list of 'interesting' functionsmainly used during optimization). With this change, we nuke builtin-function-id in favor of builtin-id and 8 bits is freed up in SFI. Bug: v8:6993 Change-Id: Iee9b539475bc6531c9aa65b1904d1402a9ef30db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1495898 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
David Benjamin authored
If buffer_ is empty and start_ is zero, even though the MemCopy would be a no-op, &buffer_[start_] is undefined. buffer_.data() + start_ would work, but due to a C/C++ language bug, that is technically undefined too[*] if an empty buffer_.data() returns nullptr, so add a length() == 0 check, matching methods above. This was caught by building with _LIBCPP_DEBUG=0. [*] https://www.imperialviolet.org/2016/06/26/nonnull.html Bug: chromium:893810 Change-Id: I9f0834ffae6769e0e191e786842e6ecc6c95a58a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1483616Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#60016}
-
Irina Yatsenko authored
AllocateUninitializedJSArrayWithElements into the method. Prior to the change, if the caller forgets to handle empty case on their side, AllocateUninitializedJSArrayWithElements would allocate a new empty FixedArray rather than return the canonical one. This refactor shifts the burden of canonicalization from the callers to AllocateUninitializedJSArrayWithElements. Bug: v8:6777 Change-Id: I1246cb288861b65b51938414a454f21af78f8399 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1480330Reviewed-by:
-
Simon Zünd authored
Moving to gtest allows negative test cases as the current parser implementation exits the process on a parser error. The CL adds two small negative tests. The idea is less to get full coverage, but to have a place for regression tests. Drive-by-change: Lexer errors need a valid source position scope and Json parser needs a valid SourceId, otherwise we read OOB when the error message is generated. R=petermarshall@chromium.org Bug: v8:8880 Change-Id: I56c4b9e0a29c8333b2e5e44f8116e5178552d2f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1498472Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60014}
-
Igor Sheludko authored
This CL also gives up trying to maintain double and system word fields at aligned addresses because currently it's not always maintained (v8:8875) and Torque object definitions do not support padding fields (v8:8863). Given that both platforms where pointer compression is going to be enabled (x64 and arm64) support loading of doubles and full words from 4-byte aligned addresses we are fine. Bug: v8:7703 Change-Id: I99fc6da5a0927f4db9b8fb24c7cc0bfc416523bc Reviewed-on: https://chromium-review.googlesource.com/c/1496974 Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Georg Neis authored
... by skipping over them. Such variables appear in the case of direct namespace exports and default exports. (Actually, the name used for default exports used to be "*default*" which is not recognized as synthetic, so I'm renaming it here to ".default"). Bug: chromium:932111 Change-Id: I0554dae9614334fdc02e78606f2db47e92196429 Reviewed-on: https://chromium-review.googlesource.com/c/1494010 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This CL removes PPC specific constants and makes the regular heap object size limit a power of two. Bug: chromium:852420 Change-Id: I5f4000f76d029d689d22112877eea124774b29d2 Reviewed-on: https://chromium-review.googlesource.com/c/1496367Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:8880 Change-Id: I835c465ccb63bcc20e9ec9cafda153a49de2bf7d Reviewed-on: https://chromium-review.googlesource.com/c/1497010Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#60010}
-
peterwmwong authored
Bug: v8:8906 Change-Id: I61c04471530ecf8b97e1e6a0670f52f55232395e Reviewed-on: https://chromium-review.googlesource.com/c/1497517 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
-
Simon Zünd authored
This CL introduces a declaration_position_ field on TypeAlias, corresponding with the SourcePosition of the name of the Type where it is declared. This information is needed by the language server for "goto defintion". R=tebbi@chromium.org Bug: v8:7793 Change-Id: I0de2f7b7ba23b86de34441107ca9982d190c227f Reviewed-on: https://chromium-review.googlesource.com/c/1497952 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
peterwmwong authored
Bug: v8:8906 Change-Id: I7a07482d2d5de13de11fa2611e3c6ae18439e820 Reviewed-on: https://chromium-review.googlesource.com/c/1493136 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
In the early days of Chrome when we used WebKit there was no support for ASCII strings on the C++ side, so we put a hint onto these two-byte strings that said "string only contains one byte data", such that internally in V8 when these were involved in string operations, we could instead create the *cheaper* one byte strings. Nowadays Blink properly supports one-byte string representations and this additional hint only comes with overhead, since we check it in quite a few places (i.e. on the hot path for string concatenation), plus we end up consuming more memory due to the additional string maps. Removing the hint also frees one bit in the InstanceType zoo for strings. This alone improves performance on the `bench-dom-serialize.js` test case by around **3%**. Tbr: mstarzinger@chromium.org Bug: v8:6622, v8:8834, v8:8939 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Change-Id: I0753f2859cee7b5a37b6f0da64d8ec39fcb044ff Doc: https://bit.ly/fast-string-concatenation-in-javascript Reviewed-on: https://chromium-review.googlesource.com/c/1498478 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:7703 Change-Id: I3d521423eec725915d1a197c79c076ad54eeef14 Reviewed-on: https://chromium-review.googlesource.com/c/1496368Reviewed-by:
-
Sven Sauleau authored
Removes the result_size parameter in TFC definitions which can be infered from the provided CallInterfaceDescriptor. Previously, the result size was added to support stubs with custom linkage. However, In pratice, the size don't differ from the provided CallInterfaceDescriptor (given that it's a DCHECK) and use mostly JS linkage (only one return). Change-Id: I8efdb3e3ce1a470735dac84ec6be506e071d2756 Bug: v8:6116 Reviewed-on: https://chromium-review.googlesource.com/c/1495554 Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#60004}
-
Dan Elphick authored
This adds a new method Isolate::LocaleConfigurationChangeNotification that clears the cached Locale allowing new Locales to be picked up in later Locale operations. It moves Date::DateTimeConfigurationChangeNotification to Isolate (deprecating the old one) so that the configuration change methods are found together. Change-Id: Iffc15e326933c5bc5baf2f0eafdd5c148b8279a8 Reviewed-on: https://chromium-review.googlesource.com/c/1491608Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#60003}
-
Dan Elphick authored
Removes JavaScriptFrame::CollectTopFrameForICStats whose last usage was removed in https://chromium-review.googlesource.com/626016. Bug: v8:8834 Change-Id: I9ffad0c712816696c56b746a137bed30362550bc Reviewed-on: https://chromium-review.googlesource.com/c/1496365 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60002}
-
Ross McIlroy authored
BUG=v8:8801 Change-Id: I9d9d9824c6c9ad0176bbfd3723da1b578b17c256 Reviewed-on: https://chromium-review.googlesource.com/c/1495555 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#60001}
-
Sigurd Schneider authored
This reverts commit 131f4a30. Reason for revert: Breaks snapshot builder: https://ci.chromium.org/p/v8/builders/ci/Linux%20Snapshot%20Builder/16103 Original change's description: > [gn] use relative paths for gtest and gmock > > TBR=machenbach@chromium.org > > Bug: v8:8941 > Change-Id: I0bbd119f7a613785b6e5e01cd8e59d5de40d68e1 > Reviewed-on: https://chromium-review.googlesource.com/c/1498473 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59996} TBR=machenbach@chromium.org,yangguo@chromium.org Change-Id: Ia2f377aa2e0fc69206104c4942085a9ded4534e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8941 Reviewed-on: https://chromium-review.googlesource.com/c/1497077 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60000}
-
peterwmwong authored
As the TODO's indicate, these helpers only used by TypedArray#join when it was implemented in JS. As of https://chromium-review.googlesource.com/c/v8/v8/+/1369330 TypedArray#join is now implemented Torque and was optimized in a way that no longer requires these helpers anymore. Bug: v8:7624 Change-Id: I1d1ff80235a12feb3846ff92764e8593ce7c72c9 Reviewed-on: https://chromium-review.googlesource.com/c/1498692Reviewed-by:
-
Dan Elphick authored
BytecodeArray::SourcePosition and BytecodeArray::SourceStatementPosition have no implementations and are never called. Bug: v8:8834 Change-Id: I919c871795084766856dfbff5344c037b6f33dd0 Reviewed-on: https://chromium-review.googlesource.com/c/1497009 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#59998}
-
Yu Yin authored
Change-Id: I3be3dc8815015c0215d3e3d655394850d85db871 Reviewed-on: https://chromium-review.googlesource.com/c/1490812Reviewed-by:
Predrag Rudic <prudic@wavecomp.com> Reviewed-by:
-
Yang Guo authored
TBR=machenbach@chromium.org Bug: v8:8941 Change-Id: I0bbd119f7a613785b6e5e01cd8e59d5de40d68e1 Reviewed-on: https://chromium-review.googlesource.com/c/1498473Reviewed-by:
-
Yu Yin authored
After 54a18895, Bug:7464, the permission of the page is read only, but this function need write permission. Since this function is not used, just remove it. Change-Id: I5a5976ab773bd808920893bbd2e3d9796e89e804 Reviewed-on: https://chromium-review.googlesource.com/c/1490813Reviewed-by:
-
Yu Yin authored
Change-Id: I2264b7850f2c091bfd28d90c5bfe36dcfe6e8a11 Reviewed-on: https://chromium-review.googlesource.com/c/1369908Reviewed-by:
-
Benedikt Meurer authored
Remove the duplication of the allocation logic via the AllocateOneByteConsString and AllocateTwoByteConsString helpers, and instead just have a diamond to figure out the result map. This reduces code size of the StringAdd_CheckNone builtin and even seems to be beneficial performance wise. It seems to improve the performance on the `bench-dom-serialize.js` test by around 1% just doing this. Drive-by-fix: Remove the `flags` from CodeStubAssembler::StringAdd() and its helpers, since we no longer support pretenuring of string additions (for quite a while now). Bug: v8:8834, v8:8939 Change-Id: Ia23e02c974b5f572930fcd45be0643094ab2fa98 Doc: https://bit.ly/fast-string-concatenation-in-javascript Reviewed-on: https://chromium-review.googlesource.com/c/1498133 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
