- 25 Oct, 2016 1 commit
-
-
yangguo authored
R=jgruber@chromium.org BUG=v8:5559 Review-Url: https://codereview.chromium.org/2445233004 Cr-Commit-Position: refs/heads/master@{#40549}
-
- 18 Oct, 2016 1 commit
-
-
kozyatinskiy authored
debug-interface.h contains part of v8-debug.h that is used by src/inspector. BUG=v8:5510 R=dgozman@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2423713003 Cr-Commit-Position: refs/heads/master@{#40404}
-
- 17 Oct, 2016 1 commit
-
-
gsathya authored
BUG=v8:5343 Review-Url: https://codereview.chromium.org/2415023002 Cr-Commit-Position: refs/heads/master@{#40369}
-
- 07 Oct, 2016 1 commit
-
-
mstarzinger authored
This removes the restriction of only allowing lazy compilation for top-level eval code with a context. We can by now compile such code without a concrete closure. R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2400973002 Cr-Commit-Position: refs/heads/master@{#40089}
-
- 28 Sep, 2016 1 commit
-
-
adamk authored
R=neis@chromium.org Review-Url: https://codereview.chromium.org/2372373002 Cr-Commit-Position: refs/heads/master@{#39842}
-
- 15 Sep, 2016 1 commit
-
-
littledan authored
Handle the "synchronous case" by marking try/catch blocks introduced for async functions as ASYNC_AWAIT and traversing up the stack, finding successive Promises and returning caught if any of them are predicted to be caught. BUG=v8:5167 Review-Url: https://codereview.chromium.org/2325813002 Cr-Commit-Position: refs/heads/master@{#39433}
-
- 07 Sep, 2016 1 commit
-
-
ulan authored
Now callers of Heap::CollectGarbage* functions need to specify the reason as an enum value instead of a string. Subsequent CL will add stats counter for GC reason. BUG= Review-Url: https://codereview.chromium.org/2310143002 Cr-Commit-Position: refs/heads/master@{#39239}
-
- 06 Sep, 2016 1 commit
-
-
marja authored
Rebuilding (after touching certain files) is crazy slow because includes are out of control. The (last remaining) offending include path is: ast.h <- liveedit.h <- debug.h <- src/x64/assembler-whatever-port-inl.h <- src/macro-assembler.h <- everything possible With this CL, the rebuild steps needed when touching ast-value-factory.h drops from 365 to 181. BUG=v8:5294 TBR=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2316443002 Cr-Commit-Position: refs/heads/master@{#39195}
-
- 19 Aug, 2016 1 commit
-
-
marja authored
Rebuilding (after touching certain files) is crazy slow because includes are out of control. Fixing it: - Don't include stuff in headers unless necessary. - Include the stuff you need, not some other stuff that happens to include the stuff you need. BUG=v8:5294 Review-Url: https://codereview.chromium.org/2260483002 Cr-Commit-Position: refs/heads/master@{#38740}
-
- 12 Aug, 2016 3 commits
-
-
yangguo authored
R=mstarzinger@chromium.org BUG=v8:5265 Review-Url: https://codereview.chromium.org/2240103002 Cr-Commit-Position: refs/heads/master@{#38607}
-
yangguo authored
R=mstarzinger@chromium.org BUG=v8:5265 Review-Url: https://codereview.chromium.org/2237423002 Cr-Commit-Position: refs/heads/master@{#38602}
-
yangguo authored
Previously, we would both instrument the code, and add/remove BreakPointInfo objects through BreakLocation. This is bad design and unsuitable for having two different code kinds. We would now add/remove BreakPointInfo objects, and use that as source of truth when instrumenting the code. If we have both bytecode and FCG code, we would simply apply these break points twice to either. Notable changes: - Removed many functionality from BreakLocation. - Instrumentation (patching code for breaks) happens by applying break point info onto code. - Instrumentation (code patching) is done by the BreakIterator. For bytecode, it's BytecodeArrayBreakIterator. For FCG code, it's CodeBreakIterator. - Changes to code instrumentation mostly involves clearing current instrumentation and then (re-)applying break points. - DebugInfo can now reference both bytecode and FCG code. R=jgruber@chromium.org, mstarzinger@chromium.org BUG=v8:5265 Review-Url: https://codereview.chromium.org/2238893002 Cr-Commit-Position: refs/heads/master@{#38596}
-
- 10 Aug, 2016 2 commits
-
-
yangguo authored
This makes break point info independent from the code kind being executed. BUG=v8:5265 Review-Url: https://codereview.chromium.org/2230143002 Cr-Commit-Position: refs/heads/master@{#38528}
-
yangguo authored
Revert of [debugger] reapply break points after clearing one shots. (patchset #1 id:1 of https://codereview.chromium.org/2221333002/ ) Reason for revert: Found better solution. Original issue's description: > [debugger] reapply break points after clearing one shots. > > On the debug info, we have a list of existing break points. When we > step in the debugger, we flood the function with one-shot break points. > Afterwards, we clear these one-shots by clearing all break locations. > > Previously, while clearing break locations, we would skip ones that have > actual break points. Now we clear all break locations, and then reapply > break points. This is necessary for the next step, when we encode break > point info by source position, and not code offset. Encoding by code > offset would mean that break points are dependent on the code kind we > use. > > R=jgruber@chromium.org > BUG=v8:5265 > > Committed: https://crrev.com/808981a22ee19461bbe981ab33b58792d991533e > Cr-Commit-Position: refs/heads/master@{#38492} TBR=jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5265 Review-Url: https://codereview.chromium.org/2231653003 Cr-Commit-Position: refs/heads/master@{#38521}
-
- 09 Aug, 2016 1 commit
-
-
yangguo authored
On the debug info, we have a list of existing break points. When we step in the debugger, we flood the function with one-shot break points. Afterwards, we clear these one-shots by clearing all break locations. Previously, while clearing break locations, we would skip ones that have actual break points. Now we clear all break locations, and then reapply break points. This is necessary for the next step, when we encode break point info by source position, and not code offset. Encoding by code offset would mean that break points are dependent on the code kind we use. R=jgruber@chromium.org BUG=v8:5265 Review-Url: https://codereview.chromium.org/2221333002 Cr-Commit-Position: refs/heads/master@{#38492}
-
- 03 Aug, 2016 1 commit
-
-
neis authored
In the parser, we desugar yield* with the help of a regular yield. One particular implementation detail of this desugaring is that when the user calls the generator's throw method, this throws an exception that we immediately catch. This exception should not be visible to the user, but through Devtools' "Pause on Caught Exceptions" feature it used to be. This CL extends the type of catch predictions with a new value for such internal exceptions and uses that for the offending try-catch statement in yield*. It instruments the debugger to _not_ trigger an exception event in that case. R=yangguo@chromium.org TBR=littledan@chromium.org BUG=v8:5218 Review-Url: https://codereview.chromium.org/2203803002 Cr-Commit-Position: refs/heads/master@{#38286}
-
- 25 Jul, 2016 1 commit
-
-
jochen authored
R=ishell@chromium.org,bmeurer@chromium.org TBR=rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/2175233003 Cr-Commit-Position: refs/heads/master@{#38009}
-
- 21 Jul, 2016 2 commits
-
-
yangguo authored
R=jgruber@chromium.org Review-Url: https://codereview.chromium.org/2168883002 Cr-Commit-Position: refs/heads/master@{#37948}
-
yangguo authored
There is simply no point in converting between relative and absolute source positions in both C++ and Javascript code. R=jgruber@chromium.org Review-Url: https://codereview.chromium.org/2169463002 Cr-Commit-Position: refs/heads/master@{#37916}
-
- 30 Jun, 2016 1 commit
-
-
yangguo authored
R=mstarzinger@chromium.org BUG=v8:5117 Review-Url: https://codereview.chromium.org/2109773004 Cr-Commit-Position: refs/heads/master@{#37426}
-
- 29 Jun, 2016 1 commit
-
-
titzer authored
This changes many interfaces to accept StandardFrames instead of JavaScriptFrames, and use the StackTraceFrameIterator instead of the JavaScriptFrameIterator. Also, the detailed frame information array now contains the script in addition to the function, as wasm frames are not associated to any javascript function. This is a rebase of (https://codereview.chromium.org/2069823003/), since clemensh's internship has ended. R=yangguo@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/2109093003 Cr-Commit-Position: refs/heads/master@{#37379}
-
- 28 Jun, 2016 2 commits
-
-
yangguo authored
R=jgruber@chromium.org Review-Url: https://codereview.chromium.org/2107693002 Cr-Commit-Position: refs/heads/master@{#37316}
-
yangguo authored
R=bmeurer@chromium.org, jgruber@chromium.org BUG=v8:5117 Review-Url: https://codereview.chromium.org/2095893002 Cr-Commit-Position: refs/heads/master@{#37309}
-
- 15 Jun, 2016 1 commit
-
-
yangguo authored
R=jochen@chromium.org, vogelheim@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2055203002 Cr-Commit-Position: refs/heads/master@{#37008}
-
- 14 Jun, 2016 3 commits
-
-
yangguo authored
R=bmeurer@chromium.org, caitpotter88@gmail.com, neis@chromium.org BUG=v8:5099 Review-Url: https://codereview.chromium.org/2067503002 Cr-Commit-Position: refs/heads/master@{#36964}
-
yangguo authored
R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2068603002 Cr-Commit-Position: refs/heads/master@{#36960}
-
cbruni authored
Reland of place all remaining Oddball checks with new function (patchset #1 id:1 of https://codereview.chromium.org/2060213002/ ) Reason for revert: Cannot reproduce gc-stress failures locally. Original issue's description: > Revert of Replace all remaining Oddball checks with new function (patchset #10 id:180001 of https://codereview.chromium.org/2043183003/ ) > > Reason for revert: > failing tests > > Original issue's description: > > Replace all remaining Oddball checks with new function > > > > This CL removes the IsUndefined() and Co. methods from Object and HeapObject. > > The new method all take the isolate as parameter. > > > > BUG= > > > > Committed: https://crrev.com/ccefb3ae5fe967288d568013fb04e8761eafebc5 > > Cr-Commit-Position: refs/heads/master@{#36921} > > TBR=mstarzinger@chromium.org,verwaest@chromium.org,yangguo@chromium.org,ahaas@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/33b8bc24a12fb062100c0be84456faeb0b9fa5d1 > Cr-Commit-Position: refs/heads/master@{#36923} TBR=mstarzinger@chromium.org,verwaest@chromium.org,yangguo@chromium.org,ahaas@chromium.org BUG= Review-Url: https://codereview.chromium.org/2059173002 Cr-Commit-Position: refs/heads/master@{#36957}
-
- 13 Jun, 2016 2 commits
-
-
cbruni authored
Revert of Replace all remaining Oddball checks with new function (patchset #10 id:180001 of https://codereview.chromium.org/2043183003/ ) Reason for revert: failing tests Original issue's description: > Replace all remaining Oddball checks with new function > > This CL removes the IsUndefined() and Co. methods from Object and HeapObject. > The new method all take the isolate as parameter. > > BUG= > > Committed: https://crrev.com/ccefb3ae5fe967288d568013fb04e8761eafebc5 > Cr-Commit-Position: refs/heads/master@{#36921} TBR=mstarzinger@chromium.org,verwaest@chromium.org,yangguo@chromium.org,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2060213002 Cr-Commit-Position: refs/heads/master@{#36923}
-
cbruni authored
This CL removes the IsUndefined() and Co. methods from Object and HeapObject. The new method all take the isolate as parameter. BUG= Review-Url: https://codereview.chromium.org/2043183003 Cr-Commit-Position: refs/heads/master@{#36921}
-
- 08 Jun, 2016 1 commit
-
-
neis authored
Also, make %GeneratorGetSourcePosition fail if called on a suspended Ignition generator (rather than return nonsense). This functionality is currently not implemented. BUG=v8:4907 Review-Url: https://codereview.chromium.org/2049663002 Cr-Commit-Position: refs/heads/master@{#36822}
-
- 06 Jun, 2016 2 commits
-
-
jochen authored
Since the generic GetCallingContext is deprecated, but there's still the use case for the debugger to get the currently debugged context while in the debug context, add a convenience API for it. Note that EventDetails already exposes this context, but the embedder might not necessarily have the EventDetails around. R=verwaest@chromium.org BUG= Review-Url: https://codereview.chromium.org/2040853003 Cr-Commit-Position: refs/heads/master@{#36751}
-
cbruni authored
Passing in the isolate and pointer compare the instnance against the corresponding constant is always faster than decoding the instance types. BUG= Review-Url: https://codereview.chromium.org/2028983002 Cr-Commit-Position: refs/heads/master@{#36744}
-
- 03 Jun, 2016 1 commit
-
-
yangguo authored
R=*bmeurer@chromium.org, caitpotter88@gmail.com, *littledan@chromium.org, *ulan@chromium.org BUG=v8:4483 Review-Url: https://codereview.chromium.org/2033223003 Cr-Commit-Position: refs/heads/master@{#36718}
-
- 31 May, 2016 3 commits
-
-
machenbach authored
Revert of [heap] Do not invoke GC to make heap iterable. (patchset #3 id:40001 of https://codereview.chromium.org/1992913004/ ) Reason for revert: [Sheriff] Speculative revert for some flakes on the waterfall: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/7409 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20avx2/builds/7983 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20internal%20snapshot/builds/4901 Original issue's description: > [heap] Do not invoke GC to make heap iterable. > > This reverts commit 0aa3707d. > > And removes the UnreachableObjectsFilter. > > BUG=chromium:580959 > LOG=n > > Committed: https://crrev.com/132f89800f560190b4d655adcb4e0eeedd17fd82 > Cr-Commit-Position: refs/heads/master@{#36617} TBR=yangguo@chromium.org,ulan@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:580959 Review-Url: https://codereview.chromium.org/2020363002 Cr-Commit-Position: refs/heads/master@{#36622}
-
littledan authored
Async functions are built out of generators, but the SharedFunctionInfo returns false for is_generator. is_resumable is the broader query. This patch fixes many parts of V8 to refer to is_resumable as appropriate. One incidental change is to remove a check for generators extending classes. This is part of a general check for constructors being the only thing which can extend classes, so it is removed here and the error message for the general case is made more accurate. BUG=v8:4483 Review-Url: https://codereview.chromium.org/1996943002 Cr-Commit-Position: refs/heads/master@{#36621}
-
hpayer authored
This reverts commit 0aa3707d. And removes the UnreachableObjectsFilter. BUG=chromium:580959 LOG=n Review-Url: https://codereview.chromium.org/1992913004 Cr-Commit-Position: refs/heads/master@{#36617}
-
- 27 May, 2016 1 commit
-
-
mvstanton authored
We get less "pollution" of type feedback if we have one vector per native context, rather than one for the whole system. This CL moves the vector appropriately. BUG= Review-Url: https://codereview.chromium.org/1906823002 Cr-Commit-Position: refs/heads/master@{#36539}
-
- 20 May, 2016 1 commit
-
-
ulan authored
Instead of dynamically creating semaphore for each page parallel job, we create one semaphore for MarkCompact and reuse it. This patch also removes all instrumentation code that was added to help with investigation. BUG=chromium:609249 LOG=NO Review-Url: https://codereview.chromium.org/1998213002 Cr-Commit-Position: refs/heads/master@{#36407}
-
- 18 May, 2016 2 commits
-
-
machenbach authored
Revert of [heap] Do not invoke GC to make heap iterable. (patchset #5 id:80001 of https://codereview.chromium.org/1961373003/ ) Reason for revert: Breaks https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/3551 Original issue's description: > [heap] Do not invoke GC to make heap iterable. > > Remove kMakeHeapIterableMask since the heap is always iterable. > > BUG=chromium:580959 > LOG=n > > Committed: https://crrev.com/7c1cac4888a248fda3fa6de3624f32a6babb37e9 > Cr-Commit-Position: refs/heads/master@{#36333} TBR=ulan@chromium.org,yangguo@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:580959 Review-Url: https://codereview.chromium.org/1987363002 Cr-Commit-Position: refs/heads/master@{#36335}
-
hpayer authored
Remove kMakeHeapIterableMask since the heap is always iterable. BUG=chromium:580959 LOG=n Review-Url: https://codereview.chromium.org/1961373003 Cr-Commit-Position: refs/heads/master@{#36333}
-