- 04 Aug, 2022 1 commit
-
-
Camillo Bruni authored
- Update parse processor to use new async log-reader functions - Fix some typos - Add more desciptions to the output - Update bytes and time formatting to use common helper.mjs functions Bug: v8:13146 Change-Id: Idf58a394aa493b7f50ad5282533c1b6d326117be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810233Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82206}
-
- 06 Apr, 2022 1 commit
-
-
Camillo Bruni authored
Reduce the dispatching overhead in the hottest loop when parsing log-lines. - Using a JSMap we can avoid internalizing strings - Preprocess the dispatch table and only have varArgs or functions as parsers - string[] seems to be slightly faster than string.charAt() Bug: v8:10644 Change-Id: I03b13bdeecda1ad037191ff74e05142ceeb6533c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571890Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79816}
-
- 01 Jun, 2021 1 commit
-
-
Camillo Bruni authored
- Move readFile helper to LogReader.readFile - Add static BaseArgumentsProcessor.process helper - Move SourceMap handling to the TickProcessor - Always skip example file mjsunit/tools/tickprocessor-test-large.js - Run tickprocessor and dumpcpp tests only in release mode Change-Id: I635fb2d2839233219b058faf9710fd0f19880fd2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929117Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74873}
-
- 22 Feb, 2021 1 commit
-
-
Camillo Bruni authored
Change-Id: I39e97298bd1b802bd011214e820babc69f6e7d00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2682639Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#72895}
-
- 30 Nov, 2020 1 commit
-
-
Camillo Bruni authored
Bug: v8:10644 Change-Id: I24229cbbf6a3ffea0fd4c3b96ef6eaf1e780b6e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565136 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#71505}
-
- 10 Nov, 2020 1 commit
-
-
Camillo Bruni authored
This is mostly an auto-conversion done by several tools. - use let / const - use arrow functions - use template strings There are some additional manual rewrite required to modernize the code further. Change-Id: I63a7a43b05b14b33ad9941350d3d5f26aab10ba0 Bug: v8:10667 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2519564Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#71080}
-
- 28 Sep, 2020 1 commit
-
-
Camillo Bruni authored
This changes all tools to use ES6 modules and proper imports. Step 1: Add converted .mjs files (*this CL*) Step 2: Update node-ci build to use new .mjs files Step 3: Remove outdated .js files Bug: v8:10667, v8:10933 Change-Id: I3e92e66f896d8a9cacaf6d421f8d2c86fb3bc444 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2431045 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#70163}
-
- 16 Jul, 2018 1 commit
-
-
Camillo Bruni authored
- Log script sources with --log-function-events - Don't show confusing duration in graphs - Introduce separate compilation category - Log script details after deserialization - Log parse times for eval scripts - Display deserialized scripts and functions Change-Id: I58f3bf8efe3955632322f958716c36ad38761fd0 Bug: chromium:757467, chromium:850038 Reviewed-on: https://chromium-review.googlesource.com/1128082Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#54465}
-
- 03 Jul, 2018 1 commit
-
-
Camillo Bruni authored
- display script size overview - color scripts in overview depending on eval, streaming or other scripts - fix stats to always take own-bytes into accout - rename all *Time properties to *Duration for consistency - extract ScriptSource log event into separate method - support script source events in parse-processor Bug: chromium:757467, chromium:850038 Change-Id: I227d1d5952ae9e508ab1a01146fcf47f74a3f7ea Reviewed-on: https://chromium-review.googlesource.com/1117195 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54159}
-
- 27 Jun, 2018 1 commit
-
-
Camillo Bruni authored
- Introduce ScriptEventType enum - Emit log event when deserializing scripts - Better handle deserialized and eval scripts when calculating the byte size Bug: chromium:757467, chromium:850038 Change-Id: I082161d8d1d4238a90d3607ca8b6b4e60f2f903e Reviewed-on: https://chromium-review.googlesource.com/1114845 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#54061}
-
- 25 Jun, 2018 1 commit
-
-
Camillo Bruni authored
This reverts commit a800e050. Original change's description: > Revert "[parser][log] Log script id during background compilation" > > This reverts commit aafd5c52. > > Reason for revert: Tentative revert for > > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825 > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242 > > Original change's description: > > [parser][log] Log script id during background compilation > > > > - Add separate script-create, script-reserve-id and script-details log events > > - Add log events for CompilationCache hits and puts > > - Simplify function event logging by only pass along the script id > > - Explicitly create Scripts in parse-processor.js on script events only > > - Create a temporary script id in the ParseInfo for use during background > > parsing and compilation > > - Clean up ParseInfo initialization to centralize creation and use of > > script ids > > - Allow creating Scripts with predefined script ids > > > > Bug: chromium:757467, chromium:850038 > > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe > > Reviewed-on: https://chromium-review.googlesource.com/1097131 > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#53978} > > TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org > > Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:757467, chromium:850038 > Reviewed-on: https://chromium-review.googlesource.com/1112538 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53984} TBR=ulan@chromium.org,yangguo@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:757467, chromium:850038 Change-Id: I3088c86362c06ee50464f1f14e25350b1b8048ad Reviewed-on: https://chromium-review.googlesource.com/1112539Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#53994}
-
- 22 Jun, 2018 2 commits
-
-
Yang Guo authored
This reverts commit aafd5c52. Reason for revert: Tentative revert for https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/24825 https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64%20-%20msvc/3242 Original change's description: > [parser][log] Log script id during background compilation > > - Add separate script-create, script-reserve-id and script-details log events > - Add log events for CompilationCache hits and puts > - Simplify function event logging by only pass along the script id > - Explicitly create Scripts in parse-processor.js on script events only > - Create a temporary script id in the ParseInfo for use during background > parsing and compilation > - Clean up ParseInfo initialization to centralize creation and use of > script ids > - Allow creating Scripts with predefined script ids > > Bug: chromium:757467, chromium:850038 > Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe > Reviewed-on: https://chromium-review.googlesource.com/1097131 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53978} TBR=ulan@chromium.org,cbruni@chromium.org,gsathya@chromium.org,leszeks@chromium.org Change-Id: I629f72f51d5e086e2b54658c1fdd18cec268aab2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:757467, chromium:850038 Reviewed-on: https://chromium-review.googlesource.com/1112538Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53984}
-
Camillo Bruni authored
- Add separate script-create, script-reserve-id and script-details log events - Add log events for CompilationCache hits and puts - Simplify function event logging by only pass along the script id - Explicitly create Scripts in parse-processor.js on script events only - Create a temporary script id in the ParseInfo for use during background parsing and compilation - Clean up ParseInfo initialization to centralize creation and use of script ids - Allow creating Scripts with predefined script ids Bug: chromium:757467, chromium:850038 Change-Id: I02dfd1d5725795b9fe0ea94ef57b287b934a1efe Reviewed-on: https://chromium-review.googlesource.com/1097131Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#53978}
-
- 20 Jun, 2018 1 commit
-
-
Camillo Bruni authored
- Add parseString and parseVarArgs helper constants - Fix number formatting in parser-processor.js - Rename time to duration in parse-processor - Fix eval handling in parse-processor Bug: chromium:757467, chromium:850038 Change-Id: Ibce57b46d22e03ddaa5baa22f45d8df4c93af2cd Reviewed-on: https://chromium-review.googlesource.com/1102435Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#53887}
-
- 06 Jun, 2018 1 commit
-
-
Camillo Bruni authored
Drive-by-fix: - improve log parsing by not wrapping single lines in arrays Change-Id: Ic4c5fdeb7875c8c5db57843f583e93285026ff74 BUG: chromium:757467, chromium:850038 Reviewed-on: https://chromium-review.googlesource.com/1078753 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#53547}
-
- 20 Dec, 2017 1 commit
-
-
Camillo Bruni authored
From the log data generated with --log-function-events we can create a detailed model of a function's lifetime. The parse processor displays several stats at a given time (percent and count) on a per function or byte basis: - preparsing - parsing - eager/lazy compiling - execution Bug: chromium:757467 Change-Id: I0ad5c9369c6a0628704e3caffb3920444ea603a9 Reviewed-on: https://chromium-review.googlesource.com/758641 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#50234}
-