- 02 Jan, 2019 3 commits
-
-
Clemens Hammacher authored
Bring ia32 in line with the arm implemention. Instead of computing the "half index" manually, pass the index and an enum pointing to either half. R=titzer@chromium.org Bug: v8:6600 Change-Id: Ia3799a42fe2b9890aa4076d2e09947380331348e Reviewed-on: https://chromium-review.googlesource.com/c/1391758 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#58501}
-
Clemens Hammacher authored
And use it in several places in wasm. R=tebbi@chromium.org Bug: v8:8562 Change-Id: I1e857baf33e99849eb32ac2c94e39d7f27b180c8 Reviewed-on: https://chromium-review.googlesource.com/c/1391757 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#58495}
-
Clemens Hammacher authored
Introduce a LeakyObject template and use that to implement static lazily initialized objects that never get destructed. This was done in a hand-crafted and complex way before via LazyInstance and LazyStaticInstance. R=tebbi@chromium.org Bug: v8:8600, v8:8562 Change-Id: Id160996753b2cb1baf0f4b2cec9e1727f1d01512 Reviewed-on: https://chromium-review.googlesource.com/c/1388539 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
- 28 Dec, 2018 2 commits
-
-
Clemens Hammacher authored
This improves validation time by 7-8% and Liftoff compilation time by 2-3% while increasing binary size by ~12kB. R=mvstanton@chromium.org Bug: v8:8423 Change-Id: I08961097fb61f4a218522138efe51a9165a7c62b Reviewed-on: https://chromium-review.googlesource.com/c/1391748Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58486}
-
Deepti Gandluri authored
Identify validation fails to read the index of prefixed opcodes, and not continue to decode the next bytes. Change-Id: I2c737af55615ba69ba0c5f5adf18a06c6cdb951a Bug: chromium:905815 Reviewed-on: https://chromium-review.googlesource.com/c/1390927 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#58485}
-
- 27 Dec, 2018 1 commit
-
-
Clemens Hammacher authored
Prevent aliasing between problematic registers for shift operations with int64 values in the arm port of Liftoff. Bug: v8:6600, chromium:912592 Change-Id: I905f0a657626fdfac3e41fe2878e918e3c779a8f Reviewed-on: https://chromium-review.googlesource.com/c/1388564 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58480}
-
- 26 Dec, 2018 1 commit
-
-
Jakob Kummerow authored
Tbr: ahaas@chromium.org,leszeks@chromium.org,verwaest@chromium.org Bug: v8:3770 Change-Id: Ia6530fbb70dac05e9972283781c3550d8b50e1eb Reviewed-on: https://chromium-review.googlesource.com/c/1390116 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58470}
-
- 21 Dec, 2018 6 commits
-
-
Bill Budge authored
- Removes ModuleCompiledCallback typedef and Set function. - Adds WasmStreaming::Client abstraction and Set function. Bug: chromium:719172 Change-Id: I8a207b628394a7660bda73cde560da1e461248a7 Reviewed-on: https://chromium-review.googlesource.com/c/1377450Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#58454}
-
George Wort authored
Ensure that GetUnusedRegister is always called before acquiring the scratch register in case it is needed for spilling the value of the used register. Bug: v8:6600, chromium:910824 Change-Id: I93ae684ad504584807dfa6227b6af14609c6bcf5 Reviewed-on: https://chromium-review.googlesource.com/c/1387498Reviewed-by:
-
Clemens Hammacher authored
Before computing the merge state, compute the list of free registers. This list is used when we need a register for ensuring single register use. It avoids picking a register which is in use by a not-yet-visited merge slot, which would then have to be moved to another register or to the stack. On epic, this saves ~10.5% generated code size in Liftoff. R=herhut@chromium.org Bug: v8:8423 Change-Id: If9fac24abbfe2273bf18d9cb287c7c05a59b2118 Reviewed-on: https://chromium-review.googlesource.com/c/1387488 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#58435}
-
Clemens Hammacher authored
This silences the new presubmit check for the whole src/wasm directory. This change uncovered that MSVC is a bit behind with noexcept annotations on standard containers. This makes all implicit constructors and assignment operators noexcept(false) if the class contains any standard container. Thus disable noexcept on MSVC for now. R=tebbi@chromium.org CC=marja@chromium.org Bug: v8:8616, v8:7999 Change-Id: Ica86ac84a5b8a835dcea9b783c7987d9b850241a Reviewed-on: https://chromium-review.googlesource.com/c/1386869 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This replaces another use of std::vector. Stack states (consisting of locals plus operand stack) are also typically small, thus optimize for those cases. Using StackVector as part of CacheState requires the definition of move constructors and copy constructors, plus a few other methods. R=tebbi@chromium.org Bug: v8:8423 Change-Id: I5d39c1ebc4d6d65e4849dd06c556114cd2cd36ff Reviewed-on: https://chromium-review.googlesource.com/c/1380053 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Since FallThruTo is often followed by PopControl, we can save a few cache state copy operations in Liftoff by merging the two. On epic workloads, this saves ~18% of Steal operations and ~22% of Split operations. R=herhut@chromium.org Bug: v8:8423 Change-Id: I99900eaa49ae14ead6a0c08b69da2175730e077e Reviewed-on: https://chromium-review.googlesource.com/c/1384093Reviewed-by:
-
- 20 Dec, 2018 3 commits
-
-
Jakob Kummerow authored
Merging the temporary HeapObjectPtr back into HeapObject. Bug: v8:3770 Change-Id: I5bcd23ca2f5ba862cf5b52955dca143e531c637b Reviewed-on: https://chromium-review.googlesource.com/c/1386492 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Avoid named constructors for Value and Control and the hack to also have them on subclasses. Instead, add a new template type and a constructor to create the subtype from this template. Instead of the named constructors on the subtype, we now create a template and initialize the subtype from the template. R=herhut@chromium.org Bug: v8:8562 Change-Id: I374fc4104ab1ae5769c587bdf5a4ca7f9a0a10d7 Reviewed-on: https://chromium-review.googlesource.com/c/1382454Reviewed-by:
-
Clemens Hammacher authored
The source register of {movsx_b} must be a byte register. Drive-by: Add missing sign extension opcodes to wasm-constants.js. R=herhut@chromium.org Bug: chromium:916869 Change-Id: I571c1ea2a0e197afefc810f306eed238250cd5e0 Reviewed-on: https://chromium-review.googlesource.com/c/1386110Reviewed-by:
-
- 19 Dec, 2018 7 commits
-
-
Clemens Hammacher authored
Reachability is already being tracked in the function body decoder. This CL adds a DCHECK that the reachability tracked in the SsaEnv matches the reachability tracked in the function body decoder. Most of our methods will only be called for reachable code anyway. For exceptions, we still track reachability explicitly for now in the wasm graph builder, this can be refactored in the future by improving reachability tracking for catch blocks in the function body decoder. If this DCHECK survives fuzzing for a few days, we can remove code that handles unreachable code in graph-building-interface.cc. R=herhut@chromium.org Bug: v8:8423, v8:8611 Change-Id: I0fb375c99497352aad396816566883fe234ca0ac Reviewed-on: https://chromium-review.googlesource.com/c/1384089Reviewed-by:
-
Igor Sheludko authored
Also added != 0 for readability in checks like: if (FIELD_SIZE(kFooOffset) != 0) {...} Bug: v8:8477, v8:8562 Change-Id: Ibc305103475e6ec029e89e7ad095ec0a1fa30189 Reviewed-on: https://chromium-review.googlesource.com/c/1382743 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: -
Clemens Hammacher authored
Many callers of {DoReturn} either already call {EndControl}, or pop the control afterwards, hence we do not need to {EndControl}. Hence only call {EndControl} when really needed. R=herhut@chromium.org Bug: v8:8423 Change-Id: Ie4e7b2dd6918cc0f9619a72d624014222f58a251 Reviewed-on: https://chromium-review.googlesource.com/c/1384085Reviewed-by: -
Igor Sheludko authored
These load operations will decompress values if pointer compression is enabled. Bug: v8:7703 Change-Id: I4c5cef39a735f3b03e36d27c0e5e7c21653bbbc0 Reviewed-on: https://chromium-review.googlesource.com/c/1382742 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This refactoring reduces the LoC after preprocessor expansion by 370,322 gen ( 21 files): 71,503 to 1,631,168 ( 23x) src ( 624 files): 367,639 to 53,231,764 ( 145x) test ( 392 files): 490,770 to 37,450,839 ( 76x) third_party ( 432 files): 239,085 to 9,547,902 ( 40x) total ( 1521 files): 1,183,681 to 102,836,194 ( 87x) gen ( 21 files): 71,503 to 1,613,222 ( 23x) src ( 624 files): 367,634 to 52,964,046 ( 144x) test ( 392 files): 490,771 to 37,366,181 ( 76x) third_party ( 432 files): 239,085 to 9,547,902 ( 40x) total ( 1521 files): 1,183,677 to 102,465,872 ( 87x) Bug: v8:8562 Change-Id: Ib4e771c37471a2ff19c5538e62c038943cc74eaf Reviewed-on: https://chromium-review.googlesource.com/c/1382469Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Andreas Haas authored
The function InstanceBuilder::ProcessImports got long and hard to understand. This CL is the third change of a series which aims at extracting parts of ProcessImports into specialized functions. This CL extracts the processing of imported globals into a separate function. Aside from copying the code, I made the following changes: * Rename {index} to {import_index}. This CL does minimal changes to the processing of globals itself. That code looks quite complex at the moment. Therefore I want to do the refactoring of that code in separate CLs, so that each CL is smaller and more understandable. R=clemensh@chromium.org Bug: v8:8562 Change-Id: Ie553a2c9031cef07f0b9925144c79248084e428d Reviewed-on: https://chromium-review.googlesource.com/c/1382732 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Andreas Haas authored
The function InstanceBuilder::ProcessImports got long and hard to understand. This CL is the third change of a series which aims at extracting parts of ProcessImports into specialized functions. This CL extracts the processing of imported memory into a separate function. Aside from copying the code, I made the following changes: * Rename {index} to {import_index}. * Add one `return false;` after reporting a LinkError. - I think it should have been this way all along. R=clemensh@chromium.org Bug: v8:8562 Change-Id: I34d68d7bc1013c2743a68778dfc22a2d8e1d46af Reviewed-on: https://chromium-review.googlesource.com/c/1382731 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
- 18 Dec, 2018 8 commits
-
-
Andreas Haas authored
The function InstanceBuilder::ProcessImports got long and hard to understand. This CL is the second change of a series which aims at extracting parts of ProcessImports into specialized functions. This CL extracts the processing of imported tables into a separate function. Aside from copying the code, I made the following changes: * Rename {index} to {import_index}. * Rename {table_num} to {table_index}. R=clemensh@chromium.org Bug: v8:8562 Change-Id: I37398f0c8feccae3647a7817d7d4d6d0d87fd5a9 Reviewed-on: https://chromium-review.googlesource.com/c/1382470 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: -
Jakob Kummerow authored
Bug: v8:3770 Change-Id: If88c285bf1528f03401d3a83349b61435ac79f85 Reviewed-on: https://chromium-review.googlesource.com/c/1382455 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:5402 Change-Id: Ib2d7b24cdcf55e3dfa8d3b1665ac565904ac2112 Reviewed-on: https://chromium-review.googlesource.com/c/1379940Reviewed-by:
-
Andreas Haas authored
The function InstanceBuilder::ProcessImports got long and hard to understand. This CL is the first of a series which aims at extracting parts of ProcessImports into specialized functions. This CL extracts the processing of imported functions into a separate function. Aside from copying the code, I made the following changes: * Use {enabled_} instead of a newly created WasmFeatures object. - I think this is more correct anyways. * Rename {index} to {import_index}. * Load {native_module} from {instance} for every function, instead of loading it once for all imports. R=clemensh@chromium.org Bug: v8:8562 Change-Id: I9533f302929eedd395962253c340ba35324df631 Reviewed-on: https://chromium-review.googlesource.com/c/1382467 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: -
Clemens Hammacher authored
This CL introduces our own minimal SmallVector implementation and uses it in several places (more might follow). I measured that in the majority of cases, these vectors are quite small (<= 8 elements), so we will avoid any heap allocation in those cases. R=mstarzinger@chromium.org CC=titzer@chromium.org Bug: v8:8423 Change-Id: I93a26b3303a10fe1dc93186430e20333ea4970a8 Reviewed-on: https://chromium-review.googlesource.com/c/1378178 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: Iafde7e4514fcc803b627a4a9b3469c84b7413282 Reviewed-on: https://chromium-review.googlesource.com/c/1382453Reviewed-by:
-
Andreas Haas authored
This CL implements the global.get and global.set instruction for anyref globals. This includes: * Properly decode anyref globals. * Add a FixedArray to WasmInstanceObject to store anyref globals. * Initialize the FixedArray. * Generate code for global.get and global set. This CL does not allow to import globals yet. R=clemensh@chromium.org Bug: v8:7581 Change-Id: I62617409271d9b6f2253a191681189865aa1f459 Reviewed-on: https://chromium-review.googlesource.com/c/1380112Reviewed-by:
-
Jakob Kummerow authored
Dropping the temporary StructPtr in the process. Bug: v8:3770 Change-Id: I70784ede7b66b432d8438536ff0c70a51dfb7f83 Reviewed-on: https://chromium-review.googlesource.com/c/1377461 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#58315}
-
- 17 Dec, 2018 9 commits
-
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: Ie80ce957ff1d2bcd3596491066f6562ce0ad129a Reviewed-on: https://chromium-review.googlesource.com/c/1380114 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#58294}
-
Jakob Kummerow authored
Along with HeapNumberBase and MutableHeapNumber, of course. Bug: v8:5402 Change-Id: I14a7f8052de3839cad36bb7e4ebb6da38b2ac096 Reviewed-on: https://chromium-review.googlesource.com/c/1379884 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Tuple2 and subclasses: EnumCache, SourcePositionTableWithFrameCache, TemplateObjectDescription Bug: v8:3770 Change-Id: Icff0860a04445dda542119834ef9866167ba2263 Reviewed-on: https://chromium-review.googlesource.com/c/1377772 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#58287}
-
Marja Hölttä authored
BUG=v8:7490,v8:8562 Change-Id: Ie3e277fef97900dbefbf08cb02f6c03e8dd408b7 Reviewed-on: https://chromium-review.googlesource.com/c/1379877Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:5402 Change-Id: Ifdbc61eb401160d03b98336292f1725d604e7f51 Reviewed-on: https://chromium-review.googlesource.com/c/1379936 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:3770 Change-Id: Id7a05e5687d36c9347f35f6f3276af2a4b6115fd Reviewed-on: https://chromium-review.googlesource.com/c/1377770 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This is a reland of 3ad101f5 Original change's description: > [assembler] Split out CPUFeatures into its own file > > This reduces the preprocessor expanded source size by 84,675 LoC: > > gen ( 20 files): 71,349 to 1,523,934 ( 21x) > src ( 624 files): 367,410 to 53,253,894 ( 145x) > test ( 392 files): 490,503 to 37,436,176 ( 76x) > third_party ( 432 files): 239,085 to 9,547,902 ( 40x) > total ( 1520 files): 1,183,031 to 102,736,424 ( 87x) > > to > > gen ( 20 files): 71,349 to 1,523,794 ( 21x) > src ( 624 files): 367,411 to 53,186,896 ( 145x) > test ( 392 files): 490,504 to 37,418,639 ( 76x) > third_party ( 432 files): 239,085 to 9,547,902 ( 40x) > total ( 1520 files): 1,183,033 to 102,651,749 ( 87x) > > > Change-Id: Ia8a79092051a42815b65e86a0784297915368c9b > Reviewed-on: https://chromium-review.googlesource.com/c/1291471 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58266} TBR=marja@chromium.org,clemensh@chromium.org,ulan@chromium.org Change-Id: I5b857666508b1c80dcadd0b470aada37dd49077e Reviewed-on: https://chromium-review.googlesource.com/c/1379872Reviewed-by:
-
Maya Lekova authored
This reverts commit 3ad101f5. Reason for revert: Broken Android Arm64 debug builder - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Android%20Arm64%20-%20debug%20builder/3089 Original change's description: > [assembler] Split out CPUFeatures into its own file > > This reduces the preprocessor expanded source size by 84,675 LoC: > > gen ( 20 files): 71,349 to 1,523,934 ( 21x) > src ( 624 files): 367,410 to 53,253,894 ( 145x) > test ( 392 files): 490,503 to 37,436,176 ( 76x) > third_party ( 432 files): 239,085 to 9,547,902 ( 40x) > total ( 1520 files): 1,183,031 to 102,736,424 ( 87x) > > to > > gen ( 20 files): 71,349 to 1,523,794 ( 21x) > src ( 624 files): 367,411 to 53,186,896 ( 145x) > test ( 392 files): 490,504 to 37,418,639 ( 76x) > third_party ( 432 files): 239,085 to 9,547,902 ( 40x) > total ( 1520 files): 1,183,033 to 102,651,749 ( 87x) > > > Change-Id: Ia8a79092051a42815b65e86a0784297915368c9b > Reviewed-on: https://chromium-review.googlesource.com/c/1291471 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58266} TBR=ulan@chromium.org,marja@chromium.org,sigurds@chromium.org,clemensh@chromium.org Change-Id: I111f9bbef9e66cd1ee7f4206b6af1097f7c50e66 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1379933Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#58268}
-
Sigurd Schneider authored
This reduces the preprocessor expanded source size by 84,675 LoC: gen ( 20 files): 71,349 to 1,523,934 ( 21x) src ( 624 files): 367,410 to 53,253,894 ( 145x) test ( 392 files): 490,503 to 37,436,176 ( 76x) third_party ( 432 files): 239,085 to 9,547,902 ( 40x) total ( 1520 files): 1,183,031 to 102,736,424 ( 87x) to gen ( 20 files): 71,349 to 1,523,794 ( 21x) src ( 624 files): 367,411 to 53,186,896 ( 145x) test ( 392 files): 490,504 to 37,418,639 ( 76x) third_party ( 432 files): 239,085 to 9,547,902 ( 40x) total ( 1520 files): 1,183,033 to 102,651,749 ( 87x) Change-Id: Ia8a79092051a42815b65e86a0784297915368c9b Reviewed-on: https://chromium-review.googlesource.com/c/1291471Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58266}
-
