Skip to content

V
V8
Switch branch/tag
  1. 27 Nov, 2014 1 commit
  3. 13 Nov, 2014 2 commits
  5. 12 Nov, 2014 1 commit
  7. 10 Nov, 2014 1 commit
  9. 07 Nov, 2014 1 commit
    • dslomov@chromium.org's avatar
      harmony_scoping: Implement lexical bindings at top level · 1a64b02d
      dslomov@chromium.org authored 
      This implements correct semantics for "extensible" top level lexical scope.
The entire lexical scope is represented at runtime by GlobalContextTable, reachable from native context and accumulating global contexts from every script loaded into the context.

When the new script starts executing, it does the following validation:
- checks the GlobalContextTable and global object (non-configurable own) properties against the set of declarations it introduces and reports potential conflicts.
- invalidates the conflicting PropertyCells on global object, so that any code depending on them will miss/deopt causing any contextual lookups to be reexecuted under the new bindings
- adds the lexical bindings it introduces to the GlobalContextTable

Loads and stores for contextual lookups are modified so that they check the GlobalContextTable before looking up properties on global object, thus implementing the shadowing of global object properties by lexical declarations.

R=adamk@chromium.org, rossberg@chromium.org

Review URL: https://codereview.chromium.org/705663004

Cr-Commit-Position: refs/heads/master@{#25220}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25220 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      1a64b02d
  11. 04 Nov, 2014 1 commit
  13. 20 Oct, 2014 1 commit
  15. 17 Oct, 2014 1 commit
  17. 14 Oct, 2014 1 commit
  19. 07 Oct, 2014 1 commit
  21. 06 Oct, 2014 1 commit
  23. 02 Oct, 2014 1 commit
  25. 01 Oct, 2014 3 commits
  27. 18 Sep, 2014 1 commit
  29. 10 Sep, 2014 2 commits
  31. 08 Sep, 2014 1 commit
  33. 02 Sep, 2014 1 commit
  35. 01 Sep, 2014 1 commit
  37. 27 Aug, 2014 1 commit
    • adamk@chromium.org's avatar
      Ensure that JSProxy::Fix gives the generated JSObject map a constructor · 71fbe7d4
      adamk@chromium.org authored 
      All JSObjects in V8 either have a map()->constructor() field or are
JSFunctions. JSProxy::Fix, however, was not enforcing this, and
Object.observe's use of JSObject::GetCreationContext() exposed this.

Note that this is not Object.observe-specific: the API call
v8::Object::CreationContext() also would have revealed this bug.

This patch chooses Object as a reasonable constructor to put on the
newly-fixed object's map. Note that this has no effect on the "constructor"
property in JS. In doing so, I've also tightened up the code underlying
JSProxy::Fix to only support JSObject and JSFunction as possible output
types.

BUG=405844
LOG=N
R=rossberg@chromium.org, verwaest@chromium.org

Review URL: https://codereview.chromium.org/505303004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23466 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      71fbe7d4
  39. 19 Aug, 2014 1 commit
  41. 12 Aug, 2014 1 commit
  43. 11 Aug, 2014 2 commits
  45. 04 Aug, 2014 1 commit
  47. 25 Jul, 2014 1 commit
  49. 21 Jul, 2014 1 commit
  51. 15 Jul, 2014 1 commit
  53. 07 Jul, 2014 3 commits
  55. 01 Jul, 2014 2 commits
  57. 30 Jun, 2014 2 commits
  59. 26 Jun, 2014 1 commit
  61. 18 Jun, 2014 1 commit