- 02 Dec, 2015 1 commit
-
-
hpayer authored
Reland of [heap] Remove live weak cells from weak cell list when finalizing incremental marking. (patchset #1 id:1 of https://codereview.chromium.org/1481383004/ ) Reason for revert: Reland after fixing the potential root cause of the canary crasher. Original issue's description: > Revert of [heap] Remove live weak cells from weak cell list when finalizing incremental marking. (patchset #3 id:40001 of https://codereview.chromium.org/1474303002/ ) > > Reason for revert: > Still investigating bad canary. > > Original issue's description: > > [heap] Remove live weak cells from weak cell list when finalizing incremental marking. > > > > BUG=chromium:548562 > > LOG=n > > > > Committed: https://crrev.com/6190c608c8f3ced0f00ff53965e115b78646cecd > > Cr-Commit-Position: refs/heads/master@{#32372} > > TBR=ulan@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:548562 > > Committed: https://crrev.com/72ae472ccc51ec304a66a8730c1fedbe265c16fa > Cr-Commit-Position: refs/heads/master@{#32459} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:548562 Review URL: https://codereview.chromium.org/1491743003 Cr-Commit-Position: refs/heads/master@{#32503}
-
- 01 Dec, 2015 1 commit
-
-
hpayer authored
Revert of [heap] Remove live weak cells from weak cell list when finalizing incremental marking. (patchset #3 id:40001 of https://codereview.chromium.org/1474303002/ ) Reason for revert: Still investigating bad canary. Original issue's description: > [heap] Remove live weak cells from weak cell list when finalizing incremental marking. > > BUG=chromium:548562 > LOG=n > > Committed: https://crrev.com/6190c608c8f3ced0f00ff53965e115b78646cecd > Cr-Commit-Position: refs/heads/master@{#32372} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:548562 Review URL: https://codereview.chromium.org/1481383004 Cr-Commit-Position: refs/heads/master@{#32459}
-
- 27 Nov, 2015 1 commit
-
-
hpayer authored
BUG=chromium:548562 LOG=n Review URL: https://codereview.chromium.org/1474303002 Cr-Commit-Position: refs/heads/master@{#32372}
-
- 24 Nov, 2015 1 commit
-
-
ofrobots authored
Makes it possible for the the inline allocation observers to be sample the actual object allocation on which the notification triggers. R=hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/1460063006 Cr-Commit-Position: refs/heads/master@{#32209}
-
- 05 Nov, 2015 1 commit
-
-
ofrobots authored
Expose the steps for incremental marking and idle scavenge more directly in NewSpace. Adjust the NewSpace and Heap interfaces to allow callers to be more clear about how they are interacting with inline allocation steps. This refactor prepares the ground for more consumers of inline allocation steps (e.g. sampling heap profiler.) R=hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/1404523002 Cr-Commit-Position: refs/heads/master@{#31814}
-
- 28 Oct, 2015 1 commit
-
-
hpayer authored
[heap] Convert overapproximate weak closure phase into finalize incremental marking phase and revisit the root set there. BUG=chromium:548562 LOG=n Review URL: https://codereview.chromium.org/1428683002 Cr-Commit-Position: refs/heads/master@{#31627}
-
- 12 Oct, 2015 1 commit
-
-
mstarzinger authored
The revert of the original change in question did not recover regressions, which allows us to reland this cleanup after all. This reverts commit 871529b4. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1393773004 Cr-Commit-Position: refs/heads/master@{#31214}
-
- 05 Oct, 2015 1 commit
-
-
mstarzinger authored
The change in question caused regressions on GC-heavy benchmarks, presumably due to the added indirection that is taken within hot code like the marking visitor. This is a manual revert due to conflicts. This reverts commit 4f55b830. R=hpayer@chromium.org BUG=chromium:539273 LOG=n Review URL: https://codereview.chromium.org/1386863002 Cr-Commit-Position: refs/heads/master@{#31097}
-
- 30 Sep, 2015 2 commits
-
-
mstarzinger authored
This enables linter checking for "readability/namespace" violations during presubmit and instead marks the few known exceptions that we allow explicitly. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1371083003 Cr-Commit-Position: refs/heads/master@{#31019}
-
mstarzinger authored
This moves some methods of IncrementalMarking from the inlined header into the compilation unit. The methods in question are either not hot or are being called through a non-inline function already. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1380523002 Cr-Commit-Position: refs/heads/master@{#31017}
-
- 29 Sep, 2015 1 commit
-
-
mstarzinger authored
This prevents the internal incremental-marking.h to be usable outisde of the "heap" directory. The logic inside that component is only useful within the GC and is now properly encapsulated. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1374203002 Cr-Commit-Position: refs/heads/master@{#31010}
-
- 28 Sep, 2015 1 commit
-
-
mstarzinger authored
R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1366183003 Cr-Commit-Position: refs/heads/master@{#30961}
-
- 08 Sep, 2015 1 commit
-
-
ulan authored
This moves incremental marking steps from gc-idle-time-handler and heap to the new incremental marking task. BUG=chromium:490559 LOG=NO Review URL: https://codereview.chromium.org/1265423002 Cr-Commit-Position: refs/heads/master@{#30641}
-
- 25 Aug, 2015 1 commit
-
-
mlippautz authored
Moves the GCCallbackflags where they belong, i.e., {Heap}, and gets rid of IncrementalMarking::Start() callsites. BUG= Review URL: https://codereview.chromium.org/1314853002 Cr-Commit-Position: refs/heads/master@{#30349}
-
- 21 Aug, 2015 1 commit
-
-
mlippautz authored
GC flags are now part of the {Heap} and should be respected by all sub-components. Also add a infrastructure to write tests accessing private methods. Review URL: https://codereview.chromium.org/1301183002 Cr-Commit-Position: refs/heads/master@{#30281}
-
- 17 Aug, 2015 1 commit
-
-
mstarzinger authored
R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1291833003 Cr-Commit-Position: refs/heads/master@{#30195}
-
- 07 Aug, 2015 1 commit
-
-
mstarzinger authored
R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1279043002 Cr-Commit-Position: refs/heads/master@{#30061}
-
- 06 Aug, 2015 1 commit
-
-
ulan authored
Idle notification should force marking to make progress. BUG= Review URL: https://codereview.chromium.org/1275573002 Cr-Commit-Position: refs/heads/master@{#30041}
-
- 04 Aug, 2015 3 commits
-
-
mlippautz authored
Combines: * https://codereview.chromium.org/1273483002/ * https://codereview.chromium.org/1266793003/ This reverts commit 0215fb56. BUG= Review URL: https://codereview.chromium.org/1265273002 Cr-Commit-Position: refs/heads/master@{#30014}
-
adamk authored
Revert of GC: Refactor public incremental marking interface in heap (patchset #6 id:100001 of https://codereview.chromium.org/1273483002/ ) Reason for revert: Fails on the MSAN builder: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/3580/steps/Check/logs/RegExpInterruption Likely due to lack of initialization of IncrementalMarking::gc_callback_flags_. Original issue's description: > GC: Refactor incremental marking interface from heap > > BUG= > > Committed: https://crrev.com/c9fcaeb336919ce4b76fded8c8059457e9820250 > Cr-Commit-Position: refs/heads/master@{#30009} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1271823006 Cr-Commit-Position: refs/heads/master@{#30011}
-
mlippautz authored
BUG= Review URL: https://codereview.chromium.org/1273483002 Cr-Commit-Position: refs/heads/master@{#30009}
-
- 06 Jul, 2015 1 commit
-
-
machenbach authored
Revert of Reland: Fix logic for incremental marking steps on tenured allocation (patchset #4 id:60001 of https://codereview.chromium.org/1077153004/) Reason for revert: [Sheriff] Speculative revert, see: https://code.google.com/p/chromium/issues/detail?id=506875 Original issue's description: > Reland: Fix logic for incremental marking steps on tenured allocation > > BUG= > > Committed: https://crrev.com/5000650bde2ec0bc90d959b529c97aea20385043 > Cr-Commit-Position: refs/heads/master@{#29442} TBR=hpayer@chromium.org,erikcorry@chromium.org BUG=chromium:506875 LOG=n NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1212063005 Cr-Commit-Position: refs/heads/master@{#29494}
-
- 02 Jul, 2015 1 commit
-
-
erikcorry authored
BUG= Review URL: https://codereview.chromium.org/1077153004 Cr-Commit-Position: refs/heads/master@{#29442}
-
- 03 Jun, 2015 1 commit
-
-
sejunho authored
Both PrepareForScavenge and ResetAllocationInfo clear semi-space mark bits before Scavenge. Doing this once is good enough. BUG= Review URL: https://codereview.chromium.org/1158623003 Cr-Commit-Position: refs/heads/master@{#28778}
-
- 22 May, 2015 1 commit
-
-
machenbach authored
Revert of Revert of Pass GC flags to incremental marker and start incremental marking with (patchset #1 id:1 of https://codereview.chromium.org/1151143002/) Reason for revert: Wasn't the reason... Original issue's description: > Revert of Pass GC flags to incremental marker and start incremental marking with (patchset #3 id:40001 of https://codereview.chromium.org/1156463002/) > > Reason for revert: > [Sheriff] Speculative revert because chromebook is really misbehaving: > http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2109 > > I also triggered a retry with the failing build to be sure. If the revert doesn't help or the bot had a scary hiccup, this can reland. > > Original issue's description: > > Pass GC flags to incremental marker and start incremental marking with > > reduce memory footprint in idle notification. > > > > BUG= > > > > Committed: https://crrev.com/4656308147b12405037678b1ab192fb4f2437bbc > > Cr-Commit-Position: refs/heads/master@{#28567} > > TBR=hpayer@chromium.org,ulan@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/634c58a4f10b346a98208ec34d169e1bdb04e1b7 > Cr-Commit-Position: refs/heads/master@{#28568} TBR=hpayer@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1157613002 Cr-Commit-Position: refs/heads/master@{#28569}
-
- 21 May, 2015 2 commits
-
-
machenbach authored
Revert of Pass GC flags to incremental marker and start incremental marking with (patchset #3 id:40001 of https://codereview.chromium.org/1156463002/) Reason for revert: [Sheriff] Speculative revert because chromebook is really misbehaving: http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2109 I also triggered a retry with the failing build to be sure. If the revert doesn't help or the bot had a scary hiccup, this can reland. Original issue's description: > Pass GC flags to incremental marker and start incremental marking with > reduce memory footprint in idle notification. > > BUG= > > Committed: https://crrev.com/4656308147b12405037678b1ab192fb4f2437bbc > Cr-Commit-Position: refs/heads/master@{#28567} TBR=hpayer@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1151143002 Cr-Commit-Position: refs/heads/master@{#28568}
-
ulan authored
reduce memory footprint in idle notification. BUG= Review URL: https://codereview.chromium.org/1156463002 Cr-Commit-Position: refs/heads/master@{#28567}
-
- 29 Apr, 2015 1 commit
-
-
hpayer authored
Note, that it also moves incremental marking traces behind the --trace-incremental-marking flag. Other PrintF's of the GC should be moved as well to PrintPIDAndIsolate. BUG= Review URL: https://codereview.chromium.org/1109133002 Cr-Commit-Position: refs/heads/master@{#28135}
-
- 20 Apr, 2015 1 commit
-
-
jkummerow authored
Revert of Fix logic for doing incremental marking steps on tenured allocation. (patchset #4 id:60001 of https://codereview.chromium.org/1040233003/) Reason for revert: Suspected of triggering memory corruption issues, e.g. crbug.com/478401. Original issue's description: > Fix logic for doing incremental marking steps on tenured allocation. > > R=hpayer@chromium.org > BUG= > > Committed: https://crrev.com/9716468ae63500adb74f5188c47de847e195d71b > Cr-Commit-Position: refs/heads/master@{#27883} TBR=hpayer@chromium.org,erikcorry@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1099633002 Cr-Commit-Position: refs/heads/master@{#27944}
-
- 17 Apr, 2015 1 commit
-
-
erikcorry authored
R=hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/1094843002 Cr-Commit-Position: refs/heads/master@{#27914}
-
- 16 Apr, 2015 1 commit
-
-
erikcorry authored
R=hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/1040233003 Cr-Commit-Position: refs/heads/master@{#27883}
-
- 31 Mar, 2015 1 commit
-
-
ulan authored
BUG=chromium:450824 LOG=NO TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/1048013003 Cr-Commit-Position: refs/heads/master@{#27544}
-
- 26 Mar, 2015 1 commit
-
-
ulan authored
This reverts commit 89ba65fd. Reason: crash in v8.detached_context_age_in_gc benchmark. BUG=chromium:450824 LOG=NO NOTRY=true NOTREECHECKS=true TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/1034203002 Cr-Commit-Position: refs/heads/master@{#27483}
-
- 25 Mar, 2015 1 commit
-
-
ulan authored
BUG=chromium:450824 LOG=NO Review URL: https://codereview.chromium.org/1038663002 Cr-Commit-Position: refs/heads/master@{#27451}
-
- 20 Mar, 2015 1 commit
-
-
ishell authored
Revert of Allow compaction when incremental marking is on. (patchset #1 id:1 of https://codereview.chromium.org/1014263002/) Reason for revert: It seems to cause crbug/469146. Original issue's description: > Allow compaction when incremental marking is on. > > BUG=chromium:450824 > LOG=NO > > Committed: https://crrev.com/92f96e4e9a527fcb085b68f81ee14b26acdd4719 > Cr-Commit-Position: refs/heads/master@{#27267} TBR=hpayer@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:450824 Review URL: https://codereview.chromium.org/1026813002 Cr-Commit-Position: refs/heads/master@{#27345}
-
- 18 Mar, 2015 2 commits
-
-
ulan authored
BUG=chromium:450824 LOG=NO Review URL: https://codereview.chromium.org/1014263002 Cr-Commit-Position: refs/heads/master@{#27267}
-
jochen authored
BUG=v8:3862 R=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/1014873002 Cr-Commit-Position: refs/heads/master@{#27261}
-
- 16 Mar, 2015 2 commits
-
-
jochen authored
The feature itself is still behind a flag. BUG=v8:3862 R=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/1014503003 Cr-Commit-Position: refs/heads/master@{#27225}
-
jochen authored
Also, include the time for building object groups in the tracing scope for the overapproximation. BUG=v8:3862 R=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/1012593004 Cr-Commit-Position: refs/heads/master@{#27218}
-
- 13 Mar, 2015 1 commit
-
-
jochen authored
Since incremental marking hasn't completed yet at this point, we can't use the MC's root visitor. Also, we shouldn't hurry with incremental marking while overapproximating BUG=v8:3862 R=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/997423002 Cr-Commit-Position: refs/heads/master@{#27184}
-