- 14 Sep, 2021 1 commit
-
-
Francis McCabe authored
s/&/,/ Bug: v8:12191 Change-Id: Ib933470455c4a0f6e133bd1277cc2bba6aa83e12 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158549Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76817}
-
- 13 Sep, 2021 6 commits
-
-
Ng Zhi An authored
We move the implementation in Liftoff (which is the most general and handles AVX/SSE and also register aliasing) into shared-macro-assembler. Also consolidate SSE/AVX for ia32. No functionality change is expected. Bug: v8:11589 Bug: v8:11217 Change-Id: I64cc71791f04332dd3505055f4672430c2daf5ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3131373Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76805}
-
Ng Zhi An authored
Move this from macro-assembler-x64 to shared-macro-assembler, and use this implementation for ia32 (TurboFan and Liftoff). Bug: v8:11589 Change-Id: If851560c8db1293924ca024725609c399c553a4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124099 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#76803}
-
Clemens Backes authored
This fixes the order of declaring class members for LiftoffCompiler, LiftoffAssembler, LiftoffRegister, and LiftoffRegList. The recommended order according to the style guide is: types, constants, constructors, other members, data members. R=thibaudm@chromium.org Bug: v8:11879 Change-Id: I5c550ed11ed0169f07477b6a1723053316374707 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3157960 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76798}
-
Junliang Yan authored
Change-Id: Icdef3916993e14e39ef9da70af128b9fde2d3b60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3158323Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76797}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: v8:12108 Change-Id: Iad128d108df64a5a0c205f7ed69a06cdffb40c31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3148133Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76790}
-
Andreas Haas authored
This reverts commit 91b72485. Reason for revert: Some spec tests are failing, see WPT tests. Original change's description: > [wasm] Ship Reference Types > > R=ecmziegler@chromium.org > > Bug: v8:7581 > Change-Id: I9acd99f3cf6832ee393d839cde7444a475a8f808 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123409 > Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76565} Bug: v8:7581 Change-Id: I18ed821ffda51cdc9869e0e36666c816d0bf00df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141576 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/main@{#76786}
-
- 10 Sep, 2021 8 commits
-
-
Junliang Yan authored
Change-Id: I05bcba3ad27b46b7c7888940895605ad463fc960 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3155302Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76774}
-
Junliang Yan authored
Change-Id: Iea662aa79bf6d8fc7f8951482b6dfc0bcf30d081 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151964Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76773}
-
Ng Zhi An authored
Move some AVX_OP into shared macro-assembler, for reuse by ia32 in future patches. Movlhps is also unused in x64, so remove it. Drive-by cleanup to use macro assembler helper Move to move 128-bit const into a XMMRegister. The change in liftoff-assembler-x64 is required because now the macro-assembler functions are defined in the base class, so even though we can use &TurboAssembler::Pcmpeqd to refer to that member function, it actually resolves to &SharedTurboAssembler::Pcmpeqd. Bug: v8:11589 Change-Id: Ie8f6a4dfd95b41192936f6e6be48c683042acec4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3150138Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76772}
-
Ng Zhi An authored
We already have some logic to try to get a reasonable name for the function when logging code. It looks up the name custom section, and falls back to the function index. Extract this into a helper, and call it when disassembly the code. Bug: v8:12098 Change-Id: Ieebe6594bc3184fa655f878faa0cb67c248d7f56 Fixed: v8:12098 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3125355Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#76769}
-
Junliang Yan authored
Change-Id: I1efa3969ee07deca1dfa33f730f46a1067c12d73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152753Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76768}
-
Junliang Yan authored
Change-Id: Ie9c8cf6475532df979c96df62254af32de6cf98f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3152748Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#76767}
-
Clemens Backes authored
In the case that {dst}, {lhs} and {rhs} all point to the same register, we would emit wrong code (negating the register and adding it to itself). This CL fixes this by checking if {lhs == rhs}, and just clearing the {dst} register in that case. R=thibaudm@chromium.org Bug: chromium:1247659 Change-Id: I7913617850adb34a5ad812369f16a7422358454d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3151955Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76765}
-
Clemens Backes authored
With statically in-bounds memory accesses (implemented in https://crrev.com/c/2919827) we would only have an offset but no index register for {TraceMemoryOperation}. This CL fixes that situation. R=thibaudm@chromium.org Bug: chromium:1248024 Change-Id: I856b263a560cb71791c61e446e78dd99c9664190 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149464Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76763}
-
- 09 Sep, 2021 1 commit
-
-
Zhao Jiazhong authored
The t6-t8 are scratch registers and should not be allocatable. Besides, add s0, s1, s2, s5 and s8 as allocatable registers. Change-Id: I0805cc5273d0e0ec5040a0376bcbfba276202077 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3147315 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76739}
-
- 08 Sep, 2021 3 commits
-
-
Francis McCabe authored
Bug: v8:12191 Change-Id: I867e81a62341f9c95cf56466b9d97a877d9debdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3145990Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76731}
-
Clemens Backes authored
This adds some basic tests for WebAssembly code protection, in four different configurations: - no protection - mprotect-based protection - PKU-based protection - PKU with fallback to mprotect If PKU is not supported by the OS or hardware, then PKU is identical to no protection, and PKU with fallback is identical to mprotect. We always execute all four configurations anyway. If protection is effective, we expect code to be writable within a {CodeSpaceWriteScope}, and not writable otherwise. When trying to write to non-writable code, we expect a crash of the process (checked via {ASSERT_DEATH_IF_SUPPORTED}). R=jkummerow@chromium.org CC=mpdenton@chromium.org Bug: v8:11974 Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_dbg_ng Change-Id: I4ec0ce9426f70ff41a292b9ea25be1e8956a670e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3138210 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#76726}
-
Manos Koukoutos authored
We add an option to BuildTFGraph to not emit stack checks and call tracing and use it in inlined functions. Also, we add tests for zero/multiple return values, as well as infinite loops in the inlined function. Bug: v8:12166 Change-Id: I5f34c57d9870592085804853ff23ba94897cc8d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141589Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#76718}
-
- 07 Sep, 2021 9 commits
-
-
Ng Zhi An authored
Bug: v8:12094 Change-Id: Ibefce881cbfcd4445485197a4a2615bdf0599ada Fixed: v8:12094 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3123638 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#76706}
-
Jakob Kummerow authored
Simply putting all features behind --experimental-wasm-gc. The intent is to simplify command lines. Bug: v8:7748 Change-Id: Ibfaa4dc720087a490b177a2b95841620a4d25d89 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141583 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#76703}
-
Lu Yahan authored
- Add vsetivli/I8x16Add/vl/vse8 - In Rvv, Vector regs is different from Float Regs. But in this cl, in order to facilitate modification, it is assumed that the vector register and float register share a set of register codes. - Because v0 is mask reg, we can't allocate it . And transfer float into vector reg, so i delete ft0 from AllocateReg. Bug: v8:11976 Change-Id: I66185d1f5ead985489bcbdf671b131f02a6bd7c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3005768 Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#76700}
-
Patrick Thier authored
The receiver is now always included in the actual argument count and the formal parameter count. kDontAdaptArgumentsSentinel is changed from UINT16_MAX to 0 to preserve the maximum allowed declared parameters. The build flag activating the changes is not set for any architecture yet. Bug: v8:11112 Change-Id: I48a4969137949a1b4d1f47545209bb22b64e7e05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3140608 Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76699}
-
Clemens Backes authored
This is a reland of 1786f8d7. It turned out that also x64 is broken, and only for TurboFan. Both is fixed now. Original change's description: > [arm64][liftoff] Fix trap handling on load lane > > This fixes the registered {protected_load_pc} to (always) point to the > actual load instruction. If {dst != src} we would emit a register move > before the load, and the trap handler would then not recognize the PC > where the signal occurs, leading to a segfault. > > R=thibaudm@chromium.org > > Bug: chromium:1242300, v8:12018 > Change-Id: I3ed2a8307e353fd85a7ddedf6ecb73e90a112d32 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3136454 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76642} Bug: chromium:1242300, v8:12018 Change-Id: I79284ab9815f5363f759569d98c8c4b52d48e738 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3140609Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76698}
-
Rakhim Khismet authored
We add table operations to the fuzzed module. GetTableType function is added in WasmModuleBuilder. Alter alternatives array in GenerateOptRef to generate less default values. Bug: v8:11954 Change-Id: I433a6fac0ab10307aeede505b7d0c1d625d27477 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3137493Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Rakhim Khismet <khismet@google.com> Cr-Commit-Position: refs/heads/main@{#76697}
-
Thibaud Michaud authored
This is a reland of 4936628e Original change's description: > [wasm][eh] Ship exception handling > > R=ahaas@chromium.org > CC=ecmziegler@chromium.org > > Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel > Bug: chromium:1173515 > Change-Id: Id487ec32de7ec10ba1f61f77414565949b8d3dc7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3138203 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76672} Bug: chromium:1173515, v8:12173 Change-Id: I61a216207e4aadfd00a716e3296af2f7c3e8df88 Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141609Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76691}
-
Manos Koukoutos authored
We introduce basic wasm inlining infrastructure behind a flag. The implementation is currently incomplete. Additionally, we always inline the function at index 0; proper inlining heuristics will be added later. Changes: - Rename WasmInliningPhase -> JSWasmInliningPhase - Introduce WasmInliningPhase and WasmInliner. - Pass additional parameters as needed to GenerateCodeForWasmFunction. - Remove EnsureEnd in WasmGraphAssembler. Create end node at the start of compilation. - Add a simple test. Bug: v8:12166 Change-Id: Ifd7006ba378e9f74cd248b71e16869fbbb8a82be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141575 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#76689}
-
Lu Yahan authored
Bug: v8:12180 Change-Id: Id3cc3a78da73b10854fd21f2760b25de91ca5966 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3143811Reviewed-by:
Ji Qiu <qiuji@iscas.ac.cn> Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#76681}
-
- 06 Sep, 2021 4 commits
-
-
Thibaud Michaud authored
Update the behavior of 'delegate' according to: https://github.com/WebAssembly/exception-handling/issues/176 Summary: delegate can target any block, which just rethrows to the next outer try/catch. R=clemensb@chromium.org Bug: v8:8091 Change-Id: I967db9ab1cbb1a15b2c5e0a1a20f64fa19a3f769 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3140603 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76677}
-
Leszek Swirski authored
This reverts commit 4936628e. Reason for revert: Seems to be making completely unrelated tests flake: https://crbug.com/v8/12173 Original change's description: > [wasm][eh] Ship exception handling > > R=ahaas@chromium.org > CC=ecmziegler@chromium.org > > Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel > Bug: chromium:1173515 > Change-Id: Id487ec32de7ec10ba1f61f77414565949b8d3dc7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3138203 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76672} Bug: chromium:1173515 Change-Id: Ibc447a8d73f81d938f6ae378a684111611d9fde5 Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141604 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#76674}
-
Thibaud Michaud authored
R=ahaas@chromium.org CC=ecmziegler@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel Bug: chromium:1173515 Change-Id: Id487ec32de7ec10ba1f61f77414565949b8d3dc7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3138203Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76672}
-
Dan Elphick authored
Adds a USE(...) around a std::accumulate which appears to have nodiscard on it in MSVC builds. Probably only manifests with debug flags on as otherwise code is not compiled. Change-Id: I78f4f2c07161598336fedcdd4a204379c4deb81b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141579 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#76671}
-
- 03 Sep, 2021 2 commits
-
-
Manos Koukoutos authored
We use BuildCCall over CallBuiltin. This improves the performance of array.copy by up to 2x for small arrays. Bug: v8:7748 Change-Id: Ibbd6a69267edb229beda1f6de4ff1c48eb38b729 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3135580 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#76661}
-
Andreas Haas authored
The WebAssembly.Table constructor supports a second parameter that was not supported by V8 so far. R=thibaudm@chromium.org Bug: v8:7581 Change-Id: Id74c53a6b1bde7f49a4edea8397d1cab253e1a0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3141571 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#76660}
-
- 02 Sep, 2021 6 commits
-
-
Milad Fa authored
Port e6961df2 Original Commit Message: Instrument floating-point operations to set a flag if the result is NaN. R=martyn.capewell@arm.com, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I6f3fe550bf30f85bbb3fa9437d676896e876fd30 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3137418Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#76645}
-
Nico Hartmann authored
This reverts commit 1786f8d7. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64/44442/overview Original change's description: > [arm64][liftoff] Fix trap handling on load lane > > This fixes the registered {protected_load_pc} to (always) point to the > actual load instruction. If {dst != src} we would emit a register move > before the load, and the trap handler would then not recognize the PC > where the signal occurs, leading to a segfault. > > R=thibaudm@chromium.org > > Bug: chromium:1242300, v8:12018 > Change-Id: I3ed2a8307e353fd85a7ddedf6ecb73e90a112d32 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3136454 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#76642} Bug: chromium:1242300, v8:12018 Change-Id: I7bc9d00a4fba3101e7ee68695961d1b543268c4e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3138202Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#76644}
-
Clemens Backes authored
This fixes the registered {protected_load_pc} to (always) point to the actual load instruction. If {dst != src} we would emit a register move before the load, and the trap handler would then not recognize the PC where the signal occurs, leading to a segfault. R=thibaudm@chromium.org Bug: chromium:1242300, v8:12018 Change-Id: I3ed2a8307e353fd85a7ddedf6ecb73e90a112d32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3136454Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#76642}
-
Patrick Thier authored
- Replace CodeStubArguments::GetLength() with GetLengthWithReceiver() and GetLengthWithoutReceiver() - Introduce and use Torque macros to load the formal parameter count (with and without receiver). - Add actual_count to Torque arguments structure for cases where the argument count is not used, but just forwarded to other builtins. Bug: v8:11112 Change-Id: I32278efeffa2fb08361989c6df8de56c74add8b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3124804Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#76637}
-
Liu Yu authored
Besides, fix an error in set_if_nan, because if src is a NaN, we should set the i32 instead of i64 at address dst to a non-zero value. Port e6961df2 Bug: v8:11856 Change-Id: Icc9afda35d4cca4fd5ae82356ecaec77bf92d009 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3139055Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#76636}
-
QiuJi authored
Also fix several out of date comments. Change-Id: I15ee6c718ad50f231cd0a8e5c6416ccb58375140 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3121693 Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by:
Brice Dobry <brice.dobry@futurewei.com> Cr-Commit-Position: refs/heads/main@{#76633}
-