- 12 Oct, 2016 40 commits
-
-
gsathya authored
This patch results in a 11% improvement over 5 runs in the bluebird benchmark. BUG=v8:5343,v8:5046 TBR=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2406343002 Cr-Commit-Position: refs/heads/master@{#40239}
-
mtrofin authored
This incorporates recent feedback: - simpler deserialization API by dropping the std::unique_ptr. The only purpose there was communicating to the caller that they own the buffer, and that the deserializer won't delete it. The new design communicates that through a naming choice. - renamed *UncompiledBytes to *WasmWireBytes BUG= Review-Url: https://codereview.chromium.org/2411263004 Cr-Commit-Position: refs/heads/master@{#40238}
-
alph authored
Review-Url: https://codereview.chromium.org/2404663002 Cr-Commit-Position: refs/heads/master@{#40237}
-
gsathya authored
Review-Url: https://codereview.chromium.org/2405173005 Cr-Commit-Position: refs/heads/master@{#40236}
-
machenbach authored
BUG=428099 Review-Url: https://codereview.chromium.org/2404283002 Cr-Commit-Position: refs/heads/master@{#40235}
-
lpy authored
The over allocated memory of fixed array type didn't equal to the sum of all fixed array sub types previously, this patch adds over allocated memory of fixed array sub types to fixed array type when we record fixed array sub type stats. BUG= LOG=N Review-Url: https://codereview.chromium.org/2410083003 Cr-Commit-Position: refs/heads/master@{#40234}
-
clemensh authored
By defining functions with namespace prefix, the compiler checks that they were previously declared, and checks that the signature matches. I stumbled across this several times when changing the interface of a function in the header. With this change you get a compile error right away instead of a linker error in the very end. This change also revealed two functions which could be placed in an anonymous namespace, saving 5.5kB program size in Debug build, 2.3kB in Optdebug and 0.3kB in Release. It's also opening more options for compiler optimizations, as the functions now have internal linkage. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2415603002 Cr-Commit-Position: refs/heads/master@{#40233}
-
fmeawad authored
The state sampling was implemented in chrome, we had an interface for it V8 but it was not implemented yet. The chrome version version has been removed in https://codereview.chromium.org/2406703002/ Therefore following up with its removal in V8 as well. This CL can land independent of the Chromium related CL. R=primiano@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2410523002 Cr-Commit-Position: refs/heads/master@{#40232}
-
verwaest authored
BUG=v8:5501 Review-Url: https://codereview.chromium.org/2410413003 Cr-Commit-Position: refs/heads/master@{#40231}
-
dschuff authored
Imported and defined globals share an index space, but previously the decoder clobbered the imported global indices with the defined globals. BUG=none Review-Url: https://codereview.chromium.org/2410953003 Cr-Commit-Position: refs/heads/master@{#40230}
-
jgruber authored
This CL is in preparation for the upcoming port of RegExp.prototype.replace, which will need use these methods in runtime-regexp.cc. Moving them in advance makes that diff less noisy. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2398413002 Cr-Commit-Position: refs/heads/master@{#40229}
-
bjaideep authored
Port c15c5827 Original commit message: This is the next step to unify the Call/Construct feedback collection and prepare it to be able to collect SharedFunctionInfo feedback. This also reduces the CallICStub overhead quite a bit since we only need one stub per mode (and tail call mode), not also one per call arity. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2415583002 Cr-Commit-Position: refs/heads/master@{#40228}
-
verwaest authored
BUG=v8:5501 Review-Url: https://codereview.chromium.org/2413673002 Cr-Commit-Position: refs/heads/master@{#40227}
-
kozyatinskiy authored
Unittests for protocol parser are located in core/inspector in blink and separate test runner for inspector tests was added. BUG=chromium:635948 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2376173002 Cr-Commit-Position: refs/heads/master@{#40226}
-
kozyatinskiy authored
This location is used at least in Chromium. BUG=chromium:635948 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2405303002 Cr-Commit-Position: refs/heads/master@{#40225}
-
titzer authored
R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2415533003 Cr-Commit-Position: refs/heads/master@{#40224}
-
ishell authored
... because the latter automatically respects the desired calling convention. BUG=v8:5408 Review-Url: https://codereview.chromium.org/2391043005 Cr-Commit-Position: refs/heads/master@{#40223}
-
ishell authored
Thus the parameter indices defined in respective CallInterfaceDescriptor can be used for querying parameters. BUG= Review-Url: https://codereview.chromium.org/2389133007 Cr-Commit-Position: refs/heads/master@{#40222}
-
hpayer authored
BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2403423007 Cr-Commit-Position: refs/heads/master@{#40221}
-
ishell authored
Review-Url: https://codereview.chromium.org/2412613004 Cr-Commit-Position: refs/heads/master@{#40220}
-
ishell authored
Review-Url: https://codereview.chromium.org/2411793004 Cr-Commit-Position: refs/heads/master@{#40219}
-
hpayer authored
The race can happen if: 1) Fixed array A is right before object B in new space 2) A slot in object C located in old space points to object B (old to new remembered set entry is created) 3) Object C becomes unreachable which held the only reference to object B which also becomes unreachable 4) Fixed array A gets right trimmed 5) The sweeper will sweep the last word of object A and object B. It will write the free space map into the last word of object A and a size field in the first word of object B. 6) Pointer updating may observe the size field now because the recored slot points to the start of object B and will confuse it with a forwarding pointer. Note a similar race may happen with left trimming. Array A points to its backing store, the backing store gets left trimmed by 1 element, and array A dies. BUG= Review-Url: https://codereview.chromium.org/2416563002 Cr-Commit-Position: refs/heads/master@{#40218}
-
verwaest authored
This should restore the codeload regression when FLAG_lazy_inner_functions is turned off BUG=v8:5501 Review-Url: https://codereview.chromium.org/2412483005 Cr-Commit-Position: refs/heads/master@{#40217}
-
ishell authored
[stubs] Drop StoreICStub and StoreICTrampolineStub (the non-TurboFan implementations of StoreIC dispatchers). Because of the planned improvements of IC system it does not make sense to keep the old platform version of the stub around. Review-Url: https://codereview.chromium.org/2413653003 Cr-Commit-Position: refs/heads/master@{#40216}
-
verwaest authored
If we're parsing a script or based on a SharedFunctionInfo marked as toplevel, we can implicitly set it. Only manually set in the background parsing task where we manually set up ParseInfo. BUG=v8:5501 Review-Url: https://codereview.chromium.org/2405263003 Cr-Commit-Position: refs/heads/master@{#40215}
-
verwaest authored
This is allocating registers in the function for all inner contexts that can be active in that function, so that nested blocks always have O(1) access to all outer contexts. However, currently it's always walking into nested functions, overallocating the number of registers, causing additional register pressure. BUG=v8:5484 Review-Url: https://codereview.chromium.org/2408303003 Cr-Commit-Position: refs/heads/master@{#40214}
-
hpayer authored
This CL also introduces a NoBarrierAtomicValue with NoBarrier accessors. BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2408233004 Cr-Commit-Position: refs/heads/master@{#40213}
-
ishell authored
Review-Url: https://codereview.chromium.org/2412493006 Cr-Commit-Position: refs/heads/master@{#40212}
-
ishell authored
[stubs] Drop LoadICStub and LoadICTrampolineStub (the non-TurboFan implementations of LoadIC dispatchers). Because of the planned improvements of IC system it does not make sense to keep the old platform version of the stub around. Review-Url: https://codereview.chromium.org/2418513002 Cr-Commit-Position: refs/heads/master@{#40211}
-
bmeurer authored
We want to extend the use of this code dependency, so the name does no longer reflect the purpose. R=ishell@chromium.org Review-Url: https://codereview.chromium.org/2410293003 Cr-Commit-Position: refs/heads/master@{#40210}
-
epertoso authored
WordIsSmi, by itself, is not that descriptive, as it just ands a word with the heap object tag. With this change, the MachineGraphVerifier can check that the input to TaggedIsSmi actually has a tagged representation. This CL also introduces a few bitcast operators in the Smi* macros in the CodeStubAssembler. R=bmeurer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2407303002 Cr-Commit-Position: refs/heads/master@{#40209}
-
machenbach authored
BUG=v8:5412 Review-Url: https://codereview.chromium.org/2409133002 Cr-Commit-Position: refs/heads/master@{#40208}
-
georgia.kouveli authored
The only way to get a minus zero result from subtraction is (-0) - (+0) = -0, hence checking for minus zero on the RHS is redundant. This is causing some unnecessary deoptimisations in Box2D from Octane on 32-bit platforms. BUG= Review-Url: https://codereview.chromium.org/2410883003 Cr-Commit-Position: refs/heads/master@{#40207}
-
bmeurer authored
This is the next step to unify the Call/Construct feedback collection and prepare it to be able to collect SharedFunctionInfo feedback. This also reduces the CallICStub overhead quite a bit since we only need one stub per mode (and tail call mode), not also one per call arity. R=mvstanton@chromium.org BUG=v8:2206 NOTRY=true Review-Url: https://codereview.chromium.org/2412453005 Cr-Commit-Position: refs/heads/master@{#40206}
-
clemensh authored
For the asm.js to WASM pipeline, the current stack traces only show low-level WASM information. This CL maps this back to asm.js source positions. It does so by attaching the asm.js source Script to the compiled WASM module, and emitting a delta-encoded table which maps from WASM byte offsets to positions within that Script. As asm.js code does not throw exceptions, we only store a mapping for call instructions. The new AsmJsWasmStackFrame implementation inherits from WasmStackFrame, but contains the logic to provide the source script and the position inside of it. What is still missing is the JSFunction object returned by CallSite.getFunction(). We currently return null. R=jgruber@chromium.org, titzer@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2404253002 Cr-Commit-Position: refs/heads/master@{#40205}
-
clemensh authored
If passing <nullptr, 0> to the decoder and trying to decode something, it correctly detects the error and sets an error message, but still returns true on ok(), and returns a valid result. I triggered this error by passing a null Vector, returned by FindSection(), to the decoder. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2410913002 Cr-Commit-Position: refs/heads/master@{#40204}
-
machenbach authored
Revert of [CQ] Remove experimental bot temporarily. (patchset #1 id:1 of https://codereview.chromium.org/2411283002/ ) Reason for revert: Root cause fixed. Original issue's description: > [CQ] Remove experimental bot temporarily. > > BUG=chromium:655033,v8:5502 > NOTRY=true > NOPRESUBMIT=true > TBR=tandrii@chromium.org > > Committed: https://crrev.com/f994fcb10ed9ebc09a3544221db8d2fc121c6e98 > Cr-Commit-Position: refs/heads/master@{#40193} TBR=tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:655033,v8:5502 Review-Url: https://codereview.chromium.org/2412073002 Cr-Commit-Position: refs/heads/master@{#40203}
-
ishell authored
BUG=chromium:645438 Review-Url: https://codereview.chromium.org/2412853002 Cr-Commit-Position: refs/heads/master@{#40202}
-
bmeurer authored
We accidently dropped the effect on the floor that we have for the polymorphic map check in case of array elements access. BUG=chromium:655004 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2411273002 Cr-Commit-Position: refs/heads/master@{#40201}
-
machenbach authored
Revert of [inspector] fix timestamp formatting with non C locales (patchset #7 id:120001 of https://codereview.chromium.org/2410933002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10548 See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [inspector] fix timestamp formatting with non C locales > > If current locale has "," as decimal separator then message for consoleAPICalled will be corrupted. > > BUG=chromium:653424 > R=dgozman@chromium.org > > Committed: https://crrev.com/dde5ef75cbac1eb7e2dae59b246e4a0d0ba6a0f4 > Cr-Commit-Position: refs/heads/master@{#40190} TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:653424 Review-Url: https://codereview.chromium.org/2419453002 Cr-Commit-Position: refs/heads/master@{#40200}
-