- 14 Nov, 2017 1 commit
-
-
Andreas Haas authored
With this CL, {CreateDefaultPlatform} returns a unique_ptr to indicate that the caller owns the returned memory. We had several memory leaks where the memory of the DefaultPlatform did not get deallocated. In addition, the {TracingController} of the {DefaultPlatform} also gets received as a unique_ptr. Thereby we document that the {DefaultPlatform} takes ownership of the {TracingController}. Note that the memory of the {TracingController} was already owned by the {DefaultPlatform}, but it was not documented in the interface, and it was used incorrectly in tests. This CL fixes the asan issues in https://chromium-review.googlesource.com/c/v8/v8/+/753583 ([platform] Implement TaskRunners in the DefaultPlatform) R=rmcilroy@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I0d1a6d3b22bb8289dc050b1977e4f58381cec675 Reviewed-on: https://chromium-review.googlesource.com/755033Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#49349}
-
- 07 Mar, 2017 1 commit
-
-
ulan authored
BUG=v8:6056 Review-Url: https://codereview.chromium.org/2737743002 Cr-Commit-Position: refs/heads/master@{#43640}
-
- 05 Jan, 2017 1 commit
-
-
jochen authored
This turns hangs on win_dbg into actually crashes R=machenbach@chromium.org BUG= Review-Url: https://codereview.chromium.org/2613033002 Cr-Commit-Position: refs/heads/master@{#42090}
-
- 04 Nov, 2015 1 commit
-
-
ishell authored
Review URL: https://codereview.chromium.org/1412223018 Cr-Commit-Position: refs/heads/master@{#31785}
-
- 14 Aug, 2015 1 commit
-
-
vogelheim authored
- Make the API look like v8::V8::InitializeICU. (That is: A static method call, not an object to be created on the stack.) - Fix path separator on Windows, by calling base::OS::isPathSeparator. - Move into API, so that it can be called by hello-world & friends. - Actually call it from hello-world and friends. R=jochen@chromium.org BUG= Review URL: https://codereview.chromium.org/1292053002 Cr-Commit-Position: refs/heads/master@{#30174}
-
- 29 Apr, 2015 1 commit
-
-
jochen authored
We shouldn't have shared state between isolates by default. The embedder is free to pass the same allocator to all isolates it creates. BUG=none R=dcarney@chromium.org LOG=y Review URL: https://codereview.chromium.org/1116633002 Cr-Commit-Position: refs/heads/master@{#28127}
-
- 28 Apr, 2015 1 commit
-
-
jochen authored
All typed arrays should be allocated through the array buffer allocator BUG=none R=dcarney@chromium.org LOG=n Review URL: https://codereview.chromium.org/1110603005 Cr-Commit-Position: refs/heads/master@{#28105}
-
- 20 Apr, 2015 1 commit
-
-
Ross McIlroy authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1088993003 Cr-Commit-Position: refs/heads/master@{#27937}
-
- 10 Feb, 2015 1 commit
-
-
vogelheim authored
To do so, extract startup_data_util from d8 and use it those executables. BUG= Review URL: https://codereview.chromium.org/913703002 Cr-Commit-Position: refs/heads/master@{#26547}
-
- 19 Nov, 2014 1 commit
-
-
Benedikt Meurer authored
Revert "Forward declaration for Isolate / Platform in libplatform.h." and "Fixes d8 on windows following.". This reverts commit 0f57ce8f. and 3245b8cb for breaking Chromium compile. TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/743533003 Cr-Commit-Position: refs/heads/master@{#25411}
-
- 18 Nov, 2014 1 commit
-
-
bulach authored
Reduces dependencies on #include files, making it easier for other build systems to include this library. BUG= Review URL: https://codereview.chromium.org/740493002 Cr-Commit-Position: refs/heads/master@{#25408}
-
- 01 Oct, 2014 1 commit
-
-
bmeurer@chromium.org authored
As per discussion on the V8 team, this is the place we want them to live, not following the Chrome Style Guide for this. BUG=v8:3489 LOG=y R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/615393002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24350 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Sep, 2014 1 commit
-
-
bmeurer@chromium.org authored
The thread local key for assert scopes can be lazily initialized and should be independent of the Isolate initialization. Also cleanup the assert-scope.{cc,h} implementation while I was at it. R=dcarney@chromium.org Review URL: https://codereview.chromium.org/609253002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24275 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Sep, 2014 1 commit
-
-
dcarney@chromium.org authored
BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/608773002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24256 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Sep, 2014 1 commit
-
-
bmeurer@chromium.org authored
TEST=compiler-unittests BUG=v8:3489 LOG=n R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/540823002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23673 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-