- 20 Apr, 2016 1 commit
-
-
thakis authored
clang assumes 16-byte stack alignment, but incoming stack alignment isn't always guaranteed to be that way. It looks like v8 was lucky to not hit this so far. See https://crbug.com/418554 -- this makes v8's standalone config match Chromium. See also https://llvm.org/bugs/show_bug.cgi?id=21414 Maybe it's possible to change the caller of OnEntryHook() to guarantee the right alignment, but matching Chromium's build flags here seems like a good idea in general. BUG=v8:4928 LOG=n Committed: https://crrev.com/3afb3324941625559635380ef98a2ee73e370a0a Cr-Commit-Position: refs/heads/master@{#35597} Review URL: https://codereview.chromium.org/1899783002 Cr-Commit-Position: refs/heads/master@{#35662}
-
- 18 Apr, 2016 2 commits
-
-
adamk authored
Revert of 32-bit linux: Force 16-byte stack alignment. (patchset #1 id:1 of https://codereview.chromium.org/1899783002/ ) Reason for revert: Broke InterpreterCreateArguments test on Linux nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/6404 Original issue's description: > 32-bit linux: Force 16-byte stack alignment. > > clang assumes 16-byte stack alignment, but incoming stack alignment isn't > always guaranteed to be that way. It looks like v8 was lucky to not hit > this so far. > > See https://crbug.com/418554 -- this makes v8's standalone config match > Chromium. See also https://llvm.org/bugs/show_bug.cgi?id=21414 > > Maybe it's possible to change the caller of OnEntryHook() to guarantee > the right alignment, but matching Chromium's build flags here seems like > a good idea in general. > > BUG=v8:4928 > LOG=n > > Committed: https://crrev.com/3afb3324941625559635380ef98a2ee73e370a0a > Cr-Commit-Position: refs/heads/master@{#35597} TBR=machenbach@chromium.org,rnk@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4928 Review URL: https://codereview.chromium.org/1895783004 Cr-Commit-Position: refs/heads/master@{#35599}
-
thakis authored
clang assumes 16-byte stack alignment, but incoming stack alignment isn't always guaranteed to be that way. It looks like v8 was lucky to not hit this so far. See https://crbug.com/418554 -- this makes v8's standalone config match Chromium. See also https://llvm.org/bugs/show_bug.cgi?id=21414 Maybe it's possible to change the caller of OnEntryHook() to guarantee the right alignment, but matching Chromium's build flags here seems like a good idea in general. BUG=v8:4928 LOG=n Review URL: https://codereview.chromium.org/1899783002 Cr-Commit-Position: refs/heads/master@{#35597}
-
- 15 Apr, 2016 1 commit
-
-
machenbach authored
Unports parts of https://codereview.chromium.org/1828543003 as per suggestion in https://codereview.chromium.org/1886293002/ Ports https://codereview.chromium.org/1532723003 Also restores -fmsc-version=1800 to support win-clang with MSVS 2013. BUG=chromium:603011 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1895453002 Cr-Commit-Position: refs/heads/master@{#35535}
-
- 14 Apr, 2016 3 commits
-
-
machenbach authored
Revert of [build] Use MSVS 2015 by default. (patchset #4 id:60001 of https://codereview.chromium.org/1886983002/ ) Reason for revert: Introduced flaky crashes on win debug. Original issue's description: > [build] Use MSVS 2015 by default. > > BUG=chromium:603131 > LOG=y > > Committed: https://crrev.com/e51e8b4ad77008ec7f88c144853e01001dbea900 > Cr-Commit-Position: refs/heads/master@{#35487} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:603131 Review URL: https://codereview.chromium.org/1890873002 Cr-Commit-Position: refs/heads/master@{#35498}
-
machenbach authored
BUG=chromium:603011 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1886293002 Cr-Commit-Position: refs/heads/master@{#35495}
-
machenbach authored
BUG=chromium:603131 LOG=y Review URL: https://codereview.chromium.org/1886983002 Cr-Commit-Position: refs/heads/master@{#35487}
-
- 13 Apr, 2016 1 commit
-
-
robtsuk authored
Fixes for misnamed toolchain from https://github.com/appcelerator/v8_titanium. Added a way to specify the NDK path since the Mac versions of the NDK aren't checked into the tools repo. Disabled a few dependencies which do not build on the Mac but which aren't needed for building usable V8 static libraries. Made the including of libdl and librt omitted for Mac hosted builds. BUG= Review URL: https://codereview.chromium.org/1879793002 Cr-Commit-Position: refs/heads/master@{#35456}
-
- 08 Apr, 2016 1 commit
-
-
rmcilroy authored
Removes the seperate Ignition snapshot and build the Ignition bytecode handlers in the default snapshot. BUG=v8:4280 LOG=N Committed: https://crrev.com/1798f3fe84faff32ba44e09f6aed79245dd98d80 Cr-Commit-Position: refs/heads/master@{#35058} Review URL: https://codereview.chromium.org/1833643002 Cr-Commit-Position: refs/heads/master@{#35359}
-
- 31 Mar, 2016 1 commit
-
-
machenbach authored
BUG=v8:4847 LOG=y Review URL: https://codereview.chromium.org/1811283002 Cr-Commit-Position: refs/heads/master@{#35148}
-
- 24 Mar, 2016 2 commits
-
-
rmcilroy authored
Revert of [Interpreter] Remove separate Ignition snapshot. (patchset #2 id:20001 of https://codereview.chromium.org/1833643002/ ) Reason for revert: Makes nosnap bots timeout due to having to rebuild bytecode handlers. Original issue's description: > [Interpreter] Remove separate Ignition snapshot. > > Removes the seperate Ignition snapshot and build the Ignition bytecode > handlers in the default snapshot. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/1798f3fe84faff32ba44e09f6aed79245dd98d80 > Cr-Commit-Position: refs/heads/master@{#35058} TBR=machenbach@google.com,yangguo@chromium.org,mstarzinger@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Review URL: https://codereview.chromium.org/1827143002 Cr-Commit-Position: refs/heads/master@{#35059}
-
rmcilroy authored
Removes the seperate Ignition snapshot and build the Ignition bytecode handlers in the default snapshot. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1833643002 Cr-Commit-Position: refs/heads/master@{#35058}
-
- 22 Mar, 2016 1 commit
-
-
jfb authored
Cleanup, and matches Chromium's build. Review URL: https://codereview.chromium.org/1820583002 Cr-Commit-Position: refs/heads/master@{#34993}
-
- 08 Mar, 2016 1 commit
-
-
machenbach authored
This adds sanitizer-coverage compilation, test-runner features and post processing. Sanitizer coverage is expected to be used together with asan. During test runner execution, the produced sancov files are disambiguated and match the pattern: <executable name>.test.<test id>.sancov. Two additional scripts are added for merging raw sancov files and for generating json data containing all instrumented lines + all covered lines from merged sancov files. Both scripts use multiprocessing for speed. The json data will later be uploaded to google storage for further use, e.g. to show coverage data in rietveld. Sancov documentation: http://clang.llvm.org/docs/SanitizerCoverage.html BUG=chromium:568949 LOG=n NOTRY=true TEST=python -m unittest sancov_formatter_test TEST=python -m unittest sancov_merger_test Review URL: https://codereview.chromium.org/1737263003 Cr-Commit-Position: refs/heads/master@{#34578}
-
- 25 Feb, 2016 4 commits
-
-
machenbach authored
The steps are slow on dev workstations. Having them run by the bots should be enough. The bots pass the mode explicitly. BUG=chromium:535160 LOG=n TBR=tandrii@chromium.org, kjellander@chromium.org Review URL: https://codereview.chromium.org/1738833002 Cr-Commit-Position: refs/heads/master@{#34290}
-
machenbach authored
This filters test and third_party files to get a speed-up when running tests and when collecting profile data. BUG=chromium:568949 LOG=n Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4 Cr-Commit-Position: refs/heads/master@{#34216} Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a Cr-Commit-Position: refs/heads/master@{#34253} Committed: https://crrev.com/fe38ad573ee737e06a74b7fcd73f557ac0f1135a Cr-Commit-Position: refs/heads/master@{#34272} Review URL: https://codereview.chromium.org/1730543002 Cr-Commit-Position: refs/heads/master@{#34276}
-
machenbach authored
Revert of [coverage] Filter some files from instrumentation. (patchset #4 id:60001 of https://codereview.chromium.org/1730543002/ ) Reason for revert: Prevents using goma with make. Original issue's description: > [coverage] Filter some files from instrumentation. > > This filters test and third_party files to get a speed-up > when running tests and when collecting profile data. > > BUG=chromium:568949 > LOG=n > > Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4 > Cr-Commit-Position: refs/heads/master@{#34216} > > Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a > Cr-Commit-Position: refs/heads/master@{#34253} > > Committed: https://crrev.com/fe38ad573ee737e06a74b7fcd73f557ac0f1135a > Cr-Commit-Position: refs/heads/master@{#34272} TBR=tandrii@chromium.org,kjellander@chromium.org,jfb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:568949 Review URL: https://codereview.chromium.org/1733213002 Cr-Commit-Position: refs/heads/master@{#34275}
-
machenbach authored
This filters test and third_party files to get a speed-up when running tests and when collecting profile data. BUG=chromium:568949 LOG=n Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4 Cr-Commit-Position: refs/heads/master@{#34216} Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a Cr-Commit-Position: refs/heads/master@{#34253} Review URL: https://codereview.chromium.org/1730543002 Cr-Commit-Position: refs/heads/master@{#34272}
-
- 24 Feb, 2016 3 commits
-
-
jfb authored
Revert of [coverage] Filter some files from instrumentation. (patchset #3 id:40001 of https://codereview.chromium.org/1730543002/ ) Reason for revert: This breaks `gclient sync` because v8_target_arch isn't defined. gyp: name 'v8_target_arch' is not defined while evaluating condition '(OS=="linux" or OS=="mac") and (target_arch=="ia32" or target_arch=="x64") and (v8_target_arch!="x87" and v8_target_arch!="x32") and coverage==0' in /media/jfb/ssd/v8/v8/build/all.gyp Error: Command '/usr/bin/python v8/build/gyp_v8' returned non-zero exit status 1 in /media/jfb/ssd/v8 Original issue's description: > [coverage] Filter some files from instrumentation. > > This filters test and third_party files to get a speed-up > when running tests and when collecting profile data. > > BUG=chromium:568949 > LOG=n > > Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4 > Cr-Commit-Position: refs/heads/master@{#34216} > > Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a > Cr-Commit-Position: refs/heads/master@{#34253} TBR=tandrii@chromium.org,kjellander@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:568949 Review URL: https://codereview.chromium.org/1737433002 Cr-Commit-Position: refs/heads/master@{#34258}
-
machenbach authored
This filters test and third_party files to get a speed-up when running tests and when collecting profile data. BUG=chromium:568949 LOG=n Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4 Cr-Commit-Position: refs/heads/master@{#34216} Review URL: https://codereview.chromium.org/1730543002 Cr-Commit-Position: refs/heads/master@{#34253}
-
machenbach authored
Revert of [coverage] Filter some files from instrumentation. (patchset #2 id:20001 of https://codereview.chromium.org/1730543002/ ) Reason for revert: [Sheriff] Breaks local make builds. Original issue's description: > [coverage] Filter some files from instrumentation. > > This filters test and third_party files to get a speed-up > when running tests and when collecting profile data. > > BUG=chromium:568949 > LOG=n > NOTRY=true > > Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4 > Cr-Commit-Position: refs/heads/master@{#34216} TBR=tandrii@chromium.org,kjellander@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:568949 Review URL: https://codereview.chromium.org/1727383002 Cr-Commit-Position: refs/heads/master@{#34247}
-
- 23 Feb, 2016 1 commit
-
-
machenbach authored
This filters test and third_party files to get a speed-up when running tests and when collecting profile data. BUG=chromium:568949 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1730543002 Cr-Commit-Position: refs/heads/master@{#34216}
-
- 22 Feb, 2016 1 commit
-
-
machenbach authored
Local testing suggests that optimized builds add more speed without trading off tool usability. We get the following differences (A: non-optimized build, B: optimized): Sometimes: Lines instrumented in A (covered and uncovered) are not instrumented in B. Rarely: Lines instrumented and covered in A are instrumented, but not covered in B. The latter might simply be caused by timing differences in the two builds. BUG=chromium:568949 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1719923002 Cr-Commit-Position: refs/heads/master@{#34193}
-
- 17 Feb, 2016 1 commit
-
-
machenbach authored
BUG=chromium:535160 LOG=n TBR=tandrii@chromium.org, kjellander@chromium.org Review URL: https://codereview.chromium.org/1709503002 Cr-Commit-Position: refs/heads/master@{#34065}
-
- 15 Feb, 2016 1 commit
-
-
machenbach authored
This creates an isolate with the v8-side valgrind wrapper and the valgrind binaries from third_party. It's dynamically checked if the directories are present. Follow up after https://codereview.chromium.org/1585093002/ and https://codereview.chromium.org/1583933006/ BUG=chromium:535160 LOG=n Review URL: https://codereview.chromium.org/1700673002 Cr-Commit-Position: refs/heads/master@{#33992}
-
- 08 Feb, 2016 1 commit
-
-
machenbach authored
Useful for example for using atomicops_internal_portable.h on Android. BUG=v8:4615 LOG=y patch from issue 1525813002 at patchset 1 (http://crrev.com/1525813002#ps1) Review URL: https://codereview.chromium.org/1637473003 Cr-Commit-Position: refs/heads/master@{#33804}
-
- 04 Feb, 2016 1 commit
-
-
machenbach authored
BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1667673003 Cr-Commit-Position: refs/heads/master@{#33724}
-
- 14 Jan, 2016 1 commit
-
-
joransiu authored
This is the first of several commits to contribute Linux on z Systems (s390/s390x) port of V8. We will be breaking up the changes into several (hopefully) logical commits. This commit contains the changes to V8 Makefile and build toolchains to introduce S390 macros and compiler options. Just for awareness for reviewers is that s390 is 31-bit (not 32!) big-endian platform on Linux on z. (MSB of address is used to distinguish between 24-bit vs 31-bit addressing!) s390x is 64-bit Linux on z. Names follow the general linux convention on the platform. A quick roadmap on upcoming commits: - Add \#include of S390 header files in common files - S390 related tests + tooling changes - printf macro for printing size_t values. - S390 platform-specific code generation code (bulk of changes!) R=danno@chromium.org,svenpanne@chromium.org,michael_dawson@ca.ibm.com,jyan@ca.ibm.com,mtbrandyberry@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1585813002 Cr-Commit-Position: refs/heads/master@{#33304}
-
- 08 Jan, 2016 1 commit
-
-
thakis authored
Matches https://crrev.com/366832 BUG=none LOG=n Review URL: https://codereview.chromium.org/1551453002 Cr-Commit-Position: refs/heads/master@{#33182}
-
- 24 Dec, 2015 1 commit
-
-
thakis authored
Follow-up to https://codereview.chromium.org/1495653002, and makes it easier to maybe have a clang/win build of v8 at some point in the future. BUG=none LOG=n Review URL: https://codereview.chromium.org/1549053002 Cr-Commit-Position: refs/heads/master@{#33037}
-
- 17 Dec, 2015 1 commit
-
-
fmeawad authored
This is based on the Skia Implementation. More on the project can be found here: https://docs.google.com/a/chromium.org/document/d/1_4LAnInOB8tM_DLjptWiszRwa4qwiSsDzMkO4tU-Qes/edit#heading=h.p97rw6yt8o2j The V8 Tracing platform will replace the isolate->event_logger(). But since the current embedders (namely chromium) currently use the isolate->event_logger, I made the default implementation (event-tracer) call into isolate->event_logger if an event_logger was set. Once the embedders properly implement the interface (for example in chromium it would look like this: https://codereview.chromium.org/707273005/), the default implementation will be doing nothing. Once the embedders side is fixed, we will change how V8 uses the tracing framework beyond the call from Logger:CallEventLogger. (which would also include a d8 implementation) BUG=v8:4560 LOG=N Review URL: https://codereview.chromium.org/988893003 Cr-Commit-Position: refs/heads/master@{#32959}
-
- 10 Dec, 2015 1 commit
-
-
jkummerow authored
Review URL: https://codereview.chromium.org/1511893004 Cr-Commit-Position: refs/heads/master@{#32743}
-
- 09 Dec, 2015 1 commit
-
-
jochen authored
Embedders still can use those APIs by default test-api.cc still has an exception to use the old APIs... BUG=v8:4143 R=vogelheim@chromium.org LOG=n Review URL: https://codereview.chromium.org/1505803004 Cr-Commit-Position: refs/heads/master@{#32701}
-
- 02 Dec, 2015 1 commit
-
-
thakis authored
update.sh is gone in chromium, and using update.py will do the right thing both before and after the deletion in chromium (previously, update.py used to call update.sh internally on non-win). This also has the benefit of working on Windows. No intended behavior change. BUG=chromium:494442 LOG=n Review URL: https://codereview.chromium.org/1495653002 Cr-Commit-Position: refs/heads/master@{#32529}
-
- 27 Nov, 2015 1 commit
-
-
balazs.kilvady authored
Fix gcc 4.9.2 signed-compare warnings/errors. BUG= Review URL: https://codereview.chromium.org/1476473002 Cr-Commit-Position: refs/heads/master@{#32367}
-
- 26 Nov, 2015 1 commit
-
-
machenbach authored
Port https://codereview.chromium.org/1474923002 BUG=chromium:538614,chromium:559530,chromium:560589 LOG=n TBR=jochen@chromium.org, thakis@chromium.org, hans@chromium.org, Review URL: https://codereview.chromium.org/1478863005 Cr-Commit-Position: refs/heads/master@{#32326}
-
- 24 Nov, 2015 1 commit
-
-
machenbach authored
BUG=chromium:534332 LOG=n Review URL: https://codereview.chromium.org/1468093004 Cr-Commit-Position: refs/heads/master@{#32214}
-
- 20 Nov, 2015 1 commit
-
-
machenbach authored
BUG=chromium:534332 LOG=n TBR=jochen@chromium.org NOTREECHECKS=true Review URL: https://codereview.chromium.org/1464583004 Cr-Commit-Position: refs/heads/master@{#32133}
-
- 04 Nov, 2015 1 commit
-
-
machenbach authored
BUG=chromium:535160 LOG=n Review URL: https://codereview.chromium.org/1413033014 Cr-Commit-Position: refs/heads/master@{#31777}
-
- 02 Nov, 2015 1 commit
-
-
machenbach authored
This ports some code from chromium for using the bundled toolchain. BUG=chromium:548586 LOG=n Review URL: https://codereview.chromium.org/1237803003 Cr-Commit-Position: refs/heads/master@{#31706}
-