Commits · 6c9bab5c7422cf257252f84746177504ecfea6e4 · Linshizhi / V8

22 Oct, 2014 18 commits

Array.prototype.{reduce, reduceRight}: Wrong order of operations when determining initial value. · 6c9bab5c

wingo@igalia.com authored Oct 22, 2014

BUG=v8:3534
LOG=
R=svenpanne@chromium.org, wingo@igalia.com

Review URL: https://codereview.chromium.org/614733002

Patch from Diego Pino <dpino@igalia.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24807 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6c9bab5c

Move js perf tests to a common root on the perf dashboard. · 5680786c

machenbach@chromium.org authored Oct 22, 2014

BUG=
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/667373004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24806 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5680786c

Add an --msan flag to run-tests.py. · e48e3e53

machenbach@chromium.org authored Oct 22, 2014

Currently a no-op and added only for consistency with ASan/TSan.

BUG=chromium:425187
R=machenbach@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/667903004

Patch from Sergey Matveev <earthdok@chromium.org>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24805 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e48e3e53

Whitespace change to test new git workflow. · 846dfa1a

machenbach@chromium.org authored Oct 22, 2014

TBR=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/638883006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24804 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

846dfa1a

Switch ScheduleLateNodeVisitor to use explicit queue. · e4fe4e2c

mstarzinger@chromium.org authored Oct 22, 2014

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/672583002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24803 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e4fe4e2c

[turbofan] Add support for deferred code. · 6619a797

bmeurer@chromium.org authored Oct 22, 2014

Branch can now have an optional hint, when the condition is
likely true or false, and if such a hint is present the other
basic block will be marked as deferred and placed at the end
of the function.

We currently use this feature for tagging int32/uint32 in
change lowering, and for load/store bounds checks in simplified
lowering.

TEST=cctest,unittests
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/642883003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24802 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6619a797

Perf tests for fromCodePoint and codePointAt. · 1efcf093

dslomov@chromium.org authored Oct 22, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/670463005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24801 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1efcf093

Add FRINTP (round towards positive infinity) instruction. · 81420f00

sigurds@chromium.org authored Oct 22, 2014

Macro Assember, assembler and simulator for ARM64 were missing FRINTP.

R=rodolph.perfetta@arm.com, ulan@chromium.org

Review URL: https://codereview.chromium.org/669923002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24800 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

81420f00

MIPS64: Spread the knowledge! · 1479cb96

balazs.kilvady@imgtec.com authored Oct 22, 2014

Port r24793 (c0c2b0d)

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24799 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1479cb96

Disable libstdc++ debug mode on x64 for now. · 08e20d12

bmeurer@chromium.org authored Oct 22, 2014

TBR=mstarzinger@chromium.org

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24798 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

08e20d12

Remove testing artifacts from Schedule::AddFoo. · cb4f2520

mstarzinger@chromium.org authored Oct 22, 2014

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/641553003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24797 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb4f2520

Flatten the string in StringToDouble function. · b664c122

dslomov@chromium.org authored Oct 22, 2014

R=yangguo@chromium.org
BUG=chromium:425551
LOG=N

Review URL: https://codereview.chromium.org/654763003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24796 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b664c122

Really disable test when running with optimize for size · 4669a5cf

jochen@chromium.org authored Oct 22, 2014

R=bmeurer@chromium.org
TBR=bmeurer@chromium.org
LOG=n
BUG=none

Review URL: https://codereview.chromium.org/652903008

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24795 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4669a5cf

Enable libstdc++ debug mode in debug builds. · ded822a5

bmeurer@chromium.org authored Oct 22, 2014

For now it's only enabled on Linux/Intel.

R=mstarzinger@chromium.org
BUG=v8:3638
LOG=y

Review URL: https://codereview.chromium.org/650013006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24794 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ded822a5

Spread the knowledge! · af97f09b

dslomov@chromium.org authored Oct 22, 2014

R=arv@chromium.org, mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/670623005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24793 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

af97f09b

Fix newly added test to not run with optimize-for-size · b5797605

jochen@chromium.org authored Oct 22, 2014

TBR=ulan@chromium.org
BUG=none
LOG=n

Review URL: https://codereview.chromium.org/673593002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24792 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b5797605

Add support for a target new space size · 8f7a455f

jochen@chromium.org authored Oct 22, 2014

When this flag is set, we will commit additional pages up until the
target size before doing a scavenge.

I made sure that all tests pass when a target size of 16MB is set.

BUG=v8:3626
R=ulan@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/652543007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24790 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8f7a455f

Use getauxval() if available. · 8214cc0e

bmeurer@chromium.org authored Oct 22, 2014

This fixes the problem of not being able to detect ARM features on
ChromeOS because sandbox cannot access /proc/self/auxv and
/proc/cpuinfo there.

Drive-by-cleanup to libc detection in two other places.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/672543002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8214cc0e

21 Oct, 2014 22 commits

Whitespace change to trigger revert of new test262-es6 tests. · f0881c61

machenbach@chromium.org authored Oct 21, 2014

TBR=rossberg@chromium.org

Review URL: https://codereview.chromium.org/665373003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24788 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f0881c61

Whitespace change to trigger new test262-es6 tests. · 681c1b92

machenbach@chromium.org authored Oct 21, 2014

TBR=rossberg@chromium.org

Review URL: https://codereview.chromium.org/672483002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24787 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

681c1b92

Whitespace change to trigger new test262-es6 tests. · bdba5b4e

machenbach@chromium.org authored Oct 21, 2014

TBR=rossberg@chromium.org

Review URL: https://codereview.chromium.org/646873005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24786 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bdba5b4e

Replace single quotes with double quotes to fix BUILD.gn · ed23b4de

adamk@chromium.org authored Oct 21, 2014

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/665313003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24785 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ed23b4de

Array.prototype.{slice,splice} should use [[DefineOwnProperty]] to generate return value · b6d0113a

adamk@chromium.org authored Oct 21, 2014

BUG=chromium:423633
LOG=N
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/649063003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24784 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b6d0113a

Update ObjectToString to Harmony-draft algorithm · 37bd1149

dslomov@chromium.org authored Oct 21, 2014

Updates Object.prototype.toString() to use algorithm described in harmony drafts.

Currently, the behaviour is essentially the same as ES262's version, however this changes when internal structures
such as Promise make use of symbolToStringTag (as they are supposed to, see v8:3241), and changes further once
Symbol.toStringTag is exposed publicly.

BUG=v8:3241, v8:3502
LOG=N
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/546803003

Patch from Caitlin Potter <caitpotter88@gmail.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24783 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

37bd1149

Revert "Make sure floating phi nodes are coupled to their control." · 5df6dc39

mstarzinger@chromium.org authored Oct 21, 2014

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/654583004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24782 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5df6dc39

Make sure floating phi nodes are coupled to their control. · bf958b0f

mstarzinger@chromium.org authored Oct 21, 2014

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/669683002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24781 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bf958b0f

Fix scheduler not to connect final merge block in the graph to its inputs. · 0c4f8bc6

titzer@chromium.org authored Oct 21, 2014

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/667953002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24780 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0c4f8bc6

[turbofan] use ZonePool in most places in the compiler pipeline a temp zone is used. · 1c5fafe8

dcarney@chromium.org authored Oct 21, 2014

R=jarin@chromium.org, bmeurer@chromium.org

BUG=

Review URL: https://codereview.chromium.org/663333003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24779 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1c5fafe8

Fix off-by-one bug in TurboFan register allocator. · 26420587

titzer@chromium.org authored Oct 21, 2014

R=jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/671703003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24778 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

26420587

Fix AstGraphBuilder for loops like for(;;). · 12a82ef3

titzer@chromium.org authored Oct 21, 2014

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/640203004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24777 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

12a82ef3

Fix incorrect private access · 077809fc

rossberg@chromium.org authored Oct 21, 2014

(I'm puzzled why GCC did not report this error.)

TBR=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/669733007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24776 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

077809fc

The issue is that by handling strings with map/handler pairs instead of a special · 8330178b

mvstanton@chromium.org authored Oct 21, 2014

version of the keyed load stub (https://code.google.com/p/v8/source/detail?r=24661),
I allowed polymorphism between string and non-string types in the IC. Before, the
IC would go generic.

Then, at crankshaft time, we special case when we only saw strings. The error
here is that crankshaft can't emit code that handles polymorphism between string
and non-string types. The choice is either to get that to happen (I don't deem
this necessary from a performance point of view, an IC with such type feedback
before would have gone generic), or simply check for the case of "polymorphic
with some string maps" and require crankshaft to go generic. I'll do the latter.

BUG=425519
LOG=N
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/667923004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24775 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8330178b

Fix data race with interface caching · 5e1cd18d

rossberg@chromium.org authored Oct 21, 2014

R=bmeurer@chromium.org
BUG=421634
LOG=N

Review URL: https://codereview.chromium.org/667703002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24774 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5e1cd18d

Use an idle notification of 0ms as hint that a GC after context disposal is triggerd · 2147d5a1

jochen@chromium.org authored Oct 21, 2014

BUG=none
R=ulan@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/671513006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24773 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2147d5a1

[turbofan] add ZonePool to correctly track compiler phase memory usage · 54fef44d

dcarney@chromium.org authored Oct 21, 2014

R=bmeurer@chromium.org

BUG=

Review URL: https://codereview.chromium.org/665893006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24771 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

54fef44d

[turbofan] Reduce ~~x to x. · 1efc572f

bmeurer@chromium.org authored Oct 21, 2014

TEST=unittests
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/666723005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24770 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1efc572f

Assign bailout and type feedback IDs in a post-pass · 4eddbaca

wingo@igalia.com authored Oct 21, 2014

This will allow us to move expressions from one function to another, for
example when the parser determines that a given cover grammar instance
is actually the default value initializer for an arrow function.

This is a re-land of https://codereview.chromium.org/636403003/ with a
fix for the arm64 code generator.

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/663373003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24769 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4eddbaca

Handle property name "-0" correctly for typed arrays. · b830c274

dslomov@chromium.org authored Oct 21, 2014

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/670623003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24768 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b830c274

Remove unused IsDirty · 37b7dde5

verwaest@chromium.org authored Oct 21, 2014

BUG=
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/670703002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24767 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

37b7dde5

Handle NaN value storing in Uint8Clamped typed arrays. · 0ffa82c3

dusan.milosavljevic@imgtec.com authored Oct 21, 2014

TEST=mjsunit/external-array
BUG=
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/667113002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24766 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0ffa82c3