Skip to content

V
V8
Switch branch/tag
  1. 07 Aug, 2013 1 commit
  3. 30 Jul, 2013 3 commits
  5. 29 Jul, 2013 1 commit
  7. 25 Jul, 2013 1 commit
  9. 24 Jul, 2013 1 commit
  11. 23 Jul, 2013 1 commit
  13. 11 Jul, 2013 1 commit
  15. 05 Jul, 2013 1 commit
  17. 26 Jun, 2013 2 commits
  19. 04 Jun, 2013 1 commit
  21. 03 Jun, 2013 1 commit
  23. 16 Apr, 2013 1 commit
  25. 05 Apr, 2013 1 commit
    • mstarzinger@chromium.org's avatar
      Refactor parser mode configuration for correctness · d7167867
      mstarzinger@chromium.org authored 
      This patch refactors the parser and preparser interface to be more
readable and type-safe.  It has no behavior changes.

Previously, parsers and preparsers were configured via bitfield called
parser_flags in the Parser constructor, and flags in
PreParser::PreParseProgram, ParserApi::Parse, and ParserApi::PreParse.
This was error-prone in practice: six call sites passed incorrectly
typed values to this interface (a boolean FLAG value, a boolean false
and a boolean true value).  None of these errors were caught by the
compiler because it's just an "int".

The parser flags interface was also awkward because it encoded a
language mode, but the language mode was only used to turn on harmony
scoping or not -- it wasn't used to actually set the parser's language
mode.

Fundamentally these errors came in because of the desire for a
procedural parser interface, in ParserApi.  Because we need to be able
to configure the parser in various ways, the flags argument got added;
but no one understood how to use the flags properly.  Also they were
only used by constructors: callers packed bits, and the constructors
unpacked them into booleans on the parser or preparser.

The solution is to allow parser construction, configuration, and
invocation to be separated.  This patch does that.

It passes the existing tests.

BUG=

Review URL: https://codereview.chromium.org/13450007
Patch from Andy Wingo <wingo@igalia.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14151 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      d7167867
  27. 18 Mar, 2013 1 commit
  29. 28 Feb, 2013 1 commit
  31. 25 Feb, 2013 1 commit
  33. 15 Feb, 2013 1 commit
  35. 11 Feb, 2013 1 commit
  37. 10 Jan, 2013 1 commit
  39. 17 Dec, 2012 2 commits
  41. 04 Dec, 2012 1 commit
  43. 03 Dec, 2012 1 commit
  45. 13 Nov, 2012 1 commit
  47. 08 Nov, 2012 1 commit
  49. 14 Sep, 2012 1 commit
  51. 10 Sep, 2012 1 commit
  53. 13 Jul, 2012 2 commits
  55. 05 Jul, 2012 1 commit
  57. 01 Jul, 2012 1 commit
  59. 25 Jun, 2012 2 commits
  61. 22 Jun, 2012 1 commit
  63. 20 Jun, 2012 1 commit
  65. 16 Jun, 2012 1 commit
  67. 15 Jun, 2012 1 commit