- 12 Jul, 2018 38 commits
-
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: Ic9b1fa0f669c8b9a82ed91d3f348dd070fc9267f Reviewed-on: https://chromium-review.googlesource.com/1135247 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54419}
-
Michael Lippautz authored
The manual scope is usually used to test corner cases of GC behavior so disable the ineffective GC detecton there. Bug: v8:7859 Change-Id: I92a1e43db739846ff0db20a60cc2ace79496e5fe Reviewed-on: https://chromium-review.googlesource.com/1135140Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54418}
-
Clemens Hammacher authored
Since Liftoff is fully implemented on arm64, we can enable the wasm/liftoff test. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I901480a417a7cc438357a67b819f226e4d3b1df4 Reviewed-on: https://chromium-review.googlesource.com/1134776 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54417}
-
Maya Lekova authored
Bug: v8:7790 Change-Id: I16a2fa9c37a8b00a067f8f7fd3a87cb747233132 Reviewed-on: https://chromium-review.googlesource.com/1128968 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54416}
-
Anna Henningsen authored
Some Linux kernels are built without `madvise()`. In that case, do not crash but rather ignore the return value instead. Refs: https://github.com/nodejs/node/issues/21562 Change-Id: Iff8d0d0e9e7935804e2fc994be7f8bd21c553846 Reviewed-on: https://chromium-review.googlesource.com/1131943Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54415}
-
Marja Hölttä authored
api.h: MAKE_TO_LOCAL funcs need the types to be available. scope.h, func-name-inferrer.h, bigint.h, module.h: These were using inline headers -> de-inlined. BUG=v8:7754,v8:7490 Change-Id: Id072f537682fb867cd68d79ca95b06628780d01f Reviewed-on: https://chromium-review.googlesource.com/1131175 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54414}
-
Dominik Inführ authored
Set number of fixpoint iterations to 10 before switching to the linear algorithm. The flag's initial default value was set to 0 to use the linear algorithm all the time for testing purposes. Bug: chromium:844008 Change-Id: Ib0fd6241b55468ef5be2c4cc3cc147db2d432c83 Reviewed-on: https://chromium-review.googlesource.com/1134769Reviewed-by:
-
Joyee Cheung authored
This patch adds a variant of EmbedderGraph::AddEdge() which allows the embedder to specify the name of an edge. The edges added without name are element edges with auto-incremented indexes while the edges added with names will be internal edges with the specified names for more meaningful output in the heap snapshot. Refs: https://github.com/nodejs/node/pull/21741 Bug: v8:7938 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I8feefa2cf6911743e24b3b2024e0e849b0c65cd3 Reviewed-on: https://chromium-review.googlesource.com/1133299 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The WasmGrowMemory builtin (defined in builtins-wasm-gen.cc) expects the runtime function to return a Smi. Thus ensure that we are really always returning a Smi. R=mstarzinger@chromium.org Change-Id: I153d75a2ab8773adbcce01e9aa125a234c93d077 Reviewed-on: https://chromium-review.googlesource.com/1131737Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54411}
-
Rodrigo Bruno authored
This is a reland of 5863c0b6 Original change's description: > [heap] Added External Strings to external memory accounting. > > Bug: chromium:845409 > Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550 > Reviewed-on: https://chromium-review.googlesource.com/1118164 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54110} Bug: chromium:845409 Change-Id: Ied341ec6268000343d2a577b22f2a483460b01f5 Reviewed-on: https://chromium-review.googlesource.com/1121736 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Currently the fuzzer only tests Turbofan and Liftoff in isolation. In order to test that both tiers use the same ABI, it should also test calls from one tier to the other. This CL introduces a new flag which controls which function will be compiled by which tier, and uses that in the fuzzer. R=ahaas@chromium.org Bug: chromium:862931, v8:6600 Change-Id: I450b906700972cfdb496b1734faed9f8208d652f Reviewed-on: https://chromium-review.googlesource.com/1134775 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Peter Marshall authored
When we changed FeedbackMetadata to be it's own type instead of a subtype of FixedArray, we missed this check for valid objects in old space. This restores the old behavior during verification. Bug: chromium:862433 Change-Id: Icdb144df4aebc0c6d78a28405c7f53e40b2e1376 Reviewed-on: https://chromium-review.googlesource.com/1134995Reviewed-by:
-
Dan Elphick authored
Bug: v8:7786 Change-Id: If9615f5dffc40937f9f35a209730d530be6b424b Reviewed-on: https://chromium-review.googlesource.com/1134986Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Instead of passing {uint8_t*, size_t} pairs as arguments, pass {Vector<uint8_t>}. This is less error prone and {Vector} provides some helpful methods. R=ahaas@chromium.org Bug: v8:7754 Change-Id: I7469054774618e0bd5c9d38501759b1b2c51d104 Reviewed-on: https://chromium-review.googlesource.com/1134773Reviewed-by: -
Jungshik Shin authored
getGetoption() in intl.js misimplemented Ecma 402 #sec-getoption by calling options[property] twice, once to check if it's defined and the second time to retrieve the value when it's defined. Bug: v8:7869 Test: test262/intl402/RelativeTimeFormat/con*/cons*/option*order Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I6d585767232c9f4c0252e65e2891c813db3da641 Reviewed-on: https://chromium-review.googlesource.com/1128444 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54405}
-
Clemens Hammacher authored
An unordered_map typically provides better performance. Instead of a compare function, we now need a hash function and equality defined on {Signature<T>}. R=mstarzinger@chromium.org Bug: chromium:862123 Change-Id: Iba71030f91949d7453740c884de1d8a4f921c618 Reviewed-on: https://chromium-review.googlesource.com/1131182 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I1045885ad1efe2b1dd7a9e2b83d1f5323e77dcbb Reviewed-on: https://chromium-review.googlesource.com/1134988Reviewed-by:
-
Andreas Haas authored
The instruction got removed from the proposal. R=titzer@chromium.org Bug: v8:7581 Change-Id: I3e27bad923544896ebf6ab8969e5c365a397f6c9 Reviewed-on: https://chromium-review.googlesource.com/1128754Reviewed-by:
-
Leszek Swirski authored
With ReadOnlyRoots and GetIsolate on JSReceiver, we can remove almost every isolate parameter from <Object>::Print. The remaining ones, like Map, are special-caseable for read-only maps, and as a result we can remove isolate parameters from <Object>::Print entirely. This patch also opportunistically cleans up a few places where isolates were only needed for Object::Print, such as TransitionAccessors and DescriptorArrays. TBR=yangguo@chromium.org,mstarzinger@chromium.org Bug: v8:7786 Change-Id: Id44bd53b9893e679eea5f37b9548257595a1bfd9 Reviewed-on: https://chromium-review.googlesource.com/1133385Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54401}
-
Andreas Haas authored
With the introduction of multiple tables the element section is able to initialize any of the defined tables. However, the spec says that only tables of type AnyFunc can be initialized. With this CL we validate that entries in the element section only target AnyFunc tables. R=titzer@chromium.org Bug: v8:7581 Change-Id: Ifea383b13c91f582813b2aa4f01a5f724575cfa0 Reviewed-on: https://chromium-review.googlesource.com/1130519 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7754,v8:5402 Change-Id: Iccbf453e6b27e4e2604bd3f074882bf864e01070 Reviewed-on: https://chromium-review.googlesource.com/1131129Reviewed-by:
-
Maya Lekova authored
This reverts commit 770ace07. Reason for revert: Breaking the V8 Arm and V8 Arm - debug builds https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm%20-%20debug/7260 Original change's description: > [heap] Cleanup: Use std::atomic<T> instead of base::AtomicValue<T> in heap/*. > > Bug: chromium:842083 > Change-Id: Idc04f9ddea326df4ac48a8c58321620660b21549 > Reviewed-on: https://chromium-review.googlesource.com/1129520 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54389} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: I108bc5386ea825c2700f9b830b85a1ca8c10bf4b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:842083 Reviewed-on: https://chromium-review.googlesource.com/1134966Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#54398}
-
Toon Verwaest authored
Bug: chromium:862538 Change-Id: I13a6886f78ee88ca7c69feb0abda6b149a1e423e Reviewed-on: https://chromium-review.googlesource.com/1133980 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54397}
-
Marja Hölttä authored
Follow-up to r54219 ( https://chromium-review.googlesource.com/1124450 ) They're relevant if we also iterate the heap and check there are no pointers to the original FixedArrayBase, but in the landed version of that CL we don't do that. BUG=chromium:859809 Change-Id: Iffd8b76e74b6690cde961d4c542cb16ddd934f33 Reviewed-on: https://chromium-review.googlesource.com/1131123Reviewed-by:
-
Dan Elphick authored
Uses Heap::FromWritableHeapObject where the object must be mutable and otherwise pass Isolate in. String and subclasses should now be free of GetIsolate/GetHeap. Bug: v8:7786 Change-Id: Ic9d55250ea4afebbebda87be9415ccdaa4fc8779 Reviewed-on: https://chromium-review.googlesource.com/1131736Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54395}
-
Dan Elphick authored
Happily this also removes a use of GetIsolate(). Also delete Descriptor::Init which is no longer needed and some friend declarations. Bug: v8:7786 Change-Id: Ica803ef6c8963b38aef72121ff4fb737c9780920 Reviewed-on: https://chromium-review.googlesource.com/1133982Reviewed-by:
-
Andreas Haas authored
This is the first CL to refactor WebAssembly.instantiateStreaming to make it spec compliant again. The design doc where the whole change is discussed is available in the tracking bug. The tracking bug also references prototype implementations of the whole change, which includes the changes in this CL. Tests for the new API functions will be added with the second V8 CL which adds the implementation of the API functions. R=ulan@chromium.org Bug: chromium:860637 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ia1048b7ca0291c824ef4212ebde2c6054e102069 Reviewed-on: https://chromium-review.googlesource.com/1127667Reviewed-by:
-
Clemens Hammacher authored
On {Isolate::PrintStack}, we currently only print the pc offset for wasm compiled frame. This CL changes this to also print the absolute PC. R=ahaas@chromium.org Change-Id: Ic72b7ad140ef74d2f284fdd8827b858cc78cf1c0 Reviewed-on: https://chromium-review.googlesource.com/1133985 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Michael Lippautz authored
Preserve flags for GC finalization triggered by EmbedderHeapTracer. Bug: chromium:843903 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ie3d039bc1b69771ce9830dddb5e4d4375581981f Reviewed-on: https://chromium-review.googlesource.com/1134766Reviewed-by:
-
Dan Elphick authored
Converts the Shape functions IsKey and IsLive to take ReadOnlyRoots rather Isolate. This allows HashTableBase::FindEntry and ObjectHashTableBase::Lookup to also take ReadOnlyRoots rather than Isolate. Bug: v8:7786 Change-Id: I37efea1d20139f394d6365569438755cb8fc44c4 Reviewed-on: https://chromium-review.googlesource.com/1133391Reviewed-by:
-
Hannes Payer authored
Bug: chromium:842083 Change-Id: Idc04f9ddea326df4ac48a8c58321620660b21549 Reviewed-on: https://chromium-review.googlesource.com/1129520Reviewed-by:
-
Hannes Payer authored
Bug: chromium:842083 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9a8d8327bfbab95cf9bdddb096804b65270cdfed Reviewed-on: https://chromium-review.googlesource.com/1127944 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Dan Elphick authored
Bug: v8:7786 Change-Id: Ifb866cbb2d02f1231b3706358930e0ace54b0db0 Reviewed-on: https://chromium-review.googlesource.com/1133158Reviewed-by:
-
John Barboza authored
Change-Id: I60aed7bf8207703fa6ceddb6165e173e68b5ff5f Reviewed-on: https://chromium-review.googlesource.com/1103533 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54386}
-
Hannes Payer authored
Bug: chromium:842083 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6b3f60526718f782b075bd450282646d97f6f9b5 Reviewed-on: https://chromium-review.googlesource.com/1131124Reviewed-by:
-
Dominik Inführ authored
Was only used when concurrent marking was disabled at compile-time. Change-Id: I3977a2cbcfb27e527b2bca4b49887558595c4215 Reviewed-on: https://chromium-review.googlesource.com/1128959Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/11ac8d7..6ff84ae Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/345d332..39de3d2 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c3975e5..32e3d1e TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I4a57a4ebfa818a19e9057d4c3746087acaf89645 Reviewed-on: https://chromium-review.googlesource.com/1134593 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54383}
-
Frank Tang authored
R=bstell@chromium.org, cira@chromium.org, yangguo@chromium.org Bug: v8:7869 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ia7176016ecd6da317b3b0eb7af7bf482f99c8129 Reviewed-on: https://chromium-review.googlesource.com/1121657Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#54382}
-
- 11 Jul, 2018 2 commits
-
-
Brian Stell authored
No change in functionality, this only changes spelling. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I8dad2315288e82b23782545b050e9502d0320de5 Reviewed-on: https://chromium-review.googlesource.com/1133679Reviewed-by:
-
Leszek Swirski authored
Move some of PreParsedScopeData's santity checks, such as the magic value separating skippable function data from scope data, to be debug only, to save memory. Start position of inner skippable functions is still kept, because it's too good at catching bugs, but we may want to remove it in the future as well. Relanding unchanged after the (unrelated) flake it exposed is fixed in: https://chromium-review.googlesource.com/1131503 Bug: chromium:818642 Change-Id: Id1d9fe757875cd05ea9a92b41e7256c3ee86fc8e Reviewed-on: https://chromium-review.googlesource.com/1131505 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
