- 27 Jul, 2021 1 commit
-
-
Michael Achenbach authored
This reverts commit 67960ba1. Reason for revert: This has been properly fixed by https://crrev.com/c/3053740. Now dcheck_always_on already defaults to false for subprojects like V8 and no other switch is required. The switch didn't fully work anyways due to https://crbug.com/1231890. Original change's description: > Reland "[build] Add V8-specific dcheck_always_on" > > This is a reland of cecc666f > > Depends on: > https://crrev.com/c/3043611 > > Original change's description: > > [build] Add V8-specific dcheck_always_on > > > > This makes the V8 dcheck control independent of Chromium's and > > prepares switching Chromium's default behavior without affecting V8 > > developers or builders. > > > > Preparation for: https://crrev.com/c/2893204 > > > > Bug: chromium:1225701 > > Change-Id: I520b96019b04196f4420716ff3500ebd6c21666f > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038528 > > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#75827} > > Bug: chromium:1225701 > Change-Id: I56568b78592addba01793d2d14f768c9ee10103d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041670 > Reviewed-by: Liviu Rau <liviurau@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75839} Bug: chromium:1225701, chromium:1231890 Change-Id: I7e27f5774d8e162977f30f685da4b15dadcc1084 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3055294Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75935}
-
- 21 Jul, 2021 1 commit
-
-
Michael Achenbach authored
This is a reland of cecc666f Depends on: https://crrev.com/c/3043611 Original change's description: > [build] Add V8-specific dcheck_always_on > > This makes the V8 dcheck control independent of Chromium's and > prepares switching Chromium's default behavior without affecting V8 > developers or builders. > > Preparation for: https://crrev.com/c/2893204 > > Bug: chromium:1225701 > Change-Id: I520b96019b04196f4420716ff3500ebd6c21666f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038528 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75827} Bug: chromium:1225701 Change-Id: I56568b78592addba01793d2d14f768c9ee10103d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041670Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75839}
-
- 20 Jul, 2021 2 commits
-
-
Zhi An Ng authored
This reverts commit cecc666f. Reason for revert: Many crashes on clusterfuzz bots https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Clusterfuzz%20Win64%20ASAN%20-%20release%20builder/23404/overview Original change's description: > [build] Add V8-specific dcheck_always_on > > This makes the V8 dcheck control independent of Chromium's and > prepares switching Chromium's default behavior without affecting V8 > developers or builders. > > Preparation for: https://crrev.com/c/2893204 > > Bug: chromium:1225701 > Change-Id: I520b96019b04196f4420716ff3500ebd6c21666f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038528 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75827} Bug: chromium:1225701 Change-Id: I20329f77707caf8fba2405919aa13c67811a1469 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3042841 Auto-Submit: Zhi An Ng <zhin@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75830}
-
Michael Achenbach authored
This makes the V8 dcheck control independent of Chromium's and prepares switching Chromium's default behavior without affecting V8 developers or builders. Preparation for: https://crrev.com/c/2893204 Bug: chromium:1225701 Change-Id: I520b96019b04196f4420716ff3500ebd6c21666f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038528Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#75827}
-
- 21 Apr, 2021 1 commit
-
-
Wenyu Zhao authored
* Filtered some tests that rely on incremental_marking and shape tracking Bug: v8:11644 Change-Id: Ic9833bf1e49e6413422484858cd1054dd2500092 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2822284 Commit-Queue: Wenyu Zhao <wenyu.zhao@anu.edu.au> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#74078}
-
- 14 Apr, 2021 1 commit
-
-
Ulan Degenbaev authored
The flag is useful for disabling tests that are not supported in the third_party_heap build configuration. Example usage in the status files: ['third_party_heap', { 'testname': [SKIP], }], # third_party_heap Bug: v8:11155 Change-Id: I991532bf7cdf89d8c505e4d6cbd7cf9e4d70dd63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2821960 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#73957}
-
- 12 Apr, 2021 1 commit
-
-
Shu-yu Guo authored
The pointer compression cage is the virtual memory reservation that all compressed pointers fall within. This CL splits pointer compression into two modes: a per-Isolate cage and a shared cage among multiple Isolates. When multiple Isolates are sharing a cage, they can decompress each others' pointers and share the same virtual memory range. Bug: v8:11460 Change-Id: I7b89b7413b8e7ca6b8b6faafd083dc387542a8b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2783674Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#73916}
-
- 22 Feb, 2021 1 commit
-
-
Clemens Backes authored
This CL introduces a test runner flag to detect if webassembly has been disabled. Since all tests that require wasm are alrady skipped in lite mode, we introduce a has_webassembly flag for the test runner which checks for v8_enable_webassembly=true and v8_enable_lite_mode=false. As a drive-by, we also do not set the V8_ENABLE_WEBASSEMBLY preprocessor flag if lite mode is enabled. The status files are updated by splitting wasm tests from the "lite_mode" section and checking for "not has_webassembly" instead. Note that the v8_enable_webassembly=false configuration is not tested on any bot currently, but I will make sure that all tests keep passing on further changes in this configuration. R=machenbach@chromium.org Bug: v8:11238 Cq-Include-Trybots: luci.v8.try:v8_linux64_no_wasm_compile_rel Change-Id: I1841eb1f1633cb47e0c079f4a4a4d769ca3a9cbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2710425Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#72898}
-
- 12 Feb, 2021 1 commit
-
-
Leszek Swirski authored
Add a .status file variable for the "v8_control_flow_integrity" gn arg, and disable baseline tests for now in that configuration. No-Tree-Checks: true No-Try: true Bug: v8:11439 Change-Id: I7274a168893cfd6619ce98fdd14a692217fd56c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692206 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#72698}
-
- 28 Sep, 2020 1 commit
-
-
Michael Achenbach authored
This additionally combines --future with all other standard testing variants. This also enables using concurrent_marking in status files to skip tests in this variant. This also marks a slow test that times out in the new config. Bug: v8:10875 Change-Id: Id904f6a2c51b814eecfccb523a897de2f5d96f56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2423719 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#70180}
-
- 22 Oct, 2019 1 commit
-
-
Simon Zünd authored
This CL removes the 'v8_enable_embedded_builtins' GN argument and sets the 'V8_EMBEDDED_BUILTIN' define unconditionally. Removing the now obsolete 'define' and corresponding C++ code will be done in a separate CL. R=machenbach@chromium.org Bug: v8:8519 Change-Id: Ibaa3e958121931c0ce14baf48ad401fab87c5337 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864929 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64456}
-
- 16 Oct, 2019 1 commit
-
-
Simon Zünd authored
This is a reland of 1c56974f This is a plain reland of the original CL. The original CL was speculatively reverted, but ended up not being the cause for bot failures. Original change's description: > Unconditionally enable snapshot builds and remove 'v8_use_snapshot' > > This CL removes 'v8_use_snapshot' and the usages of the implied > V8_USE_SNAPSHOT define. One test runner unittest was updated to use the > "asan" variant instead of the now obsolete "no_snap" variant. > > Related chromium CL: https://crrev.com/c/1796325. > > Bug: v8:8531 > Change-Id: I5da7c9f8e9110fe7bc0f4e4f821bcb7f7d98f927 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784282 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64290} TBR=thakis@chromium.org,machenbach@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tmrts@chromium.org,szuend@chromium.org Bug: v8:8531 Change-Id: Id75a802279238138f7aefec62e0b6425a5acc08d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864649Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#64305}
-
- 15 Oct, 2019 2 commits
-
-
Clemens Backes authored
This reverts commit 1c56974f. Reason for revert: Causes several bots to timeout, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/27945 Original change's description: > Unconditionally enable snapshot builds and remove 'v8_use_snapshot' > > This CL removes 'v8_use_snapshot' and the usages of the implied > V8_USE_SNAPSHOT define. One test runner unittest was updated to use the > "asan" variant instead of the now obsolete "no_snap" variant. > > Related chromium CL: https://crrev.com/c/1796325. > > Bug: v8:8531 > Change-Id: I5da7c9f8e9110fe7bc0f4e4f821bcb7f7d98f927 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784282 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64290} TBR=thakis@chromium.org,machenbach@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tmrts@chromium.org,szuend@chromium.org Change-Id: I4024d818877e534b9f7908a2d14f33dca35b5924 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8531 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1862572Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64293}
-
Simon Zünd authored
This CL removes 'v8_use_snapshot' and the usages of the implied V8_USE_SNAPSHOT define. One test runner unittest was updated to use the "asan" variant instead of the now obsolete "no_snap" variant. Related chromium CL: https://crrev.com/c/1796325. Bug: v8:8531 Change-Id: I5da7c9f8e9110fe7bc0f4e4f821bcb7f7d98f927 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784282 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#64290}
-
- 07 May, 2019 1 commit
-
-
Michael Achenbach authored
Bug: v8:9145 Change-Id: Idb1a838666ea21cb260a141929fd80b400913836 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596731Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61262}
-
- 27 Feb, 2019 1 commit
-
-
Michael Achenbach authored
Also enable test runner to differentiate between clang and gcc. Bug: v8:8919 Change-Id: Icdcae0aba3644a1b1b9ddc6c037eabde27d717f7 Reviewed-on: https://chromium-review.googlesource.com/c/1491634Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59906}
-
- 19 Dec, 2018 1 commit
-
-
Igor Sheludko authored
Tbr: machenbach@chromium.org Bug: v8:8562 Change-Id: If2242c6271d400e7c4c031e10871b06438c2636d Reviewed-on: https://chromium-review.googlesource.com/c/1384088 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58373}
-
- 22 Oct, 2018 1 commit
-
-
Ross McIlroy authored
BUG=v8:8293 Change-Id: Ic58ac512d5f32d26756e21ca929dda79f133a40e Reviewed-on: https://chromium-review.googlesource.com/c/1290982Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#56844}
-
- 16 Oct, 2018 1 commit
-
-
Sigurd Schneider authored
Change-Id: Ibacdc7b41a96fc7c7d4ff44552fe6d86ec2ef1aa Bug: v8:8312 Reviewed-on: https://chromium-review.googlesource.com/c/1282605 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56679}
-
- 10 Oct, 2018 1 commit
-
-
Sigurd Schneider authored
R=machenbach@chromium.org, sigurds@chromium.org Bug: v8:6666 Change-Id: I9ac0fc393a9f9a66bebb72abd54a429e95aa078a Reviewed-on: https://chromium-review.googlesource.com/c/1270840 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#56510}
-
- 10 Aug, 2018 3 commits
-
-
Michael Achenbach authored
This is a reland of 4c094342 Original change's description: > [test] Add logic to run tests on Android > > This adds a new command abstraction for running commands on Android > using dockered devices on swarming. > > The new abstraction handles pushing all required files to the device. > The logic used for pushing and running is reused from the perf runner. > > This adds only the mjsunit test suite. Others will be handled in > follow up CLs. The suite logic is enhanced with auto-detection of files > to be pushed to devices, for e.g. load or import statements. > > Some test cases need an extra resource section for specifying required > files. > > Remaining failing tests are marked in the status files for later > triage. > > Bug: chromium:866862 > Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7 > Reviewed-on: https://chromium-review.googlesource.com/1150153 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55041} Bug: chromium:866862 Change-Id: Icf7e04c75d4abeab7254d10ba21240e46b0022ae Reviewed-on: https://chromium-review.googlesource.com/1170643Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55059}
-
Sergiy Byelozyorov authored
This reverts commit 4c094342. Reason for revert: Unfortunately this broke all perf builders. Original change's description: > [test] Add logic to run tests on Android > > This adds a new command abstraction for running commands on Android > using dockered devices on swarming. > > The new abstraction handles pushing all required files to the device. > The logic used for pushing and running is reused from the perf runner. > > This adds only the mjsunit test suite. Others will be handled in > follow up CLs. The suite logic is enhanced with auto-detection of files > to be pushed to devices, for e.g. load or import statements. > > Some test cases need an extra resource section for specifying required > files. > > Remaining failing tests are marked in the status files for later > triage. > > Bug: chromium:866862 > Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7 > Reviewed-on: https://chromium-review.googlesource.com/1150153 > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55041} TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org Change-Id: If80129810586b709dab762c9b5724888e15daec2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:866862 Reviewed-on: https://chromium-review.googlesource.com/1170962Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55058}
-
Michael Achenbach authored
This adds a new command abstraction for running commands on Android using dockered devices on swarming. The new abstraction handles pushing all required files to the device. The logic used for pushing and running is reused from the perf runner. This adds only the mjsunit test suite. Others will be handled in follow up CLs. The suite logic is enhanced with auto-detection of files to be pushed to devices, for e.g. load or import statements. Some test cases need an extra resource section for specifying required files. Remaining failing tests are marked in the status files for later triage. Bug: chromium:866862 Change-Id: I2b957559f07fdcd8c1bd2f7034f5ba7754a31fb7 Reviewed-on: https://chromium-review.googlesource.com/1150153Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55041}
-
- 16 Jan, 2018 1 commit
-
-
Michael Achenbach authored
This is a reland of 96f55796 Original change's description: > [test] Add test runner system tests for flaky tests > > This uses a temporary file in the mocked d8 script to let d8 flip > between FAIL and PASS on rerun. > > This adds a separate test root with dedicated test suite for testing > flakes to no interfere with existing status file configs. > > NOTRY=true > > Bug: v8:6917 > Change-Id: Id43753650195fb74cceb2a3ee9014100cabad546 > Reviewed-on: https://chromium-review.googlesource.com/867917 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50621} TBR=sergiyb@chromium.org NOTRY=true Bug: v8:6917 Change-Id: I4e7bca272dfd8778fbb8d012fcd6fd8406158e43 Reviewed-on: https://chromium-review.googlesource.com/868433Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50625}
-
- 27 Dec, 2017 1 commit
-
-
Michael Achenbach authored
This tests some high-level scenarios of the V8 test runner, with fake executable, test-suite extension and build configs. The runners are slightly modified to be easier testable. Args are passed from the tests now and the V8 root folder can be faked by the tests. We support coverage if python coverage 4.0 is installed. Otherwise we run without it. Bug: v8:6917 Change-Id: Ib149fd88027cbdc3382bcaea2d82020582f79d2d Reviewed-on: https://chromium-review.googlesource.com/831506 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#50310}
-