Commits · 6a806b9917cf39c8ed24a2ec0287b9f929839a3f · Linshizhi / V8

23 May, 2013 13 commits

Add asserts to String::GetFlatContent. · 6a806b99

yangguo@chromium.org authored May 23, 2013

R=verwaest@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/13841012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14776 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6a806b99

Missing type cell on ia32 from bindings. · 1a4482ab

mvstanton@chromium.org authored May 23, 2013

Javascript constructors called from C++ code didn't have a type cell
properly filled in on ia32. This showed up as a bug in webkit bindings.
Re-enabled flag optimize-constructed-arrays.

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/15870002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14775 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1a4482ab

Don't use fast literal if the boilerplate map is still deprecated. · af451684

verwaest@chromium.org authored May 23, 2013

R=mvstanton@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15660005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14774 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

af451684

Fix Windows build after r14770 · 28729d24

dslomov@chromium.org authored May 23, 2013

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/15848003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14771 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

28729d24

Externalization API for ArrayBuffer · fc73052d

dslomov@chromium.org authored May 23, 2013

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/15001041

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14770 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fc73052d

Improve SeqStringSetChar implementation. · a1e18bdf

yangguo@chromium.org authored May 23, 2013

R=jkummerow@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/15743006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14769 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a1e18bdf

Always require exact maps. · 06b7bf60

verwaest@chromium.org authored May 23, 2013

R=danno@chromium.org

Review URL: https://chromiumcodereview.appspot.com/13923003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14768 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

06b7bf60

Omit smi-check for write-barrier unless tagged. · d41f9290

verwaest@chromium.org authored May 23, 2013

R=mvstanton@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15848002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14767 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d41f9290

Avoid creating duplicate entries for a value when merging HSimulates · f691f48c

jkummerow@chromium.org authored May 23, 2013

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/15660003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14766 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f691f48c

Implement HChange support for Smis and use it in Load/StoreNameField · 308e6975

verwaest@chromium.org authored May 23, 2013

BUG=
R=verwaest@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15303004

Patch from Daniel Clifford <danno@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14765 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

308e6975

de-isolate Persistent::Dispose · 36694884

dcarney@chromium.org authored May 23, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/15648008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14764 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

36694884

Move global pretenuring flag check to ShouldGloballyPretenure(). · 2cbc81a5

hpayer@chromium.org authored May 23, 2013

BUG=

Review URL: https://codereview.chromium.org/15734007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14763 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2cbc81a5

Make Object.freeze fast · 36e91242

verwaest@chromium.org authored May 23, 2013

This patch both speeds up the freeze operation itself, but also
allows properties to remain in fast mode. Objects with non-empty
elements backing stores still end up with slow elements.

Relanding r14758 and r14759 with fix for Test262: only mark properties
and elements READ_ONLY if they are not JS setter/getters. Tightened up
tests to assert frozen-ness, and added targeted tests for the new code
(covering accessors).

BUG=v8:1858, 115960
R=verwaest@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15691007

Patch from Adam Klein <adamk@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14762 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

36e91242

22 May, 2013 17 commits

MIPS: Handle holes in smi-untag from LoadKeyed requiring hole handling. · 71ab26d2

palfia@homejinni.com authored May 22, 2013

Port r14756 (fda1989f)

BUG=

Review URL: https://codereview.chromium.org/15690003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14761 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

71ab26d2

Revert "Make Object.freeze fast" · 4d48bb83

adamk@chromium.org authored May 22, 2013

and "Fix Object.freeze on dictionary-backed arrays to properly freeze elements"

This reverts r14758 and r14759 due to introducing failures in Test262

TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/15681004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4d48bb83

Fix Object.freeze on dictionary-backed arrays to properly freeze elements · 3ebccb7a

adamk@chromium.org authored May 22, 2013

Follow-up to r14758: slightly rearranges JSObject::Freeze() to avoid duplicating
code while still retaining proper dictionary elements storage behavior.

Also fix a lint error.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/15737018

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14759 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3ebccb7a

Make Object.freeze fast · 648e99e3

adamk@chromium.org authored May 22, 2013

This patch both speeds up the freeze operation itself, but also
allows properties to remain in fast mode. Objects with non-empty
elements backing stores still end up with slow elements.

BUG=v8:1858, 115960
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/14888005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14758 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

648e99e3

Fix bogus deopt in BuildEmitDeepCopy for holey arrays. · b704cb91

mstarzinger@chromium.org authored May 22, 2013

R=verwaest@chromium.org
BUG=chromium:242924
TEST=mjsunit/regress/regress-crbug-242924

Review URL: https://codereview.chromium.org/15735012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14757 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b704cb91

Handle holes in smi-untag from LoadKeyed requiring hole handling. · d1b5a251

verwaest@chromium.org authored May 22, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15737003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14756 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d1b5a251

Don't allow copying holes to fields. · b353b1d1

verwaest@chromium.org authored May 22, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15745006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14753 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b353b1d1

Fix corner case in optimized code map zapping. · d259e1ce

mstarzinger@chromium.org authored May 22, 2013

R=jkummerow@chromium.org
TEST=mjsunit/math-floor-part2

Review URL: https://codereview.chromium.org/15743005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14752 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d259e1ce

Fix Windows shared library build. · aadfc39a

ulan@chromium.org authored May 22, 2013

We cannot dll-export templates.

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15697006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14751 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

aadfc39a

Prepare push to trunk. Now working on version 3.19.4. · 3512dd3b

ulan@chromium.org authored May 22, 2013

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15746005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14748 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3512dd3b

Fix VisitLogicalExpression for empty blocks on RHS. · bf413b51

mstarzinger@chromium.org authored May 22, 2013

R=jkummerow@chromium.org
BUG=chromium:242870
TEST=mjsunit/regress/regress-crbug-242870

Review URL: https://codereview.chromium.org/15744002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14747 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bf413b51

Fix unexpected elements transition in JSON.parse · 9960b246

yangguo@chromium.org authored May 22, 2013

R=verwaest@chromium.org
BUG=241344

Review URL: https://chromiumcodereview.appspot.com/15739003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14746 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9960b246

Keep representations while overwriting transitions. · 8db30149

verwaest@chromium.org authored May 22, 2013

BUG=chromium:241477
R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15718002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14745 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8db30149

Use explicit type feedback clearing in some tests. · d696f7b3

mstarzinger@chromium.org authored May 22, 2013

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/15711004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14744 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d696f7b3

Force GC before executing unbox double arrays test to avoid timeouts. · 9c3c2864

hpayer@chromium.org authored May 22, 2013

BUG=

Review URL: https://codereview.chromium.org/15292002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14743 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9c3c2864

build fix for 14738 · 64aa4834

dcarney@chromium.org authored May 22, 2013

BUG=
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/15688003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14739 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

64aa4834

implement fast ReturnValue setters · 1045d627

dcarney@chromium.org authored May 22, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/15398008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14738 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1045d627

21 May, 2013 10 commits

MIPS: fix arm simulator after 14725 · ea122ef8

palfia@homejinni.com authored May 21, 2013

Port r14731 (046b5d8d)

BUG=

Review URL: https://codereview.chromium.org/15606002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14737 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ea122ef8

MIPS: new style of property/function callbacks · b2729b1b

palfia@homejinni.com authored May 21, 2013

Port r14725 (d393d88)

BUG=

Review URL: https://codereview.chromium.org/15562007
Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14736 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b2729b1b

Don't track representations in context extensions. · f74a85f3

verwaest@chromium.org authored May 21, 2013

This also enables verification of representations.

BUG=
R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15411003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14735 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f74a85f3

Add regression test for fix from r14732. · db4a770c

mstarzinger@chromium.org authored May 21, 2013

R=verwaest@chromium.org
BUG=chromium:242502
TEST=mjsunit/regress/regress-crbug-242502

Review URL: https://codereview.chromium.org/15288008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14734 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

db4a770c

a tiny bug in DehoistArrayIndex · 3947fefe

mmassi@chromium.org authored May 21, 2013

R=mmassi@chromium.org

Review URL: https://codereview.chromium.org/15268009

Patch from Weiliang Lin <weiliang.lin2@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3947fefe

Zap map value in the stub-cache on clear. · 8fed3da4

verwaest@chromium.org authored May 21, 2013

The empty_string is a valid key for keyed loads and stores.

BUG=
R=mstarzinger@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15565002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14732 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8fed3da4

fix arm simulator after 14725 · 8633086f

dcarney@chromium.org authored May 21, 2013

BUG=

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/15484006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14731 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8633086f

Make sure we register extensions only once. Removed unused member variable. · 4a7ed948

svenpanne@chromium.org authored May 21, 2013

V8::Initialize() can be called from various threads simultaneously, so
everything should be done only once per process or within the Isolate. For
registering extensions, we do the former now.

R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/15564002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14730 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4a7ed948

Disable flaky test after r14723. · 87436616

mstarzinger@chromium.org authored May 21, 2013

R=svenpanne@chromium.org
BUG=v8:2628
TEST=cctest/test-cpu-profiler/SampleWhenFrameIsNotSetup

Review URL: https://codereview.chromium.org/15415007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14729 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

87436616

Don't create new maps in CurrentMapForDeprecated. · 9f32d94c

verwaest@chromium.org authored May 21, 2013

R=yangguo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15358005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14728 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9f32d94c