- 30 Nov, 2021 1 commit
-
-
Frank Tang authored
Implement the changes in https://github.com/tc39/proposal-intl-locale-info/pull/44 So weekInfo will return weekend as an array instead of weekendStart and weekendEnd. Bug: v8:11638 Change-Id: I775b003b36f67179943911faa7f77a323ad9f6f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3307685Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#78172}
-
- 24 Nov, 2021 1 commit
-
-
Jakob Gruber authored
1. The default locale may be reset / is not immutable as we thought. 2. A suffix of ignorable code points after the common length affects the comparison result. Bug: v8:12196 Fixed: v8:12398 Change-Id: I6f60f56352956779df801c43de6ebac8cd9c592d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3291314 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#78053}
-
- 20 Nov, 2021 1 commit
-
-
Frank Tang authored
Remove two flags for feature shipped in m95 --harmony_intl_displaynames_v2 --harmony_intl_more_timezone Bug: v8:11637, v8:11661 Change-Id: I9432865722664f64c64b5bf7fde5e05e6b324b20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3292518Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#78005}
-
- 17 Nov, 2021 1 commit
-
-
Tobias Tebbi authored
This fast path works for ASCII-only strings and is similar to the existing fast-path in C++. Important differences: - The locale check is done at Turbofan optimization time instead of at runtime - Use tables of size 256 instead of 128 to save a bounds-check when handling one-byte strings. - It first performs an equality check that's optimized for detecting inequality quickly by comparing the strings from both ends. If the equality check succeeds, we are done. Otherwise chances are high that the strings differ according to collation level L1 already. Therefore, we first do an L1 check and perform the L3 check only when L1 didn't find a difference. This is based on the assumption that few strings are identical except for different capitalization. - Use the Torque version of string flattening instead of the runtime version. Bug: v8:12196 Change-Id: I2d043c1138846783f6d567b736d34063ba9301e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268465Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#77946}
-
- 12 Nov, 2021 1 commit
-
-
Frank Tang authored
Diary https://docs.google.com/document/d/1NqMw7DAVFCZRx67auC7sgOvrikHvCYuaB87JUf21yG8/edit# https://chromium.googlesource.com/chromium/deps/icu.git/+log/eedbaf76..3e05d9da chromium roll in https://chromium-review.googlesource.com/c/chromium/src/+/3224333 Bug: chromium:1260116 Change-Id: Ie1922a129310106985f3bf1bffd9101fce6bb73a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3237532Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#77868}
-
- 21 Oct, 2021 1 commit
-
-
Frank Tang authored
Bug: v8:12301 Change-Id: Ia87943478c1b67c077a18785668c485c404cd5dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3235814Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#77505}
-
- 07 Oct, 2021 1 commit
-
-
Jakob Gruber authored
Certain collators and subject strings may take this new fast path without calling into the (slow) ICU comparison functions. This CL can be roughly split into three topics: 1. The fast path check, precomputed and implemented as a whitelist on the current locale string. 2. The actual fast path, which checks subject string eligibility and performs L1 and L3 collation weight comparisons all in one pass. 3. Resuming from an aborted fast-path into the generic path. A longer overview is available at https://docs.google.com/document/d/1oyDwjYn2JyHsx2YnJJKhjX0WMNQXb8ao86-DRzqiYNg/edit?usp=sharing JetStream2/cdjs scores improve by roughly 40%. Bug: v8:12196 Change-Id: I5e1bbd731a36c361af9667f9104d6fa15c42e117 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149463Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77284}
-
- 24 Aug, 2021 1 commit
-
-
Camillo Bruni authored
This test regularly fails due to my local language setting. Change-Id: Ic4719ffbe49a8fc9d38d75b05b52ac550315a405 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3114138Reviewed-by: Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#76448}
-
- 16 Aug, 2021 1 commit
-
-
Jakob Kummerow authored
In this particular case, a comment in the code provides sufficient protection against regressions. No-Try: true Fixed: v8:12087 Change-Id: If9cad800bcc822b7b5ab91669ccda8b4314009f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3098185 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#76320}
-
- 12 Aug, 2021 2 commits
-
-
Frank Tang authored
flag --harmony_intl_enumeration I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/Txtf_rSqGH8/m/e27FY33JAQAJ Design Doc: https://docs.google.com/document/d/1lbj_YVW-xhzYNMQeHB-qDjVkf4SA-eTHYpYXx3Oaud8 https://chromestatus.com/guide/edit/5649454590853120 Bug: v8:10743 Change-Id: I3bfe0c25b50eb55025498534eba975a20723bd2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953519 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#76265}
-
Frank Tang authored
Move from recusion to loop to avoid stack overflow Bug: v8:12059 Change-Id: I44981f4271495adf00d7697114663f966b8f9f11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3087937Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#76252}
-
- 03 Aug, 2021 1 commit
-
-
Frank Tang authored
This is a temp fix to throw instead of DCHECK in debug build. The correct fix depends on the landing of https://github.com/unicode-org/icu/pull/1762 Once that land I will cherrypick into chrome to fix the function correctly. But the current (before this CL) behavior is not harmful in release build. It basically does not do the max nor min just return itself. Bug: chromium:1224869 Change-Id: Iebce2ab0a5ce047e83e8fce05db8290212e64509 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3017300Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#76047}
-
- 24 Jun, 2021 1 commit
-
-
Nico Hartmann authored
Bug: v8:11922 Change-Id: I9836b9ab2b8667b2c08f9525a386566117d95598 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982606 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#75363}
-
- 21 Jun, 2021 1 commit
-
-
Frank Tang authored
This is a reland of dd8845cd Original change's description: > [intl] Improve test coverage of "best fit" localeMatcher > > https: //docs.google.com/document/d/1cPGfiihn76yj2iAomKcspPFyLLcnk3WkCiqceBQPQyk/edit#heading=h.cc9tt7s0iwsd > Bug: v8:7051 > Change-Id: I8c35e859062c5bdb009334dd1b725751e6df2123 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2965481 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75228} Bug: v8:7051 Change-Id: I9af13b8fdf7ec3de2ac24050074d13fcdef981c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2973648Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#75280}
-
- 18 Jun, 2021 2 commits
-
-
Frank Tang authored
This reverts commit dd8845cd. Reason for revert: Performance regression Original change's description: > [intl] Improve test coverage of "best fit" localeMatcher > > https: //docs.google.com/document/d/1cPGfiihn76yj2iAomKcspPFyLLcnk3WkCiqceBQPQyk/edit#heading=h.cc9tt7s0iwsd > Bug: v8:7051 > Change-Id: I8c35e859062c5bdb009334dd1b725751e6df2123 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2965481 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75228} Bug: v8:7051 Change-Id: I4cf9484d727291ebc2868e3594ab1f18b19bec6b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2973227 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#75262}
-
Frank Tang authored
https: //docs.google.com/document/d/1cPGfiihn76yj2iAomKcspPFyLLcnk3WkCiqceBQPQyk/edit#heading=h.cc9tt7s0iwsd Bug: v8:7051 Change-Id: I8c35e859062c5bdb009334dd1b725751e6df2123 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2965481Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#75228}
-
- 16 Jun, 2021 1 commit
-
-
Frank Tang authored
Add tests for Intl Locale Info API to ensure the return items fit the type definition in UTS35 Bug: v8:11887 Change-Id: Ie92d80518909df9472ffd887800832a656807b5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964597Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#75190}
-
- 15 Jun, 2021 1 commit
-
-
Frank Tang authored
1. Add test to ensure none of the array contains undefined 2. Calculate the fixed array size by considering the code may filter out some itmes returned by ICU. 3. Add test to check there are no undefined. 4. Add test to check the locale.timeZones return sorted array. 5. Also refactor the JSArray generation code. Bug: v8:11871 Change-Id: I8ad4a779d137d9b7e2deead7a1aa38e599e1af2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953517 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75162}
-
- 09 Jun, 2021 1 commit
-
-
Frank Tang authored
The test push stack boundary and too flaky (timeout) while running machine with more memory. Bug: v8:11845 Change-Id: I5b603f05270d224de71c735ece5dd65a27311c25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939082Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#75030}
-
- 08 Jun, 2021 2 commits
-
-
Frank Tang authored
Add "calendar", and "dateTimeField" Add option for languageDisplay https://tc39.es/intl-displaynames-v2/ https://chromestatus.com/feature/5082027281874944 Design Doc: https://docs.google.com/document/d/17hQz4nOC7PJYhxc_MU-BRoT6BnYGZv66XlU1iGX0ywQ/edit# Bug: v8:11637 Change-Id: Ie7dc80d16956f0e668b11e600e47f5bafb081ff7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2924523 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75027}
-
Frank Tang authored
Only return "subset of" the requested Locales. Bug: v8:11860 Change-Id: I917753c6f0f5dfc7a52d071febbe03abfab45b04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2946746Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#75025}
-
- 27 May, 2021 1 commit
-
-
Frank Tang authored
https://tc39.es/proposal-intl-extend-timezonename/ https://chromestatus.com/guide/edit/4506375298220032 Bugs: v8:11661 Change-Id: I6d7e1bccf5a26ca02d39dc72d9362134a60ad6b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2757899Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#74809}
-
- 06 May, 2021 1 commit
-
-
Frank Tang authored
Spec: https://tc39.es/proposal-intl-locale-info/ Design Doc: https://docs.google.com/document/d/1OwEsvs8VQwvR-ug01xLyIwpgcvUfaP24u9owc7aBKJ4/edit# https://www.chromestatus.com/feature/5566859262820352 Behind flag --harmony_intl_locale_info Bug: v8:11638 Change-Id: Ie616b3394d047c99d95ae46f112b5f0b367afe74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2570218 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74394}
-
- 20 Apr, 2021 1 commit
-
-
Frank Tang authored
Diary https://docs.google.com/document/d/1T60FUG62FuvZ447FNoK81uE1fgJ7bayPf_w-rPqFrFM https://chromium.googlesource.com/chromium/deps/icu.git/+log/81d6568..7e7574bd chrome DEPS rolling https://chromium-review.googlesource.com/c/chromium/src/+/2824939 Bug: chromium:1193795 Change-Id: Ibccb97fe9b6b0601676800dea6c066e0d66a0a6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2793151Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#74075}
-
- 07 Apr, 2021 1 commit
-
-
Frank Tang authored
Somehow we have no-NO-NY locale data in ICU and cause problem. Bug: v8:11595 Change-Id: I68ba4c4c219bb3fbc88976f901a86219c44ea265 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782602Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#73818}
-
- 02 Mar, 2021 1 commit
-
-
Frank Tang authored
This reverts commit 57ae048b. Reason for revert: bug fixed in https://chromium-review.googlesource.com/c/v8/v8/+/2706353 Original change's description: > [test] Disable tests failing with new msan roll > > Temporarily disable these tests failing on msan builds after latest > roll: > - test262/intl402/DateTimeFormat/timezone-invalid > - intl/regress-364374 > - mjsunit/regress/regress-crbug-627935 > > No-Try: true > No-Tree-Checks: true > Bug: v8:11438 > Change-Id: I4a7755f9f65b2e9a12463c9e12fbbe39d3f5efb2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692188 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#72691} Bug: v8:11438 Change-Id: Iaca0a401a2c6d89e1bc8292ad41ae0086943c635 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2724862Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#73115}
-
- 26 Feb, 2021 1 commit
-
-
Frank Tang authored
Add GetOptionsObject/CoerceOptionsToObject for ECMA402 2021 Change Intl.ListFormat / Intl.DisplayNames and Intl.Segmenter to use GetOptionsObject and keep old API under CoerceOptionsToObject based on https://github.com/tc39/ecma402/pull/538/files Test262 tests need to be changed per https://github.com/tc39/test262/issues/2950 Bug: v8:11466 Change-Id: I5cb9b7aba0556effc76b4005e95c90db1e59d41f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2705696 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73082}
-
- 19 Feb, 2021 1 commit
-
-
Frank Tang authored
v8::internal::JSDateTimeFormat::New Bug: chromium:1177812, chromium:1177623 Change-Id: I91e6babd796c6735e96e3cd1541d8aba51aaefee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2706353 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#72878}
-
- 12 Feb, 2021 1 commit
-
-
Nico Hartmann authored
Temporarily disable these tests failing on msan builds after latest roll: - test262/intl402/DateTimeFormat/timezone-invalid - intl/regress-364374 - mjsunit/regress/regress-crbug-627935 No-Try: true No-Tree-Checks: true Bug: v8:11438 Change-Id: I4a7755f9f65b2e9a12463c9e12fbbe39d3f5efb2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2692188Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#72691}
-
- 10 Feb, 2021 1 commit
-
-
Frank Tang authored
Bug: v8:11424 Change-Id: Ic9c9dc2609ee85f046f6bc5794004ededd32bee5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2684931 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#72616}
-
- 29 Jan, 2021 2 commits
-
-
Frank Tang authored
Make sure there are space between day and hour in the pattern when we alternate date pattern for the change of hour cycle. Bug: chromium:1170305 Change-Id: I2714111dcdedeefafdb854d1684f301786273303 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2654002 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72418}
-
Frank Tang authored
Bug: v8:11350 Change-Id: Ic34b40c4d88d6c2a0ac62bbebee4e2a95ebba826 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2648973 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#72417}
-
- 25 Jan, 2021 1 commit
-
-
Frank Tang authored
Implement https://github.com/tc39/ecma402/pull/500 For the legacy [optional] Unwrap*Format steps, use OrdinaryHasInstance instead of InstanceofOperator. ECMA402 agree w/ PR500 on 2021-1-14 Bug: v8:10981 Change-Id: Ic697aa245b11fecaf998127c009e59a821aaa01e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2444092Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#72303}
-
- 12 Jan, 2021 1 commit
-
-
Frank Tang authored
Use a bit to work around the issue of ICU getType() bug. Bug: v8:11295 Change-Id: I15d65bd44c489031d789e7638ea8abab90128124 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2614216 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#72028}
-
- 10 Dec, 2020 2 commits
-
-
Frank Tang authored
cl for chrome/src/DEPS in https://chromium-review.googlesource.com/c/chromium/src/+/2582536 Bug: v8:10447 Change-Id: I28452cab64f000aa8cc466290ffcc97aa0b41f78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2583189 Commit-Queue: Shu-yu Guo <syg@chromium.org> Auto-Submit: Frank Tang <ftang@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#71702}
-
Frank Tang authored
This is a reland of c9c3ec4c Original change's description: > [intl] Clean up intl_segmenter flag > > Intl.Segmenter shipped in m87 and launched. > > Bug: v8:11225 > Change-Id: I4213e261e1aea717c1281f19785a8c29ff1bbd8b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2570461 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71653} Bug: v8:11225, v8:11240 Change-Id: Ibded9038671862d90206d328f8a12db51c40e63c Cq-Include-Trybots: luci.v8.try:v8_linux64_gc_stress_custom_snapshot_dbg_ng,v8_linux_arm64_gc_stress_dbg_ng,v8_linux_gc_stress_dbg_ng,v8_mac64_gc_stress_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2579043 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#71691}
-
- 08 Dec, 2020 2 commits
-
-
Clemens Backes authored
This reverts commit c9c3ec4c. Reason for revert: Speculative revert for https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/34616/overview (looks unrelated, but fails consistently since this CL) Original change's description: > [intl] Clean up intl_segmenter flag > > Intl.Segmenter shipped in m87 and launched. > > Bug: v8:11225 > Change-Id: I4213e261e1aea717c1281f19785a8c29ff1bbd8b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2570461 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71653} TBR=jkummerow@chromium.org,ftang@chromium.org,syg@chromium.org Change-Id: Ic1d1b02abb9ae7faa41307eee694bb7e40d0fae2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:11225 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2578979Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71657}
-
Frank Tang authored
Intl.Segmenter shipped in m87 and launched. Bug: v8:11225 Change-Id: I4213e261e1aea717c1281f19785a8c29ff1bbd8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2570461 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#71653}
-
- 24 Nov, 2020 2 commits
-
-
Maya Lekova authored
This reverts commit 1341dbd2. Reason for revert: The new test is failing on arm64 simulator MSAN - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/35559 Original change's description: > [int] Fix security bug in Intl.ListFormat > > Also add test to ensure it won't crash. The crash is caused by int32_t overflow inside ICU68-1 > > Real fix in https://chromium.googlesource.com/chromium/deps/icu/+/3bf08c6a50f77921ae79d4e715b580b959e494c7 > > Bug: chromium:1150371 > Change-Id: I71c7bb3c50453fe3fa40226cab83bee0d865b0f0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551212 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71357} TBR=jkummerow@chromium.org,machenbach@chromium.org,ftang@chromium.org,syg@chromium.org Change-Id: I10862ad1fb308d1610b8f7a80cca43c010475397 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1150371 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2557512Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#71362}
-
Frank Tang authored
Also add test to ensure it won't crash. The crash is caused by int32_t overflow inside ICU68-1 Real fix in https://chromium.googlesource.com/chromium/deps/icu/+/3bf08c6a50f77921ae79d4e715b580b959e494c7 Bug: chromium:1150371 Change-Id: I71c7bb3c50453fe3fa40226cab83bee0d865b0f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551212Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#71357}
-