Skip to content

V
V8
Switch branch/tag
  1. 14 Nov, 2016 1 commit
    • yangguo's avatar
      [serializer] small fixes for blink snapshot. · c759a3d8
      yangguo authored 
      Changes include:
 - Adding V8_EXPORT macro for SnapshotCreator
 - Removing outdated DCHECKs.
 - Allow nullptr as external reference. This required a...
 - Refactoring of hashmaps used by the serializer.
 - Remove external references for counters. These are not used
   anywhere for isolates that are being serialized.
 - Put template infos into the partial snapshot cache.
 - Remove unnecessary presubmit check for external references.
   mksnapshot crashes if external references are missing.

R=jochen@chromium.org, vogelheim@chromium.org
BUG=chromium:617892

Review-Url: https://codereview.chromium.org/2490783004
Cr-Commit-Position: refs/heads/master@{#40949}
      c759a3d8
  3. 27 Oct, 2016 1 commit
  5. 06 Sep, 2016 1 commit
    • mlippautz's avatar
      Move kMaxRegularHeapObjectSize into globals · 059b5643
      mlippautz authored 
      This way we avoid the cyclic dependency between objects.h and heap.h and still
have one definition. Add a static assert that this size is indeed smaller than
the payload of a page.

Follow ups can finally remove the dependency on spaces.h for all heap.h users.

R=ulan@chromium.org,bmeurer@chromium.org,vogelheim@chromium.og

Review-Url: https://codereview.chromium.org/2311203002
Cr-Commit-Position: refs/heads/master@{#39206}
      059b5643
  7. 22 Aug, 2016 1 commit
  9. 10 Aug, 2016 1 commit
  11. 24 Jun, 2016 1 commit
  13. 10 Jun, 2016 1 commit
  15. 06 Jun, 2016 1 commit
  17. 19 May, 2016 2 commits
    • yangguo's avatar
      [serializer] do not cache resource data pointer for native source. · 28df32d9
      yangguo authored 
      The cached resource data pointer is a source of non-determinism when
creating the snapshot.  Long-term we may not keep the native source in
memory anyways, so caching the resource data pointer will not be
possible.

R=ulan@chromium.org
BUG=v8:4886
LOG=N

Review-Url: https://codereview.chromium.org/1990183002
Cr-Commit-Position: refs/heads/master@{#36361}
      28df32d9
    • yangguo's avatar
      [serializer] do not copy code if snapshot is not required to be deterministic. · 5a88c047
      yangguo authored 
      Code in V8 embeds memory addresses. Upon deserialization, those addresses will
be updated anyways, so it's not important whether the serializer records those
addresses. In order to have a deterministic build, we create a copy of the code
and null out memory addresses and serialize this copy.

For the code cache, we do not care about determinism. By avoiding the copy we
can save some time spent on serialization. For the mandreel script in Octane,
this reduces the serialization time from ~85ms to ~75ms.

R=vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/1991033003
Cr-Commit-Position: refs/heads/master@{#36350}
      5a88c047
  19. 18 May, 2016 1 commit
    • yangguo's avatar
      [serializer] prepare attached references for general use. · 735fa0c4
      yangguo authored 
      Currently attached references are only used for global proxy, source
string and code stubs. Mid-term future we want to use attached
references for arbitrary objects (in fixed order) provided from outside.

This change renames BackReference to SerializerReference to include both
back references and attached references.

R=mtrofin@chromium.org, vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/1992723002
Cr-Commit-Position: refs/heads/master@{#36318}
      735fa0c4
  21. 12 Apr, 2016 1 commit
  23. 11 Apr, 2016 2 commits
  25. 08 Apr, 2016 2 commits
    • jfb's avatar
      Revert of Fix printf formats (patchset #8 id:140001 of... · 4c4fdc2d
      jfb authored 
      Revert of Fix printf formats (patchset #8 id:140001 of https://codereview.chromium.org/1869433004/ )

Reason for revert:
One small issue easily fixed here: https://codereview.chromium.org/1867333003/

But it looks like MSVS 2013 doesn't like some of the formats and exists with the unhelpful:
Stderr:
f:\dd\vctools\crt\crtw32\stdio\output.c(1125) : Assertion failed: ("Incorrect
format specifier", 0)

It's easier to revert for now, I'll dig more into the docs:
https://msdn.microsoft.com/en-us/library/56e442dc(v=vs.120).aspx
https://msdn.microsoft.com/en-us/library/tcxf1dw6(v=vs.120).aspx

And then resubmit, making sure I run these bots.

Original issue's description:
> Fix printf formats
>
> The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL:
>
>  - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
>  - Uses it appropriately.
>  - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done).
>  - Fixes a bunch of incorrect formats.
>
> R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org
>
> Committed: https://crrev.com/6ebf9fbb93d31f9be41156a3325d58704ed4933d
> Cr-Commit-Position: refs/heads/master@{#35365}

TBR=jochen@chromium.org,bmeurer@chromium.org,yangguo@chromium.org,ahaas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1867383002

Cr-Commit-Position: refs/heads/master@{#35366}
      4c4fdc2d
    • jfb's avatar
      Fix printf formats · 6ebf9fbb
      jfb authored 
      The usage of __attribute__((format(x, y)) was either wrong or missing from multiple functions, leading to erroneous formats. This CL:

 - Imports PRINTF_FORMAT macro from Chrome's src/base/compiler-specific.h.
 - Uses it appropriately.
 - Imports Chrome's base/format_macros.h mainly to fix size_t formats (further cleanup could be done).
 - Fixes a bunch of incorrect formats.

R= jochen@chromium.org, bmeurer@chromium.org, yangguo@chromium.org, ahaas@chromium.org

Review URL: https://codereview.chromium.org/1869433004

Cr-Commit-Position: refs/heads/master@{#35365}
      6ebf9fbb
  27. 05 Apr, 2016 1 commit
  29. 17 Mar, 2016 1 commit
    • yangguo's avatar
      [serializer] ensure that immortal immovable roots are correctly deserialized. · 6e8958ff
      yangguo authored 
      Immortal immovable roots must be allocated on the first page of the space.
If serializing the root list exceeds the first page, immortal immovable root
objects might end up outside of the first page. That could cause missing
write barriers.

We now iterate the root list twice. The first time we only serialize immortal
immovable root objects. The second time we serialize the rest.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/1811913002

Cr-Commit-Position: refs/heads/master@{#34859}
      6e8958ff
  31. 11 Mar, 2016 1 commit
    • joransiu's avatar
      S390: Printf format specifier for size_t · 59267a08
      joransiu authored 
      GCC on S390 31-bit treats size_t as 'long unsigned int', which
is incompatible with %d format specifier that expects an 'int'.
Introduce a new V8 SIZET PREFIX to use %zd instead.

R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com,yangguo@chromium.org

BUG=

Review URL: https://codereview.chromium.org/1782293002

Cr-Commit-Position: refs/heads/master@{#34724}
      59267a08
  33. 02 Mar, 2016 1 commit
  35. 01 Mar, 2016 1 commit