Commits · 673baa3cf462bb207535ad34ee15452488c175bd · Linshizhi / V8

11 Nov, 2015 9 commits

[deoptimizer] Remove unused function argument. · 673baa3c

jarin authored Nov 11, 2015

Review URL: https://codereview.chromium.org/1439583002

Cr-Commit-Position: refs/heads/master@{#31940}

673baa3c

[Interpreter] Disable another flaky test262 test. · 392d1469

machenbach authored Nov 11, 2015

This is for disabling 9.2.2. for release on arm64
(approximating a bit).

BUG=v8:4280
LOG=N
NOTRY=True
TBR=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/1432183002

Cr-Commit-Position: refs/heads/master@{#31939}

392d1469

[turbofan] Add support to lower Function.prototype.call. · f5e6dcb6

bmeurer authored Nov 11, 2015

Support lowering of Function.prototype.call in the JSBuiltinReducer,
which is actually straightforward because of the way we represent JS
calls in TurboFan.  Currently we cannot inline the actual target yet,
since inlining still runs before typed lowering, but that will be
possible as well soon(ish).

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/1439533002

Cr-Commit-Position: refs/heads/master@{#31938}

f5e6dcb6

MIPS64: Fix after [turbofan] Avoid unnecessary write barriers and improve code generation. · 6e0aa37c

paul.lind authored Nov 11, 2015

Use 64-bit add for address.

TEST=mjsunit/sparse-array.js, others.
BUG=

Review URL: https://codereview.chromium.org/1435793002

Cr-Commit-Position: refs/heads/master@{#31937}

6e0aa37c

Update V8 DEPS. · 1ff9258b

v8-autoroll authored Nov 11, 2015

Rolling v8/buildtools to 4a95614772d9bcbd8bc197e1d9bd034e088fc740

TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org

Review URL: https://codereview.chromium.org/1439503002

Cr-Commit-Position: refs/heads/master@{#31936}

1ff9258b

X87: [turbofan] Avoid unnecessary write barriers and improve code generation. · f1478bd1

zhengxing.li authored Nov 11, 2015

   port 1e277012 (r31914)

   original commit message:
   Avoid write barriers when storing values in the root set, and use
   cheaper write barriers for storing maps or tagged pointers. Also
   improve the generated code for write barriers, utilizing the out
   of line code mechanism that is available to TurboFan backends,
   which moves the unlikely case out of the hot path.

BUG=

Review URL: https://codereview.chromium.org/1435743003

Cr-Commit-Position: refs/heads/master@{#31935}

f1478bd1

X87: Support fast-path allocation for subclass constructors with correctly... · e9528b83

zhengxing.li authored Nov 11, 2015

X87: Support fast-path allocation for subclass constructors with correctly initialized initial maps.

  port b9d25d86 (r31913)

  original commit message:

BUG=

Review URL: https://codereview.chromium.org/1434853002

Cr-Commit-Position: refs/heads/master@{#31934}

e9528b83

PPC64: Implemented the RoundInt64ToFloat32 TurboFan operator. · 693c553c

mbrandy authored Nov 11, 2015

R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=

Review URL: https://codereview.chromium.org/1409073016

Cr-Commit-Position: refs/heads/master@{#31933}

693c553c

make v8_use_snapshot configurable in gn · d62efc12

mostynb authored Nov 11, 2015

Changing this value is not guaranteed to work yet, but it needs to be
an arg in order to experiment with it.

Review URL: https://codereview.chromium.org/1427343003

Cr-Commit-Position: refs/heads/master@{#31932}

d62efc12

10 Nov, 2015 25 commits

PPC64: Implemented the Word64Popcnt TurboFan operator. · d151feeb

mbrandy authored Nov 10, 2015

R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=

Review URL: https://codereview.chromium.org/1413833013

Cr-Commit-Position: refs/heads/master@{#31931}

d151feeb

Revert changes introduced in http://crrev.com/1367953002 . · 56c7a053

epertoso authored Nov 10, 2015

This CL is in preparation for the API change introduced in http://crrev.com/1407313004.

BUG=

Review URL: https://codereview.chromium.org/1434693008

Cr-Commit-Position: refs/heads/master@{#31930}

56c7a053

Implemented the RoundInt64ToFloat32 TurboFan operator for x64, arm64, and mips64. · 1b535ca0

ahaas authored Nov 10, 2015

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/1435603003

Cr-Commit-Position: refs/heads/master@{#31929}

1b535ca0

Implemented the Word64Popcnt TurboFan operator for x64. · 01fd8e05

ahaas authored Nov 10, 2015

Popcnt is implemented as an optional operator, which is only implementd by x64
at the moment.

Review URL: https://codereview.chromium.org/1424173006

Cr-Commit-Position: refs/heads/master@{#31928}

01fd8e05

PPC: [turbofan] Avoid unnecessary write barriers and improve code generation. · e2f4f04f

mbrandy authored Nov 10, 2015

Port 1e277012

Original commit message:
    Avoid write barriers when storing values in the root set, and use
    cheaper write barriers for storing maps or tagged pointers. Also
    improve the generated code for write barriers, utilizing the out
    of line code mechanism that is available to TurboFan backends,
    which moves the unlikely case out of the hot path.

R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=

Review URL: https://codereview.chromium.org/1431923003

Cr-Commit-Position: refs/heads/master@{#31927}

e2f4f04f

PPC: Support fast-path allocation for subclass constructors with correctly... · f3726944

mbrandy authored Nov 10, 2015

PPC: Support fast-path allocation for subclass constructors with correctly initialized initial maps.

Port b9d25d86

R=verwaest@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=v8:3330
LOG=n

Review URL: https://codereview.chromium.org/1434793002

Cr-Commit-Position: refs/heads/master@{#31926}

f3726944

PPC64: Define the optional ctz Turbo Fan operator. · 432d1a6f

mbrandy authored Nov 10, 2015

Like its 32-bit counterpart, this is not implemented on PPC.

R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=

Review URL: https://codereview.chromium.org/1438583002

Cr-Commit-Position: refs/heads/master@{#31925}

432d1a6f

Revert "Revert of [turbofan] Remove redundant code. (patchset #1 id:1 · b10e8506

mtrofin authored Nov 10, 2015

 of https://codereview.chromium.org/1428943004/ )"

This reverts commit 5f4828a1.

Maintaining the behavior of processing both ranges with spill ranges,
as well as those with spill operands.

BUG=

Review URL: https://codereview.chromium.org/1406223010

Cr-Commit-Position: refs/heads/master@{#31924}

b10e8506

[Interpreter] Disable Arm/Arm64 tests on release as well as debug for ignition. · 0609ed27

rmcilroy authored Nov 10, 2015

BUG=v8:4280
LOG=N
NOTRY=True
TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/1423803009

Cr-Commit-Position: refs/heads/master@{#31923}

0609ed27

MIPS: Fix 'MIPS:r6 compact branch optimization.' · 6993cd0d

balazs.kilvady authored Nov 10, 2015

Jic and jialc compact branch ops are fixed as they does not have 'forbidden slot' restriction. Also COP1 branches (CTI instructions) added to IsForbiddenAfterBranchInstr().

TEST=cctest/test-disasm-mips/Type0
BUG=

Review URL: https://codereview.chromium.org/1423493006

Cr-Commit-Position: refs/heads/master@{#31922}

6993cd0d

Remove redundant activation threshold for incremental marking. · e28e4d5f

ulan authored Nov 10, 2015

The minimum allocation limit already enforces this constraint for normal GCs.

GCs triggered by the memory reducer and external limit should work for all heap sizes.

BUG=chromium:552305
LOG=NO

Review URL: https://codereview.chromium.org/1418293006

Cr-Commit-Position: refs/heads/master@{#31921}

e28e4d5f

[Interpreter] Disable mjsunit/array-sort on Arm/Arm64 · 6e599ce9

rmcilroy authored Nov 10, 2015

BUG=v8:4280
LOG=N
NOTRY=true
TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/1410883009

Cr-Commit-Position: refs/heads/master@{#31920}

6e599ce9

[Interpreter] Skip some more tests on Arm64 for Ignition. · 1820acb9

rmcilroy authored Nov 10, 2015

Skips some more tests which started failing after https://codereview.chromium.org/1414183006 landed.

BUG=v8:4280
LOG=N
NOTRY=True

Review URL: https://codereview.chromium.org/1412343009

Cr-Commit-Position: refs/heads/master@{#31919}

1820acb9

PPC: Disable gcc generation of fmadd/fmsub in cctests. · 40eeb69b

mbrandy authored Nov 10, 2015

Generated code performs distinct floating multiply and add/subtract
operations.  Tests fail when GCC uses fmadd/fmsub to calculate the
expected result since these instructions provide higher accuracy due
to the lack of an intermediate round.

R=machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1416123007

Cr-Commit-Position: refs/heads/master@{#31918}

40eeb69b

MIPS: JALR to JAL optimization removal · 60b97e80

Djordje.Pesic authored Nov 10, 2015

Review URL: https://codereview.chromium.org/1419793014

Cr-Commit-Position: refs/heads/master@{#31917}

60b97e80

[turbofan] Pseudo-inline 'instanceof' · 45787501

sigurds authored Nov 10, 2015

This patch extends the typed lowering with a specialized version of 'instanceof' that is used if the "class", i.e. the constructor function, is a known constant.

Unittests check that replacement occurs as intended. Functional correctness is ensured by extensive unit tests covering instanceof already in the testsuite.

TESTS=unittests/JSTypedLoweringTest.{JSInstanceOfSpecializationWithSmiCheck,JSInstanceOfSpecializationWithoutSmiCheck,JSInstanceOfNoSpecialization}

Review URL: https://codereview.chromium.org/1407413014

Cr-Commit-Position: refs/heads/master@{#31916}

45787501

Make JSFunction::BodyDescriptor the only single place that knows how to iterate JSFunction's body. · 8e09ee1d

ishell authored Nov 10, 2015

The body descriptor supports different visiting policies: it could visit or skip
the code entry and it could visit or skip next function field.

BUG=v8:4531
LOG=Y

Review URL: https://codereview.chromium.org/1422773007

Cr-Commit-Position: refs/heads/master@{#31915}

8e09ee1d

[turbofan] Avoid unnecessary write barriers and improve code generation. · 1e277012

bmeurer authored Nov 10, 2015

Avoid write barriers when storing values in the root set, and use
cheaper write barriers for storing maps or tagged pointers. Also
improve the generated code for write barriers, utilizing the out
of line code mechanism that is available to TurboFan backends,
which moves the unlikely case out of the hot path.

R=jarin@chromium.org, mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/1414183006

Cr-Commit-Position: refs/heads/master@{#31914}

1e277012

Support fast-path allocation for subclass constructors with correctly initialized initial maps. · b9d25d86
verwaest authored Nov 10, 2015
```
BUG=v8:3330
LOG=n

Review URL: https://codereview.chromium.org/1413003008

Cr-Commit-Position: refs/heads/master@{#31913}
```
b9d25d86

Implemented the ctz Turbo Fan operator for x64. · a594ff73

ahaas authored Nov 10, 2015

Ctz is implemented as an optional operator at the moment, which is only
implemented by x64 at the moment.

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/1421163005

Cr-Commit-Position: refs/heads/master@{#31912}

a594ff73

[es6] Implement @@split subclassing. · 9a569ec2

yangguo authored Nov 10, 2015

RegExp.prototye[@@split] is not yet implement to spec regarding creating
new RegExp object with the SpeciesConstructor.

R=littledan@chromium.org
BUG=v8:4345
LOG=N

Review URL: https://codereview.chromium.org/1427573005

Cr-Commit-Position: refs/heads/master@{#31911}

9a569ec2

Unify setting accessor properties in native code. · 483d8b9b

yangguo authored Nov 10, 2015

R=cbruni@chromium.org

Review URL: https://codereview.chromium.org/1416093006

Cr-Commit-Position: refs/heads/master@{#31910}

483d8b9b

X87: [runtime] Drop redundant %CharFromCode runtime entry. · 12a073e6

zhengxing.li authored Nov 10, 2015

  port 2b4cb2a1 (r31873)

  original commit message:
  The %StringCharFromCode and %CharFromCode runtime function perform
  exactly the same task, so we need only one of them.

BUG=

Review URL: https://codereview.chromium.org/1432063002

Cr-Commit-Position: refs/heads/master@{#31909}

12a073e6

Allow constant heap accesses in asm typer. · 318bcbee

bradnelson authored Nov 10, 2015

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=titzer@chromium.org,aseemgarg@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/1405993009

Cr-Commit-Position: refs/heads/master@{#31908}

318bcbee

Revert of "[es6] Partially implement Reflect.ownKeys." · ec0f891d

neis authored Nov 10, 2015

Reason for revert: failed tests on a Windows build.

TBR=rossberg,cbruni,neis
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1426943007

Cr-Commit-Position: refs/heads/master@{#31907}

ec0f891d

09 Nov, 2015 6 commits

[es6] Partially implement Reflect.ownKeys. · 4194d0eb

neis authored Nov 09, 2015

Proxies are not properly supported yet.

R=cbruni, rossberg
BUG=

Review URL: https://codereview.chromium.org/1405243006

Cr-Commit-Position: refs/heads/master@{#31906}

4194d0eb

PPC: [builtins] Introduce specialized Call/CallFunction builtins. · 74966e61

mbrandy authored Nov 09, 2015

Port 7c3396d0

Original commit message:
    Introduce receiver conversion mode specialization for the Call and
    CallFunction builtins, so we can specialize the builtin functionality
    (actually an optimization only) based on static information from the
    callsite (this is basically a superset of the optimizations that were
    available with the CallFunctionStub and CallICStub, except that these
    optimizations are correct now).

    This fixes a regression introduced by the removal of CallFunctionStub,
    for programs that call a lot.

R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=chromium:552244
LOG=n

Review URL: https://codereview.chromium.org/1425083004

Cr-Commit-Position: refs/heads/master@{#31905}

74966e61

PPC: [runtime] Drop redundant %CharFromCode runtime entry. · bdb04d5b

mbrandy authored Nov 09, 2015

Port 2b4cb2a1

Original commit message:
    The %StringCharFromCode and %CharFromCode runtime function perform
    exactly the same task, so we need only one of them.

R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=

Review URL: https://codereview.chromium.org/1429953005

Cr-Commit-Position: refs/heads/master@{#31904}

bdb04d5b

PPC64: Implemented the Word64Clz TurboFan operator. · dba4dfb2

mbrandy authored Nov 09, 2015

R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=

Review URL: https://codereview.chromium.org/1433733002

Cr-Commit-Position: refs/heads/master@{#31903}

dba4dfb2

PPC: Remove receiver conversion from function prologue · 96baec27

mbrandy authored Nov 09, 2015

Port 4ab1b05d

Original commit message:
    Depends on https://codereview.chromium.org/1407373007/
    After that CL, all receiver conversion is handled by the call builtin.

R=verwaest@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=

Review URL: https://codereview.chromium.org/1412803014

Cr-Commit-Position: refs/heads/master@{#31902}

96baec27

PPC: Remove CallFunctionStub, always call through the Call builtin (also from CallIC). · 44fcc2e7

mbrandy authored Nov 09, 2015

Port 44c44521

Original commit message:
    This fixes receiver conversion since the Call builtin does it correctly.

R=verwaest@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=v8:4526
LOG=n

Review URL: https://codereview.chromium.org/1423973006

Cr-Commit-Position: refs/heads/master@{#31901}

44fcc2e7