- 26 Sep, 2017 1 commit
-
-
Yang Guo authored
This is a reland of 629406d1 Original change's description: > [snapshot] include version string in the startup snapshot. > > This is to easier diagnose build issues involving the snapshot. > Sample error message for mismatching snapshot: > > # > # Fatal error in ../../src/snapshot/snapshot-common.cc, line 286 > # Version mismatch between V8 binary and snapshot. > # V8 binary version: 6.3.1 (candidate) > # Snapshot version: 6.3.0 (candidate) > # The snapshot consists of 2820444 bytes and contains 1 contexts. > # > > > R=machenbach@chromium.org > > Bug: chromium:764327 > Change-Id: Icdc7aeac77819b113985b424feda814a072d5406 > Reviewed-on: https://chromium-review.googlesource.com/684295 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48161} Bug: chromium:764327 Change-Id: I3721689824e0a6909eede86d0829dc258ae40c4d Reviewed-on: https://chromium-review.googlesource.com/684494Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48164}
-
- 21 Jan, 2017 2 commits
-
-
hablich authored
Revert of [build] Introduce an embedder version string (patchset #3 id:40001 of https://codereview.chromium.org/2619213002/ ) Reason for revert: Blocks roll https://codereview.chromium.org/2647183002/ Original issue's description: > [build] Introduce an embedder version string > > Sometimes, the embedder might want to merge a fix to an abandoned branch > or to a supported branch but the fix is not relevant to Chromium. > This adds a new version string that the embedder can set on compile time > and that will be appended to the official V8 version. > The separator must be provided in the string. For instance, to have a > full version string like "5.5.372.37.custom.1", the embedder must set > V8_EMBEDDER_STRING to ".custom.1". > > Related Node.js issue: https://github.com/nodejs/node/pull/9754 > > BUG=v8:5740 > R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng > > Review-Url: https://codereview.chromium.org/2619213002 > Cr-Original-Commit-Position: refs/heads/master@{#42175} > Committed: https://chromium.googlesource.com/v8/v8/+/fc86d4329b253bf21c1dd85469f1ef4b6e5ba01a > Review-Url: https://codereview.chromium.org/2619213002 > Cr-Commit-Position: refs/heads/master@{#42582} > Committed: https://chromium.googlesource.com/v8/v8/+/2c1d1e60883882011ed50310a9b09e95dc61234a TBR=hablich@chromium.com,machenbach@chromium.org,ofrobots@google.com,mic.besace@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5740 Review-Url: https://codereview.chromium.org/2643393004 Cr-Commit-Position: refs/heads/master@{#42583}
-
mic.besace authored
Sometimes, the embedder might want to merge a fix to an abandoned branch or to a supported branch but the fix is not relevant to Chromium. This adds a new version string that the embedder can set on compile time and that will be appended to the official V8 version. The separator must be provided in the string. For instance, to have a full version string like "5.5.372.37.custom.1", the embedder must set V8_EMBEDDER_STRING to ".custom.1". Related Node.js issue: https://github.com/nodejs/node/pull/9754 BUG=v8:5740 R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng Review-Url: https://codereview.chromium.org/2619213002 Cr-Original-Commit-Position: refs/heads/master@{#42175} Committed: https://chromium.googlesource.com/v8/v8/+/fc86d4329b253bf21c1dd85469f1ef4b6e5ba01a Review-Url: https://codereview.chromium.org/2619213002 Cr-Commit-Position: refs/heads/master@{#42582}
-
- 12 Jan, 2017 2 commits
-
-
scottmg authored
This is part of removing the dependency of the Chromium browser DLL on Windows on V8. R=jochen@chromium.org BUG=chromium:581766 Review-Url: https://codereview.chromium.org/2621983002 Cr-Original-Commit-Position: refs/heads/master@{#42243} Committed: https://chromium.googlesource.com/v8/v8/+/45938454177f53fa24cfc08ad97ccbc162c3ba6d Review-Url: https://codereview.chromium.org/2621983002 Cr-Commit-Position: refs/heads/master@{#42289}
-
hablich authored
Revert of Pull define for version out into v8-version.h and separate build target (patchset #1 id:1 of https://codereview.chromium.org/2621983002/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/2633463002/ Original issue's description: > Pull define for version out into v8-version.h and separate build target > > This is part of removing the dependency of the Chromium browser DLL on > Windows on V8. > > R=jochen@chromium.org > BUG=chromium:581766 > > Review-Url: https://codereview.chromium.org/2621983002 > Cr-Commit-Position: refs/heads/master@{#42243} > Committed: https://chromium.googlesource.com/v8/v8/+/45938454177f53fa24cfc08ad97ccbc162c3ba6d TBR=jochen@chromium.org,machenbach@chromium.org,scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:581766 Review-Url: https://codereview.chromium.org/2627713008 Cr-Commit-Position: refs/heads/master@{#42257}
-
- 11 Jan, 2017 1 commit
-
-
scottmg authored
This is part of removing the dependency of the Chromium browser DLL on Windows on V8. R=jochen@chromium.org BUG=chromium:581766 Review-Url: https://codereview.chromium.org/2621983002 Cr-Commit-Position: refs/heads/master@{#42243}
-
- 10 Jan, 2017 2 commits
-
-
hablich authored
Revert of [build] Introduce an embedder version string (patchset #2 id:20001 of https://codereview.chromium.org/2619213002/ ) Reason for revert: Seems to break the Chromium build: https://codereview.chromium.org/2619193005/ Message: [1832/9671] CXX obj/v8/v8_base/version.o FAILED: obj/v8/v8_base/version.o /b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/v8/v8_base/version.o.d -DV8_DEPRECATION_WARNINGS -DDCHECK_ALWAYS_ON=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=289944-2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DV8_I18N_SUPPORT -DENABLE_HANDLE_ZAPPING -DV8_USE_EXTERNAL_STARTUP_DATA -DV8_TARGET_ARCH_X64 -DDEBUG -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. -Igen -I../../v8 -I../../v8/include -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/b/c/b/linux/src=. -m64 -march=x86-64 -pthread -g1 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Werror -Wall -Wno-unused-variable -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wsign-compare -Winconsistent-missing-override -Wshorten-64-to-32 -O3 -fno-ident -fdata-sections -ffunction-sections -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -Wno-deprecated -c ../../v8/src/version.cc -o obj/v8/v8_base/version.o ../../v8/src/version.cc:42:34: error: use of undeclared identifier 'V8_EMBEDDER_STRING' const char* Version::embedder_ = V8_EMBEDDER_STRING; ^ 1 error generated. Original issue's description: > [build] Introduce an embedder version string > > Sometimes, the embedder might want to merge a fix to an abandoned branch > or to a supported branch but the fix is not relevant to Chromium. > This adds a new version string that the embedder can set on compile time > and that will be appended to the official V8 version. > The separator must be provided in the string. For instance, to have a > full version string like "5.5.372.37.custom.1", the embedder must set > V8_EMBEDDER_STRING to ".custom.1". > > Related Node.js issue: https://github.com/nodejs/node/pull/9754 > > BUG=v8:5740 > R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com > > Review-Url: https://codereview.chromium.org/2619213002 > Cr-Commit-Position: refs/heads/master@{#42175} > Committed: https://chromium.googlesource.com/v8/v8/+/fc86d4329b253bf21c1dd85469f1ef4b6e5ba01a TBR=hablich@chromium.com,machenbach@chromium.org,ofrobots@google.com,mic.besace@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5740 Review-Url: https://codereview.chromium.org/2621033002 Cr-Commit-Position: refs/heads/master@{#42182}
-
mic.besace authored
Sometimes, the embedder might want to merge a fix to an abandoned branch or to a supported branch but the fix is not relevant to Chromium. This adds a new version string that the embedder can set on compile time and that will be appended to the official V8 version. The separator must be provided in the string. For instance, to have a full version string like "5.5.372.37.custom.1", the embedder must set V8_EMBEDDER_STRING to ".custom.1". Related Node.js issue: https://github.com/nodejs/node/pull/9754 BUG=v8:5740 R=machenbach@chromium.org,hablich@chromium.com,ofrobots@google.com Review-Url: https://codereview.chromium.org/2619213002 Cr-Commit-Position: refs/heads/master@{#42175}
-
- 20 Aug, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1285183010 Cr-Commit-Position: refs/heads/master@{#30263}
-
- 01 Jun, 2015 1 commit
-
-
erikcorry authored
When compiling on a laptop I like to concatenate the small test files. This makes a big difference to compile times. These changes make that easier. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1163803002 Cr-Commit-Position: refs/heads/master@{#28742}
-
- 26 Feb, 2015 1 commit
-
-
machenbach authored
Side note: tools/v8-info.sh seems to have been broken ever since the move to git. At least it's not more broken now. BUG=v8:3075 LOG=y TEST=./script_test.py Review URL: https://codereview.chromium.org/959713003 Cr-Commit-Position: refs/heads/master@{#26873}
-
- 23 Feb, 2015 1 commit
-
-
machenbach authored
NOTRY=true TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/948003002 Cr-Commit-Position: refs/heads/master@{#26798}
-
- 23 Jan, 2015 1 commit
-
-
machenbach authored
This reverts commit 9ae1c238. BUG=chromium:446166 LOG=n NOTRY=true TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/868093002 Cr-Commit-Position: refs/heads/master@{#26254}
-
- 22 Jan, 2015 1 commit
-
-
machenbach authored
BUG=chromium:446166 LOG=n Review URL: https://codereview.chromium.org/865153003 Cr-Commit-Position: refs/heads/master@{#26224}
-
- 09 Jan, 2015 1 commit
-
-
Jochen Eisinger authored
R=machenbach@chromium.org LOG=y BUG=none Review URL: https://codereview.chromium.org/809803007 Cr-Commit-Position: refs/heads/master@{#26011}
-
- 23 Dec, 2014 1 commit
-
-
jochen authored
BUG=none LOG=n R=ulan@chromium.org Review URL: https://codereview.chromium.org/820033002 Cr-Commit-Position: refs/heads/master@{#25936}
-
- 10 Nov, 2014 1 commit
-
-
machenbach@chromium.org authored
R=jkummerow@chromium.org TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/681113011 Cr-Commit-Position: refs/heads/master@{#25237} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25237 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Sep, 2014 1 commit
-
-
jochen@chromium.org authored
BUG=none LOG=n R=danno@chromium.org Review URL: https://codereview.chromium.org/612823003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24302 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Sep, 2014 2 commits
-
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24227 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24213 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Sep, 2014 2 commits
-
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24156 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24153 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Sep, 2014 2 commits
-
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24084 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24059 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Sep, 2014 2 commits
-
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24053 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24028 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Sep, 2014 3 commits
-
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24014 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24004 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23993 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Sep, 2014 3 commits
-
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23987 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23983 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23967 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Sep, 2014 1 commit
-
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23946 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Sep, 2014 1 commit
-
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23927 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Sep, 2014 3 commits
-
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23919 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23907 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23892 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Sep, 2014 1 commit
-
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23885 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Sep, 2014 2 commits
-
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23849 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
v8-autoroll@chromium.org authored
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23831 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-