- 20 Jan, 2016 8 commits
-
-
hablich authored
Revert of [builtins] Migrate Object.getOwnPropertyDescriptor to C++. (patchset #1 id:1 of https://codereview.chromium.org/1606783002/ ) Reason for revert: Breaks roll: https://codereview.chromium.org/1603953002/ Original issue's description: > [builtins] Migrate Object.getOwnPropertyDescriptor to C++. > > The implementation of Object.getOwnPropertyDescriptor always called into > C++ anyway, so there's no need to have this JavaScript wrapper around at > all. > > R=yangguo@chromium.org > > Committed: https://crrev.com/3fdd37b028f4711d0f6dcb038f575ce08ef0cfa3 > Cr-Commit-Position: refs/heads/master@{#33379} TBR=yangguo@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review URL: https://codereview.chromium.org/1609023003 Cr-Commit-Position: refs/heads/master@{#33404}
-
hablich authored
Revert of [runtime] Introduce maps for the likely cases of FromPropertyDescriptor. (patchset #1 id:1 of https://codereview.chromium.org/1607943003/ ) Reason for revert: Predecessor CL suspect for roll breakage: https://codereview.chromium.org/1610563002 Original issue's description: > [runtime] Introduce maps for the likely cases of FromPropertyDescriptor. > > This change improves performance for the common case of > Object.getOwnPropertyDescriptor by up 3x-4x, where we just > return a property descriptor object for a regular data or > accessor property. > > R=yangguo@chromium.org > > Committed: https://crrev.com/ffa9e82235b20c523ebb1151c6196bc6232296b9 > Cr-Commit-Position: refs/heads/master@{#33398} TBR=yangguo@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1604243002 Cr-Commit-Position: refs/heads/master@{#33403}
-
mstarzinger authored
This removes the above flag definition. The flag is no longer needed as the default implementation is more than capable of faking presence of handling of try-catch and try-finally constructs by now. R=rmcilroy@chromium.org BUG=v8:4674 LOG=n Review URL: https://codereview.chromium.org/1603063003 Cr-Commit-Position: refs/heads/master@{#33402}
-
mstarzinger authored
R=oth@chromium.org Review URL: https://codereview.chromium.org/1608693004 Cr-Commit-Position: refs/heads/master@{#33401}
-
mstarzinger authored
This implements a first version of exception handler table construction within the interpreter. Note that the local control flow for try-catch and try-finally statements is still off, and also stack unwinding does not yet respect interpreter frames. But generated handler tables should be populated correctly already. R=oth@chromium.org BUG=v8:4674 LOG=n Review URL: https://codereview.chromium.org/1607433005 Cr-Commit-Position: refs/heads/master@{#33400}
-
hablich authored
Revert of [runtime] Migrate Object.getOwnPropertyNames to C++. (patchset #2 id:20001 of https://codereview.chromium.org/1605803002/ ) Reason for revert: Breaks roll: https://codereview.chromium.org/1603953002/ Original issue's description: > [runtime] Migrate Object.getOwnPropertyNames to C++. > > The Object.getOwnPropertyNames method always calls into C++ anyway, > so there's no point in having the JavaScript wrapper around at all. > > Drive-by-fix: Inline GetOwnEnumerablePropertyNames into its single > call site. > > R=yangguo@chromium.org > > Committed: https://crrev.com/bf027fe756f62b4abcac8aa08134c8c5ed055620 > Cr-Commit-Position: refs/heads/master@{#33380} TBR=yangguo@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review URL: https://codereview.chromium.org/1609173002 Cr-Commit-Position: refs/heads/master@{#33399}
-
bmeurer authored
This change improves performance for the common case of Object.getOwnPropertyDescriptor by up 3x-4x, where we just return a property descriptor object for a regular data or accessor property. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1607943003 Cr-Commit-Position: refs/heads/master@{#33398}
-
v8-autoroll authored
Rolling v8/tools/clang to 9c45873bbb82dc33f5f88f5c7dbc06ee9ecc7e8f TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1610483002 Cr-Commit-Position: refs/heads/master@{#33397}
-
- 19 Jan, 2016 19 commits
-
-
adamk authored
The old handling of escaped keywords erroneously treated escaped versions of "let" and "static" as ESCAPED_KEYWORD, leading to erroneous errors in sloppy mode. Moreover, though the class literal parsing code attempted to fix up the parsing of escaped versions of "static" to allow it in the right places, that code wasn't complete. Fixing the scanner to mark escaped "static" as ESCAPED_STRICT_RESERVED_WORD allows simplifying the class literal parsing code. A little extra code was needed to properly handle the new treatment of escaped "let". Note that "yield" is still broken (that is, we're overly restrictive of escaped "yield" in sloppy mode). Review URL: https://codereview.chromium.org/1602013007 Cr-Commit-Position: refs/heads/master@{#33396}
-
mlippautz authored
The dust has settled and it can now be used like any other header file R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1605973002 Cr-Commit-Position: refs/heads/master@{#33395}
-
hpayer authored
Revert of Tenure descriptor arrays. (patchset #1 id:1 of https://codereview.chromium.org/1526663002/ ) Reason for revert: Regresses memory consumption. BUG=571180,571657 LOG=n Original issue's description: > Tenure descriptor arrays. > > BUG= > > Committed: https://crrev.com/74bc69166de8cfb967e79b5c8cc31c2a76490dc8 > Cr-Commit-Position: refs/heads/master@{#32846} TBR=ishell@chromium.org,ulan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review URL: https://codereview.chromium.org/1606003002 Cr-Commit-Position: refs/heads/master@{#33394}
-
littledan authored
This patch implements one aspect of ES2015 RegExp subclassing: String.prototype.replace is separated into two parts, a method on RegExp.prototype in case the first argument is a RegExp, and the String.prototype.replace method, which handles the string pattern case. This separation is described in the ES2015 specification. Most of the patch is simply moving code from string.js to regexp.js. R=yangguo LOG=Y BUG=v8:4343 Review URL: https://codereview.chromium.org/1590673002 Cr-Commit-Position: refs/heads/master@{#33393}
-
mbrandy authored
Port fc53eed1 Original commit message: The new operator converts a float32 input to int32 through truncation. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1593333006 Cr-Commit-Position: refs/heads/master@{#33392}
-
machenbach authored
BUG=chromium:535160 LOG=n TBR=tandrii@chromium.org Review URL: https://codereview.chromium.org/1607503002 Cr-Commit-Position: refs/heads/master@{#33391}
-
balazs.kilvady authored
BUG= Review URL: https://codereview.chromium.org/1608933003 Cr-Commit-Position: refs/heads/master@{#33390}
-
oth authored
o Adds wide variants of bytecodes that have operands describing ranges of registers. The upcoming wide register support does not suppport re-mapping ranges. o Adds kRegPair16 and kRegTriple16 operands required for new wide bytecodes and renames Count8/Count16 operands to RegCount8/RegCount16. o Removes Exchange bytecodes BUG=v8:4675 LOG=NO Review URL: https://codereview.chromium.org/1595103006 Cr-Commit-Position: refs/heads/master@{#33389}
-
rmcilroy authored
Fixes a bug where the context would be popped before labeled block break target location. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1601153002 Cr-Commit-Position: refs/heads/master@{#33388}
-
ivica.bogosavljevic authored
Newly added tests cctest/test-run-wasm-js/Run_JSSelect_0...6 cause failures on MIPS bigendian and are skipped until a solution is found. BUG= Review URL: https://codereview.chromium.org/1608813003 Cr-Commit-Position: refs/heads/master@{#33387}
-
jkummerow authored
This is the ia32/x64 version of https://codereview.chromium.org/873703002, which fixed the same problem on arm/arm64. BUG=chromium:553441 LOG=n R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1604913002 Cr-Commit-Position: refs/heads/master@{#33386}
-
nikolaos authored
After 1564083002, spread expressions are desugared and should not survive in the AST after parsing. This patch removes dead code related to this. It also eliminates the kSpread bailout reason and the concat_iterable_to_array_builtin. R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/1592713002 Cr-Commit-Position: refs/heads/master@{#33385}
-
rmcilroy authored
Now that we support eval in Ignition, remove the fallback for eval checks and make the flag only fallback on catch blocks. BUG=v8:4280,v8:4676 LOG=N Review URL: https://codereview.chromium.org/1595223004 Cr-Commit-Position: refs/heads/master@{#33384}
-
jkummerow authored
Automate ALL the repetitive workflows! Drive-by: fix 'interpreter' watchlist definition. NOTRY=true Review URL: https://codereview.chromium.org/1589633007 Cr-Commit-Position: refs/heads/master@{#33383}
-
mlippautz authored
This reverts commit 7cf64f40. Tanks octane. Will use a different approach here. BUG=chromium:578871, chromium:524425 LOG=N TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/1605813004 Cr-Commit-Position: refs/heads/master@{#33382}
-
titzer authored
R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1604603002 Cr-Commit-Position: refs/heads/master@{#33381}
-
bmeurer authored
The Object.getOwnPropertyNames method always calls into C++ anyway, so there's no point in having the JavaScript wrapper around at all. Drive-by-fix: Inline GetOwnEnumerablePropertyNames into its single call site. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1605803002 Cr-Commit-Position: refs/heads/master@{#33380}
-
bmeurer authored
The implementation of Object.getOwnPropertyDescriptor always called into C++ anyway, so there's no need to have this JavaScript wrapper around at all. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1606783002 Cr-Commit-Position: refs/heads/master@{#33379}
-
v8-autoroll authored
Rolling v8/tools/clang to c3b604840a63c06fa1c0c652119860e97fd57abe TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1601523006 Cr-Commit-Position: refs/heads/master@{#33378}
-
- 18 Jan, 2016 13 commits
-
-
verwaest authored
The old mechanism was a left-over from a previous time where the runtime would rely on the presence or absence of the setter to figure out whether or not the property is mutable. This is unnecessary by now. Review URL: https://codereview.chromium.org/1600923002 Cr-Commit-Position: refs/heads/master@{#33377}
-
verwaest authored
Previously MakeModuleExport invalidly set "all-can-*" to true. Also module export setters need to throw (in strict-mode) according to ES6 9.4.6.6 and 9.4.6.9. BUG= Review URL: https://codereview.chromium.org/1602753002 Cr-Commit-Position: refs/heads/master@{#33376}
-
Ben L. Titzer authored
R=jkummerow@chromium.org BUG= Review URL: https://codereview.chromium.org/1603683002 . Cr-Commit-Position: refs/heads/master@{#33375}
-
titzer authored
R=ahaas@chromium.org,bradnelson@chromium.org BUG= Review URL: https://codereview.chromium.org/1601843002 Cr-Commit-Position: refs/heads/master@{#33374}
-
mstarzinger authored
This adds a handler table field to the header of our BytecodeArray objects. The field will eventually hold a range-based handler table similar to full-codegen code, to support exception handlong within interpreted code. R=oth@chromium.org BUG=v8:4674 LOG=n Review URL: https://codereview.chromium.org/1606493002 Cr-Commit-Position: refs/heads/master@{#33373}
-
titzer authored
LOG=Y BUG=chromium:575167 Review URL: https://codereview.chromium.org/1576953002 Cr-Commit-Position: refs/heads/master@{#33372}
-
mythria authored
VisitObjectLiteral has two parts. First it creates a literal and then sets properties or accessor properties. Setting properties requires a runtime call and it expects the literal object which was created in the first part is contiguous with other registers it allocates. Since these are allocated in a different scope they are not always contiguous. This causes problems with mjsunit/setter-on-constructor-prototype.js. This cl fixes by allocating contiguous registers in the inner scope. Literal value is copied into the newly allocated register so that all the required registers are always contiguous. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1588903002 Cr-Commit-Position: refs/heads/master@{#33371}
-
Ben L. Titzer authored
R=ahaas@chromium.org BUG= Review URL: https://codereview.chromium.org/1608543002 . Cr-Commit-Position: refs/heads/master@{#33370}
-
ahaas authored
Revert of [turbofan] Implement rounding of floats on x64 and ia32 without sse4.1. (patchset #2 id:20001 of https://codereview.chromium.org/1584663007/ ) Reason for revert: Code is incorrect for -0. Original issue's description: > [turbofan] Implement rounding of floats on x64 and ia32 without sse4.1. > > The implementation sets the rounding mode flag and then uses the > cvtsd2si and cvtsi2sd instructions (convert between float and int) to do > the rounding. Input values outside int range either don't have to be > rounded anyways, or are rounded by calculating input + 2^52 - 2^52 for > positive inputs, or input -2^52 + 2^52 for negative inputs. The original > rounding mode is restored afterwards. > > R=titzer@chromium.org > > B=575379 > > Committed: https://crrev.com/fa5d09e547abe79a8c82f780deb980c53ad78beb > Cr-Commit-Position: refs/heads/master@{#33367} TBR=titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1593313010 Cr-Commit-Position: refs/heads/master@{#33369}
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1601743002 Cr-Commit-Position: refs/heads/master@{#33368}
-
ahaas authored
The implementation sets the rounding mode flag and then uses the cvtsd2si and cvtsi2sd instructions (convert between float and int) to do the rounding. Input values outside int range either don't have to be rounded anyways, or are rounded by calculating input + 2^52 - 2^52 for positive inputs, or input -2^52 + 2^52 for negative inputs. The original rounding mode is restored afterwards. R=titzer@chromium.org B=575379 Review URL: https://codereview.chromium.org/1584663007 Cr-Commit-Position: refs/heads/master@{#33367}
-
titzer authored
R=bradnelson@chromium.org, ahaas@chromium.org LOG=Y BUG=chromium:575372 Review URL: https://codereview.chromium.org/1573213002 Cr-Commit-Position: refs/heads/master@{#33366}
-
nikolaos authored
This became temporarily a big issue, because spreads are desugared into do-expressions. This patch fixes the problem with having spreads as parameter initializers in arrow expressions, e.g., this line would crash: [], ((x = [...[42]]) => x)(); R=rossberg@chromium.org BUG=chromium:578038 LOG=N Review URL: https://codereview.chromium.org/1581403007 Cr-Commit-Position: refs/heads/master@{#33365}
-