1. 13 Feb, 2019 1 commit
  2. 31 Jan, 2019 1 commit
  3. 23 Jan, 2019 1 commit
  4. 21 Jan, 2019 2 commits
  5. 18 Jan, 2019 1 commit
  6. 14 Jan, 2019 1 commit
    • Camillo Bruni's avatar
      Reland "[parser] Inline byte scope data into PreparseData object" · a6f44629
      Camillo Bruni authored
      This is a reland of e2d44ede
      
      Original change's description:
      > [parser] Inline byte scope data into PreparseData object
      > 
      > Each PreparseData object had at least one pointer to a PodArray for its
      > serialized scope data. These objects usually have only tens of bytes of
      > payload. By inlining the byte data we save 3 words per PreparseData object.
      > This optimization saves 140KB of data on cnn.com.
      > 
      > 
      > - Store data_length and inner_length as int32 saving a words on 64bit
      > - Inline store byte data into PreparseData
      > - OnHeapConsumedPreparseData directly uses the PreparseData object
      > - get_inner, set_inner no longer allow Null sentinels
      > 
      > Change-Id: I1f62154d05ea2f98a6574efa738b32a8a84319d5
      > Reviewed-on: https://chromium-review.googlesource.com/c/1406673
      > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#58751}
      
      Change-Id: I1f0a22c641d0d67f435b01c82daf8da7f144bff4
      Reviewed-on: https://chromium-review.googlesource.com/c/1407066Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58785}
      a6f44629
  7. 11 Jan, 2019 2 commits
    • Maya Lekova's avatar
      Revert "[parser] Inline byte scope data into PreparseData object" · 1ec1712c
      Maya Lekova authored
      This reverts commit e2d44ede.
      
      Reason for revert: Breaks GC stress tests - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/23527
      
      Original change's description:
      > [parser] Inline byte scope data into PreparseData object
      > 
      > Each PreparseData object had at least one pointer to a PodArray for its
      > serialized scope data. These objects usually have only tens of bytes of
      > payload. By inlining the byte data we save 3 words per PreparseData object.
      > This optimization saves 140KB of data on cnn.com.
      > 
      > 
      > - Store data_length and inner_length as int32 saving a words on 64bit
      > - Inline store byte data into PreparseData
      > - OnHeapConsumedPreparseData directly uses the PreparseData object
      > - get_inner, set_inner no longer allow Null sentinels
      > 
      > Change-Id: I1f62154d05ea2f98a6574efa738b32a8a84319d5
      > Reviewed-on: https://chromium-review.googlesource.com/c/1406673
      > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#58751}
      
      TBR=ulan@chromium.org,cbruni@chromium.org,leszeks@chromium.org
      
      Change-Id: I39d92ee7bd2864e1b0c3a8fed4a11b68b3e14d58
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Reviewed-on: https://chromium-review.googlesource.com/c/1407073Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
      Commit-Queue: Maya Lekova <mslekova@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58753}
      1ec1712c
    • Camillo Bruni's avatar
      [parser] Inline byte scope data into PreparseData object · e2d44ede
      Camillo Bruni authored
      Each PreparseData object had at least one pointer to a PodArray for its
      serialized scope data. These objects usually have only tens of bytes of
      payload. By inlining the byte data we save 3 words per PreparseData object.
      This optimization saves 140KB of data on cnn.com.
      
      
      - Store data_length and inner_length as int32 saving a words on 64bit
      - Inline store byte data into PreparseData
      - OnHeapConsumedPreparseData directly uses the PreparseData object
      - get_inner, set_inner no longer allow Null sentinels
      
      Change-Id: I1f62154d05ea2f98a6574efa738b32a8a84319d5
      Reviewed-on: https://chromium-review.googlesource.com/c/1406673Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Camillo Bruni <cbruni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58751}
      e2d44ede
  8. 07 Jan, 2019 1 commit
  9. 21 Dec, 2018 2 commits
  10. 04 Dec, 2018 1 commit
  11. 24 Nov, 2018 1 commit
  12. 17 Oct, 2018 1 commit
  13. 16 Oct, 2018 1 commit
  14. 07 Sep, 2018 2 commits
    • Ross McIlroy's avatar
      [Parser] Split building logic out of ProducedPreParserScopeData. · 83dee31e
      Ross McIlroy authored
      Splits PreParsedScopeDataBuilder out of ProducedPreParserScopeData to make the split between
      building PreParsedScopeData and using already build PreParserScopeData more explicit.
      
      BUG=v8:8041
      
      Change-Id: Iab42cab84c247152c14ac39f3136f985753160ec
      Reviewed-on: https://chromium-review.googlesource.com/1202104
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55718}
      83dee31e
    • Ross McIlroy's avatar
      [Parser] Add support for Zone allocated ConsumedPreParsingScopeData. · 8da9dbbb
      Ross McIlroy authored
      Adds support for zone allocated (off-heap) ConsumedPreParsingScopeData to
      enable worker-thread access to PreParsingScopeData during parallel IIFE
      compile tasks.
      
      In order to avoid code-duplication, a templated
      BaseConsumedPreParsingScopeData is added which implements the logic for
      decoding the bytestream into scope data. Two implementations of this
      base class are instantiated for each of the underlying serialized scope date:
        - ZoneConsumedPreParsedScopeData for exposing ZonePreParsedScopeData
        - OnHeapConsumedPreParsedScopeData for exposing on-heap PreParsedScopeData
      The interface for each of these classes is the ConsumedPreParsingScopeData,
      which exposes the methods required by the parser to deserialize the required
      data.
      
      As a side-cleanup, moved Ucs2CharLength and Utf8LengthHelper implementations
      to cc file so that we don't get a linker error if one of them are unused by
      the cc file including the header.
      
      
      BUG=v8:8041
      
      Change-Id: Id502312d32fe4a9ddb6f5d2d9d3e3a9d30b9b27d
      Reviewed-on: https://chromium-review.googlesource.com/1199462
      Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55711}
      8da9dbbb