- 04 Apr, 2018 7 commits
-
-
Peter Marshall authored
Don't dispatch based on the construct_stub field anymore. Rather than read it out and jump to the construct stub, we can switch on the builtin_id. Builtins will always have builtin_id as a Smi, so this signals we need to jump to JSBuiltinsConstructStub. The only exception is for uncompiled functions, which will have kCompileLazy as the builtin_id, but need to jump to the generic stub instead. API function calls will have a FunctionTemplateInfo in the SFI function_data field, and need to go to the builtins stub as well. The final case is everything else, which should go to the generic stub. Bug: v8:7503 Change-Id: I14790a5f9784dc0d940bf10a05f5310026e1d482 Reviewed-on: https://chromium-review.googlesource.com/980941Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#52345}
-
Michael Achenbach authored
This reverts commit 9a7e9cf2. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds/14341 Original change's description: > Enable cfi-icall on the v8 CFI bots > > BUG=v8:7164 > > Change-Id: I7522ba6ac2bde89c84bcd49bc116a432091a2938 > Reviewed-on: https://chromium-review.googlesource.com/990802 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52343} TBR=machenbach@chromium.org,clemensh@chromium.org,vtsyrklevich@chromium.org Change-Id: Id979a20d28445e05c6c2266614bb6ea1d6560ef6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7164 Reviewed-on: https://chromium-review.googlesource.com/995292Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52344}
-
Vlad Tsyrklevich authored
BUG=v8:7164 Change-Id: I7522ba6ac2bde89c84bcd49bc116a432091a2938 Reviewed-on: https://chromium-review.googlesource.com/990802 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52343}
-
Andreas Haas authored
The tests are flaky at the moment. CC=clemensh@chromium.org R=machenbach@chromium.org No-Try: true Change-Id: Ifc56116ebbe44d92c726c973e2beb8a1ec996379 Reviewed-on: https://chromium-review.googlesource.com/995092Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#52342}
-
Sigurd Schneider authored
Bug: v8:7584 Change-Id: I7443c28c74676ee1f27550674c8f712594e21cc7 Reviewed-on: https://chromium-review.googlesource.com/992314Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52341}
-
Sigurd Schneider authored
This CL allows builtin continuations to handle pending exceptions. This implements exception handling for the promise constructor in case of deoptimization. Bug: v8:7584 Change-Id: Ib5df5eb6606abb3f9690f294397981858dbdbf25 Reviewed-on: https://chromium-review.googlesource.com/983912 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#52340}
-
Andrey Lushnikov authored
This patch teaches Runtime.callFunctionOn to run evals inside its task. This is aligned with how Runtime.evaluate works. R=kozy Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3189beebc9020703d2b2e23a7c828a2394d43910 Reviewed-on: https://chromium-review.googlesource.com/994070 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52339}
-
- 03 Apr, 2018 25 commits
-
-
Clemens Hammacher authored
This reverts commit dbdede01. Reason for revert: Fails webkit_tests, blocks roll: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064 Original change's description: > Implement a new spec for timezone offset calculation > > https://github.com/tc39/ecma262/pull/778 was recently merged > to Ecma 262. > > It changes the way to convert between "local time" and UTC in such > a way that it'd work for all timezones whether or not there has > been any change in the timezone offset of the standard time. For > instance, Europe/Moscow and some parts of US state of Indiana have > changed the standard (non-DST) timezone offset a few times. The > previous spec assumes that the the standard timezone offset is > constant, but the new spec take into account the offset change > history. > > In addition, it specifies a new way to calculate the timezone > offset during a timezone transition (either in and > out of DST or timezone offset shift). > > During a negative transition (e.g. fall backward / getting > out of DST), repeated times are to be interpreted as if the > offset before the transition is in effect. > > During a positive transition (e.g. spring forward / getting > into DST), skipped times are to be treated similarly. That > is, they are to be interpreted as if the offset before the > transition is in effect. > > With icu-timezone-data, v8 is compliant to the new spec for the > past and the future as well as now whether or not the standard > timezone offset of a given timezone has changed over time > (e.g. Europe/Moscow, Pacific/Apia). With icu-timezone-data, > Australia/Lord_Howe (30 minute DST change) also works per spec. > > Without icu-timezone-data, it works only for timezones of which > the standard timezone offset is the same as the current offset > (e.g. most North American timezones other than parts of Indiana) > and of which the DST shift is an hour. For instance, it doesn't work > for Europe/Moscow in 2010 when the standard timezone offset was > +4h because the current (2018) standard timezone offset is +3h. Neither > does it for Lord Howe in Australia with the DST shift of 0.5 hr. > > This CL used to require one of the two ICU CLs below, but not > any more. > > https://chromium-review.googlesource.com/c/chromium/deps/icu/+/572652 > https://chromium-review.googlesource.com/851265 (a proposed CL to the > upstream ICU). > > Bug: v8:3547,chromium:417640,v8:5714 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Ib162295da5bee31b2390bd0918157014aebd3e33 > Reviewed-on: https://chromium-review.googlesource.com/572148 > Commit-Queue: Jungshik Shin <jshin@chromium.org> > Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52332} TBR=adamk@chromium.org,littledan@chromium.org,mlippautz@chromium.org,jshin@chromium.org Change-Id: I6b3bf4427c761b106280d565a3912cd8e25cf87e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:3547, chromium:417640, v8:5714 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/994192Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52338}
-
Sathya Gunasekaran authored
This reverts commit cd1dd34f. Patchset 1 is the original CL that was reverted. Patchset 2 has the fix. TBR=bmeurer@chromium.org Bug: v8:7611 Change-Id: I15291175ab894ef667c001e1b21b8b220e1f9b48 Reviewed-on: https://chromium-review.googlesource.com/993995Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#52337}
-
Nico Weber authored
This instance of `pragma optimize` was from long ago when we built with frame pointers disabled. We always build with frame pointers on these days. (Also, clang-cl ignores this pragma and will warn about it.) Bug: chromium:505314 Change-Id: Ia125c9c54e6ec486247241102de1cb62c72d268b Reviewed-on: https://chromium-review.googlesource.com/993423 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#52336}
-
Ben Smith authored
This change implements the WebAssembly.Global object and constructor, but none of the accessors or functions. There is a new flag to enable this: --experimental-wasm-mut-global. Change-Id: Ifeb270d57392d7ca0900c80c0038932c96ee8b61 Reviewed-on: https://chromium-review.googlesource.com/989296 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#52335}
-
Eric Holk authored
This reverts commit 0cd7468b. Reason for revert: Blocks v8 roll into chromium: https://crbug.com/828499 Original change's description: > [wasm] Always enable guard regions on 64-bit platforms > > This change makes full 8 GiB guard regions always enabled on 64-bit > platforms. > > Additionally, since all Wasm memory allocation paths have some form of > guard regions, this removes and simplifies most of the logic around > whether to enable guard regions. > > R=gdeepti@chromium.org > > Change-Id: Idf3fbcc11ac70ea2ee7eb88c2173d6a1410395e1 > Reviewed-on: https://chromium-review.googlesource.com/985142 > Commit-Queue: Eric Holk <eholk@chromium.org> > Reviewed-by: Brad Nelson <bradnelson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52310} TBR=bradnelson@chromium.org,gdeepti@chromium.org,eholk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I126b5afe283a4fe08adfa301e637d2641c29cccd Reviewed-on: https://chromium-review.googlesource.com/993160Reviewed-by: Eric Holk <eholk@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#52334}
-
Ulan Degenbaev authored
This patch enables ShouldOptimizeForMemoryUsage if the old generation size is within 1/8th of the max old generation size. This patch also passes the reduce-memory flag to incremental marking whenever ShouldOptimizeForMemoryUsage is enabled. Bug: chromium:824214 Change-Id: I5cfc0566ca0e23dfa1b8c0439a4e67424ddc852d Reviewed-on: https://chromium-review.googlesource.com/973524 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52333}
-
Jungshik Shin authored
https://github.com/tc39/ecma262/pull/778 was recently merged to Ecma 262. It changes the way to convert between "local time" and UTC in such a way that it'd work for all timezones whether or not there has been any change in the timezone offset of the standard time. For instance, Europe/Moscow and some parts of US state of Indiana have changed the standard (non-DST) timezone offset a few times. The previous spec assumes that the the standard timezone offset is constant, but the new spec take into account the offset change history. In addition, it specifies a new way to calculate the timezone offset during a timezone transition (either in and out of DST or timezone offset shift). During a negative transition (e.g. fall backward / getting out of DST), repeated times are to be interpreted as if the offset before the transition is in effect. During a positive transition (e.g. spring forward / getting into DST), skipped times are to be treated similarly. That is, they are to be interpreted as if the offset before the transition is in effect. With icu-timezone-data, v8 is compliant to the new spec for the past and the future as well as now whether or not the standard timezone offset of a given timezone has changed over time (e.g. Europe/Moscow, Pacific/Apia). With icu-timezone-data, Australia/Lord_Howe (30 minute DST change) also works per spec. Without icu-timezone-data, it works only for timezones of which the standard timezone offset is the same as the current offset (e.g. most North American timezones other than parts of Indiana) and of which the DST shift is an hour. For instance, it doesn't work for Europe/Moscow in 2010 when the standard timezone offset was +4h because the current (2018) standard timezone offset is +3h. Neither does it for Lord Howe in Australia with the DST shift of 0.5 hr. This CL used to require one of the two ICU CLs below, but not any more. https://chromium-review.googlesource.com/c/chromium/deps/icu/+/572652 https://chromium-review.googlesource.com/851265 (a proposed CL to the upstream ICU). Bug: v8:3547,chromium:417640,v8:5714 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ib162295da5bee31b2390bd0918157014aebd3e33 Reviewed-on: https://chromium-review.googlesource.com/572148 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#52332}
-
Igor Sheludko authored
Bug: chromium:827013 Change-Id: I07a04cbe278b35dcd822d71d0a39a19aa9b46eb3 Reviewed-on: https://chromium-review.googlesource.com/993053 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52331}
-
Ben Smith authored
This is a follow-up to https://chromium-review.googlesource.com/981687. When a wasm function has a large stack frame, the x64 code generator performs the stack overflow check before constructing the frame. This requires the use of the `address_of_real_stack_limit` external reference. This reference is thread local, so if it is not relocated the stack overflow check will always fail. Bug: chromium:808848 Change-Id: I0edf3fe5a006242fc50d0bff44cd9dd0e7d85bd9 Reviewed-on: https://chromium-review.googlesource.com/982906 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#52330}
-
Clemens Hammacher authored
This adds a systematic test for binary operations on different sets of registers. By loading a number of values from memory to locals, we create a cache state where all registers are used to hold local variables. We then pick two of them and perform a binary operation on them. R=titzer@chromium.org Bug: v8:7589, v8:6600 Change-Id: I2a4855810bb5c39247688c43cbe9d12d64fbc181 Reviewed-on: https://chromium-review.googlesource.com/992412 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52329}
-
Erik Luo authored
Makes CallHandlerInfo its own instance type, with an additional map to distinguish side-effect-free handlers. In a followup, we can expose an API flag to set the map. This CL does not support whitelisting calls to ObjectTemplates that use SetCallAsFunctionHandler(). Bug: v8:7515 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ie32fe144046a9fae3e3b1ea5602b0da3db8a5616 Reviewed-on: https://chromium-review.googlesource.com/965741Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#52328}
-
Clemens Hammacher authored
On ia32, the implementation of 64-bit shifts first moved {src} into {dst}, then {amount} into {ecx}. This fails if {dst} overlaps {amount}, because {amount} would be overwritten before being used. Just changing the order to these two moves would also not be correct, since {src} can contain {ecx}. Thus, implement this via a general parallel register move, which resolves cycles automatically. R=titzer@chromium.org Bug: v8:7589, v8:6600 Change-Id: I2556b9aa66a89a067372b7713dbbb3d71d2f923f Reviewed-on: https://chromium-review.googlesource.com/981134 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52327}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:773297 Change-Id: Icbff53ed84b72d74f1db9884b3b846b8ff72686b No-Try: true No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/992317Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#52326}
-
Ulan Degenbaev authored
The destructor of the owner of a phantom handle must clear the phantom handle first before calling any function that can trigger GC. Bug: chromium:827806 Change-Id: I20141d0d710c486aec3d92e729d76a53069e16fd Reviewed-on: https://chromium-review.googlesource.com/992093Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#52325}
-
Ivica Bogosavljevic authored
Summary of work done: * Simplify complicated CompareAndBranch instructions * Mark BC1EQZ and BC1NEZ as compact branches in simulator * Remove unneeded nops for BC1EQZ and BC1NEZ * Block trampolines for delay slot of BC1T and BC1F Change-Id: I86f3a497e6e9ac73075bb51653c2d4c6ab8454b9 Reviewed-on: https://chromium-review.googlesource.com/986260 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by: Sreten Kovacevic <sreten.kovacevic@mips.com> Cr-Commit-Position: refs/heads/master@{#52324}
-
Sigurd Schneider authored
This reverts commit 12420537. Reason for revert: MSAN complains https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/20527 Original change's description: > [heap] fix Sweeper::kNumberOfSweepingSpaces > > When indexing into vectors of sweeping spaces, convert the > AllocationSpace to an index (by subtracting FIRST_GROWABLE_PAGED_SPACE) > to avoid wasted space at the start. > > Change-Id: Ia23fe6dae42d5accea9f7fe7ec5c3b303ef857b4 > Reviewed-on: https://chromium-review.googlesource.com/978242 > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52320} TBR=hpayer@chromium.org,delphick@chromium.org Change-Id: I9894dc10f122c9fab409e08b2a45389f1f51748f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/992152Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52323}
-
Sigurd Schneider authored
Builtin continuation frames know their height now. This is prework to allow UnwindAndFindHandler to reconstructor the stack pointer for the ContinueToBuiltin trampoline. Bug: v8:7584 Change-Id: If1361f5bbac130c284cd46c0d39cc81e2df613d3 Reviewed-on: https://chromium-review.googlesource.com/983633Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52322}
-
Yang Guo authored
R=leszeks@chromium.org Bug: v8:7591 Change-Id: Idcd2d586ab279dc070d2cfb2558298ebdd3ce33b Reviewed-on: https://chromium-review.googlesource.com/991873 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#52321}
-
Dan Elphick authored
When indexing into vectors of sweeping spaces, convert the AllocationSpace to an index (by subtracting FIRST_GROWABLE_PAGED_SPACE) to avoid wasted space at the start. Change-Id: Ia23fe6dae42d5accea9f7fe7ec5c3b303ef857b4 Reviewed-on: https://chromium-review.googlesource.com/978242Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#52320}
-
Sergiy Byelozyorov authored
This reverts commit 0258a061. Reason for revert: breaks perfbots, e.g. https://luci-milo.appspot.com/buildbot/internal.client.v8/v8_arm64_perf/21485 Original change's description: > [test] Add JSTest benchmark for object literal spread > > Bug: v8:7611 > Change-Id: Ia5467fd4da3b385568bcc3f3fdc1a8c56bd6340e > Reviewed-on: https://chromium-review.googlesource.com/987321 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52313} TBR=gsathya@chromium.org,bmeurer@chromium.org Change-Id: I4a0e8da965b784739f821ff2c3bba742e70a4b7f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7611 Reviewed-on: https://chromium-review.googlesource.com/992092Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#52319}
-
Yang Guo authored
This ensures that we have gatekeepers for API changes. R=adamk@chromium.org Change-Id: I7a78f9590dfc444a20044fe323b9470f4f9004a3 Reviewed-on: https://chromium-review.googlesource.com/986267 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#52318}
-
Camillo Bruni authored
Bug: chromium:794998 Change-Id: Ib607bc891625db686fe37cfe416c3abf4ddf9a2b Reviewed-on: https://chromium-review.googlesource.com/983777Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#52317}
-
Andreas Haas authored
When we know that the imported JavaScript function, and we cannot generate a direct call because the parameter count does not match, then we can call directly to the ArgumentsAdaptor instead of the Call builtin. R=bmeurer@chromium.org Change-Id: I72882c2edf170d88135d12352852302d56cc54a5 Reviewed-on: https://chromium-review.googlesource.com/986095Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#52316}
-
Benedikt Meurer authored
When peeking into descriptor arrays (for Function.prototype.bind inlining), we need to check the number of descriptors rather than the length of the DescriptorArray. Bug: chromium:825045 Change-Id: I55dbe1544e5e4cb8e23d873961c71ed12294d89c Reviewed-on: https://chromium-review.googlesource.com/991812Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52315}
-
Benedikt Meurer authored
This reverts commit 6031412e. Reason for revert: Tanks quite a few benchmarks (crbug.com/827854). Original change's description: > [x64] Reuse scratch register for ExternalReference > > This reduces CEntryStub code size by 64 bytes, and reduces CallApiCallbackStub > by 27 bytes. > > Change-Id: I46479077f61fdae6b260ca28c67df3509dee5c1a > Reviewed-on: https://chromium-review.googlesource.com/963652 > Commit-Queue: Kanghua Yu <kanghua.yu@intel.com> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52005} TBR=bmeurer@chromium.org,kanghua.yu@intel.com Bug: chromium:827854 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ief0905a7bdba86f7b9fd20888eecdfd58bc6ea7d Reviewed-on: https://chromium-review.googlesource.com/991712Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52314}
-
- 02 Apr, 2018 2 commits
-
-
Sathya Gunasekaran authored
Bug: v8:7611 Change-Id: Ia5467fd4da3b385568bcc3f3fdc1a8c56bd6340e Reviewed-on: https://chromium-review.googlesource.com/987321Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#52313}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:773297 Change-Id: I51a9cff42adb477bc089a869741e34513426e5b6 Reviewed-on: https://chromium-review.googlesource.com/989715 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#52312}
-
- 31 Mar, 2018 1 commit
-
-
Ben Noordhuis authored
Remove a call to `icu::toUCharPtr()` that wasn't present in other similar looking call sites either, just reinterpret_cast directly. Fixes https://github.com/nodejs/node/issues/19656. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If281ce0a39356aa8bd20efb24c3e4b52b06841a3 Reviewed-on: https://chromium-review.googlesource.com/987953Reviewed-by: Daniel Ehrenberg <littledan@chromium.org> Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl> Cr-Commit-Position: refs/heads/master@{#52311}
-
- 30 Mar, 2018 5 commits
-
-
Eric Holk authored
This change makes full 8 GiB guard regions always enabled on 64-bit platforms. Additionally, since all Wasm memory allocation paths have some form of guard regions, this removes and simplifies most of the logic around whether to enable guard regions. R=gdeepti@chromium.org Change-Id: Idf3fbcc11ac70ea2ee7eb88c2173d6a1410395e1 Reviewed-on: https://chromium-review.googlesource.com/985142 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by: Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#52310}
-
Reid Kleckner authored
crtdbg.h provides the declarations for _CrtSetReportMode and the _CRT_* constants. It should have moved in https://chromium-review.googlesource.com/968244, but the MSVC C++ headers appear to include crtdbg.h transitively, so we only noticed this on the libc++ Windows buildbot. Tbr: mlippautz@chromium.org Bug: chromium:801780 Change-Id: Ia07f6136e4b8d1f25014e00b0b9f662029ab5a2b Reviewed-on: https://chromium-review.googlesource.com/981399 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#52309}
-
sreten.kovacevic authored
Bug: v8:6600 Change-Id: Ieec3b7b9fcfd278c844c9591164e14247743e218 Reviewed-on: https://chromium-review.googlesource.com/987852Reviewed-by: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#52308}
-
Jakob Kummerow authored
This is a reland of 16aecc5d Intent to ship: https://groups.google.com/d/msg/v8-users/ShhW0Xewph0/1-OT9q0_DQAJ Originally reviewed at: Reviewed-on: https://chromium-review.googlesource.com/981596 Bug: v8:6791 Change-Id: I772af807b9486081d7cd96b538bf5bc98d4dcffe Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng;luci.v8.try:v8_linux_blink_rel Reviewed-on: https://chromium-review.googlesource.com/984857Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#52307}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org Bug: chromium:616879 No-Try: true Change-Id: I55d89aa3ef4cd2a112fd6ff3b4e977d73117c747 Reviewed-on: https://chromium-review.googlesource.com/983414 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#52306}
-