1. 06 Aug, 2020 2 commits
    • Tobias Tebbi's avatar
      Reland "[torque] typed context slot access" · 6647f292
      Tobias Tebbi authored
      This is a reland of 408e7240
      Change: Allow CSA load elimination accross code comments
      
      Original change's description:
      > [torque] typed context slot access
      >
      > This introduces a new type Slot<ContextType, SlotType> that is used
      > for enum values used to access context slots.
      > Together with new types for the various custom contexts used in
      > Torque, this results in fairly type-safe access to context slots,
      > including the NativeContext's slots.
      >
      > Drive-by changes:
      > - Introduce a new header file to specify headers needed for
      >   generated CSA headers, to reduce the amount of includes specified
      >   in implementation-visitor.cc
      > - Port AllocateSyntheticFunctionContext to Torque.
      >
      > Bug: v8:7793
      > Change-Id: I509a128916ca408eeeb636a9bcc376b2cc868532
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335064
      > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
      > Reviewed-by: Seth Brenith <seth.brenith@microsoft.com>
      > Cr-Commit-Position: refs/heads/master@{#69249}
      
      Bug: v8:7793
      Change-Id: I1fe100d8d62e8220524eddb8ecc4faa85219748d
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339462Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#69264}
      6647f292
    • Jakob Gruber's avatar
      Revert "[torque] typed context slot access" · a55a2447
      Jakob Gruber authored
      This reverts commit 408e7240.
      
      Reason for revert: debug builds fail
      
      is_component_build = true
      is_debug = true
      use_goma = true
      v8_enable_backtrace = true
      v8_enable_debugging_features = true
      v8_enable_fast_mksnapshot = true
      v8_enable_slow_dchecks = true
      v8_enable_snapshot_code_comments = true
      v8_enable_verify_csa = true
      v8_optimized_debug = false
      v8_use_multi_snapshots = false
      
      # Fatal error in ../../src/compiler/backend/instruction-selector.cc, line 3088
      # Expected Turbofan static assert to hold, but got non-true input:
        static_assert(nativeContext == LoadNativeContext(context)) at src/builtins/promise-resolve.tq:45:5
      
      
      Original change's description:
      > [torque] typed context slot access
      > 
      > This introduces a new type Slot<ContextType, SlotType> that is used
      > for enum values used to access context slots.
      > Together with new types for the various custom contexts used in
      > Torque, this results in fairly type-safe access to context slots,
      > including the NativeContext's slots.
      > 
      > Drive-by changes:
      > - Introduce a new header file to specify headers needed for
      >   generated CSA headers, to reduce the amount of includes specified
      >   in implementation-visitor.cc
      > - Port AllocateSyntheticFunctionContext to Torque.
      > 
      > Bug: v8:7793
      > Change-Id: I509a128916ca408eeeb636a9bcc376b2cc868532
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335064
      > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
      > Reviewed-by: Seth Brenith <seth.brenith@microsoft.com>
      > Cr-Commit-Position: refs/heads/master@{#69249}
      
      TBR=tebbi@chromium.org,seth.brenith@microsoft.com
      
      Change-Id: I90c014022a808449aca4a9b9b3c3b8e036beb28e
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:7793
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2340903Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#69256}
      a55a2447
  2. 05 Aug, 2020 1 commit
    • Tobias Tebbi's avatar
      [torque] typed context slot access · 408e7240
      Tobias Tebbi authored
      This introduces a new type Slot<ContextType, SlotType> that is used
      for enum values used to access context slots.
      Together with new types for the various custom contexts used in
      Torque, this results in fairly type-safe access to context slots,
      including the NativeContext's slots.
      
      Drive-by changes:
      - Introduce a new header file to specify headers needed for
        generated CSA headers, to reduce the amount of includes specified
        in implementation-visitor.cc
      - Port AllocateSyntheticFunctionContext to Torque.
      
      Bug: v8:7793
      Change-Id: I509a128916ca408eeeb636a9bcc376b2cc868532
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2335064
      Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
      Reviewed-by: 's avatarSeth Brenith <seth.brenith@microsoft.com>
      Cr-Commit-Position: refs/heads/master@{#69249}
      408e7240
  3. 03 Jul, 2020 1 commit
  4. 09 Jun, 2020 1 commit
  5. 12 May, 2020 1 commit
  6. 07 May, 2020 1 commit
  7. 06 May, 2020 1 commit
  8. 10 Jan, 2020 1 commit
  9. 08 Jan, 2020 3 commits
    • Joshua Litt's avatar
      Revert "Reland "Reland "[promises] Port Promise.race to Torque.""" · e5e8685c
      Joshua Litt authored
      This reverts commit d6556fbd.
      
      Reason for revert: ugh, accidentally submitted this
      
      Original change's description:
      > Reland "Reland "[promises] Port Promise.race to Torque.""
      > 
      > This reverts commit 2225d242.
      > 
      > Reason for revert: clusterfuzz fixed
      > 
      > Original change's description:
      > > Revert "Reland "[promises] Port Promise.race to Torque.""
      > > 
      > > This reverts commit 766aeb99.
      > > 
      > > Reason for revert: clusterfuzz
      > > Bug: chromium:1040238
      > > 
      > > Original change's description:
      > > > Reland "[promises] Port Promise.race to Torque."
      > > >
      > > > Fixes clusterfuzz bug.
      > > >
      > > > This is a reland of 15ec4a09
      > > >
      > > > Original change's description:
      > > > > [promises] Port Promise.race to Torque.
      > > > >
      > > > > Bug: v8:9838
      > > > > Change-Id: Iee3bcaa3a7149309c01d16be67d189ccc56bd0e8
      > > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965919
      > > > > Commit-Queue: Joshua Litt <joshualitt@chromium.org>
      > > > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > > > > Cr-Commit-Position: refs/heads/master@{#65562}
      > > >
      > > > Bug: v8:9838
      > > > Change-Id: Id295a12023195511289d92517936733ab22cdf4b
      > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1988542
      > > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > > > Commit-Queue: Joshua Litt <joshualitt@chromium.org>
      > > > Cr-Commit-Position: refs/heads/master@{#65613}
      > > 
      > > TBR=jgruber@chromium.org,tebbi@chromium.org,joshualitt@chromium.org
      > > 
      > > 
      > > Bug: v8:9838
      > > Change-Id: I1d14eae04ee228806f69b489ab2d86e87fec1ae5
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991808
      > > Reviewed-by: Joshua Litt <joshualitt@chromium.org>
      > > Auto-Submit: Joshua Litt <joshualitt@chromium.org>
      > > Commit-Queue: Joshua Litt <joshualitt@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#65649}
      > 
      > TBR=jgruber@chromium.org,tebbi@chromium.org,joshualitt@chromium.org
      > 
      > Change-Id: I9dda79c99070478443db1a2d8190bd27b4e990d3
      > No-Presubmit: true
      > No-Tree-Checks: true
      > No-Try: true
      > Bug: chromium:1040238, v8:9838
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1992605
      > Reviewed-by: Joshua Litt <joshualitt@chromium.org>
      > Commit-Queue: Joshua Litt <joshualitt@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#65650}
      
      TBR=jgruber@chromium.org,tebbi@chromium.org,joshualitt@chromium.org
      
      Change-Id: I8cf8909e4e4d9ec59fd80eaa6804a8421b0626a6
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:1040238, v8:9838
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1992606Reviewed-by: 's avatarJoshua Litt <joshualitt@chromium.org>
      Commit-Queue: Joshua Litt <joshualitt@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65651}
      e5e8685c
    • Joshua Litt's avatar
      Reland "Reland "[promises] Port Promise.race to Torque."" · d6556fbd
      Joshua Litt authored
      This reverts commit 2225d242.
      
      Reason for revert: clusterfuzz fixed
      
      Original change's description:
      > Revert "Reland "[promises] Port Promise.race to Torque.""
      > 
      > This reverts commit 766aeb99.
      > 
      > Reason for revert: clusterfuzz
      > Bug: chromium:1040238
      > 
      > Original change's description:
      > > Reland "[promises] Port Promise.race to Torque."
      > >
      > > Fixes clusterfuzz bug.
      > >
      > > This is a reland of 15ec4a09
      > >
      > > Original change's description:
      > > > [promises] Port Promise.race to Torque.
      > > >
      > > > Bug: v8:9838
      > > > Change-Id: Iee3bcaa3a7149309c01d16be67d189ccc56bd0e8
      > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965919
      > > > Commit-Queue: Joshua Litt <joshualitt@chromium.org>
      > > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > > > Cr-Commit-Position: refs/heads/master@{#65562}
      > >
      > > Bug: v8:9838
      > > Change-Id: Id295a12023195511289d92517936733ab22cdf4b
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1988542
      > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > > Commit-Queue: Joshua Litt <joshualitt@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#65613}
      > 
      > TBR=jgruber@chromium.org,tebbi@chromium.org,joshualitt@chromium.org
      > 
      > 
      > Bug: v8:9838
      > Change-Id: I1d14eae04ee228806f69b489ab2d86e87fec1ae5
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991808
      > Reviewed-by: Joshua Litt <joshualitt@chromium.org>
      > Auto-Submit: Joshua Litt <joshualitt@chromium.org>
      > Commit-Queue: Joshua Litt <joshualitt@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#65649}
      
      TBR=jgruber@chromium.org,tebbi@chromium.org,joshualitt@chromium.org
      
      Change-Id: I9dda79c99070478443db1a2d8190bd27b4e990d3
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:1040238, v8:9838
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1992605Reviewed-by: 's avatarJoshua Litt <joshualitt@chromium.org>
      Commit-Queue: Joshua Litt <joshualitt@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65650}
      d6556fbd
    • Joshua Litt's avatar
      Revert "Reland "[promises] Port Promise.race to Torque."" · 2225d242
      Joshua Litt authored
      This reverts commit 766aeb99.
      
      Reason for revert: clusterfuzz
      Bug: chromium:1040238
      
      Original change's description:
      > Reland "[promises] Port Promise.race to Torque."
      >
      > Fixes clusterfuzz bug.
      >
      > This is a reland of 15ec4a09
      >
      > Original change's description:
      > > [promises] Port Promise.race to Torque.
      > >
      > > Bug: v8:9838
      > > Change-Id: Iee3bcaa3a7149309c01d16be67d189ccc56bd0e8
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1965919
      > > Commit-Queue: Joshua Litt <joshualitt@chromium.org>
      > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#65562}
      >
      > Bug: v8:9838
      > Change-Id: Id295a12023195511289d92517936733ab22cdf4b
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1988542
      > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
      > Commit-Queue: Joshua Litt <joshualitt@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#65613}
      
      TBR=jgruber@chromium.org,tebbi@chromium.org,joshualitt@chromium.org
      
      
      Bug: v8:9838
      Change-Id: I1d14eae04ee228806f69b489ab2d86e87fec1ae5
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991808Reviewed-by: 's avatarJoshua Litt <joshualitt@chromium.org>
      Auto-Submit: Joshua Litt <joshualitt@chromium.org>
      Commit-Queue: Joshua Litt <joshualitt@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65649}
      2225d242
  10. 07 Jan, 2020 1 commit
  11. 06 Jan, 2020 1 commit
  12. 27 Dec, 2019 1 commit