- 08 Aug, 2016 1 commit
-
-
jgruber authored
Revert of Fix an OOB read through CallSite.GetFunctionName (patchset #1 id:1 of https://codereview.chromium.org/2199333002/ ) Reason for revert: We can revert this now that it's landed on 5.3. Original issue's description: > Fix an OOB read through CallSite.GetFunctionName > > The func_index parameter passed to GetWasmFunctionNameFromTable can be > user-controlled through the CallSite constructor. Catch out-of-bounds > reads and return null as the function name in such cases. > > This applies to the 5.3 branch and will be reverted on TOT in a bit. > > BUG=632965 > > Committed: https://crrev.com/8592c450a68581d7257c1b2002983c0092cd749a > Cr-Commit-Position: refs/heads/master@{#38276} TBR=ahaas@chromium.org,yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=632965 Review-Url: https://codereview.chromium.org/2225773002 Cr-Commit-Position: refs/heads/master@{#38414}
-
- 03 Aug, 2016 1 commit
-
-
jgruber authored
The func_index parameter passed to GetWasmFunctionNameFromTable can be user-controlled through the CallSite constructor. Catch out-of-bounds reads and return null as the function name in such cases. This applies to the 5.3 branch and will be reverted on TOT in a bit. BUG=632965 Review-Url: https://codereview.chromium.org/2199333002 Cr-Commit-Position: refs/heads/master@{#38276}
-
- 14 Jun, 2016 1 commit
-
-
clemensh authored
The function name table will now always be set; a CHECK will fail if the length would exceed the integer range. Also, the resolution of undefined function names to "<WASM UNNAMED>" is moved over to the wasm side. R=titzer@chromium.org Committed: https://crrev.com/3400ee9f4f21a455b7850ec42a4182a3c0eba310 Review-Url: https://codereview.chromium.org/2057523002 Cr-Original-Commit-Position: refs/heads/master@{#36918} Cr-Commit-Position: refs/heads/master@{#36952}
-
- 13 Jun, 2016 2 commits
-
-
machenbach authored
Revert of [wasm] Refactor function name table and lookup (patchset #2 id:20001 of https://codereview.chromium.org/2057523002/ ) Reason for revert: [Sheriff] Speculative revert for flaky gc stress crashes, e.g.: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/6592 https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/6143 Original issue's description: > [wasm] Refactor function name table and lookup > > The function name table will now always be set; a CHECK will fail if > the length would exceed the integer range. > Also, the resolution of undefined function names to "<WASM UNNAMED>" is > moved over to the wasm side. > > R=titzer@chromium.org > > Committed: https://crrev.com/3400ee9f4f21a455b7850ec42a4182a3c0eba310 > Cr-Commit-Position: refs/heads/master@{#36918} TBR=titzer@chromium.org,clemensh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2062793002 Cr-Commit-Position: refs/heads/master@{#36925}
-
clemensh authored
The function name table will now always be set; a CHECK will fail if the length would exceed the integer range. Also, the resolution of undefined function names to "<WASM UNNAMED>" is moved over to the wasm side. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2057523002 Cr-Commit-Position: refs/heads/master@{#36918}
-
- 24 May, 2016 1 commit
-
-
mtrofin authored
Moved globals offsets calculation to the wasm module decoder, since this is a property of the module, not of each instance. Qualified as "const" references to WasmModule outside of the decoder and some test situations. BUG= Review-Url: https://codereview.chromium.org/2005933003 Cr-Commit-Position: refs/heads/master@{#36484}
-
- 19 May, 2016 1 commit
-
-
clemensh authored
Empty function names are allowed and are output as such, unnamed functions or functions with no valid UTF-8 name are output as "<WASM UNNAMED>", while the CallSite object returns null as the function name. R=titzer@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/1970503004 Cr-Commit-Position: refs/heads/master@{#36348}
-
- 12 May, 2016 1 commit
-
-
clemensh authored
Names passed for imports and exports are checked during decoding, leading to errors if they are no valid UTF-8. Function names are not checked during decode, but rather lead to undefined being returned at runtime if they are not UTF-8. We need to do these checks on the Wasm side, since the factory methods assume to get valid UTF-8 strings. R=titzer@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/1967023004 Cr-Commit-Position: refs/heads/master@{#36208}
-
- 29 Apr, 2016 1 commit
-
-
clemensh authored
We now store the wasm object and the function index in the deoptimization data of the wasm Code object, and store an array with function names in the wasm object. This will make both the wasm module as well as the respective function name available from the code object. Tests will follow in https://codereview.chromium.org/1916403002. R=titzer@chromium.org, mstarzinger@chromium.org, machenbach@chromium.org Review-Url: https://codereview.chromium.org/1912103002 Cr-Commit-Position: refs/heads/master@{#35905}
-