- 25 Oct, 2017 1 commit
-
-
Michael Lippautz authored
This reverts commit e26cd874. Reason for revert: The issue has been fixed. See related bug for description and CLs. Original change's description: > [heap] Add TSAN suppression for lock-order inversion in Scavenger > > The Scavenger currently requires taking the lock for OLD->NEW processing > and can also take another lock for sweeping a different page. > > Since order of pages during scavenge and sweep is unstable this may > result in lock order inversion reports on TSAN when long-running > programms are only executed on a single thread. > > The report is a false positve, hence flag it as suppression until we > redesign this particular piece. > > No-try: true > Bug: v8:6923 > Change-Id: I82355be1c8d83ea61cc21152aeb10b58b1dc4b86 > Reviewed-on: https://chromium-review.googlesource.com/716261 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#48504} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:6923 Change-Id: I7711466c6e2175dcab8d64d6a642e458e1cde3f5 Reviewed-on: https://chromium-review.googlesource.com/738110Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#48913}
-
- 12 Oct, 2017 1 commit
-
-
Michael Lippautz authored
The Scavenger currently requires taking the lock for OLD->NEW processing and can also take another lock for sweeping a different page. Since order of pages during scavenge and sweep is unstable this may result in lock order inversion reports on TSAN when long-running programms are only executed on a single thread. The report is a false positve, hence flag it as suppression until we redesign this particular piece. No-try: true Bug: v8:6923 Change-Id: I82355be1c8d83ea61cc21152aeb10b58b1dc4b86 Reviewed-on: https://chromium-review.googlesource.com/716261Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#48504}
-
- 09 Oct, 2014 2 commits
-
-
jochen@chromium.org authored
TBR=machenbach@chromium.org LOG=n BUG=none Review URL: https://codereview.chromium.org/646493002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24487 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
Also suppress a deliberate lock cycle in test-lockers BUG=none R=glider@chromium.org, machenbach@chromium.org LOG=n Review URL: https://codereview.chromium.org/642023002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24484 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-