- 03 Sep, 2015 1 commit
-
-
bmeurer authored
This turns the has_instance_call_handler bit on Map into an is_callable bit, that matches the spec definition of IsCallable (i.e. instances have [[Call]] internal methods). Also fix the typeof operator to properly say "function" for everything that is callable. Also remove the (unused) premature %_GetPrototype optimization from Crankshaft, which just complicated the Map bit swap. R=mstarzinger@chromium.org, rossberg@chromium.org, yangguo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg Review URL: https://codereview.chromium.org/1316933002 Cr-Commit-Position: refs/heads/master@{#30552}
-
- 01 Sep, 2015 1 commit
-
-
mstarzinger authored
This CL us a pure refactoring that makes an empty compilation unit including just "isolate.h" or "contexts.h" but not "objects-inl.h" compile without warnings or errors. This is needed to further reduce the header dependency tangle. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1322883002 Cr-Commit-Position: refs/heads/master@{#30500}
-
- 10 Jul, 2015 1 commit
-
-
verwaest authored
Revert preallocating of descriptors since right now getters and setters cause copying of descriptor arrays BUG= Review URL: https://codereview.chromium.org/1225213008 Cr-Commit-Position: refs/heads/master@{#29579}
-
- 03 Jul, 2015 1 commit
-
-
verwaest authored
Additionally speed up instantiation of ObjectTemplates by preallocating enough space in the descriptor arrays BUG=v8:4184 LOG=n Review URL: https://codereview.chromium.org/1218403002 Cr-Commit-Position: refs/heads/master@{#29468}
-
- 17 Jun, 2015 2 commits
-
-
machenbach authored
Revert of Added constructor call on object in InstantiateObject method (patchset #5 id:80001 of https://codereview.chromium.org/1137693003/) Reason for revert: [Sheriff] This breaks layout test expectations: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/builds/437 See: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_32/437/layout-test-results/fast/dom/create-element-after-stack-overflow-pretty-diff.html Please land a needsmanualrebaseline change on the blink-side before relanding this, if the change was intended. Please include a blink trybot on relanding this. Original issue's description: > Added constructor call on object in InstantiateObject method > > I found after upgrading from 4.2.2 where apinatives.js still > existed to 4.4.56 where everything had been converted to C++ in > api-natives.cc, my constructors for ObjectTemplate instantiated objects > were no longer being called. After investigation, I noticed in > apinatives.js that a new call would handle that, but there was no > corresponding constructor call in api-natives.cc (or anywhere else > along the chain of InstantiateObject), so I added a call to > Execution::Call to actually construct the object. Forgive me if that > isn't the right place to add it (InitializeBody in objects-inl.h also > looked like a good place), or if there's a reason constructors are > not being called. > > I also added myself to the AUTHORS file in this CL. > > Committed: https://crrev.com/e61a957b2a9726294cdd2802a6a2b6e3a9ef657d > Cr-Commit-Position: refs/heads/master@{#29076} TBR=verwaest@chromium.org,svenpanne@chromium.org,dtalley@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1188233002 Cr-Commit-Position: refs/heads/master@{#29085}
-
dtalley authored
I found after upgrading from 4.2.2 where apinatives.js still existed to 4.4.56 where everything had been converted to C++ in api-natives.cc, my constructors for ObjectTemplate instantiated objects were no longer being called. After investigation, I noticed in apinatives.js that a new call would handle that, but there was no corresponding constructor call in api-natives.cc (or anywhere else along the chain of InstantiateObject), so I added a call to Execution::Call to actually construct the object. Forgive me if that isn't the right place to add it (InitializeBody in objects-inl.h also looked like a good place), or if there's a reason constructors are not being called. I also added myself to the AUTHORS file in this CL. Review URL: https://codereview.chromium.org/1137693003 Cr-Commit-Position: refs/heads/master@{#29076}
-
- 12 Jun, 2015 2 commits
-
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1178893002 Cr-Commit-Position: refs/heads/master@{#29004}
-
verwaest authored
Reland of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (patchset #3 id:40001 of https://codereview.chromium.org/1178503004/) BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1180943002 Cr-Commit-Position: refs/heads/master@{#29000}
-
- 11 Jun, 2015 2 commits
-
-
ishell authored
Revert of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (patchset #3 id:40001 of https://codereview.chromium.org/1178503004/) Reason for revert: Blocks revert of https://codereview.chromium.org/1175973002 Original issue's description: > Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. > > @yangguo: please look at the debugger part of the CL. > @ishell: please look at the rest. > > Additionally: > - Ensure the LookupIterator for named properties does not accidentally get indexes in. > - Fix the return value for typed array assignments to be the incoming value. > > BUG=v8:4137 > LOG=n > > Committed: https://crrev.com/15aa811f8fe2708a757c3b53ca89db736aa8b222 > Cr-Commit-Position: refs/heads/master@{#28954} TBR=yangguo@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4137 Review URL: https://codereview.chromium.org/1181733002 Cr-Commit-Position: refs/heads/master@{#28957}
-
verwaest authored
@yangguo: please look at the debugger part of the CL. @ishell: please look at the rest. Additionally: - Ensure the LookupIterator for named properties does not accidentally get indexes in. - Fix the return value for typed array assignments to be the incoming value. BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1178503004 Cr-Commit-Position: refs/heads/master@{#28954}
-
- 12 May, 2015 3 commits
-
-
yangguo authored
R=mvstanton@chromium.org Committed: https://crrev.com/8608e619afe2b4514b0577bfb73a153b1550d41f Cr-Commit-Position: refs/heads/master@{#28357} Review URL: https://codereview.chromium.org/1126043004 Cr-Commit-Position: refs/heads/master@{#28366}
-
yangguo authored
Revert of Migrate error messages, part 10. (patchset #2 id:20001 of https://codereview.chromium.org/1126043004/) Reason for revert: patch didn't apply correctly. Original issue's description: > Migrate error messages, part 10. > > R=mvstanton@chromium.org > > Committed: https://crrev.com/8608e619afe2b4514b0577bfb73a153b1550d41f > Cr-Commit-Position: refs/heads/master@{#28357} TBR=mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1130073005 Cr-Commit-Position: refs/heads/master@{#28358}
-
yangguo authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1126043004 Cr-Commit-Position: refs/heads/master@{#28357}
-
- 21 Apr, 2015 1 commit
-
-
svenpanne authored
Baby steps towards saner #includes... Review URL: https://codereview.chromium.org/1051393003 Cr-Commit-Position: refs/heads/master@{#27958}
-
- 09 Mar, 2015 1 commit
-
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/988283003 Cr-Commit-Position: refs/heads/master@{#27066}
-
- 02 Mar, 2015 1 commit
-
-
Sven Panne authored
BUG=v8:3929 LOG=y R=dcarney@chromium.org Review URL: https://codereview.chromium.org/958053003 Cr-Commit-Position: refs/heads/master@{#26937}
-
- 06 Feb, 2015 1 commit
-
-
dcarney authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/901923002 Cr-Commit-Position: refs/heads/master@{#26481}
-
- 04 Feb, 2015 1 commit
-
-
dcarney authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/895053002 Cr-Commit-Position: refs/heads/master@{#26426}
-