Skip to content

V
V8
Switch branch/tag
  1. 11 Mar, 2015 1 commit
  3. 10 Mar, 2015 1 commit
    • arv's avatar
      [es6] Throw TypeError for computed static prototype property name · 8d946b9c
      arv authored 
      The prototype of a class constructor function is read only. When we set
computed property names we were ignoring this and we were overriding the
property.

Since the prototype is the only possible own read only property on the
constructor function object we special case this so we do not have to
check this for every property in the class literal.

BUG=v8:3945
LOG=N
R=mstarzinger@chromium.org, dslomov@chromium.org

Review URL: https://codereview.chromium.org/985643003

Cr-Commit-Position: refs/heads/master@{#27106}
      8d946b9c
  5. 06 Mar, 2015 1 commit
  7. 05 Mar, 2015 2 commits
  9. 04 Mar, 2015 2 commits
  11. 02 Mar, 2015 1 commit
  13. 28 Feb, 2015 1 commit
  15. 25 Feb, 2015 1 commit
  17. 24 Feb, 2015 1 commit
  19. 18 Feb, 2015 2 commits
  21. 17 Feb, 2015 1 commit
  23. 14 Feb, 2015 1 commit
  25. 12 Feb, 2015 2 commits
  27. 11 Feb, 2015 7 commits
  29. 10 Feb, 2015 1 commit
    • marja's avatar
      Parsing: Make Scope not know about Isolate. · 5d68529b
      marja authored 
      Scope, like Parser, must be able to operate independent of Isolate and the V8
heap (for background parsing). After the heap-independent phase, there is a heap
dependent phase, during which we do operations such as scope anaylysis.

This CL makes the phases explicit by not telling Scope about the Isolate too
early (during the heap-independent phase, Scope should know nothing about
Isolate). This decreases the probability of accidental code changes which would
add heap-dependent operations into the heap-independent phase.

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/909093003

Cr-Commit-Position: refs/heads/master@{#26546}
      5d68529b
  31. 05 Feb, 2015 2 commits
  33. 04 Feb, 2015 4 commits
  35. 03 Feb, 2015 2 commits
  37. 30 Jan, 2015 4 commits
  39. 29 Jan, 2015 1 commit
    • arv's avatar
      Move object literal checking into checker classes · b004b1d8
      arv authored 
      This removes the duplicate property check from object literals.

Instead we repurpose the ObjectLiteralChecker into two cases, implemented
by two subclasses to ObjectLiteralCheckerBase called ObjectLiteralChecker
and ClassLiteralChecker.

The object literal checker now only checks for duplicate __proto__ fields in
object literals.

The class literal checker checks for duplicate constructors, non constructor
fields named constructor as well as static properties named prototype.

BUG=v8:3819
LOG=Y
R=adamk, dslomov@chromium.org

Review URL: https://codereview.chromium.org/873823003

Cr-Commit-Position: refs/heads/master@{#26336}
      b004b1d8
  41. 28 Jan, 2015 2 commits