- 20 Dec, 2013 2 commits
-
-
svenpanne@chromium.org authored
This reverts r18383. The CL in itself is OK, we just have to wait until Chrome's commit queue lands the final corresponding change and re-land this CL. :-/ TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/119013004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18384 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
* Removed String::Empty, Number::New, Integer::New, Integer::NewFromUnsigned, FunctionTemplate::New and Object::New without Isolate* parameter. * Removed Integer::New and Integer::NewUnsigned with weird argument order. Chrome CLs matching this change are prepared, BTW. LOG=y BUG=324225 R=dcarney@chromium.org Review URL: https://codereview.chromium.org/118523003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18383 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Dec, 2013 1 commit
-
-
svenpanne@chromium.org authored
LOG=y R=dcarney@chromium.org Review URL: https://codereview.chromium.org/108063003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18342 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Dec, 2013 1 commit
-
-
verwaest@chromium.org authored
Fixed global object leak caused by overwriting the global receiver (the global proxy) in the global object with the global object itself. This CL additionally removes the API function to reattach a global proxy to a global object. BUG=324812 LOG=y R=dcarney@chromium.org, titzer@chromium.org Review URL: https://chromiumcodereview.appspot.com/101733002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18299 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Nov, 2013 1 commit
-
-
jochen@chromium.org authored
Also turn on deprecation warnings BUG=v8:3023 R=svenpanne@chromium.org, dcarney@chromium.org LOG=n Review URL: https://codereview.chromium.org/83343002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@18011 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Nov, 2013 1 commit
-
-
jochen@chromium.org authored
We can't deprecate the non-Isolate version yet but soon will. R=svenpanne@chromium.org, svenpanne@google.com BUG=266838 Review URL: https://codereview.chromium.org/70163002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17638 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Sep, 2013 2 commits
-
-
dcarney@chromium.org authored
TBR=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/24726002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16958 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/24508006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16957 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Sep, 2013 2 commits
-
-
dcarney@chromium.org authored
R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/24169005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16819 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/23534067 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16817 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Sep, 2013 1 commit
-
-
svenpanne@chromium.org authored
BUG= R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/23707009 Patch from Marja Hölttä <marja@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16493 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Jun, 2013 1 commit
-
-
dcarney@chromium.org authored
TBR=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/17336003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15237 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 May, 2013 1 commit
-
-
dcarney@chromium.org authored
R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/15964004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14849 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 May, 2013 1 commit
-
-
dcarney@chromium.org authored
BUG= TBR=svenpanne@chromium.org Review URL: https://codereview.chromium.org/14947005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14585 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 May, 2013 2 commits
-
-
mstarzinger@chromium.org authored
This reverts r14573 because of test failures in no-snapshot mode in the cctest/test-debug/ScriptCollectedEventContext test case. TBR=dcarney@chromium.org,svenpanne@chromium.org TEST=cctest/test-debug/ScriptCollectedEventContext Review URL: https://codereview.chromium.org/15038002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14578 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
BUG= TBR=marja@chromium.org Review URL: https://codereview.chromium.org/14793004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14573 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 May, 2013 1 commit
-
-
dcarney@chromium.org authored
R=svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/12729023 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14530 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Apr, 2013 1 commit
-
-
mstarzinger@chromium.org authored
This moves the responsibility of putting a new context into a persistent handle to the embedder. Also it removes one API function where the copy constructor for persistent handles is needed. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/13799003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14203 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Mar, 2013 1 commit
-
-
svenpanne@chromium.org authored
I tried to limit the use of v8::Isolate::GetCurrent() and v8::internal::Isolate::Current() as much as possible, but sometimes this would have involved restructuring tests quite a bit, which is better left for a separate CL. BUG=v8:2487 Review URL: https://codereview.chromium.org/12716010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13953 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Jan, 2013 1 commit
-
-
svenpanne@chromium.org authored
BUG=v8:2487 Review URL: https://codereview.chromium.org/12033011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13501 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Jan, 2013 1 commit
-
-
yangguo@chromium.org authored
BUG= Review URL: https://chromiumcodereview.appspot.com/11880018 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13371 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Dec, 2012 1 commit
-
-
yangguo@chromium.org authored
R=ulan@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11678006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13279 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Dec, 2012 1 commit
-
-
yangguo@chromium.org authored
BUG=v8:2340 Review URL: https://chromiumcodereview.appspot.com/11377158 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13188 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Nov, 2012 1 commit
-
-
rossberg@chromium.org authored
Modules now have their own local scope, represented by their own context. Module instance objects have an accessor for every export that forwards access to the respective slot from the module's context. (Exports that are modules themselves, however, are simple data properties.) All modules have a _hosting_ scope/context, which (currently) is the (innermost) enclosing global scope. To deal with recursion, nested modules are hosted by the same scope as global ones. For every (global or nested) module literal, the hosting context has an internal slot that points directly to the respective module context. This enables quick access to (statically resolved) module members by 2-dimensional access through the hosting context. For example, module A { let x; module B { let y; } } module C { let z; } allocates contexts as follows: [header| .A | .B | .C | A | C ] (global) | | | | | +-- [header| z ] (module) | | | +------- [header| y ] (module) | +------------ [header| x | B ] (module) Here, .A, .B, .C are the internal slots pointing to the hosted module contexts, whereas A, B, C hold the actual instance objects (note that every module context also points to the respective instance object through its extension slot in the header). To deal with arbitrary recursion and aliases between modules, they are created and initialized in several stages. Each stage applies to all modules in the hosting global scope, including nested ones. 1. Allocate: for each module _literal_, allocate the module contexts and respective instance object and wire them up. This happens in the PushModuleContext runtime function, as generated by AllocateModules (invoked by VisitDeclarations in the hosting scope). 2. Bind: for each module _declaration_ (i.e. literals as well as aliases), assign the respective instance object to respective local variables. This happens in VisitModuleDeclaration, and uses the instance objects created in the previous stage. For each module _literal_, this phase also constructs a module descriptor for the next stage. This happens in VisitModuleLiteral. 3. Populate: invoke the DeclareModules runtime function to populate each _instance_ object with accessors for it exports. This is generated by DeclareModules (invoked by VisitDeclarations in the hosting scope again), and uses the descriptors generated in the previous stage. 4. Initialize: execute the module bodies (and other code) in sequence. This happens by the separate statements generated for module bodies. To reenter the module scopes properly, the parser inserted ModuleStatements. R=mstarzinger@chromium.org,svenpanne@chromium.org BUG= Review URL: https://codereview.chromium.org/11093074 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13033 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Nov, 2012 1 commit
-
-
svenpanne@chromium.org authored
Review URL: https://codereview.chromium.org/11365224 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12945 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Nov, 2012 1 commit
-
-
svenpanne@chromium.org authored
Fixed visibility attribute for GetPointerFromInternalField Heavy cleanup of the external pointer API. Review URL: https://codereview.chromium.org/11359125 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12911 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 05 Nov, 2012 1 commit
-
-
svenpanne@chromium.org authored
Added highly efficient Object::SetAlignedPointerInInternalField and Object::GetAlignedPointerFromInternalField functions for 2-byte-aligned pointers. Their non-aligned counterparts Object::GetPointerFromInternalField and Object::SetPointerInInternalField are now deprecated utility functions. External is now a true Value again, with New/Value/Cast using a JSObject with an internal field containing a Foreign. External::Wrap, and External::Unwrap are now deprecated utility functions. Added Context::GetEmbedderData and Context::SetEmbedderData. Deprecated Context::GetData and Context::SetData, these are now only wrappers to access internal field 0. Added highly efficient Context::SetAlignedPointerInEmbedderData and Context::GetAlignedPointerFromEmbedderData functions for 2-byte-aligned pointers. Review URL: https://codereview.chromium.org/11190050 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12849 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Aug, 2012 2 commits
-
-
rossberg@chromium.org authored
- The global object has a reference to the current global scope chain. Running a script adds to the chain if it contains global lexical declarations. - Scripts are executed relative to a global, not a native context. - Harmony let and const bindings are allocated to the innermost global context; var and function still live on the global object. (Lexical bindings are not reflected on the global object at all, but that will probably change later using accessors, as for modules.) - Compilation of scripts now needs a (global) context (previously only eval did). - The global scope chain represents one logical scope, so collision tests take the chain into account. R=svenpanne@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/10872084 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12398 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
in preparation for global lexical scope. R=ulan@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10878007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12397 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Aug, 2012 1 commit
-
-
rossberg@chromium.org authored
R=ulan@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10872037 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@12374 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Jun, 2012 1 commit
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org TEST=cctest/test-decls/ExistsInHiddenPrototype Review URL: https://chromiumcodereview.appspot.com/10628002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11896 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Apr, 2012 1 commit
-
-
rossberg@chromium.org authored
R=mstarzinger@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10163003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11402 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Apr, 2012 1 commit
-
-
rossberg@chromium.org authored
I also discovered that our treatment of const declarations is inconsistent when inside a global eval under 'with' (i.e., when created by DeclareContextSlots). That is, var x; eval("const x = 9") and var x; eval("with({}) const x = 9") differ (the former assigns 9, the latter throws). This appears to be an oversight from earlier changes to our const semantics (the latter shouldn't throw either). Fixing this is a separate issue, though (and one that doesn't seem quite worthwhile). R=mstarzinger@chromium.org BUG=v8:1991,80591 TEST= Review URL: https://chromiumcodereview.appspot.com/10067010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11333 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Sep, 2011 1 commit
-
-
jkummerow@chromium.org authored
and make window.{Infinity,NaN,undefined} read-only as per ES5 BUG=89490 TEST=mjsunit/const-redecl.js, mjsunit/undeletable-functions.js, es5conform, sputnik Review URL: http://codereview.chromium.org/7811015 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9299 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Sep, 2011 2 commits
-
-
kmillikin@chromium.org authored
Committed incorrectly. TBR=ricow@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7890026 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9270 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
kmillikin@chromium.org authored
port r9260 (af9cfd83). Original commit message: We passed this flag around in a lot of places and had differenc call ICs based on it, but never did any real specialization based on its value. BUG= TEST= Review URL: http://codereview.chromium.org/7886028 Patch from Paul Lind <plind44@gmail.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9269 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Aug, 2011 1 commit
-
-
jkummerow@chromium.org authored
This reverts r8766. TEST=WebKit LayoutTests green again. Review URL: http://codereview.chromium.org/7562005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8800 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Aug, 2011 1 commit
-
-
jkummerow@chromium.org authored
as per ES5. BUG=89490 TEST=es5conform 15.1.*, 15.2.3.*; mjsunit/undeletable-functions Review URL: http://codereview.chromium.org/7538016 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8766 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Mar, 2011 2 commits
-
-
vitalyr@chromium.org authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7271 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
vitalyr@chromium.org authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@7269 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-