- 13 Mar, 2014 13 commits
-
-
dcarney@chromium.org authored
R=marja@chromium.org BUG= Review URL: https://codereview.chromium.org/198583003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19883 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
This reverts revision 19881. Reason: WebKit build failure (will commit a fixed version shortly). BUG= Review URL: https://codereview.chromium.org/196793013 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19882 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
- Distinguish between context bound scripts (Script) and context unbound scripts (UnboundScript). - Add ScriptCompiler (which will later contain functions for async compilation). This is a breaking change, in particular, Script::New no longer exists (it is replaced by ScriptCompiler::CompileUnbound). Script::Compile remains as a backwards-compatible shorthand for ScriptCompiler::Compile. Passing CompilerOptions with produce_data_to_cache = true doesn't do anything yet; the only way to generate the data to cache is the old preparsing API. (To be fixed in the next version.) BUG= R=dcarney@chromium.org Review URL: https://codereview.chromium.org/186723005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19881 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
R=marja@chromium.org BUG= Review URL: https://codereview.chromium.org/198713002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19880 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
BUG=v8:3204 LOG=y R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/195793016 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19878 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Drive-By-Fix: Improve ARM code generation for flooring division by power of 2. BUG=v8:3204 LOG=y R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/196653009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19877 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
This is another step towards getting rid of the bleeding edge change log file. Now it can be omitted in a follow up CL. R=jarin@chromium.org Review URL: https://codereview.chromium.org/197023004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19876 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yurys@chromium.org authored
There used to be additional pass in the heap profiler that estimated memory required for the snapshot and it used special implementation of the interface. Now that we dropped that step it doesn't makes sense to keep the interface with single implementation. BUG=None LOG=N R=loislo@chromium.org, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/194503002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19875 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jarin@chromium.org authored
The escape analysis calculates the number of slots in an object as no-of-slots = object-size / pointer-size. This gives 3 slots for heap numbers on 32-bit architectures (one slot for the map, two for the double value); however, my argument materialization code assumed just two slots (map + value). Since Hydrogen allocates heap numbers quite rarely, it is hard to produce a more meaningful repro than the one provided by Clusterfuzz. Any suggestions are welcome. The fix is simple - we just read out all extra slots (beyond the map and the double) for heap numbers. R=mstarzinger@chromium.org BUG=351315 LOG=N Review URL: https://codereview.chromium.org/196283004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19874 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
This is preparatory work to get rid of UnsafePersistent in blink. The previous version had to be reverted due to timeouts in win32/Debug: https://codereview.chromium.org/197173002/ The timeouts happened because the STL version on that platform contains sanity checking code which opens a 'debug window' in the GUI, patiently waiting for the user to click ok/cancel/somethirdoption. It turns out, the cause for that debug window was totally valid and the test had a use-after-free issue. The 1st patch set is the code as before. The 2nd patch set contains the fix. Related blink changes are here: https://codereview.chromium.org/180363004/ This patch is largely based on https://codereview.chromium.org/175503003/, with some methods added to support the blink change mentioned above. BUG= R=dcarney@chromium.org Review URL: https://codereview.chromium.org/197263002 Patch from Daniel Vogelheim <vogelheim@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19873 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
BUG=v8:3204 LOG=y R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/195023002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19872 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
R=jkummerow@chromium.org TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/195873008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19869 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
adamk@chromium.org authored
This re-re-re-lands enabling Object.observe. The Chromium tests that failed last time this was rolled into Chromium have been disabled in https://src.chromium.org/viewvc/chrome?view=revision&revision=256706 This patch should be safe to merge once that lands. BUG=v8:2409 LOG=Y TBR=rossberg@chromium.org,dslomov@chromium.org,rafaelw@chromium.org Review URL: https://codereview.chromium.org/198383002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19868 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Mar, 2014 27 commits
-
-
plind44@gmail.com authored
MIPS: Reland "Pass a Code object to Assembler::(set_)target_address_at for use by ool constant pool." Port r19856 (0546217) Original commit message: The ool constant pool will require a pointer to the code's constant pool when updating or reading target addresses using set_target_address_at() and target_address_at(). BUG= R=plind44@gmail.com Review URL: https://codereview.chromium.org/198163002 Patch from Balazs Kilvady <kilvadyb@homejinni.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19867 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
BUG=chromium:351787 LOG=y R=yangguo@chromium.org Review URL: https://codereview.chromium.org/197793003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19862 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
R=rossberg@chromium.org, rossberg BUG=v8:3126 LOG=N Review URL: https://codereview.chromium.org/196953004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19861 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rmcilroy@chromium.org authored
Ensure that relocinfo's host code object is correctly reset on GC in TypeFeedbackOracle::RelocateRelocInfos TBR=ulan@chromium.org Review URL: https://codereview.chromium.org/197593003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19860 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rodolph.perfetta@arm.com authored
BUG= R=jochen@chromium.org Review URL: https://codereview.chromium.org/196133005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19859 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rmcilroy@chromium.org authored
Adds FrameAndConstantPoolScope and ConstantPoolUnavailableScope to enable scoped management of constant pool availability. Also load constant pool pointer when entering an internal frame scope. R=rodolph.perfetta@arm.com, ulan@chromium.org Review URL: https://codereview.chromium.org/190793002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19858 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
alexandre.rames@arm.com authored
Mapping the code offsets between code with and without debug break slots requires information about the size of the veneer pools and constant pools. BUG=v8:3173 LOG=N R=ulan@chromium.org Review URL: https://codereview.chromium.org/188253005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19857 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rmcilroy@chromium.org authored
The ool constant pool will require a pointer to the code's constant pool when updating or reading target addresses using set_target_address_at() and target_address_at(). Original Review URL: https://codereview.chromium.org/183803022 R=ulan@chromium.org Review URL: https://codereview.chromium.org/195983002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19856 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
alexandre.rames@arm.com authored
R=ulan@chromium.org Review URL: https://codereview.chromium.org/194473005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19855 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mvstanton@chromium.org authored
The feedback vector is stored in the shared function info, and there is an effort to reuse it when re-running full code generation as a prelude to creating optimized code. However we shouldn't reuse the vector for lazily compiled methods on first compile, as scoping analysis can change the allocation of vector slots. BUG=351257 LOG=N R=danno@chromium.org, bmeuer@chromium.org Review URL: https://codereview.chromium.org/196723003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19854 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
- Up to now, mock expectations were simple lists of arguments + return value - These expectations are now modeled explicitly including the name of the mock (e.g. git or readline) - The optional test callback function is now explicitly named - This will allow merging all mock expectation types (e.g. git and readline) into a single list per test case (follow up CL) TEST=tools/push-to-trunk/script_test.py R=jarin@chromium.org Review URL: https://codereview.chromium.org/197313002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19853 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
Added a test to check the various division-like operations more exhaustively. R=bmeurer@chromium.org, ulan@chromium.org Review URL: https://codereview.chromium.org/194863002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19852 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
ReportUnexpectedToken already calls Traits::ReportMessageAt. If we're in Parser, that already suppresses the syntax error. If we're in PreParser, we don't need to suppress the syntax error (preparser errors don't go through Isolate, and having both stack overflow and a syntax error present is handled correctly by PreParserApi::PreParse). R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/197293003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19851 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
We should really split up the Lithium instruction, but this will be done in some future cleanup CL. Removed some "const"s for local variables on the way, they don't really help us much and just clutter up the code. R=ulan@chromium.org Review URL: https://codereview.chromium.org/196603004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19850 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
R=marja@chromium.org BUG= Review URL: https://codereview.chromium.org/197103002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19849 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG=351645 LOG=n R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/197043004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19848 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mvstanton@chromium.org authored
It's possible to get a transitioned map with no links to the origin map if it's a shared map. Code in KeyedStoreIC::StoreElementStub assumes it can check if two maps are in the same family by traversing the transition array. Long term, the "family" relationship should be recognized with the Normalized Map Cache. For now, allow the IC to remain monomorphic in this case if the receiver map and the previous receiver map are the same. Filed V8 issue 3210 (https://code.google.com/p/v8/issues/detail?id=3210) to track the issue with the Normalized Map Cache. BUG=350884 LOG=N R=verwaest@chromium.org Review URL: https://codereview.chromium.org/194623005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19847 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mvstanton@chromium.org authored
Also, less efficient code was generated because of negative keyed load offsets. I changed this to benefit from HLoadKeyed dehoisting. BUG=v8:3185 LOG=N R=yangguo@chromium.org Review URL: https://codereview.chromium.org/184103004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19846 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
marja@chromium.org authored
(For more details, see bug.) The problem occurs when a parsing function hits a stack overflow, but still manages to return something meaningful. This happens because the call to ParserBase::Next() which hits the stack overflow will still return a valid token (the last token which we had already read), and only the next call after the stack overflow will return INVALID. So for example ParseIdentifier will still return a valid identifier even if we've hit a stack overflow. In this case, some upper recursion level might detect and report a valid syntax error, and then we bail out of the recursive descent because of the syntax error. So we end up having both stack overflow and a syntax error present. When we try to report the stack overflow after parsing (e.g., end of ParseLazy), the isolate already has the syntax error as a pending exception, and a CHECK fails. This fix suppresses the syntax errors in when a stack overflow has been detected. BUG=351335 LOG=N R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/194713013 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19845 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
This is necessary to guarantee correct representation usage. Some unhandlified code still needs to be handlified before we can push this through fully. BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/194783002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19844 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
R=dslomov@google.com Review URL: https://codereview.chromium.org/196953003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19843 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
R=machenbach@chromium.org TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/197293002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19840 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
and "Win64 fix for r19833." This reverts commits r19833 and r19837 for breaking Windows tests (test-api/PersistentValueMap). TBR=vogelheim@chromium.org,dcarney@chromium.org Review URL: https://codereview.chromium.org/197173002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19839 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
- This adds a suppression of lines concerning error handling for the test coverage analysis - Fixes also calling push-to-trunk from auto-roll TEST=tools/push-to-trunk/script_test.py TBR=ulan@chromium.org Review URL: https://codereview.chromium.org/196883003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19838 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dcarney@chromium.org authored
R=dcarney@chromium.org BUG= Review URL: https://codereview.chromium.org/197083002 Patch from Daniel Vogelheim <vogelheim@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19837 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
Constants can still change their representation, so we cannot determine reachability of blocks based on their Smi-ness BUG=chromium:351320 LOG=y R=yangguo@chromium.org Review URL: https://codereview.chromium.org/196943002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19836 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
danno@chromium.org authored
R=jkummerow@chromium.org BUG=chromium:351319 LOG=Y Review URL: https://codereview.chromium.org/196353004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19835 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-