- 30 Aug, 2022 40 commits
-
-
Jakob Kummerow authored
Per https://github.com/WebAssembly/function-references/pull/76, call_ref and return_call_ref should consume type immediates specifying the signature of the funcref. This is a breaking change. To ease the migration, this patch introduces a temporary alternative binary encoding for call_ref: - 0x14 continues to *not* take a type immediate for now. - 0x17 (formerly "let") is the new call_ref *with* type immediate. Module producers are encouraged to emit this encoding ASAP. - After a few weeks of transitionary period, we'll update 0x14 to take a type immediate as well. At this point, module producers will be encouraged to switch back to 0x14. - After a few more weeks of transitionary period, we'll drop 0x17 again. We're not doing the same dance for return_call_ref because it currently has no uses that we know of. Bug: v8:7748,v8:9495 Change-Id: Id8d468be3949f84571efff713c937ffd1addff70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863280Reviewed-by:
Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#82839}
-
Igor Sheludko authored
Bug: v8:12547 Change-Id: I9956b91a6211345bd5a0e0f51bc04367835f82f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863275 Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#82838}
-
Feng Yu authored
- move cctest/test-parsing -> unittests/parser/parsing-unittest - move common/{scope-test-helper, unicode-helper} to unittests/parser directory because these are only be used by tests in unittests/parser Bug: v8:12781 Change-Id: Ie0fb043d5df6178bbe088d140a76f606454bbf29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855313Reviewed-by:Marja Hölttä <marja@chromium.org> Commit-Queue: Feng Yu <f3n67u@gmail.com> Cr-Commit-Position: refs/heads/main@{#82837}
-
Matthias Liedtke authored
- fix handling of undefined for non-externref tables - add test for non-nullable ref table Bug: v8:7748 Change-Id: I3f0f3aa68eb43208aea84cb8f21b37a539e14d26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862206 Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#82836}
-
Peter Kasting authored
This fixes a compile error under C++20. Bug: chromium:1284275 Change-Id: Ib263d3817c578825d303926f321eaec227e5add8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3864103 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#82835}
-
Anton Bikineev authored
The 2GB cage caused new OOMs on M106. While those issues are being investigated, this CL returns the 4GB back. The pointer compression is still enabled. Bug: chromium:1325007, chromium:1354660 Change-Id: I4fa4fabece2910ca84913d8df201acfbdf4b26e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865004Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/main@{#82834}
-
Manos Koukoutos authored
This reverts commit ddafb7a3. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/43620/overview Original change's description: > [heap] Verify client heaps during shared GC > > With --verify-heap verify all client heaps before and after a shared > GC. This ensures that the OLD_TO_SHARED remembered set is properly > filled for each client isolate. > > Bug: v8:11708 > Change-Id: I1506a419c7a91c5baa87ce251da9861d8ad9e066 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857559 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82829} Bug: v8:11708 Change-Id: I421bce59211fe420b0893aaa9d35750ecaf23570 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863282 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Owners-Override: Manos Koukoutos <manoskouk@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82833}
-
Junliang Yan authored
Change-Id: Iebbd01499dc7cf7ebc19b98c194fcddba3d5465c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863278Reviewed-by:
-
Manos Koukoutos authored
... from WasmDecoder::AnalyzeLoopAssignment. Bug: v8:9495 Change-Id: I937aca15ca77914ed920766e0e55b6d337139e17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865956Reviewed-by:
-
Michael Achenbach authored
This will help catching issues with tests that require SIMD and might need skipping on bots without SIMD support. Bug: v8:13008 Change-Id: I44a5b3094059c7661a6cb3d90ab96f9e79b55ca2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865159Reviewed-by:
-
Dominik Inführ authored
With --verify-heap verify all client heaps before and after a shared GC. This ensures that the OLD_TO_SHARED remembered set is properly filled for each client isolate. Bug: v8:11708 Change-Id: I1506a419c7a91c5baa87ce251da9861d8ad9e066 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857559Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82829}
-
Milad Fa authored
Port af62c4f0 Original Commit Message: Adapted from https://crrev.com/c/3862264. Add a new teardown trampoline for the case where a Sparkplug function is deoptimized during its function entry stack check. In these cases, the stack is in an incomplete setup state, so instead of forwarding to interpreter re-entry, we undo the partial stack setup and forward to the standard interpreter entry. R=szuend@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I6e3b906938dc9a297b602290e762426e56fb8d9d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3864189Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82828}
-
Milad Fa authored
Port ed90ea5c Original Commit Message: This implementation sticks closely to what Ignition-to-Turbofan (and now Sparkplug-to-TF) does. OSR is detected in the TieringManager by having optimized code available, without having entered it. The osr_urgency is increased to enable OSR for increasing loop depths. When a candidate JumpLoop backedge is reached, we call into runtime to trigger OSR compilation. JumpLoop also detects the availability of cached OSR'd code. When a matching OSR code object is available, Maglev 1) deoptimizes s.t. the unoptimized frame layout is reconstructed, and 2) delegates the actual OSR tierup to the unoptimized tier. For purposes of 1), we add a new DeoptimizeReason that causes a one-time eager deopt without invalidating any code. into a generic spot that both SP and ML can use. R=jgruber@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I2de3ef530b9d1aac97e499fee75716a958cd9d09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863277 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
-
Darius M authored
Bug: chromium:1355917, v8:12037 Change-Id: I5a0a19fd1abb06920f851ef04f5313e9d37dadc6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855361Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/heads/main@{#82826}
-
Samuel Groß authored
This CL introduces a new ExternalPointerTable::Entry class and moves all low-level logic related to entry management into this class. Bug: v8:10391 Change-Id: Ib7eb05da1d277cb665503e98b3f074520e572bad Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3829485Reviewed-by:
-
Matthias Liedtke authored
Bug: v8:7748 Change-Id: Ib5df6996583435275e9f9c8929763cb19d467d09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865157 Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> Reviewed-by:
-
Danylo Boiko authored
Bug: v8:7327 Change-Id: I6991579e2b165a4218935be6588ded269ace1e27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865150Reviewed-by:
-
Camillo Bruni authored
- Use consistent names: Ignition, Sparkplug, Maglev, Turbofan - Fix parsing Sparkpliug / Baseline entries - Fix c++filt calls for recent MacOS versions - Do not visualise Turboprop entries anymore Change-Id: Id8fc83c0822383d4c552c898b15c720c44b95cd7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865309Reviewed-by:
Jakob Linke <jgruber@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82822}
-
Camillo Bruni authored
Change-Id: Ifa0b6419484aea82f575db6ef8863c318cfabfe6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865152Reviewed-by:
-
Junliang Yan authored
Bug: v8:10391 Change-Id: Ib07287b166cfc54d4f52575ffecdc929f7ec3892 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863406Reviewed-by:
Samuel Groß <saelo@chromium.org> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#82820}
-
Michael Achenbach authored
No-Tree-Checks: True No-Try: True Bug: v8:7700 Change-Id: I6d02e9109664ab2dfaa578c03ee0286aad56880c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863274 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#82819}
-
Jakob Kummerow authored
Bug: chromium:1356718 No-Tree-Checks: True No-Try: True Change-Id: Ibe8ed82903a10406f9907939ec8704ff448768a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863272 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL changes debug breaks that are triggered via interrupts (i.e. via stack check). One client of this behavior is the `Debugger.pause` CDP method. The problem is that when we pause so early, the JSFunction didn't have time yet to create and push it's context. This requires special handling in the ScopeIterator and makes an upcoming change unnecessary complex. Another (minor) problem is that local debug-evaluate can't change context-allocated local variables (see changed regression bug). Since the context is not yet created and pushed, variables are written to the DebugEvaluateContext that goes away after the evaluation. The solution is to mirror what `BreakOnNextFunction` does. Instead of staying paused in the middle of the function entry, we trigger a "step in" and pause at the first valid breakable position instead. This ensures that the function context is already created and pushed. Note that we do this only in case for JSFunctions. In all other cases we keep the existing behavior and stay paused in the entry. R=jgruber@chromium.org Fixed: chromium:1246907 Change-Id: I0cd8ae6e049a3b55bdd44858e769682a1ca47064 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3854501Reviewed-by:
-
Jakob Linke authored
This implementation sticks closely to what Ignition-to-Turbofan (and now Sparkplug-to-TF) does. OSR is detected in the TieringManager by having optimized code available, without having entered it. The osr_urgency is increased to enable OSR for increasing loop depths. When a candidate JumpLoop backedge is reached, we call into runtime to trigger OSR compilation. JumpLoop also detects the availability of cached OSR'd code. When a matching OSR code object is available, Maglev 1) deoptimizes s.t. the unoptimized frame layout is reconstructed, and 2) delegates the actual OSR tierup to the unoptimized tier. For purposes of 1), we add a new DeoptimizeReason that causes a one-time eager deopt without invalidating any code. Drive-by: Annotate OSR for more --trace-opt output. Todo: Refactor non-Sparkplug-specific bits of the BaselineAssembler into a generic spot that both SP and ML can use. Bug: v8:7700 Change-Id: I6ebab2df8b87f9f70ffb78162a3c1226ec545468 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859850Reviewed-by:
-
Jakob Kummerow authored
...to honor the {pinned} list under all circumstances. Drive-by: DEBUG-mode helpers to print FunctionSig and LiftoffRegList objects to stdout. Fixed: chromium:1356718 Change-Id: I487db12294f687790cec1d658d7a7d754f3c2f99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859752Reviewed-by:Clemens Backes <clemensb@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#82815}
-
Dominik Inführ authored
This class is only used for heap verification and doesn't need to be public. Bug: v8:11708 Change-Id: I9d1750a6f701ed0d9a106f8d93ab3ff82bbf4f3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862208Reviewed-by:
-
Darius M authored
Only Internalized and Thin strings should be accessed from the background. My CL "[compiler] Remove map check in StringRef::length" removed a check, and, while doing so, made it possible to read Cons strings in the background, which is incorrect because such strings can be mutated by the main threads. Fixed: chromium:1357438 Change-Id: I3a5445f91d10e5ceab62ac208a04be5ed71798ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862007 Commit-Queue: Darius Mercadier <dmercadier@chromium.org> Reviewed-by:
-
Camillo authored
If either target or source are shared buffers, use relaxed memmove. Bug: chromium:1353555 Change-Id: Ieaad826c610b0f2f808b4061947372d851f95978 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862209Reviewed-by:
-
Simon Zünd authored
Adapted from https://crrev.com/c/3862264. Add a new teardown trampoline for the case where a Sparkplug function is deoptimized during its function entry stack check. In these cases, the stack is in an incomplete setup state, so instead of forwarding to interpreter re-entry, we undo the partial stack setup and forward to the standard interpreter entry. R=leszeks@chromium.org Bug: chromium:1246907, chromium:1357554 Change-Id: I0795b20cdc60d3ba28bc32cd55bdf82d72f83aac Also-by: leszeks@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865144 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Methods are now defined in heap-verifier.h in the HeapVerifier class. Bug: v8:11708 Change-Id: I13e7f1760598f3659ad6aa31082840caf2e44038 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3857558Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82810}
-
Victor Gomes authored
This CL: - Separates Wasm frame pointer iteration from TypedFrame iteration - Introduces the frame StubWithContext that correspond to a TF-optimized code without JS linkage - Fixes WasmToJsFrame to be a WasmFrame - Fixes the hack with JsToWasmFrame that calls TypedFrame when not the right builtin - Cleans up TypedFrame::Iterate Change-Id: Ie238df5188f2e2f081f5353b4538b75b6e79f64a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3859787Reviewed-by:
-
jameslahm authored
... when deserializing. EphemeronHashTables require valid HeapObject keys, however EphemeronHashTables are filled with Smi::uninitialized_deserialization_value when deserializing. We could fill EphemeronHashTable's elements with "the initial filler" which is undefined value to make sure the elements are valid. Bug: v8:13232 Change-Id: I268cdbd4303fbe9afa2f9a5d8aafcace397c8164 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3864185 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
-
Vasili Skurydzin authored
Change-Id: Ia0078bed77f5f75eebd837b7ffcc34cfb2c7d305 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863723Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
-
Dominik Inführ authored
Add a flag for disabling FastForwardSchedule() during incremental marking. This CL disables "schedule fast forwarding" by default to experiment with this setup for a few days and to see whether this causes performance regressions. Bug: v8:12775 Change-Id: Id2c0a62f4b67b3a2379816581800cfb62361b40c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865003 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL adjusts a DCHECK that verifies a bytecode offset when looking for the closest breakpoint given that offset. When we pause on function entry via interrupt, then the offset is kFunctionEntryBytecodeOffset (-1), which is still a valid offset. R=jarin@chromium.org Fixed: chromium:1357554 Change-Id: I5b25b58f02be0e605191c38e9d1d93e334664c63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862265 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/main@{#82805}
-
Frank Tang authored
PR https://github.com/tc39/proposal-temporal/pull/2266 Disallow arbitrary integers for the reference ISO year in PlainMonthDay Spec text: https://tc39.es/proposal-temporal/#sec-temporal-createtemporalmonthday Also add missed assertion of calling ISODateTimeWithinLimits Bug: v8:11544 Change-Id: Idd18428f3e6e6af53c2c207652688af269746782 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855703Reviewed-by:
-
ishell@chromium.org authored
This is a reland of commit 40901824 The reason for revert was regressions in `blink_gc:effective_size` buckets of `system_health.memory_desktop` benchmarks. See http://crbug/1356329#c51. Memory Perf Sheriffs: This CL shifts GC times which regresses `blink_gc:effective_size` but improves `v8:effective_size` bucket by a similar amount. The `private_footprint_size` metric stays neutral for the majority of the stories and for certain load stories it even improves. Original change's description: > [ext-code-space] Enable Code-less embedded builtins > > Bug: v8:11880, v8:12592 > Change-Id: I8d3d6ad0a4c26eb1fea2a998ffeddd1d96afa690 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784593 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Jakob Linke <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82642} Bug: v8:11880, v8:12592, chromium:1356329, chromium:1356763 Change-Id: Ia9150ecb1f16581e249e4e3e566be20ac4591e78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3862503 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Frank Tang authored
Subtract timeZone.[[OffsetNanoseconds]] from epochNanoseconds before calling the IsValidEpochNanoseconds() for the case of 4. If timeZone.[[OffsetNanoseconds]] is not undefined Bug: v8:11544 Change-Id: Icea2d8390a9db01054956f8c57b47dc5a88446d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855980Reviewed-by:
-
Frank Tang authored
Validate fractionalSecondDigits after truncation https://github.com/tc39/proposal-temporal/pull/2297 Spec text: https://tc39.es/proposal-temporal/#sec-temporal-tosecondsstringprecision Bug: v8:11544 Change-Id: I648f087f4fa2cfd6245c7946cfa625a7c5e3b3b9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3855702 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7e25322..adc338f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2417ba3..6552f9b Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b7ec673..bbb66d7 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/1eff359..ad4caa4 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ife992f3f909a23faa528e8ee1637b1213cc07fa4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3863152 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82800}
-
