Skip to content

V
V8
Switch branch/tag
  1. 01 Mar, 2019 1 commit
  3. 09 Jan, 2019 1 commit
  5. 26 Dec, 2018 1 commit
  7. 18 Dec, 2018 1 commit
  9. 14 Dec, 2018 1 commit
  11. 08 Dec, 2018 1 commit
  13. 25 Nov, 2018 1 commit
  15. 24 Nov, 2018 1 commit
  17. 23 Nov, 2018 1 commit
  19. 13 Nov, 2018 1 commit
  21. 28 Sep, 2018 1 commit
    • Daniel Clifford's avatar
      Clean up common argument objects that share length property · 64e8a948
      Daniel Clifford authored 
      This CL adds a bit more rigor to the handling of length properties
in JSObject-derived classes that explicitly contain that property
inline.

This involves:
- Introducing a new superclass of JSArgumentsObject called
  JSArgumentsObjectWithLength that is shared with other object
  instances that also have a fixed length property.
- Adding JSArgumentsObjectWithLength to the type hierarchy in Torque,
  including adding fast-cases for leading the length property for all
  classes deriving from JSObjectWithLength.
- Adding more rigor to Context and NativeContext handling in base.tq.
  This is useful for the map checks required to verify objects are
  argument object types derived from JSArgumentsObjectWithLength.

Change-Id: I2f0a20601ffcb90b3767cbaeb766e9998d3462ec
Reviewed-on: https://chromium-review.googlesource.com/1248661
Commit-Queue: Daniel Clifford <danno@chromium.org>
Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56289}
      64e8a948
  23. 26 Jul, 2018 1 commit
  25. 24 May, 2018 1 commit
  27. 26 Oct, 2017 1 commit
  29. 28 Aug, 2017 1 commit
    • Michael Starzinger's avatar
      [objects] Remove dangerous arguments accessors. · a33b0d25
      Michael Starzinger authored 
      This removes dangerous accessors method from the arguments object
accessor classes. The shape of an arguments object might transition,
turning the fields into dictionary mode, making the accessors invalid.

It also fixes a bug in the reported number of embedder fields on the
arguments object.

R=ishell@chromium.org
TEST=cctest/test-api/InternalFieldsOfRegularObjects

Change-Id: Ib7a73608c6236fe8864434e0cfdcb754ae012a75
Reviewed-on: https://chromium-review.googlesource.com/636368
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47643}
      a33b0d25
  31. 13 Jun, 2017 1 commit