1. 14 Apr, 2018 1 commit
    • Jakob Kummerow's avatar
      [ubsan] Change Address typedef to uintptr_t · 2459046c
      Jakob Kummerow authored
      The "Address" type is V8's general-purpose type for manipulating memory
      addresses. Per the C++ spec, pointer arithmetic and pointer comparisons
      are undefined behavior except within the same array; since we generally
      don't operate within a C++ array, our general-purpose type shouldn't be
      a pointer type.
      
      Bug: v8:3770
      Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: Ib96016c24a0f18bcdba916dabd83e3f24a1b5779
      Reviewed-on: https://chromium-review.googlesource.com/988657
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#52601}
      2459046c
  2. 21 Feb, 2018 1 commit
  3. 09 Feb, 2018 1 commit
  4. 08 Jan, 2018 2 commits
  5. 15 Dec, 2017 1 commit
  6. 13 Dec, 2017 2 commits
  7. 02 Dec, 2017 1 commit
    • Mathias Bynens's avatar
      Normalize casing of hexadecimal digits · 822be9b2
      Mathias Bynens authored
      This patch normalizes the casing of hexadecimal digits in escape
      sequences of the form `\xNN` and integer literals of the form
      `0xNNNN`.
      
      Previously, the V8 code base used an inconsistent mixture of uppercase
      and lowercase.
      
      Google’s C++ style guide uses uppercase in its examples:
      https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters
      
      Moreover, uppercase letters more clearly stand out from the lowercase
      `x` (or `u`) characters at the start, as well as lowercase letters
      elsewhere in strings.
      
      BUG=v8:7109
      TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org
      NOPRESUBMIT=true
      
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6
      Reviewed-on: https://chromium-review.googlesource.com/804294
      Commit-Queue: Mathias Bynens <mathias@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49810}
      822be9b2
  8. 24 Nov, 2017 1 commit
    • Yang Guo's avatar
      [snapshot] make API external references optional. · 13a68e6c
      Yang Guo authored
      In snapshots with several contexts, some contexts may not reference
      function or object templates, and therefore would not require external
      references for deserialization. However, function and object templates
      are deserialized with the isolate as part of the partial snapshot cache,
      so we would need these external references even if we only use contexts
      that don't need them.
      
      With this patch, we use a fallback in case no external references are
      provided. This way, we only run into issues when we actually call native
      callbacks.
      
      R=jgruber@chromium.org, peria@chromium.org
      
      Change-Id: I6af8a77f26c92bd73fdab6112474c62da270597f
      Reviewed-on: https://chromium-review.googlesource.com/784831Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49615}
      13a68e6c
  9. 26 Oct, 2017 1 commit
  10. 23 Oct, 2017 1 commit
  11. 18 Oct, 2017 1 commit
  12. 13 Oct, 2017 1 commit
  13. 11 Oct, 2017 1 commit
  14. 09 Oct, 2017 1 commit
  15. 03 Aug, 2017 2 commits
  16. 02 Aug, 2017 1 commit
  17. 16 May, 2017 1 commit
  18. 02 May, 2017 1 commit
    • neis's avatar
      [simulator] Make reference redirection thread-safe. · 34e79456
      neis authored
      In the simulators, the ExternalReference constructor rewrites external
      addresses, which involves mutating a linked list rooted in the isolate.
      
      We already construct external references concurrently (at least in Turbofan),
      but the list mutation was not thread-safe (though no crashes are known). This
      CL adds the necessary locking.
      
      BUG=v8:6048
      
      Review-Url: https://codereview.chromium.org/2852983002
      Cr-Commit-Position: refs/heads/master@{#45014}
      34e79456
  19. 25 Apr, 2017 1 commit
  20. 30 Mar, 2017 1 commit
  21. 23 Mar, 2017 1 commit
  22. 24 Feb, 2017 1 commit
  23. 30 Jan, 2017 1 commit
  24. 13 Jan, 2017 1 commit
  25. 12 Jan, 2017 1 commit
  26. 30 Sep, 2016 1 commit
  27. 26 Jul, 2016 1 commit
  28. 27 Jun, 2016 1 commit
  29. 10 Jun, 2016 1 commit
    • bjaideep's avatar
      PPC: Move hashmap into src/base. · c7cddee6
      bjaideep authored
      Port 2fd55667
      
      Original commit message:
      
          We ported hashmap.h into libsampler as a workaround before, so the main focus of
          this patch is to reduce code duplication. This patch moves the hashmap into
          src/base as well as creates DefaultAllocationPolicy using malloc and free.
      
      R=lpy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com
      
      BUG=v8:5050
      LOG=N
      
      Review-Url: https://codereview.chromium.org/2057263002
      Cr-Commit-Position: refs/heads/master@{#36900}
      c7cddee6
  30. 25 May, 2016 1 commit
    • bjaideep's avatar
      PPC: [build] Fix a clang warning · 8b295a0e
      bjaideep authored
      Port a23222ed
      
      Original commit message:
      
          For cross-compiler-compatibility and standards compliance %p
          requires a void*, rather than any pointer type.
      
      R=machenbach@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com
      
      BUG=chromium:474921
      LOG=N
      
      Review-Url: https://codereview.chromium.org/2009653002
      Cr-Commit-Position: refs/heads/master@{#36519}
      8b295a0e
  31. 16 Mar, 2016 2 commits
    • mbrandy's avatar
      PPC: Simulator fixes for shift operations. · dddb12c4
      mbrandy authored
      R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
      BUG=
      
      Review URL: https://codereview.chromium.org/1809643004
      
      Cr-Commit-Position: refs/heads/master@{#34837}
      dddb12c4
    • mbrandy's avatar
      PPC: [wasm] Int64Lowering of Int64Sub. · eb0a2324
      mbrandy authored
      Port 33c08596
      
      Original commit message:
          Int64Sub is lowered to a new turbofan operator, Int32SubPair. The new
          operator takes 4 inputs an generates 2 outputs. The inputs are the low
          word of the left input, high word of the left input, the low word of the
          right input, and high word of the right input. The ouputs are the low
          and high word of the result of the subtraction.
      
          The implementation is very similar to the implementation of Int64Add.
      
      R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
      BUG=
      
      Review URL: https://codereview.chromium.org/1812473002
      
      Cr-Commit-Position: refs/heads/master@{#34821}
      eb0a2324
  32. 15 Mar, 2016 1 commit
    • mbrandy's avatar
      PPC: [wasm] Int64Lowering of Int64Add. · 0548cf49
      mbrandy authored
      Port 1b230799
      
      Original commit message:
          Int64Add is lowered to a new turbofan operator, Int32AddPair. The new
          operator takes 4 inputs an generates 2 outputs. The inputs are the low
          word of the left input, high word of the left input, the low word of the
          right input, and high word of the right input. The ouputs are the low
          and high word of the result of the addition.
      
      R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
      BUG=
      
      Review URL: https://codereview.chromium.org/1803113002
      
      Cr-Commit-Position: refs/heads/master@{#34797}
      0548cf49
  33. 10 Feb, 2016 1 commit
    • mbrandy's avatar
      PPC: [heap] Move to page lookups for SemiSpace, NewSpace, and Heap containment methods · 1ab7f2f8
      mbrandy authored
      Port cfbd2561
      
      Original commit message:
      
          Preparing the young generation for (real) non-contiguous backing memory, this
          change removes object masks that are used to compute containment in semi and new
          space. The masks are replaced by lookups for object tags and page headers, where
          possible.
      
          Details:
          - Use the fast checks (page header lookups) for containment in regular code.
          - Use the slow version that masks out the page start adress and iterates all
            pages of a space for debugging/verification.
          - The slow version works for off-heap/unmapped memory.
          - Encapsulate all checks for the old->new barrier in Heap::RecordWrite().
      
      R=mlippautz@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
      BUG=chromium:581412
      LOG=N
      
      Review URL: https://codereview.chromium.org/1687113002
      
      Cr-Commit-Position: refs/heads/master@{#33877}
      1ab7f2f8
  34. 22 Jan, 2016 1 commit
    • mbrandy's avatar
      Introduce BUILTIN_CALL_PAIR. · 433e8848
      mbrandy authored
      This change allows the PPC simulator to execute on PPC hardware where,
      due to calling conventions, we must distinguish between Object* and
      ObjectPair return values.
      
      We find this useful as another available option for debugging certain
      problems.  While not strictly necessary for Intel platforms, we hope
      that this is less offensive now that BUILTIN_CALL_TRIPLE has been
      added.
      
      BUG=
      R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
      
      Review URL: https://codereview.chromium.org/1604653006
      
      Cr-Commit-Position: refs/heads/master@{#33475}
      433e8848
  35. 20 Jan, 2016 1 commit
  36. 15 Jan, 2016 1 commit