- 18 Nov, 2016 1 commit
-
-
yangguo authored
See https://github.com/mathiasbynens/es-regexp-unicode-property-escapes Changes: - only allow General Category, binary properties, Script, and Script_Extensions. - implement Script_Extensions. R=littledan@chromium.org BUG=v8:4743 Review-Url: https://codereview.chromium.org/2502933002 Cr-Commit-Position: refs/heads/master@{#41091}
-
- 17 Nov, 2016 1 commit
-
-
jgruber authored
This adds access to the LiveEdit API object, frame.restart(), and various breakpoint setters. The LiveEdit API still depends on the JS debugging context and blocks its removal; but it should be removed once LiveEdit is rewritten in the midterm. BUG=v8:5530 Review-Url: https://codereview.chromium.org/2503293002 Cr-Commit-Position: refs/heads/master@{#41062}
-
- 16 Nov, 2016 1 commit
-
-
jgruber authored
This CL further extends the debug wrapper, migrates around 60 tests, and removes a few tests that use functionality we will not support anymore. In more detail: * Removed tests that use: * enable/disable individual breakpoints * invocationText() * the ScriptCollected event * showBreakPoints * evalFromScript (and similar) * mirror.constructedBy and mirror.referencedBy * event_data.promise() * Some frame.evaluate uses were adapted since due to differences between remote objects (inspector) and mirrors. For instance, exceptions are currently not recreated exactly, since the inspector protocol does not give us the stack and message separately. Other objects (such as 'this' in debug-evaluate-receiver-before-super) need to be explicitly converted to a string before the test works correctly. * Ensure that inspector stores the script before sending ScriptParsed and ScriptFailedToParse events in order to be able to use the script from within those events. * Better remote object reconstruction (e.g. for undefined and arrays). * New functionality in wrapper: * debuggerFlags().breakPointsActive.setValue() * scripts() * execState.setVariableValue() * execState.scopeObject().value() * execState.scopeObject().property() * execState.frame().allScopes() * eventData.exception() * eventData.script() * setBreakPointsActive() BUG=v8:5530 Review-Url: https://codereview.chromium.org/2497973002 Cr-Commit-Position: refs/heads/master@{#41019}
-
- 11 Nov, 2016 1 commit
-
-
verwaest authored
Methods in the runtime that enumerate over properties should never deal with private symbols. Most commonly such methods only loop over enumerable properties. This fix avoids accidentally handling private symbols in methods that only deal with enumerable properties. Methods that need to look at non-enumerable properties as well still have to manually filter private symbols (e.g., the KeyAccumulator). BUG=chromium:664411 Review-Url: https://codereview.chromium.org/2499593002 Cr-Commit-Position: refs/heads/master@{#40932}
-
- 08 Nov, 2016 3 commits
-
-
jgruber authored
BUG=v8:5530 Review-Url: https://codereview.chromium.org/2487673002 Cr-Commit-Position: refs/heads/master@{#40840}
-
jgruber authored
This adds clearStepping plus the family of {set,clear}BreakOn{,Uncaught}Exception functions. BUG=v8:5530 Review-Url: https://codereview.chromium.org/2482903002 Cr-Commit-Position: refs/heads/master@{#40834}
-
jgruber authored
This moves all tests currently working with the inspector debugger wrapper to test/debugger. BUG=v8:5530 Review-Url: https://codereview.chromium.org/2480223002 Cr-Commit-Position: refs/heads/master@{#40824}
-
- 07 Nov, 2016 2 commits
-
-
jgruber authored
Revert of [debugger] Migrate more debugger tests to inspector (patchset #2 id:20001 of https://codereview.chromium.org/2480223002/ ) Reason for revert: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/9724 Original issue's description: > [debugger] Migrate more debugger tests to inspector > > This moves all tests currently working with the inspector debugger wrapper to > test/debugger. > > BUG=v8:5530 TBR=yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5530 Review-Url: https://codereview.chromium.org/2480283002 Cr-Commit-Position: refs/heads/master@{#40805}
-
jgruber authored
This moves all tests currently working with the inspector debugger wrapper to test/debugger. BUG=v8:5530 Review-Url: https://codereview.chromium.org/2480223002 Cr-Commit-Position: refs/heads/master@{#40804}
-
- 04 Nov, 2016 1 commit
-
-
adamk authored
The flag has been on since at least Chrome 53. R=littledan@chromium.org Review-Url: https://codereview.chromium.org/2478883002 Cr-Commit-Position: refs/heads/master@{#40780}
-
- 31 Oct, 2016 1 commit
-
-
adamk authored
Both --harmony-object-values-entries and --harmony-object-own-property-descriptors are on by default in v8 5.4, which has now shipped to stable as Chrome 54. R=caitp@igalia.com Review-Url: https://codereview.chromium.org/2464733003 Cr-Commit-Position: refs/heads/master@{#40683}
-
- 28 Oct, 2016 1 commit
-
-
mstarzinger authored
This flag is on by default for now. Whenever heuristics in the compiler pipeline decide to use Ignition+TurboFan, then {BytecodeGraphBuilder} is active. Removing the flag reduces maintenance overhead. R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2437103002 Cr-Commit-Position: refs/heads/master@{#40639}
-
- 25 Oct, 2016 1 commit
-
-
cbruni authored
Object.create(null) is most likely to be used for dictionary-like objects. Hence it would be beneficial to directly create a slow-mode object and avoid additional overhead later-on. BUG= Review-Url: https://codereview.chromium.org/2430273007 Cr-Commit-Position: refs/heads/master@{#40551}
-
- 14 Oct, 2016 1 commit
-
-
gsathya authored
If the catch prediction machinery in the middle of some async op, we shouldn't send invalid events to the debugger. Instead of sending events with an undefined id, we don't send them at all. Review-Url: https://codereview.chromium.org/2417093003 Cr-Commit-Position: refs/heads/master@{#40327}
-
- 12 Oct, 2016 1 commit
-
-
gsathya authored
Review-Url: https://codereview.chromium.org/2405173005 Cr-Commit-Position: refs/heads/master@{#40236}
-
- 11 Oct, 2016 1 commit
-
-
adamk authored
The ES spec has been updated to include this legacy syntax in Annex B: https://tc39.github.io/ecma262/#sec-initializers-in-forin-statement-heads R=neis@chromium.org BUG=v8:4942 Review-Url: https://codereview.chromium.org/2407863003 Cr-Commit-Position: refs/heads/master@{#40189}
-
- 24 Sep, 2016 1 commit
-
-
littledan authored
If DevTools is turned on in the middle of doing some things with async functions, then more items may be popped from the Promise stack than were pushed to it. In this sort of case, it's OK to have a catch misprediction, but a crash is unacceptable. This patch defensively handles this edge case where the Promise stack is unexpectedly empty for that reason. BUG=v8:5167 Review-Url: https://codereview.chromium.org/2361333003 Cr-Commit-Position: refs/heads/master@{#39705}
-
- 23 Sep, 2016 1 commit
-
-
littledan authored
This patch tracks the stack of async functions differently from other Promise async stack tracking. With this patch, the stack trace of a callstack of async functions should look similarly to the call stack if all of the functions were synchronous. An example can be found in the updated test expectations: https://codereview.chromium.org/2362923002 . The new stack traces are implemented using existing mechanisms in the inspector. The inspector has two ways to save async stack traces: recurring and non-recurring stacks. An example of a non-recurring stack is setTimeout, and a recurring one is saved for setInterval. Recurring stacks are deleted only when a special "cancel" function is called, rather than being deleted after being used the first time. Previous Promise async stack tracking always used non-recurring stacks. For async functions, this patch saves a recurring stack. The top frame of the stack is duplicated, as the resuming function contains a similar frame; the devtools frontend is responsible for removing or marking this frame, which it can do based on seeing the [async function] line which follows it. The second frame will instead be provided by the resuming execution context. The recurring stack is saved when the async function is entered, and it is deleted from a finally block. The id of the stack is saved in the outer Promise being constructed by the async function. When an intermediate throwaway Promise will be triggered as a reaction, it will be identified as such based on its debugging metadata, and the corresponding async function's recurring stack will be used. BUG=v8:4483 Review-Url: https://codereview.chromium.org/2357423002 Cr-Commit-Position: refs/heads/master@{#39695}
-
- 20 Sep, 2016 2 commits
-
-
littledan authored
This patch knits together Promises returned by async/await such that when one async function awaits the result of another one, catch prediction works across the boundaries, whether the exception comes synchronously or asynchronously. Edges are added in three places: - When a locally uncaught await happens, if the value passed into await is a Promise, from the awaited value to the Promise under construction in the broader async function - From a "throwaway" Promise, which may be found on the Promise debug stack, to the Promise under construction in the async function that surrounds it - When a Promise is resolved with another Promise (e.g., when returning a Promise from an async function) In this reland, the caught tests are broken up into four parts to avoid timeouts. BUG=v8:5167 Review-Url: https://codereview.chromium.org/2346363004 Cr-Commit-Position: refs/heads/master@{#39564}
-
littledan authored
Revert of Async/await Promise dependency graph (patchset #30 id:550001 of https://codereview.chromium.org/2317383002/ ) Reason for revert: Need to break up test into smaller tests to avoid timeouts Original issue's description: > Async/await Promise dependency graph > > This patch knits together Promises returned by async/await such that when > one async function awaits the result of another one, catch prediction works > across the boundaries, whether the exception comes synchronously or > asynchronously. Edges are added in three places: > - When a locally uncaught await happens, if the value passed into await > is a Promise, from the awaited value to the Promise under construction > in the broader async function > - From a "throwaway" Promise, which may be found on the Promise debug > stack, to the Promise under construction in the async function that > surrounds it > - When a Promise is resolved with another Promise (e.g., when returning a > Promise from an async function) > > BUG=v8:5167 > > Committed: https://crrev.com/7265fdde7c76b9f875b40b0b139515936d491d64 > Cr-Commit-Position: refs/heads/master@{#39522} TBR=adamk@chromium.org,jgruber@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5167 Review-Url: https://codereview.chromium.org/2351953002 Cr-Commit-Position: refs/heads/master@{#39523}
-
- 19 Sep, 2016 5 commits
-
-
littledan authored
This patch knits together Promises returned by async/await such that when one async function awaits the result of another one, catch prediction works across the boundaries, whether the exception comes synchronously or asynchronously. Edges are added in three places: - When a locally uncaught await happens, if the value passed into await is a Promise, from the awaited value to the Promise under construction in the broader async function - From a "throwaway" Promise, which may be found on the Promise debug stack, to the Promise under construction in the async function that surrounds it - When a Promise is resolved with another Promise (e.g., when returning a Promise from an async function) BUG=v8:5167 Review-Url: https://codereview.chromium.org/2317383002 Cr-Commit-Position: refs/heads/master@{#39522}
-
littledan authored
Reland of Fix async/await memory leak (patchset #1 id:1 of https://codereview.chromium.org/2348403003/ ) This patch closes a memory leak in async/await where the desugaring was creating a situation analagous to that described in v8:5002. Intermediate Promises were being kept alive, so a long-running loop would cause linear memory usage on the heap. This patch returns undefined to the 'then' callback passed into PerformPromiseThen in order to avoid this hazard. Test expectations are fixed to remove expecting extraneous events which occurred on Promises that are now not given unnecessarily complex resolution paths before being thrown away. This patch is a reland; originally, tests which exercised the memory exhaustion were checked in. Although it's possible to find good parameters for running such tests locally, it is difficult to automate the tests between the rock of timeouts and the hard place of too-small heaps causing memory exhaustion in some modes even when there is no leak. BUG=v8:5390 Review-Url: https://codereview.chromium.org/2352933002 Cr-Commit-Position: refs/heads/master@{#39520}
-
littledan authored
Revert of Fix async/await memory leak (patchset #5 id:160001 of https://codereview.chromium.org/2348403002/ ) Reason for revert: Still causes issues on bot (sometimes!) Original issue's description: > Reland of Fix async/await memory leak (patchset #1 id:1 of https://codereview.chromium.org/2354473002/ ) > > Reason for revert: > Relanding with faster-running test > > Original issue's description: > > Revert of Fix async/await memory leak (patchset #5 id:80001 of https://codereview.chromium.org/2334323006/ ) > > > > Reason for revert: > > newly introduced test async-await-loop times out: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/10894/steps/Ignition%20-%20turbofan%20%28flakes%29/logs/async-await-loop > > > > Original issue's description: > > > Fix async/await memory leak > > > > > > This patch closes a memory leak in async/await where the desugaring > > > was creating a situation analagous to that described in v8:5002. > > > Intermediate Promises were being kept alive, so a long-running loop > > > would cause linear memory usage on the heap. This patch returns > > > undefined to the 'then' callback passed into PerformPromiseThen > > > in order to avoid this hazard. Test expectations are fixed to remove > > > expecting extraneous events which occurred on Promises that are > > > now not given unnecessarily complex resolution paths before being > > > thrown away. > > > > > > BUG=v8:5390 > > > > > > Committed: https://crrev.com/a0ba18e9634c5e2d439033ab61a77cff54f9af35 > > > Cr-Commit-Position: refs/heads/master@{#39479} > > > > TBR=adamk@chromium.org,caitp@igalia.com,littledan@chromium.org > > NOTRY=true > > BUG=v8:5390 > > > > Committed: https://crrev.com/196db1999da130019bbf8e3bd65977f840e8afaf > > Cr-Commit-Position: refs/heads/master@{#39493} > > TBR=adamk@chromium.org,caitp@igalia.com,hablich@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > BUG=v8:5390 > > Committed: https://crrev.com/e51482f01f26e0013e6377e85c4d2c41900e403c > Cr-Commit-Position: refs/heads/master@{#39508} TBR=adamk@chromium.org,caitp@igalia.com,hablich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5390 Review-Url: https://codereview.chromium.org/2348403003 Cr-Commit-Position: refs/heads/master@{#39512}
-
littledan authored
Reland of Fix async/await memory leak (patchset #1 id:1 of https://codereview.chromium.org/2354473002/ ) Reason for revert: Relanding with faster-running test Original issue's description: > Revert of Fix async/await memory leak (patchset #5 id:80001 of https://codereview.chromium.org/2334323006/ ) > > Reason for revert: > newly introduced test async-await-loop times out: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/10894/steps/Ignition%20-%20turbofan%20%28flakes%29/logs/async-await-loop > > Original issue's description: > > Fix async/await memory leak > > > > This patch closes a memory leak in async/await where the desugaring > > was creating a situation analagous to that described in v8:5002. > > Intermediate Promises were being kept alive, so a long-running loop > > would cause linear memory usage on the heap. This patch returns > > undefined to the 'then' callback passed into PerformPromiseThen > > in order to avoid this hazard. Test expectations are fixed to remove > > expecting extraneous events which occurred on Promises that are > > now not given unnecessarily complex resolution paths before being > > thrown away. > > > > BUG=v8:5390 > > > > Committed: https://crrev.com/a0ba18e9634c5e2d439033ab61a77cff54f9af35 > > Cr-Commit-Position: refs/heads/master@{#39479} > > TBR=adamk@chromium.org,caitp@igalia.com,littledan@chromium.org > NOTRY=true > BUG=v8:5390 > > Committed: https://crrev.com/196db1999da130019bbf8e3bd65977f840e8afaf > Cr-Commit-Position: refs/heads/master@{#39493} TBR=adamk@chromium.org,caitp@igalia.com,hablich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. BUG=v8:5390 Review-Url: https://codereview.chromium.org/2348403002 Cr-Commit-Position: refs/heads/master@{#39508}
-
hablich authored
Revert of Fix async/await memory leak (patchset #5 id:80001 of https://codereview.chromium.org/2334323006/ ) Reason for revert: newly introduced test async-await-loop times out: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/10894/steps/Ignition%20-%20turbofan%20%28flakes%29/logs/async-await-loop Original issue's description: > Fix async/await memory leak > > This patch closes a memory leak in async/await where the desugaring > was creating a situation analagous to that described in v8:5002. > Intermediate Promises were being kept alive, so a long-running loop > would cause linear memory usage on the heap. This patch returns > undefined to the 'then' callback passed into PerformPromiseThen > in order to avoid this hazard. Test expectations are fixed to remove > expecting extraneous events which occurred on Promises that are > now not given unnecessarily complex resolution paths before being > thrown away. > > BUG=v8:5390 > > Committed: https://crrev.com/a0ba18e9634c5e2d439033ab61a77cff54f9af35 > Cr-Commit-Position: refs/heads/master@{#39479} TBR=adamk@chromium.org,caitp@igalia.com,littledan@chromium.org NOTRY=true BUG=v8:5390 Review-Url: https://codereview.chromium.org/2354473002 Cr-Commit-Position: refs/heads/master@{#39493}
-
- 16 Sep, 2016 1 commit
-
-
littledan authored
This patch closes a memory leak in async/await where the desugaring was creating a situation analagous to that described in v8:5002. Intermediate Promises were being kept alive, so a long-running loop would cause linear memory usage on the heap. This patch returns undefined to the 'then' callback passed into PerformPromiseThen in order to avoid this hazard. Test expectations are fixed to remove expecting extraneous events which occurred on Promises that are now not given unnecessarily complex resolution paths before being thrown away. BUG=v8:5390 Review-Url: https://codereview.chromium.org/2334323006 Cr-Commit-Position: refs/heads/master@{#39479}
-
- 15 Sep, 2016 1 commit
-
-
littledan authored
Handle the "synchronous case" by marking try/catch blocks introduced for async functions as ASYNC_AWAIT and traversing up the stack, finding successive Promises and returning caught if any of them are predicted to be caught. BUG=v8:5167 Review-Url: https://codereview.chromium.org/2325813002 Cr-Commit-Position: refs/heads/master@{#39433}
-
- 25 Aug, 2016 1 commit
-
-
verwaest authored
BUG=v8:5209 Review-Url: https://codereview.chromium.org/2272083003 Cr-Commit-Position: refs/heads/master@{#38920}
-
- 24 Aug, 2016 1 commit
-
-
littledan authored
To make async/await catch prediction work well, this patch regularizes the exception events sent to DevTools from various places in the Promise lifecycle. The core is that there should be an exception event when the rejection first starts, rather than when it is propagated. - Several cases within Promise code which propagate errors are modified to not trigger a new ExceptionEvent in that case, such as .then on a rejected Promise and returning a rejected Promise from .then, as well as Promise.race and Promise.all. - Make Promise.reject() create an ExceptionEvent, subject to catch prediction based on the Promise stack. This is important so that, e.g., if "await Promise.reject()" will trigger a new throw (rather than a silent rethrow of something that never triggered an event in the first place). BUG=v8:5167 Review-Url: https://codereview.chromium.org/2244003003 Cr-Commit-Position: refs/heads/master@{#38847}
-
- 18 Aug, 2016 1 commit
-
-
neis authored
TBR=littledan@chromium.org NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2259793002 Cr-Commit-Position: refs/heads/master@{#38701}
-
- 17 Aug, 2016 2 commits
-
-
bakkot authored
Reland of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset #2 id:170001 of https://codereview.chromium.org/2113593002/ ) Reason for revert: WebGL tests have been updated and rolled (at https://codereview.chromium.org/2227023002), so this should no longer fail outdated tests. Original issue's description: > Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset #8 id:140001 of https://codereview.chromium.org/2090353003/ ) > > Reason for revert: > Speculative revert to unblock roll: https://codereview.chromium.org/2107223003/ > > Original issue's description: > > Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. > > > > The spec was modified to relax some requirements which implementors had not been > > enforcing. Part of this process involved introducing a new abstract operation > > ToIndex, which had partial overlap with our existing semantics as well as some > > differences (most notably treating undefined as 0). Test262 tests were introduced to > > check for the new semantics, some of which we were failing. This patch amends the > > parts of our implementation corresponding to specification algorithms which use > > ToIndex to follow its semantics precisely. > > > > BUG=v8:4784,v8:5120 > > > > Committed: https://crrev.com/09720349ea058d178521ec58d0a5676443a5a132 > > Cr-Commit-Position: refs/heads/master@{#37406} > > TBR=littledan@chromium.org,adamk@chromium.org,bakkot@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4784,v8:5120 > > Committed: https://crrev.com/b1f7f1f4e41a723d5f997738a07e35a031713b8f > Cr-Commit-Position: refs/heads/master@{#37417} TBR=littledan@chromium.org,adamk@chromium.org,hablich@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4784,v8:5120 Review-Url: https://codereview.chromium.org/2247073004 Cr-Commit-Position: refs/heads/master@{#38689}
-
neis authored
Async functions are implemented via special generator functions; special in the sense that they generally do not immediately yield. However, our generators implementation still assumed that every generator function initially yields (concretely: before doing the state dispatch in a loop header). This CL fixes that. R=littledan@chromium.org, rmcilroy@chromium.org BUG=chromium:638019 Review-Url: https://codereview.chromium.org/2253033002 Cr-Commit-Position: refs/heads/master@{#38684}
-
- 12 Aug, 2016 1 commit
-
-
caitp authored
No longer include the "async" keyword, or an async arrow function's single identifier parameter as part of its inferred name. BUG=v8:5281, v8:4483 R=adamk@chromium.org, littledan@chromium.org, marja@chromium.org Review-Url: https://codereview.chromium.org/2235423003 Cr-Commit-Position: refs/heads/master@{#38627}
-
- 10 Aug, 2016 1 commit
-
-
littledan authored
This patch adds additional tests for async functions and generators, in how they interact with destructuring, default arguments and shadow parameter copying. BUG=v8:5167 Review-Url: https://codereview.chromium.org/2229243002 Cr-Commit-Position: refs/heads/master@{#38560}
-
- 08 Aug, 2016 1 commit
-
-
neis authored
Introduces a new VariableLocation MODULE for variables that live in a module's export table. Scope analysis sets this for the approriate variables. Not yet supported by any backend. Also, treats all imports as CONST bindings (including namespace imports), rather than having new special variable modes. BUG= Review-Url: https://codereview.chromium.org/2199283002 Cr-Commit-Position: refs/heads/master@{#38426}
-
- 06 Aug, 2016 1 commit
-
-
littledan authored
- Don't read .constructor when returning a Promise from an async function. Instead, call out to the internals of Promise.resolve directly. This is done by adding back in an "optimization" from an earlier form of the async/await code written by Caitlin Potter. - Async functions always return a new Promise with a distinct identity, even if they simply return another Promise. R=caitp@igalia.com BUG=v8:4483 Review-Url: https://codereview.chromium.org/2219623002 Cr-Commit-Position: refs/heads/master@{#38404}
-
- 04 Aug, 2016 1 commit
-
-
caitp authored
The `PerformPromiseThen` spec-internal operation is used by the async functions proposal, in order to ensure that AwaitExpressions are not observable via usual mechanisms/hooks, such as Symbol.species. BUG=v8:5253 R=littledan@chromium.org, adamk@chromium.org, gsathya@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2209433003 Cr-Commit-Position: refs/heads/master@{#38353}
-
- 02 Aug, 2016 1 commit
-
-
adamk authored
It's shipped in M52. R=caitp@igalia.com, littledan@chromium.org Review-Url: https://codereview.chromium.org/2203843002 Cr-Commit-Position: refs/heads/master@{#38256}
-
- 25 Jul, 2016 1 commit
-
-
neis authored
This flag has been enabled by default for over a month now. R=mstarzinger@chromium.org, rmcilroy@chromium.org BUG= Review-Url: https://codereview.chromium.org/2176143002 Cr-Commit-Position: refs/heads/master@{#38020}
-
- 22 Jul, 2016 1 commit
-
-
jwolfe authored
See discussion in https://codereview.chromium.org/2156303002/#msg8 With the new --harmony-function-tostring behavior, these tests would fail without this change. This change makes the tests pass regardless of whether or not --harmony-function-tostring is used. All of these changes are simply inserting a space after the "function" keyword to match the current function toString behavior. When --harmony-function-tostring is enabled, the toString behavior matches the spacing used in the function declaration. With the declaration matching the current formatting, the toString behavior becomes unaffected by --harmony-function-tostring. BUG=v8:4958 LOG=n Review-Url: https://codereview.chromium.org/2161413002 Cr-Commit-Position: refs/heads/master@{#37959}
-