- 24 May, 2019 1 commit
-
-
Yang Guo authored
TBR=mvstanton@chromium.org,neis@chromium.org,ahaas@chromium.org Bug: v8:9247 Change-Id: I5433c863a54f3412d73df0d38aba3fdbcfac7ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627973 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61830}
-
- 22 May, 2019 1 commit
-
-
Yang Guo authored
Bug: v8:9247 Change-Id: I79e0553e8a0d6dac2aa16b94a6c0e05b6ccde4a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621934 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#61725}
-
- 18 Oct, 2017 1 commit
-
-
Clemens Hammacher authored
This CL fixes all occurences that don't require special OWNER reviews, or can be reviewed by Michi. After this one, we should be able to reenable the readability/check cpplint check. R=mstarzinger@chromium.org Bug: v8:6837, v8:6921 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: Ic81d68d5534eaa795b7197fed5c41ed158361d62 Reviewed-on: https://chromium-review.googlesource.com/721120 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#48670}
-
- 14 Aug, 2017 1 commit
-
-
Mostyn Bramley-Moore authored
* Avoid "using namespace" statements, which trigger clang's -Wheader-hygiene warnings in jumbo builds. * Undefine created macros at the end of source files. BUG=chromium:746958 Change-Id: I5d25432c314437f607b0e1be22765a6764267ba6 Reviewed-on: https://chromium-review.googlesource.com/610962Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@opera.com> Cr-Commit-Position: refs/heads/master@{#47347}
-
- 01 Sep, 2016 1 commit
-
-
marja authored
Rebuilding (after touching certain files) is crazy slow because includes are out of control. Many of these files we need to rebuild are cctests which pull in more includes than they need. BUG=v8:5294 Review-Url: https://codereview.chromium.org/2304553002 Cr-Commit-Position: refs/heads/master@{#39080}
-
- 09 Dec, 2015 1 commit
-
-
jochen authored
Embedders still can use those APIs by default test-api.cc still has an exception to use the old APIs... BUG=v8:4143 R=vogelheim@chromium.org LOG=n Review URL: https://codereview.chromium.org/1505803004 Cr-Commit-Position: refs/heads/master@{#32701}
-
- 25 Nov, 2015 5 commits
-
-
yangguo authored
Credits go to Erik Corry. Taken from: https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc R=jkummerow@chromium.org BUG=v8:4566 LOG=N Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff Cr-Commit-Position: refs/heads/master@{#32211} Committed: https://crrev.com/3d84f05cd77091ea8dde7821973f13f53dbaa730 Cr-Commit-Position: refs/heads/master@{#32238} Committed: https://crrev.com/eeee7ab050013782704b5f89e49d06a30b3455c4 Cr-Commit-Position: refs/heads/master@{#32246} Review URL: https://codereview.chromium.org/1467133006 Cr-Commit-Position: refs/heads/master@{#32254}
-
yangguo authored
Revert of Add test to check PRNG quality. (patchset #5 id:80001 of https://codereview.chromium.org/1467133006/ ) Reason for revert: failure here https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosse4/builds/6842/steps/Check/logs/RandomBitCorrelations12 Original issue's description: > Add test to check PRNG quality. > > Credits go to Erik Corry. Taken from: > https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc > > R=jkummerow@chromium.org > BUG=v8:4566 > LOG=N > > Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff > Cr-Commit-Position: refs/heads/master@{#32211} > > Committed: https://crrev.com/3d84f05cd77091ea8dde7821973f13f53dbaa730 > Cr-Commit-Position: refs/heads/master@{#32238} > > Committed: https://crrev.com/eeee7ab050013782704b5f89e49d06a30b3455c4 > Cr-Commit-Position: refs/heads/master@{#32246} TBR=jkummerow@chromium.org,erikcorry@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4566 Review URL: https://codereview.chromium.org/1472833004 Cr-Commit-Position: refs/heads/master@{#32247}
-
yangguo authored
Credits go to Erik Corry. Taken from: https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc R=jkummerow@chromium.org BUG=v8:4566 LOG=N Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff Cr-Commit-Position: refs/heads/master@{#32211} Committed: https://crrev.com/3d84f05cd77091ea8dde7821973f13f53dbaa730 Cr-Commit-Position: refs/heads/master@{#32238} Review URL: https://codereview.chromium.org/1467133006 Cr-Commit-Position: refs/heads/master@{#32246}
-
yangguo authored
Revert of Add test to check PRNG quality. (patchset #4 id:60001 of https://codereview.chromium.org/1467133006/ ) Reason for revert: still timing out Original issue's description: > Add test to check PRNG quality. > > Credits go to Erik Corry. Taken from: > https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc > > R=jkummerow@chromium.org > BUG=v8:4566 > LOG=N > > Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff > Cr-Commit-Position: refs/heads/master@{#32211} > > Committed: https://crrev.com/3d84f05cd77091ea8dde7821973f13f53dbaa730 > Cr-Commit-Position: refs/heads/master@{#32238} TBR=jkummerow@chromium.org,erikcorry@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4566 Review URL: https://codereview.chromium.org/1480533002 Cr-Commit-Position: refs/heads/master@{#32243}
-
yangguo authored
Credits go to Erik Corry. Taken from: https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc R=jkummerow@chromium.org BUG=v8:4566 LOG=N Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff Cr-Commit-Position: refs/heads/master@{#32211} Review URL: https://codereview.chromium.org/1467133006 Cr-Commit-Position: refs/heads/master@{#32238}
-
- 24 Nov, 2015 2 commits
-
-
machenbach authored
Revert of Add test to check PRNG quality. (patchset #3 id:40001 of https://codereview.chromium.org/1467133006/ ) Reason for revert: [Sheriff] Times out on arm: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim/builds/6202/steps/Check/logs/RandomBitCorrelations Original issue's description: > Add test to check PRNG quality. > > Credits go to Erik Corry. Taken from: > https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc > > R=jkummerow@chromium.org > BUG=v8:4566 > LOG=N > > Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff > Cr-Commit-Position: refs/heads/master@{#32211} TBR=jkummerow@chromium.org,erikcorry@google.com,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4566 Review URL: https://codereview.chromium.org/1473613002 Cr-Commit-Position: refs/heads/master@{#32215}
-
yangguo authored
Credits go to Erik Corry. Taken from: https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc R=jkummerow@chromium.org BUG=v8:4566 LOG=N Review URL: https://codereview.chromium.org/1467133006 Cr-Commit-Position: refs/heads/master@{#32211}
-
- 08 Oct, 2015 1 commit
-
-
mythria authored
Removes deprecated functions from the following files: test/cctest/test-object-observe.cc test/cctest/test-parsing.cc test/cctest/test-platform.cc test/cctest/test-platform-linux.cc test/cctest/test-platform-win32.cc test/cctest/test-profile-generator.cc test/cctest/test-random-number-generator.cc test/cctest/test-regexp.cc test/cctest/test-reloc-info.cc test/cctest/test-representation.cc test/cctest/test-sampler-api.cc test/cctest/test-serialize.cc test/cctest/test-simd.cc test/cctest/test-slots-buffer.cc test/cctest/test-spaces.cc test/cctest/test-strings.cc test/cctest/test-strtod.cc test/cctest/test-symbols.cc test/cctest/test-threads.cc BUG=v8:4134 LOG=n Review URL: https://codereview.chromium.org/1371363006 Cr-Commit-Position: refs/heads/master@{#31173}
-
- 29 Apr, 2015 1 commit
-
-
jochen authored
We shouldn't have shared state between isolates by default. The embedder is free to pass the same allocator to all isolates it creates. BUG=none R=dcarney@chromium.org LOG=y Review URL: https://codereview.chromium.org/1116633002 Cr-Commit-Position: refs/heads/master@{#28127}
-
- 21 Apr, 2015 1 commit
-
-
svenpanne authored
Baby steps towards saner #includes... Review URL: https://codereview.chromium.org/1051393003 Cr-Commit-Position: refs/heads/master@{#27958}
-
- 19 Sep, 2014 1 commit
-
-
jochen@chromium.org authored
> We also initialize the Isolate on creation. > > This should allow for getting rid of the last remaining default isolate > traces. Also, it'll speed up several isolate related operations that no > longer require locks. > > Embedders that relied on v8::Isolate to return an uninitialized Isolate > (so they can set ResourceConstraints for example, or set flags that > modify the way the isolate is created) should either do the setup before > creating the isolate, or use the recently added CreateParams to pass e.g. > ResourceConstraints. > > BUG=none > LOG=y > R=svenpanne@chromium.org > > Review URL: https://codereview.chromium.org/469783002 BUG=none LOG=y TBR=svenpanne@chromium.org Review URL: https://codereview.chromium.org/583153002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24067 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 18 Sep, 2014 2 commits
-
-
jochen@chromium.org authored
LOG=n TBR=svenpanne@chromium.org BUG=none Review URL: https://codereview.chromium.org/582953002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24055 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
We also initialize the Isolate on creation. This should allow for getting rid of the last remaining default isolate traces. Also, it'll speed up several isolate related operations that no longer require locks. Embedders that relied on v8::Isolate to return an uninitialized Isolate (so they can set ResourceConstraints for example, or set flags that modify the way the isolate is created) should either do the setup before creating the isolate, or use the recently added CreateParams to pass e.g. ResourceConstraints. BUG=none LOG=y R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/469783002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24052 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
Our own ARRAY_SIZE() was pretty bad at error checking. If you use arrasize() in a wrong way, the compiler will issue an error instead of silently doing the wrong thing. The previous ARRAY_SIZE() macro is still available as ARRAYSIZE_UNSAFE() similar to Chrome. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/501323002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23389 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
TEST=base-unittests BUG=v8:3489 LOG=y R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/448603002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22911 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
Also split v8-core independent methods from checks.h to base/logging.h and merge v8checks with the rest of checks. The CPU::FlushICache method is moved to CpuFeatures::FlushICache RoundUp and related methods are moved to base/macros.h Remove all layering violations from src/libplatform BUG=none R=jkummerow@chromium.org LOG=n Review URL: https://codereview.chromium.org/358363002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Jun, 2014 1 commit
-
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/333013002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21894 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
This will allow for using the RNG from platform files without depending on isolates. BUG=none R=bmeurer@chromium.org LOG=n Review URL: https://codereview.chromium.org/333053002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21879 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Sep, 2013 2 commits
-
-
bmeurer@chromium.org authored
TBR=svenpanne@chromium.org Review URL: https://codereview.chromium.org/23658034 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16617 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Introduce a RandonNumberGenerator class. Refactor the random/private_random uses in Isolate/Context. The RandomNumberGenerator is a pseudorandom number generator with 48-bit state. It is properly seeded using either (1) the --random-seed if specified, or (2) the entropy_source function if configured, or (3) /dev/urandom if available, or (4) falls back to Time and TimeTicks based seeding. Each Isolate now contains a RandomNumberGenerator, which replaces the previous private_random_seed. Every native context still has its own random_seed. But this random seed is now properly initialized during bootstrapping, instead of on-demand initialization. This will allow us to cleanup and speedup the HRandom implementation quite a lot (this is delayed for a followup CL)! Also stop messing with the system rand()/random(), which should not be done from a library anyway! We probably re-seeded the libc rand()/random() after the application (i.e. Chrome) already seeded it (with better entropy than what we used). Another followup CL will replace the use of the per-isolate random number generator for the address randomization and thereby get rid of the Isolate::UncheckedCurrent() usage in the platform code. TEST=cctest/test-random-number-generator,cctest/test-random R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/23548024 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16612 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Aug, 2013 1 commit
-
-
bmeurer@chromium.org authored
The name NumberOfCores is misleading, as it does not return the actual number of cores. While NumberOfProcessorsOnline is also not a great name, it's at least consistent with the operating system terminology. R=verwaest@chromium.org Review URL: https://codereview.chromium.org/23655004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16392 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Aug, 2013 1 commit
-
-
bmeurer@chromium.org authored
Move all of the CPU detection logic to the CPU class, and make all other code use the CPU class for feature detection. This also fixes the ARM CPU feature detection logic, which was based on fragile string search in /proc/cpuinfo. Now we use ELF hwcaps if available, falling back to sane(!!) parsing of /proc/cpuinfo for CPU features. The ia32 and x64 code was also cleaned up to make it usable outside the assembler. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/23401002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16315 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Apr, 2013 1 commit
-
-
ulan@chromium.org authored
This allows to distinguish between stubs compiled for the current object from stubs compiled for objects that have the current object as a prototype. BUG=v8:2593 R=verwaest@chromium.org Review URL: https://chromiumcodereview.appspot.com/13552003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@14132 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Feb, 2013 1 commit
-
-
mstarzinger@chromium.org authored
R=verwaest@chromium.org BUG=v8:2539 TEST=mjsunit/regress/regress-2539 Review URL: https://codereview.chromium.org/12255033 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13673 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Jan, 2013 1 commit
-
-
mstarzinger@chromium.org authored
This fixes materialization of the arguments object in case the constant function check if TryCallApply() inside an inlined frame fails. R=svenpanne@chromium.org BUG=v8:2489 TEST=mjsunit/regress/regress-2489 Review URL: https://codereview.chromium.org/11931012 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13386 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Mar, 2012 1 commit
-
-
yangguo@chromium.org authored
BUG= TEST=regress-sqrt.js Review URL: https://chromiumcodereview.appspot.com/9690010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11012 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 13 Jan, 2012 1 commit
-
-
yangguo@chromium.org authored
BUG=v8:1898 TEST=mjsunit/regress/regress-1898.js Review URL: http://codereview.chromium.org/9190047 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10396 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Nov, 2009 1 commit
-
-
fschneider@chromium.org authored
Also added a simple test that invokes a JS runtime function in top-level code. Review URL: http://codereview.chromium.org/437081 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3371 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 23 Oct, 2009 1 commit
-
-
sgjesse@chromium.org authored
If we had compiled the comment instead of the code it would have worked. BUG=483 TEST=mjsunit/regress/regress-483.js Review URL: http://codereview.chromium.org/332007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3120 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Oct, 2009 1 commit
-
-
sgjesse@chromium.org authored
The check for arguments in registers in one of the three versions of GenericBinaryOpStub::GenerateCall was plain wrong. BUG=475 TEST=mjsunit/regress/regress-475.js Review URL: http://codereview.chromium.org/307002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Mar, 2009 1 commit
-
-
olehougaard authored
Review URL: http://codereview.chromium.org/39126 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1416 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 26 Sep, 2008 1 commit
-
-
christian.plesner.hansen@gmail.com authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@386 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Sep, 2008 1 commit
-
-
christian.plesner.hansen@gmail.com authored
Added presubmit step to check copyright. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-