- 07 Oct, 2021 1 commit
-
-
Jakob Gruber authored
Certain collators and subject strings may take this new fast path without calling into the (slow) ICU comparison functions. This CL can be roughly split into three topics: 1. The fast path check, precomputed and implemented as a whitelist on the current locale string. 2. The actual fast path, which checks subject string eligibility and performs L1 and L3 collation weight comparisons all in one pass. 3. Resuming from an aborted fast-path into the generic path. A longer overview is available at https://docs.google.com/document/d/1oyDwjYn2JyHsx2YnJJKhjX0WMNQXb8ao86-DRzqiYNg/edit?usp=sharing JetStream2/cdjs scores improve by roughly 40%. Bug: v8:12196 Change-Id: I5e1bbd731a36c361af9667f9104d6fa15c42e117 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149463Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77284}
-
- 24 Sep, 2021 1 commit
-
-
Marja Hölttä authored
Bug: v8:12244 Change-Id: I9ec30012f7238f53448b80cf9d657571a37502a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3180822Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#77030}
-
- 14 Sep, 2021 1 commit
-
-
Frank Tang authored
Refactor generic option reading facility also used by Temporal from intl-objects.* to option-util.* See https://tc39.es/proposal-temporal/#sec-getoptionsobject https://tc39.es/proposal-temporal/#sec-getoptionsobject-deleted https://tc39.es/ecma402/#sec-getoptionsobject Bug: v8:11544 Change-Id: I8b27e8fa3515c1287217c2fbe225172fb8f69210 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3122501Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#76824}
-
- 09 Sep, 2021 1 commit
-
-
Jakob Gruber authored
The icu object cache consists of 5 keys at most -> change it from an unordered_set to a plain array. Possible return values of CompareStrings are {-1,0,1}. Return those directly instead of going through Factory::NewNumberFromInt. Bug: v8:12196 Change-Id: Ia42bb6b1a0ebdc99550f604aa79cb438b150ee88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3149454 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#76746}
-
- 12 Aug, 2021 1 commit
-
-
Frank Tang authored
flag --harmony_intl_enumeration I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/Txtf_rSqGH8/m/e27FY33JAQAJ Design Doc: https://docs.google.com/document/d/1lbj_YVW-xhzYNMQeHB-qDjVkf4SA-eTHYpYXx3Oaud8 https://chromestatus.com/guide/edit/5649454590853120 Bug: v8:10743 Change-Id: I3bfe0c25b50eb55025498534eba975a20723bd2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953519 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#76265}
-
- 07 May, 2021 1 commit
-
-
Frank Tang authored
This API is the new public one added in ICU 69.1 in https://github.com/unicode-org/icu/pull/1610 Bug: v8:11512 Change-Id: I424e15e6a60edee7c98e6ce55974986f0bb6ab1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2876368 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#74428}
-
- 26 Feb, 2021 1 commit
-
-
Frank Tang authored
Add GetOptionsObject/CoerceOptionsToObject for ECMA402 2021 Change Intl.ListFormat / Intl.DisplayNames and Intl.Segmenter to use GetOptionsObject and keep old API under CoerceOptionsToObject based on https://github.com/tc39/ecma402/pull/538/files Test262 tests need to be changed per https://github.com/tc39/test262/issues/2950 Bug: v8:11466 Change-Id: I5cb9b7aba0556effc76b4005e95c90db1e59d41f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2705696 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#73082}
-
- 19 Nov, 2020 1 commit
-
-
Frank Tang authored
roll node-ci in https://chromium-review.googlesource.com/c/v8/node-ci/+/2547360 Bug: chromium:1138555 Change-Id: I894f47023ea45493d94a107ca22038a54543fc6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543263 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#71286}
-
- 21 Jul, 2020 1 commit
-
-
Frank Tang authored
Per change in https://github.com/tc39/ecma402/pull/459/ Bug: v8:10732 Change-Id: I2ef21e8b450cbf9c61f987c61f3ba7d6959db81a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2309149Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68976}
-
- 10 Jun, 2020 1 commit
-
-
Ng Zhi An authored
This destructor is declared virtual, but the class is not subclassed anywhere. The empty body can be replaced by a =default. But since the destructor doesn't do anything interesting, we can remove it. Bug: v8:10488 Change-Id: Ie9c5f2c2742f644a99d85111dec208b01ad13fba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219397 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68276}
-
- 04 Jun, 2020 1 commit
-
-
Frank Tang authored
This reverts commit 3b1d24cf. Reason for revert: The problem is fixed Original change's description: > Revert "[Intl] Use new getDefaultHourCycle to replace old hack" > > This reverts commit 611e4127. > > Reason for revert: https://crbug.com/1080367 > > Original change's description: > > [Intl] Use new getDefaultHourCycle to replace old hack > > > > Use the ICU 67.1 new API DateTimePatternGenerator::getDefaultHourCycle > > to replace a hack which get the pattern of "jjmm" to find out the > > default hour cycle of a locale > > Bump the required API version from 65 to 67 > > > > Bug: v8:10225 > > Change-Id: I3378edacb6dfb8400357ac0bf3d5d50b9fe008bd > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173875 > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > > Commit-Queue: Frank Tang <ftang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#67549} > > TBR=jkummerow@chromium.org,ftang@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: v8:10225 > Change-Id: I8bdfbdfc6c906814e5a7525cbde79c9cac854bd1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208811 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67929} TBR=jkummerow@chromium.org,zhin@chromium.org,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:10225 Change-Id: I386cf0347a0fa5403fb196bb46ac77f48c9c0a0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2229470Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#68165}
-
- 26 May, 2020 1 commit
-
-
Ng Zhi An authored
Recommended by clang-tidy's modernize-use-nullptr. Bug: v8:10488 Change-Id: I7cf26f7bda69b9b1a6bdabe274399b494f6d49ed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211155Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67979}
-
- 20 May, 2020 1 commit
-
-
Zhi An Ng authored
This reverts commit 611e4127. Reason for revert: https://crbug.com/1080367 Original change's description: > [Intl] Use new getDefaultHourCycle to replace old hack > > Use the ICU 67.1 new API DateTimePatternGenerator::getDefaultHourCycle > to replace a hack which get the pattern of "jjmm" to find out the > default hour cycle of a locale > Bump the required API version from 65 to 67 > > Bug: v8:10225 > Change-Id: I3378edacb6dfb8400357ac0bf3d5d50b9fe008bd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173875 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67549} TBR=jkummerow@chromium.org,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:10225 Change-Id: I8bdfbdfc6c906814e5a7525cbde79c9cac854bd1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2208811Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67929}
-
- 04 May, 2020 1 commit
-
-
Frank Tang authored
Use the ICU 67.1 new API DateTimePatternGenerator::getDefaultHourCycle to replace a hack which get the pattern of "jjmm" to find out the default hour cycle of a locale Bump the required API version from 65 to 67 Bug: v8:10225 Change-Id: I3378edacb6dfb8400357ac0bf3d5d50b9fe008bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173875Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67549}
-
- 01 Apr, 2020 1 commit
-
-
Frank Tang authored
Use new API available in ICU65.1 so legacy locales won't be hidden. Bug: v8:9312,chromium:968269 Change-Id: I6e44501249cdb863ff9b1ab858efdf8908380a82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2131373 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#66957}
-
- 24 Feb, 2020 1 commit
-
-
Frank Tang authored
Bug: v8:10224 Change-Id: Ief05b93d71f6da53b0bcfd68719fa79fc2b59e51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2068903Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#66410}
-
- 21 Feb, 2020 1 commit
-
-
Frank Tang authored
Move functions into anonymous namespce. Remove dead code. Move GetCaseFirst into JSCollator Move HourCycle, ToHourCycle and GetHourCycle into JSDateTimeFormat Change-Id: Ie6089e7f33677dd40169c56198b52d87ba490b20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2067689 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#66395}
-
- 19 Dec, 2019 1 commit
-
-
Frank Tang authored
Bug: chromium:1014272 Change-Id: I5707dbfcff4ac52f7f27b0f9feb2edfe1c7775ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1972425Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#65514}
-
- 18 Nov, 2019 1 commit
-
-
Frank Tang authored
Design Doc https://shorturl.at/emEHW I2I: http://shorturl.at/pKRUV Bug: v8:8703 Change-Id: I9573b2ee6f1dce4dc594aa1df2753095f45af15e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1848683Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#65021}
-
- 11 Oct, 2019 1 commit
-
-
Frank Tang authored
* Change the logic to reflect the spec change of https://github.com/tc39/proposal-intl-datetime-style/pull/37/ * Move enum value of kUndefined to 0 to make unset behavior the same as kUndefined. * Change the expectation of existing tests * Additional tests - https://github.com/tc39/test262/pull/2385 Bug: v8:9826 Change-Id: Ic437b5f6414aa641ae73766d8c5fd5b9d352a230 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1846722Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#64255}
-
- 01 Oct, 2019 1 commit
-
-
Frank Tang authored
* Throws RangeError only when the calendar and numberingSystem is ill-formed. * Set the calendar and numberingSystem to the locale only if the values are valid. * Fix the order of GetOption of "localeMatcher". * Add more unit tests. See https://github.com/tc39/ecma402/pull/175 for details. Bug: v8:9786, v8:9787, v8:9788 Change-Id: Ic0f918ad7d9afb0b7c8df39caa0f44ef07ca10c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1830345 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64070}
-
- 16 Sep, 2019 1 commit
-
-
Frank Tang authored
Bug: v8:9613 Change-Id: Ie91a5bd39c82b6baf33fd84dee8420d2c4a5f504 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803783 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63815}
-
- 13 Sep, 2019 1 commit
-
-
Clemens Hammacher authored
After https://crrev.com/c/1800575 and https://crrev.com/c/1803343, which tried to fix this on occuring compile errors, this CL systematically adds the <memory> include to each header that uses {std::unique_ptr}. R=sigurds@chromium.org TBR=mlippautz@chromium.org,alph@chromium.org,rmcilroy@chromium.org,verwaest@chromium.org Bug: v8:9396 Change-Id: If7f9c3140842f9543135dddd7344c0f357999da0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803349Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#63767}
-
- 12 Sep, 2019 1 commit
-
-
Frank Tang authored
Bug: v8:9464 Change-Id: I3252de850bbaa5fdb15f5fc2103f1ebb7be3e1ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799396 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63734}
-
- 28 Jun, 2019 1 commit
-
-
Frank Tang authored
1. Move the reading of Notation before calling SetNumberFormatDigitOptions() ( sync after https://github.com/tc39/proposal-unified-intl-numberformat/pull/37) 2. Sync SetNumberFormatDigitOptions to the spec. 3. Consider the case that while RoundingType is "compact-rounding" do not set the precision. 4. correct the tests accordingly. 5. Fix the rounding of notation: "compact" and put regression cases into test/intl/regress-9408.js Bug: v8:9408 Change-Id: I78d66601fe21b1a74a50047b2abe6a2838a58b8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1681599 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62450}
-
- 27 Jun, 2019 1 commit
-
-
Zhang, Shiyu authored
The localeCompare for ASCII chars needs to expand the string contents from one-byte representation into two-byte representation, which requires memory copy. This CL skips the representation conversion by using compareUTF8. It can improve the JetStream2 cdjs case by 21% on my machine. Change-Id: I3841dc700e36744aadd9a1ff9fa7d93c84dc04fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624705 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62408}
-
- 21 Jun, 2019 1 commit
-
-
Frank Tang authored
1. Check resources and not solely depend on res_index.res file 2. Performance is +2-3% for Collator, DateTimeFormat, Locale, -2-3% for PluralRules, RelativeTimeFormat, ListFormat, NumberFormat Consider we improve the performance x3 not long ago, these perf regression could be ignored. Bug: v8:9340 Change-Id: Iab7cd64a77a55a03aae40f4d477523c37b3bcd3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1655978 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#62322}
-
- 19 Jun, 2019 1 commit
-
-
Dan Elphick authored
Fix JSSegmentIterator::Create getting the unicode string as a raw object pointer and then performing memory allocation which then invalidates it. This changes SetTextToBreakIterator to return a handle instead. Bug: v8:6891 Change-Id: I57e175b31e78a074a0b3c5a8fc26b4af05b4a752 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1667409 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#62287}
-
- 06 Jun, 2019 1 commit
-
-
Frank Tang authored
quarter option- see https://github.com/tc39/ecma402/pull/345 dayPeriod option- see https://github.com/tc39/ecma402/pull/346 fractionalSecondDigits option- see https://github.com/tc39/ecma402/pull/347 2019-6-5 TC39 presentation- http://shorturl.at/mtB12 test262: https://github.com/tc39/test262/pull/2194 I2I: http://shorturl.at/beCNV (for quarter) I2I: http://shorturl.at/bekrZ (for dayPeriod) I2I: http://shorturl.at/flwF5 (for fractionalSecondDigits) Bug: v8:9282,v8:9283,v8:9284 Change-Id: I99f4c0f861507c7451497b735a276780bb8aead6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1621445 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62041}
-
- 23 May, 2019 1 commit
-
-
Yang Guo authored
TBR=bmeurer@chromium.org,leszeks@chromium.org Bug: v8:9247 Change-Id: I8d14d0192ea8c705f8274e8e61a162531826edb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1624220Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#61769}
-
- 10 May, 2019 2 commits
-
-
Frank Tang authored
1. Use the newer LocalizedNumberFormatter API which improve the performance score x3.3. Here are how I got the performance score: $ python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Intl" \ test/js-perf-test/JSTests5.json Look for NewIntlNumberFormat-Intl(Score) for 3 runs. BEFORE: 539 507 507 AFTER: 2009 2069 1994 2. Also add symbol and enum to prepare implementing of the unified number proposal. Bug: v8:8515 Change-Id: Ie1ca1dba1e806449632cc96b81d44f0dc61b6093 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1392233 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#61421}
-
Frank Tang authored
Create an Intl::GetNumberingSystem function shared by several Intl object which throw exception internally. Bug: v8:9190 Change-Id: Ibe658e61bc8d0e5c061b26fe8527e69d086ea185 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1590442Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#61419}
-
- 29 Apr, 2019 1 commit
-
-
Frank Tang authored
Implement ECMA402 PR https://github.com/tc39/ecma402/pull/175 Add numberingSystem option to NumberFormat And numberingSystem and calendar option to DateTimeFormat Bug: v8:9154 Change-Id: Ic4e85a232a9ad26c17ee20385f839b0e09a56c77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575919Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#61061}
-
- 19 Apr, 2019 1 commit
-
-
Frank Tang authored
Design Doc: https://goo.gl/PGUQ1d Use template to share code between formatRange and formatRangeToParts Lazy crate DateIntervalFormat inside formatRange/formatRangeToParts to reduce performance impact. Bug: v8:7729 Change-Id: I130748a5ff7ca11235e6608195d365e58d440580 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1556573 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#60930}
-
- 12 Apr, 2019 1 commit
-
-
Frank Tang authored
1. Add Intl::NumberFieldToType to support RelativeTimeFormat by refactoring IcuNumberFieldIdToNumberType 2. Use formatNumericToValue / formatToValue to implement formatToParts Bug: v8:8837 Change-Id: I4d8fab9c337ec02eeb3500b4c0f90547e48444e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1560661Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#60797}
-
- 04 Apr, 2019 1 commit
-
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: I1b9f3c0c805709c6570785ec9f1045f21c9d03e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541048Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60638}
-
- 08 Feb, 2019 1 commit
-
-
Frank Tang authored
Bug: chromium:928098 Change-Id: I47333b06bb7cf2319eec6f6beab830ce6c6da1c5 Reviewed-on: https://chromium-review.googlesource.com/c/1461162Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#59474}
-
- 07 Feb, 2019 1 commit
-
-
Frank Tang authored
Lazy initialize some data once. $ python -u tools/run_perf.py --binary-override-path out/x64.release/d8 --filter "JSTests/Intl" test/js-perf-test/JSTests.json INFO >>> Running suite: JSTests/Intl INFO >>> Stdout (#1): NewIntlCollator-Intl(Score): 2047 NewIntlDateTimeFormat-Intl(Score): 26.5 NewIntlNumberFormat-Intl(Score): 449 NewIntlPluralRules-Intl(Score): 670 NewIntlListFormat-Intl(Score): 1762 NewIntlRelativeTimeFormat-Intl(Score): 918 Compare to performance baseline scores in https://chromium-review.googlesource.com/c/v8/v8/+/1455717 Bug: chromium:928098 Change-Id: I7f213f50eb261474fb38d9592725a101939020d8 Reviewed-on: https://chromium-review.googlesource.com/c/1455727 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#59425}
-
- 06 Feb, 2019 1 commit
-
-
Frank Tang authored
1. Change the function to align with UTS35 instead of (old) RFC. 2. Restrict tag as Unicode Locale Identifier by code that on top of ICU. Because icu::Locale in ICU63 is not tight enough to restrict that. Added comments to show what to do (to use icu::LocaleBuilder) after the landing of ICU64 3. Fix to pass two tests in test262. Bug: v8:8262,v8:8670,v8:7684 Change-Id: If244647e6a50daae305b9ae1a569100859be8a0c Reviewed-on: https://chromium-review.googlesource.com/c/1435737 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#59382}
-
- 04 Jan, 2019 1 commit
-
-
Frank Tang authored
Make the function return Maybe<std::string> to propagate error. Bug: chromium:917151 Change-Id: I4330b0c54c122b1eddd3b37e21e0f387cb5d803a Reviewed-on: https://chromium-review.googlesource.com/c/1392205Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58535}
-