- 06 Jun, 2018 8 commits
-
-
Andreas Haas authored
The typical use of assertThrowsEquals is to check that a specific object is thrown. However, assertEquals only does a proper equality check for primitive types, not for complex types. Using assertSame does a reference equality check on objects, which is more what you would expect from assertThrowsEquals. For exception kind testing, assertThrowsEquals actually did not work correctly, assertThrows is better for that case. R=clemensh@chromium.org, mythria@chromium.org Change-Id: I24fb22e75fa33ebe90eb4bae40825119a054bba5 Reviewed-on: https://chromium-review.googlesource.com/1087952Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#53556}
-
Bill Budge authored
This reverts commit 3c4d0316. Reason for revert: Breaks MSAN on ARM64 https://ci.chromium.org/buildbot/client.v8/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/21425 'enabled' field not initialized in constructor? Original change's description: > [async] Expose async hooks to d8 > > This implementation follows the Node.js API as a guideline. > > Change-Id: I09274ea25ccdbb9794a7440d6c14f26b9febb4f4 > Reviewed-on: https://chromium-review.googlesource.com/1065818 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Ali Ijaz Sheikh <ofrobots@google.com> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53551} TBR=ofrobots@google.com,gsathya@chromium.org,bmeurer@chromium.org,mslekova@chromium.org Change-Id: I8b2bedb51cba18c77578d4e223474015d819e428 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1088811Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#53555}
-
Maya Lekova authored
This implementation follows the Node.js API as a guideline. Change-Id: I09274ea25ccdbb9794a7440d6c14f26b9febb4f4 Reviewed-on: https://chromium-review.googlesource.com/1065818 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#53551}
-
Ivica Bogosavljevic authored
Test ThreadTicks.ThreadNow fails on systems with low resolution thread timers because the tests detects that no time elapsed since the beginning of the test. This CL adds a counting loop that makes sure the thread timer has progressed by at least one tick. TEST=unittests/ThreadTicks.ThreadNow Change-Id: I910309208b3a154798cbc43813d41d3755ab819d Reviewed-on: https://chromium-review.googlesource.com/1082352 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#53548}
-
Camillo Bruni authored
Bug: chromium:850005 Change-Id: I287a274b86941e7d29705a24e479e4a02ecdfb07 Reviewed-on: https://chromium-review.googlesource.com/1088608Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#53546}
-
Anna Henningsen authored
`SetBuildEmbedderGraphCallback`, unlike `SetWrapperClassInfoProvider`, assumes a monolithic embedder that can provide all necessary information. That is not the case for e.g. Node.js, which can e.g. provide multiple Node.js instances per V8 Isolate, as well as native addons that may allocate resources on their own. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib53dfde82416dd69934b08623e27d674a483ac2d Reviewed-on: https://chromium-review.googlesource.com/1082441 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53545}
-
jgruber authored
Enabling once again post-branch point. This CL is expected to come with major memory improvements and slight performance regressions. Recent work on performance improvements has focused on x64, hence only enabling there for now. Bug: v8:6666 Change-Id: I29dc55eb4e592465073559647e280f74253b73e1 Reviewed-on: https://chromium-review.googlesource.com/1076247 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53544}
-
Michael Achenbach authored
This reverts commit 91bab558. Reason for revert: Seems to break a layout test: https://ci.chromium.org/buildbot/client.v8.fyi/V8-Blink%20Linux%2064/23895 See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original change's description: > [array] Use random middle element to determine pivot during sorting > > This CL adds a "random state" to the Smi Root list and implements a > basic Linear congruential pseudo random number generator in Torque. > > The RNG is used to determine the pivot element for sorting. This will > prevent the worst cases for certain data layouts. > > Drive-by-fix: Make sorting of ranges and execution pauses for profviz > deterministic by adding a secondary sorting criteria. > > Bug: v8:7382 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Ieb871e98e74bdb803f821b0cd35d2f67ee0f2868 > Reviewed-on: https://chromium-review.googlesource.com/1082193 > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Commit-Queue: Simon Zünd <szuend@google.com> > Cr-Commit-Position: refs/heads/master@{#53524} TBR=hpayer@chromium.org,cbruni@chromium.org,jgruber@chromium.org,szuend@google.com Change-Id: I54f5d3f719428fd089ff12ff217d1c819f9ad1f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7382 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1088506Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53542}
-
- 05 Jun, 2018 22 commits
-
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: chromium:849656 Change-Id: I4c1990e10905969c94913f434ec0013e5cbbfb19 Reviewed-on: https://chromium-review.googlesource.com/1087273Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53535}
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: chromium:849656 Change-Id: I34effca4770f732216b93b5e4e8c28383f2f9963 Reviewed-on: https://chromium-review.googlesource.com/1087271Reviewed-by:
-
Alexey Kozyatinskiy authored
DevTools may process another protocol message during API interrupt this API may lead to createInjectedScript reentrance and will fail. Let's postpone interrupts. Bug: chromium:846099 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia06e034a6287087e4674559d8911d2f4a0b1b459 Reviewed-on: https://chromium-review.googlesource.com/1086372 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#53531}
-
Alexey Kozyatinskiy authored
Currently we enable instrumentation if debugger is active. With this approach we can not: - capture async stack when debugger is disabled, - avoid async instrumentation overhead when debugger is enabled and async stacks are disabled. R=dgozman@chromium.org,yangguo@chromium.org Bug: none Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I19400c4c4e12b6c9b5a980fb6bd3293bac6e6a64 Reviewed-on: https://chromium-review.googlesource.com/1081494 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Mathias Bynens authored
It was shipped in Chrome 66. Bug: v8:6889 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I6333ee20ab913b281674b911d525d2851f4694c9 Reviewed-on: https://chromium-review.googlesource.com/1086928Reviewed-by:
-
jgruber authored
`date` could be outside the int32_t range and thus FastD2I may not be used. Bug: chromium:849663 Change-Id: I96a012b40d35ec8f80e449e4e687b0ce7b572d5e Reviewed-on: https://chromium-review.googlesource.com/1087063Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53526}
-
Simon Zünd authored
This CL adds a "random state" to the Smi Root list and implements a basic Linear congruential pseudo random number generator in Torque. The RNG is used to determine the pivot element for sorting. This will prevent the worst cases for certain data layouts. Drive-by-fix: Make sorting of ranges and execution pauses for profviz deterministic by adding a secondary sorting criteria. Bug: v8:7382 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ieb871e98e74bdb803f821b0cd35d2f67ee0f2868 Reviewed-on: https://chromium-review.googlesource.com/1082193Reviewed-by:
-
Leszek Swirski authored
SharedFunctionInfos store their original function literal's id. This is also their index in the Script's SFI list. Since the function literal id is only needed for lazy compilation and live edit, we can calculate it on-the-fly by linear search in the Script SFI list, and save a field on the SFI. If this regresses compile performance, we could alternatively store the function literal id on the preparsed scope data as future work. Bug: chromium:818642 Change-Id: I5468cea0e115921f1c864d94e567d749a4349882 Reviewed-on: https://chromium-review.googlesource.com/1082480 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#53523}
-
Simon Zünd authored
This CL changes the behaviour of number literals. Large integer literals (bigger than Smi, but fit into int32) should have type "constexpr int32" instead of "constexpr float64". R=tebbi@chromium.org Change-Id: I3a83c617c7d257451d299670c891fac5b21d045c Reviewed-on: https://chromium-review.googlesource.com/1084991 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53522}
-
Tobias Tebbi authored
Bug: v8:7793 Change-Id: I69e27cb1e8477ca0d64ad7a96ab256cae96339f4 Reviewed-on: https://chromium-review.googlesource.com/1086801Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53521}
-
Camillo Bruni authored
Bug: chromium:848622 Change-Id: I8fff648fc4867cfbad1ee762652a5e628c66aeaa Reviewed-on: https://chromium-review.googlesource.com/1086929Reviewed-by:
-
Igor Sheludko authored
This CL introduces a new gn argument: v8_enable_pointer_compression which is false by default. All the changes done in this CL are made under this flag. Upper half-word of a Smi word must be properly sign-extended according to the sign of the lower-half containing the actual Smi value. Bug: v8:7703 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I2b52ab49cd18c7c613130705de445fef44c30ac5 Reviewed-on: https://chromium-review.googlesource.com/1061175Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#53519}
-
Dan Elphick authored
Removes all explicit calls to GetIsolate() in transitions.cc by passing it through calling functions and implicit calls via the single argument Handle constructor and handle function. Unfortunately in the interests of making these changes vaguely manageable, I've also pushed some new GetIsolates down into objects-debug.cc, objects-printer.cc and objects.cc. Bug: v8:7786 Change-Id: I1f98530dec6c004e17dc3336f3cef09fbb446bae Reviewed-on: https://chromium-review.googlesource.com/1085451 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Anna Henningsen authored
Add an inspection callback for embedders that allows tracking of `Atomics.wait()` calls in order to enable diagnostic tooling around it, as well as providing a way to break out of an `Atomics.wait()` call without having to fully terminate execution. The motivation here is that this allows embedders to perform somewhat customizable deadlock detection. Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib6346747aa3cbffb07cf6abd12645e2d98584f0f Reviewed-on: https://chromium-review.googlesource.com/1080788 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#53517}
-
Amos Lim authored
date in Makeday should be converted to integer. https://www.ecma-international.org/ecma-262/5.1/#sec-15.9.1.12 Bug: v8:7475,chromium:846723 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I3aa725e7ce1822345502284aec919695c4ca084d Reviewed-on: https://chromium-review.googlesource.com/1080110 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Mythri authored
This cl enables sharing of feedback slots for load / sotre named property. This is a follow up cl of https://chromium-review.googlesource.com/c/v8/v8/+/966302 that introduces this feature. Bug: v8:7530 Change-Id: I0c056b7a3608117db2fc99ebcd6836dfeed471d8 Reviewed-on: https://chromium-review.googlesource.com/1065737Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Mathias Bynens authored
It was shipped in Chrome 64. Bug: v8:4743 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I1084f55d19c0370d344acedeab630f03c02f49e5 Reviewed-on: https://chromium-review.googlesource.com/1086799Reviewed-by:
-
Dan Elphick authored
Removes most[1] explicit calls to GetIsolate() in parsing/ by passing it through calling function functions and implicit calls via the single argument Handle constructor and handle function. [1] One remains in preparsed-scope-data.cc: data_->GetIsolate()->PushStackTraceAndDie() Bug: v8:7786 Change-Id: I4c445995a73c19bdf4649b65487b7443d56ddd2a Reviewed-on: https://chromium-review.googlesource.com/1085057Reviewed-by:
-
jgruber authored
This is a reland of 515cc07d Original change's description: > [csa] Ensure the requested allocation size fits in a Smi > > In CSA::AllocateRaw, ensure that the given allocation size fits into a > Smi. > > Bug: chromium:848672 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I4e74791296163188b1ca77cae8226a9833fba8ef > Reviewed-on: https://chromium-review.googlesource.com/1084930 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53495} TBR=yangguo@chromium.org,ishell@chromium.org Bug: chromium:848672 Change-Id: I135868390784a0ee95ff42224dd00f66f3bf2d80 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1086828 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Simon Zünd authored
This is a reland of df1676e6 Original change's description: > [array] Implement Array.p.sort in Torque > > This CL implements a generic baseline version and 3 fastpaths, for > various elements kinds, of Array.p.sort in Torque. Details can be found > in the Design Doc: https://goo.gl/Ge321G. > > Performance impact on micro benchmarks depends on the element kind > and whether the user provides a comparison function. > For HoleySmi/HoleyElement we have a speedup between 1.5-1.8 across > the board. For Dictionary we are slower in all micro benchmarks (0.7). > For PackedSmi it depends on the call site and whether or not a > comparison function is used. > > Detailed numbers: https://goo.gl/mTyPSb > > Bug: v8:7382 > Change-Id: I50acabd2032af0bc01d36b0de0f555d66be56a7e > Reviewed-on: https://chromium-review.googlesource.com/1061523 > Commit-Queue: Simon Zünd <szuend@google.com> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53481} Bug: v8:7382,v8:7806,chromium:849293 Change-Id: I176cb660d92eb174bd91685cb0a39f50c4cbaa69 Reviewed-on: https://chromium-review.googlesource.com/1086827Reviewed-by:
-
Mathias Bynens authored
It was shipped in Chrome 64. Bug: v8:5437 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I6d9ac762b2eafdf4e64fd1dd10dbce553a8455f9 Reviewed-on: https://chromium-review.googlesource.com/1086790Reviewed-by:
-
Alexey Kozyatinskiy authored
Added tests that I forgot to commit with big debug.js removal. TBR=dgozman@chromium.org Bug: none Change-Id: I518dd254af116d391a2af96a6f6c11da457129a1 Reviewed-on: https://chromium-review.googlesource.com/1086375Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#53507}
-
- 04 Jun, 2018 10 commits
-
-
Hidy Han authored
1) Let firstNonEmptySourceURL traverse async stack trace (if any). 2) Expose Runtime.setMaxCallStackSizeToCapture API to control the number of frames to capture. Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I72f021c6ae9e317af67c3114fd4860ce0f06d977 Reviewed-on: https://chromium-review.googlesource.com/1085643 Commit-Queue: Hidy Han <hidyhan@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#53506}
-
Mathias Bynens authored
It was shipped in Chrome 63. Bug: v8:5967 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I1ade30d7ba3cf012f4d0c898f868192972aac726 Reviewed-on: https://chromium-review.googlesource.com/1085289 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This reverts 667555c6. This is a short-term fix for NodeJS regression caused by Scavenger not collecting weak handles that are marked as independent. Bug: chromium:847863, chromium:780749 Change-Id: Ia1c02e042d0e593c6f5badb82c4ef20b923d3806 Reviewed-on: https://chromium-review.googlesource.com/1082442Reviewed-by:
-
Deepti Gandluri authored
Change-Id: Id6f87f55541eba44a22be2721f9182095ca69359 Reviewed-on: https://chromium-review.googlesource.com/1085508Reviewed-by:
-
Tom Anderson authored
After [1], a manual dependency on exe_and_shlib_deps is no longer necessary since it's automatically added. This CL removes all remaining manual references to exe_and_shlib_deps. [1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5 BUG=chromium:845700 R=machenbach Change-Id: I17da573b7b6509a690caf8be6ae6afc180105f07 Reviewed-on: https://chromium-review.googlesource.com/1082913 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
This reverts commit 515cc07d. Reason for revert: Tree closed on mkgrokdump failures https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.v8%2FV8_Mac64%2F22277%2F%2B%2Frecipes%2Fsteps%2FCheck%2F0%2Flogs%2Fmkgrokdump%2F0 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.v8%2FV8_Linux64%2F24882%2F%2B%2Frecipes%2Fsteps%2FCheck_-_noavx%2F0%2Flogs%2Fmkgrokdump%2F0 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.v8%2FV8_Win64%2F24413%2F%2B%2Frecipes%2Fsteps%2FCheck%2F0%2Flogs%2Fmkgrokdump%2F0 Original change's description: > [csa] Ensure the requested allocation size fits in a Smi > > In CSA::AllocateRaw, ensure that the given allocation size fits into a > Smi. > > Bug: chromium:848672 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I4e74791296163188b1ca77cae8226a9833fba8ef > Reviewed-on: https://chromium-review.googlesource.com/1084930 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53495} TBR=yangguo@chromium.org,jgruber@chromium.org,ishell@chromium.org Change-Id: I4d1019c03b393c1a59e5eca558d9cd26ce63e17a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:848672 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1085647Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#53496}
-
jgruber authored
In CSA::AllocateRaw, ensure that the given allocation size fits into a Smi. Bug: chromium:848672 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I4e74791296163188b1ca77cae8226a9833fba8ef Reviewed-on: https://chromium-review.googlesource.com/1084930Reviewed-by:
-
Jakob Gruber authored
This reverts commit df1676e6. Reason for revert: https://crbug.com/v8/7382#c26 Original change's description: > [array] Implement Array.p.sort in Torque > > This CL implements a generic baseline version and 3 fastpaths, for > various elements kinds, of Array.p.sort in Torque. Details can be found > in the Design Doc: https://goo.gl/Ge321G. > > Performance impact on micro benchmarks depends on the element kind > and whether the user provides a comparison function. > For HoleySmi/HoleyElement we have a speedup between 1.5-1.8 across > the board. For Dictionary we are slower in all micro benchmarks (0.7). > For PackedSmi it depends on the call site and whether or not a > comparison function is used. > > Detailed numbers: https://goo.gl/mTyPSb > > Bug: v8:7382 > Change-Id: I50acabd2032af0bc01d36b0de0f555d66be56a7e > Reviewed-on: https://chromium-review.googlesource.com/1061523 > Commit-Queue: Simon Zünd <szuend@google.com> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53481} TBR=cbruni@chromium.org,jgruber@chromium.org,szuend@google.com Change-Id: I4c1b32a434d49caba67c80bccb068390607f90a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7382 Reviewed-on: https://chromium-review.googlesource.com/1085407Reviewed-by:
-
Michael Starzinger authored
This avoids embedding the {CEntryStub} into generated {WasmCode} and instead loads it from the instance object. It is another step towards making the generated code independent of the Isolate. R=clemensh@chromium.org BUG=v8:7472 Change-Id: Ic6ab7602a77fc11e6ec4a03e1bdba647d54df5e3 Reviewed-on: https://chromium-review.googlesource.com/1084841Reviewed-by: -
Clemens Hammacher authored
1) The code table never grows, so store it in a heap-allocated byte array instead of an std::vector. 2) Rename {functions_count} to {num_functions} for consistency with {num_imported_functions} and occurences in other data structures. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: Id9d66545ed7aa675d663dad5936a9ef6d44ace7d Reviewed-on: https://chromium-review.googlesource.com/1066014 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
