Commits · 5d840171c17967d9ed6e78020d4b727d94cf33cc · Linshizhi / V8

08 Sep, 2014 4 commits

Revert r23732 ("ARM64: Fix and improve --trace-sim register trace.") and... · 5d840171

svenpanne@chromium.org authored Sep 08, 2014

Revert r23732 ("ARM64: Fix and improve --trace-sim register trace.") and r23733 ("ARM64: Fix build warning in r23732.)

They break the build when compiling with optimizations, e.g. optdebug:

../src/arm64/simulator-arm64.cc: In member function ‘void v8::internal::Simulator::PrintWriteFP(uintptr_t, size_t, unsigned int)’:
../src/arm64/simulator-arm64.cc:792:29: error: array subscript is above array bounds [-Werror=array-bounds]
../src/arm64/simulator-arm64.cc:799:29: error: array subscript is above array bounds [-Werror=array-bounds]

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/549083004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23765 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5d840171

[turbofan] Fix Projection operator parameter type. · 263a96b2

bmeurer@chromium.org authored Sep 08, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/549063002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23764 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

263a96b2

Fix windows build. · ccf6c266

bmeurer@chromium.org authored Sep 08, 2014

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/550063002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23761 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ccf6c266

Next base/macros.h cleanup step. · 20db0ff3

bmeurer@chromium.org authored Sep 08, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/544043002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23760 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

20db0ff3

07 Sep, 2014 3 commits

[Auto-roll] Bump up version to 3.29.49.0 · 880110ae

v8-autoroll@chromium.org authored Sep 07, 2014

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23756 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

880110ae

Keep svn checkout up-to-date in roll scripts. · 199ba41c

machenbach@chromium.org authored Sep 07, 2014

BUG=chromium:408523
LOG=n
TBR=jarin@chromium.org
TEST=script_test.py

Review URL: https://codereview.chromium.org/551573002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23755 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

199ba41c

Add ability to make pure svn commits to roll scripts · e9916e90

machenbach@chromium.org authored Sep 07, 2014

BUG=chromium:408523
LOG=n
TBR=jarin@chromium.org
TEST=script_test.py

Review URL: https://codereview.chromium.org/544153002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23754 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e9916e90

05 Sep, 2014 33 commits

[Auto-roll] Bump up version to 3.29.48.0 · 7da038fd

machenbach@chromium.org authored Sep 05, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/542343002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23752 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7da038fd

MIPS: Do not cache CodeStubInterfaceDescriptor on the isolate. · 50f28700

paul.lind@imgtec.com authored Sep 05, 2014

Port r23744 (998c3e4)

BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/540403002

Patch from Balazs Kilvady <balazs.kilvady@imgtec.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23750 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

50f28700

MIPS: Unify JSEntryStub and JSConstructEntryStub, and some more code stub cleanups. · fc90c556

paul.lind@imgtec.com authored Sep 05, 2014

Port r23742 (a68a0c0)

BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/548523003

Patch from Balazs Kilvady <balazs.kilvady@imgtec.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23749 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fc90c556

[Auto-roll] Bump up version to 3.29.47.0 · 8c82d6c2

machenbach@chromium.org authored Sep 05, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/544053003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23748 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8c82d6c2

Disable broken JSLoadContext typer. · 6774288e

mstarzinger@chromium.org authored Sep 05, 2014

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/542193002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23747 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6774288e

Fix ARM64 build after r23744. · d9d2149f

mstarzinger@chromium.org authored Sep 05, 2014

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/547683002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23746 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d9d2149f

Fix more fallout from making OptimizeFunctionOnNextCall work as advertised. · 4c53bb08

titzer@chromium.org authored Sep 05, 2014

R=jarin@chromium.org
BUG=411262

Review URL: https://codereview.chromium.org/544213002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23745 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4c53bb08

Do not cache CodeStubInterfaceDescriptor on the isolate. · b7ea991a

yangguo@chromium.org authored Sep 05, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/544123002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23744 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b7ea991a

Harden OptimizeFunctionOnNextCall. · 83af12c2

jarin@chromium.org authored Sep 05, 2014

BUG=411237
LOG=N
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/547553003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23743 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

83af12c2

Unify JSEntryStub and JSConstructEntryStub, and some more code stub cleanups. · a6260ee4

yangguo@chromium.org authored Sep 05, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/545163002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23742 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a6260ee4

Fix typer to actually visit the entire graph. · dd877953

mstarzinger@chromium.org authored Sep 05, 2014

R=titzer@chromium.org
TEST=mjsunit

Review URL: https://codereview.chromium.org/545223002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23740 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dd877953

X87: disable turbofan dependent test · 6bbd2e0e

weiliang.lin@intel.com authored Sep 05, 2014

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/548433002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23739 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6bbd2e0e

MIPS: Generalized division via multiplication. · f2fdb8b2

balazs.kilvady@imgtec.com authored Sep 05, 2014

Port r23730 (967b787)

Original commit message:
We can now compute the magic numbers for all combinations of 32bit and
64bit (un)signed multiplications.

BUG=
R=dusan.milosavljevic@imgtec.com

Review URL: https://codereview.chromium.org/540343002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23738 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f2fdb8b2

X87: Fix build · 7d160cd9

weiliang.lin@intel.com authored Sep 05, 2014

BUG=
R=weiliang.lin@intel.com

Review URL: https://codereview.chromium.org/545133003

Patch from Jing Bao <jing.bao@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23737 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7d160cd9

Platform-dependent turbofan tests. · 09dccec9

titzer@chromium.org authored Sep 05, 2014

R=jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/541343003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23736 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

09dccec9

[Auto-roll] Bump up version to 3.29.46.0 · 5bad9e6a

machenbach@chromium.org authored Sep 05, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/545903002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23735 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5bad9e6a

Fix --trace-parse. · 3ffabd52

titzer@chromium.org authored Sep 05, 2014

R=yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/545193002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23734 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3ffabd52

ARM64: Fix build warning in r23732. · 45bb1931

Jacob.Bramley@arm.com authored Sep 05, 2014

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/548493002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23733 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

45bb1931

ARM64: Fix and improve --trace-sim register trace. · d0054c75

Jacob.Bramley@arm.com authored Sep 05, 2014

- Use standard names (except that our GREY is the standard BLACK).
- Make non-bold colours explicit, otherwise the boldness can carry over
  into subsequent colour declarations.
- I've moved some colours around to make them consistent. Register value
  updates (which are very common) now stand out less than they did,
  making the less-common (and arguably more important) debug
  announcements appear brighter.
  - FP registers and values are now magenta.
  - Integer registers and values are now cyan.
  - Memory accesses are now blue.
- LOG_WRITE prints the source register for stores.
- Loads are logged with a format similar to that used for stores.
  Specifically, the memory address is printed alongside the new register
  value.
- Updates to D registers print the raw bits as well as the double value.
  Updates to S registers print the raw bits as well as the float value.
  (Previously, we printed both double and float interpretations of the
  bits, which was a bit cluttered.)

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/548473002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23732 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d0054c75

Generalized division via multiplication. · 051972d2

svenpanne@chromium.org authored Sep 05, 2014

We can now compute the magic numbers for all combinations of 32bit and
64bit (un)signed multiplications.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/532003004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23730 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

051972d2

[turbofan] Missing fix from last commit. · 2a40210a

bmeurer@chromium.org authored Sep 05, 2014

TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/538373003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23729 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2a40210a

[turbofan] Add MachineType to Phi. · 99ccab81

bmeurer@chromium.org authored Sep 05, 2014

TEST=cctest,compiler-unittests,mjsunit
R=mstarzinger@chromium.org, titzer@chromium.org

Review URL: https://codereview.chromium.org/545153002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23728 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

99ccab81

Allocate a new empty number dictionary when resetting elements · 1dddf69f

verwaest@chromium.org authored Sep 05, 2014

BUG=410332
LOG=y
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/545773003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23727 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1dddf69f

[turbofan] Fix cctest/test-graph-reducer/ReduceForward1. · 65fa2b49

bmeurer@chromium.org authored Sep 05, 2014

TBR=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/542063003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23726 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

65fa2b49

[turbofan] Nodes are killed by resetting all their inputs to zero. · aed44ece

bmeurer@chromium.org authored Sep 05, 2014

TEST=compiler-unittests,mjsunit/numops-fuzz
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/540253003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23725 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

aed44ece

[turbofan] Value numbering should never replace a node with itself. · ddf358ca

bmeurer@chromium.org authored Sep 05, 2014

R=mstarzinger@chromium.org
TEST=compiler-unittests

Review URL: https://codereview.chromium.org/539833003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23724 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ddf358ca

Fix another assertion in the context typer. · d4852080

mstarzinger@chromium.org authored Sep 05, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/540283002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23723 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d4852080

Fix EvacuateJSFunction to obtain the target address from the forwarding pointer. · b74fae55

jarin@chromium.org authored Sep 05, 2014

R=mstarzinger@chromium.org
BUG=410912
LOG=N

Review URL: https://codereview.chromium.org/541353003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23722 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b74fae55

MIPS: Introduce code stub constructors for stub keys. · 835b000a

balazs.kilvady@imgtec.com authored Sep 05, 2014

Port r23716 (9118048)

BUG=
R=dusan.milosavljevic@imgtec.com

Review URL: https://codereview.chromium.org/535373003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23721 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

835b000a

[Auto-roll] Bump up version to 3.29.45.0 · a6a9adb5

machenbach@chromium.org authored Sep 05, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/541373002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23720 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a6a9adb5

Add cwd to all shell commands in auto roll scripts. · a44c42a4

machenbach@chromium.org authored Sep 05, 2014

The v8 root directory is assumed to be the default cwd. All
commands executed in another directory (e.g. the chromium
checkout) need an explicit specification (also in the
tests).

This also fixes several small testing and robustness bugs:
- Get rid of all 'rm ...' shell calls
- Don't leak tmp files/dirs
- Add some forgotten shell calls to the test expectations
- Hardcode the DEPS location (must always be
chromium_dir/DEPS)
- Expect correct return code when terminating gracefully

BUG=chromium:408523
LOG=n
TBR=jarin@chromium.org
TEST=script_test.py

Review URL: https://codereview.chromium.org/540973002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23719 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a44c42a4

[turbofan] Get rid of the StructuredMacroAssembler. · 5042b23b

bmeurer@chromium.org authored Sep 05, 2014

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/544053002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23718 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5042b23b

Fix null-dereference in r23716. · 42f94d59

yangguo@chromium.org authored Sep 05, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/545843002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23717 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

42f94d59