- 15 Jan, 2019 1 commit
-
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I9cdea29db2b409d773a16e3d6c29ef4325257162 Reviewed-on: https://chromium-review.googlesource.com/c/1409437 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58815}
-
- 12 Jan, 2019 2 commits
-
-
Sigurd Schneider authored
- 'let' instead of 'var', and prefer 'const' - Prefer for-of over indexed interation - Variable names should be 'camel-case' or all-caps snake-case. - Only one variable declaration per line Change-Id: I645dd2333d6d9a993f24c29121f5f156249f1b71 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1405320 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58761}
-
Sigurd Schneider authored
Change-Id: I8e147bcb5d1e0b8e16874f0593a8ce4338dfc201 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1405319 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58760}
-
- 07 Jan, 2019 1 commit
-
-
Sigurd Schneider authored
This CL simplifies the keydown handling code and fixes several issues: - Input to the search box was not reliably working, because the SVG keydown handler was attached to the window and its repeat-key detection was supressing key events. - Selecting the input of a node via keys 1-9 did not select the input, but always enabled the corresponding input node. 1-9 now select the input node, and CTRL+1 through CTRL+9 can be used to toggle the input edge. Bug: v8:7327 Notry: true Change-Id: Ifedc8b703f6552e101ad00fee2f3c50f29b325b5 Reviewed-on: https://chromium-review.googlesource.com/c/1397666 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58579}
-
- 04 Jan, 2019 2 commits
-
-
Sigurd Schneider authored
This CL adds more TypeScript types and inserts some instanceof checks to ensure typing. The CL also selects es2018 as target and loads es6/es2018 libs for TypeScript types. This ensures that RegExp groups matching results are properly typed. Notry: true Bug: v8:7327 Change-Id: I1a59a1047188a49579c975149b336cc232c05eef Reviewed-on: https://chromium-review.googlesource.com/c/1396095Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58553}
-
Sigurd Schneider authored
...and fix all related issues. Change-Id: I3bd37ae038b9ea7c4305600958c1ae20e67e0f1f Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396092Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58552}
-
- 21 Dec, 2018 1 commit
-
-
Sigurd Schneider authored
Bug: v8:7327 Notry: true Change-Id: Ia1c2164269d3d656b951d46debe42a811a6d9c89 Reviewed-on: https://chromium-review.googlesource.com/c/1386494Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58421}
-
- 21 Nov, 2018 1 commit
-
-
Sigurd Schneider authored
Instead of attaching an event handler to every line in the code view, attach it only to the container and find the lineNumber based on the event target element. Notry: true Change-Id: I1920f7a200cf2f5ffaf259c0aaa04d6fb6698d2d Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1346110 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#57670}
-
- 06 Nov, 2018 1 commit
-
-
Sigurd Schneider authored
Change-Id: If8faa3c7c0324fc9d0a2704533278828c62d5b91 Notry: true Bug: v8:8128, v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1319765Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#57286}
-
- 11 Oct, 2018 1 commit
-
-
Sigurd Schneider authored
This will allow us to use ts-node to execute tests written in TypeScript. Bug: v8:7327 Change-Id: I0804db1f112448350c5e91135242e6ec6706d231 Reviewed-on: https://chromium-review.googlesource.com/c/1274086 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#56564}
-
- 11 Jul, 2018 1 commit
-
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: If2670e2b8e64a34f5de7855615e2288b6f2f3133 Reviewed-on: https://chromium-review.googlesource.com/1131193 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54371}
-
- 13 Jun, 2018 1 commit
-
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: I8cd57abf612393852532a695663175dff8e3a199 Reviewed-on: https://chromium-review.googlesource.com/1098955 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53713}
-
- 11 Jun, 2018 2 commits
-
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: Id354b039977a82af8b2c6bba416cf5a1f804ca71 Reviewed-on: https://chromium-review.googlesource.com/1095257 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53637}
-
Sigurd Schneider authored
This CL allows selection/highlighting of wasm source when a graph node is clicked. Bug: v8:7327 Change-Id: I4a3347a83c8a38804feabffefaefd761596005c3 Reviewed-on: https://chromium-review.googlesource.com/1092712 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53636}
-
- 29 May, 2018 1 commit
-
-
Sigurd Schneider authored
Change-Id: I2be450c6498ce863d5e36acf02db643788e6c8bf Reviewed-on: https://chromium-review.googlesource.com/1068045 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53400}
-
- 22 May, 2018 1 commit
-
-
Sigurd Schneider authored
Change-Id: I6d84e7ef500aecd83a77ed2ce3fed4e15b29b7ac Reviewed-on: https://chromium-review.googlesource.com/1065881 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#53289}
-
- 16 May, 2018 1 commit
-
-
Sigurd Schneider authored
This CL adds support for inlined functions in Turbolizer. It is also a refactoring of the Turbolizer code-base. Most importantly, handling of source positions changed to exact source positions, and not code ranges. This improves selection interoperability between different phase views. A separate CL changes the Turbolizer JSON format to include inlining information. This Turbolizer update, however, is intended to be backwards compatible with the JSON format Turbolizer generated before the JSON format change. Bug: v8:7327 Change-Id: Ic67506a6f3a36fe98c012b1e76994972779c1fd2 Reviewed-on: https://chromium-review.googlesource.com/1032784 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#53213}
-
- 12 Jan, 2018 1 commit
-
-
Sigurd Schneider authored
- Turbolizer highlights input and output nodes on hover. - The three panes support resizing now (snap to side still works). Bug: Change-Id: Ida1513fd714a02ab772885ea1fdf6d9da8d540f6 Reviewed-on: https://chromium-review.googlesource.com/837068 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#50523}
-
- 29 Mar, 2017 1 commit
-
-
Leszek Swirski authored
Previously code view was set using innerHTML. This would cause problems for html characters in the code -- in particular, '<' without a space after it would start new HTML tags, and the code following it wouldn't be visible. Now, the source text is set using textContent, which doesn't parse the value as HTML and implicitly escapes any HTML characters in the code. Change-Id: I612a18c37bbb4da6a87063bb39d7f7123a3c4c0d Reviewed-on: https://chromium-review.googlesource.com/461826Reviewed-by: Daniel Clifford <danno@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#44233}
-
- 10 Aug, 2016 1 commit
-
-
danno authored
Also convert CodeView to a class and fix a host of selection bugs in the process, as well as move the logic and data to "enrich" location with one type of location data with location data known globally to the whole graph in the selection broker. Review-Url: https://codereview.chromium.org/2230083004 Cr-Commit-Position: refs/heads/master@{#38544}
-
- 11 Jul, 2016 1 commit
-
-
Alexander.Gilday2 authored
This change analyzes and links the output of --code-comments in the disassembly view within turbolizer with the other views, such that selecting these comments will also select the respective blocks/lines/nodes within the other views. The block start comments (e.g. -- B4 start --) are linked with the blocks in the schedule phase view and vice versa. The source position comments (e.g. -- primes.js:3:10 --) select the respective spans, lines, and nodes in the JavaScript code view, the schedule phase view, and the other compilation phase views respectively, and vice versa. It also modifies the display of the line and column numbers in the source position comments to be offset from 1 instead of 0 and ignore the initial source position of the first line of code (from removal of the function name in the compiler). Also fixed the bug where previous selections weren't being cleared properly across multiple views, adding appropriate clear calls when using the selection broker. Review-Url: https://codereview.chromium.org/2133663002 Cr-Commit-Position: refs/heads/master@{#37627}
-
- 19 May, 2016 1 commit
-
-
danno authored
Review-Url: https://codereview.chromium.org/729913004 Cr-Commit-Position: refs/heads/master@{#36351}
-