1. 15 Jan, 2019 1 commit
  2. 12 Jan, 2019 2 commits
  3. 07 Jan, 2019 1 commit
    • Sigurd Schneider's avatar
      [turbolizer] Rework keydown event handling · 753ff7f3
      Sigurd Schneider authored
      This CL simplifies the keydown handling code and fixes
      several issues:
      
       - Input to the search box was not reliably working, because
         the SVG keydown handler was attached to the window and its
         repeat-key detection was supressing key events.
       - Selecting the input of a node via keys 1-9 did not select the
         input, but always enabled the corresponding input node.
         1-9 now select the input node, and CTRL+1 through CTRL+9 can
         be used to toggle the input edge.
      
      Bug: v8:7327
      Notry: true
      Change-Id: Ifedc8b703f6552e101ad00fee2f3c50f29b325b5
      Reviewed-on: https://chromium-review.googlesource.com/c/1397666
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58579}
      753ff7f3
  4. 04 Jan, 2019 2 commits
  5. 21 Dec, 2018 1 commit
  6. 21 Nov, 2018 1 commit
  7. 06 Nov, 2018 1 commit
  8. 11 Oct, 2018 1 commit
  9. 11 Jul, 2018 1 commit
  10. 13 Jun, 2018 1 commit
  11. 11 Jun, 2018 2 commits
  12. 29 May, 2018 1 commit
  13. 22 May, 2018 1 commit
  14. 16 May, 2018 1 commit
    • Sigurd Schneider's avatar
      [turbolizer] Add support for inlined functions · a97a362d
      Sigurd Schneider authored
      This CL adds support for inlined functions in Turbolizer. It is also a
      refactoring of the Turbolizer code-base. Most importantly, handling of
      source positions changed to exact source positions, and not code ranges.
      This improves selection interoperability between different phase views.
      
      A separate CL changes the Turbolizer JSON format to include inlining
      information. This Turbolizer update, however, is intended to be backwards
      compatible with the JSON format Turbolizer generated before the JSON
      format change.
      
      
      Bug: v8:7327
      Change-Id: Ic67506a6f3a36fe98c012b1e76994972779c1fd2
      Reviewed-on: https://chromium-review.googlesource.com/1032784
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Reviewed-by: 's avatarDaniel Clifford <danno@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#53213}
      a97a362d
  15. 12 Jan, 2018 1 commit
  16. 29 Mar, 2017 1 commit
    • Leszek Swirski's avatar
      [turbolizer] Use textContent to set code view · 7b8d8e9a
      Leszek Swirski authored
      Previously code view was set using innerHTML. This would cause problems
      for html characters in the code -- in particular, '<' without a space
      after it would start new HTML tags, and the code following it wouldn't
      be visible.
      
      Now, the source text is set using textContent, which doesn't parse the
      value as HTML and implicitly escapes any HTML characters in the code.
      
      Change-Id: I612a18c37bbb4da6a87063bb39d7f7123a3c4c0d
      Reviewed-on: https://chromium-review.googlesource.com/461826Reviewed-by: 's avatarDaniel Clifford <danno@chromium.org>
      Commit-Queue: Leszek Swirski <leszeks@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#44233}
      7b8d8e9a
  17. 10 Aug, 2016 1 commit
  18. 11 Jul, 2016 1 commit
    • Alexander.Gilday2's avatar
      [turbolizer] Improve code comments in disassembly · 7f162dbc
      Alexander.Gilday2 authored
      This change analyzes and links the output of --code-comments in the disassembly view within turbolizer with the other views, such that selecting these comments will also select the respective blocks/lines/nodes within the other views. The block start comments (e.g. -- B4 start --) are linked with the blocks in the schedule phase view and vice versa. The source position comments (e.g. -- primes.js:3:10 --) select the respective spans, lines, and nodes in the JavaScript code view, the schedule phase view, and the other compilation phase views respectively, and vice versa. It also modifies the display of the line and column numbers in the source position comments to be offset from 1 instead of 0 and ignore the initial source position of the first line of code (from removal of the function name in the compiler).
      
      Also fixed the bug where previous selections weren't being cleared properly across multiple views, adding appropriate clear calls when using the selection broker.
      
      Review-Url: https://codereview.chromium.org/2133663002
      Cr-Commit-Position: refs/heads/master@{#37627}
      7f162dbc
  19. 19 May, 2016 1 commit