Skip to content

V
V8
Switch branch/tag
  1. 23 May, 2019 1 commit
  3. 02 May, 2019 1 commit
  5. 29 Apr, 2019 2 commits
    • Clemens Hammacher's avatar
      [cleanup] Remove {StrLength} function · 423b357b
      Clemens Hammacher authored 
      The {Vector} class does not use it any more. External uses should be
converted to {size_t} instead of {int}.
This CL removes the function from vector.h and updates all users to
either use {size_t}, or cast to {int} explicitly. In tests, no further
checks are needed if the string is a constant.

R=mstarzinger@chromium.org

Bug: v8:9183
Change-Id: I60f99302504c74d8a7c79b147ca01d8ba61b6879
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587393Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61092}
      423b357b
    • Clemens Hammacher's avatar
      [cleanup] Use Vector::begin instead of Vector::start · 4b0f9c85
      Clemens Hammacher authored 
      Our {Vector} template provides both {start} and {begin} methods. They
return exactly the same value. Since the {begin} method is needed for
iteration, and is also what standard containers provide, this CL
switches all uses of the {start} method to use {begin} instead.

Patchset 1 was auto-generated by using this clang AST matcher:
    callExpr(
        callee(
          cxxMethodDecl(
            hasName("start"),
            ofClass(hasName("v8::internal::Vector")))
        ),
        argumentCountIs(0))

Patchset 2 was created by running clang-format. Patchset 3 then
removes the now unused {Vector::start} method.

R=jkummerow@chromium.org
TBR=mstarzinger@chromium.org,yangguo@chromium.org,verwaest@chromium.org

Bug: v8:9183
Change-Id: Id9f01c92870872556e2bb3f6d5667463b0e3e5c6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587381Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61081}
      4b0f9c85
  7. 29 Nov, 2018 1 commit
  9. 18 Sep, 2018 1 commit
  11. 15 Sep, 2018 1 commit
  13. 06 Aug, 2018 1 commit
  15. 31 Jul, 2018 1 commit
    • Sigurd Schneider's avatar
      [utils] Change ReadFile interface · ec067322
      Sigurd Schneider authored 
      ReadFile returned a Vector with ownership transfer, i.e. the client
needed to call Dispose to free the memory. This CL changes the interface
to return a std::string instead, which manages ownership. As it turns
out, there is only one user of ReadString that sometimes calls an API
function which expects to take ownership of its Vector argument.

Bug: v8:7932
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie624a7a65cf5814fddce7a57bc557e4b9876bc53
Reviewed-on: https://chromium-review.googlesource.com/1155115
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54805}
      ec067322
  17. 18 Jul, 2018 1 commit
  19. 16 May, 2018 1 commit
  21. 19 Oct, 2017 1 commit
  23. 18 Oct, 2017 1 commit
  25. 13 Oct, 2017 1 commit
  27. 18 Jul, 2017 1 commit
  29. 07 Feb, 2017 1 commit
  31. 20 Sep, 2016 1 commit
  33. 02 Jun, 2016 1 commit
  35. 01 Jun, 2016 2 commits
  37. 26 Nov, 2015 1 commit
  39. 01 Oct, 2015 1 commit
  41. 14 Aug, 2015 1 commit
  43. 01 Jun, 2015 1 commit
  45. 29 Apr, 2015 1 commit
  47. 28 Apr, 2015 1 commit
  49. 30 Jan, 2015 1 commit
  51. 07 Oct, 2014 1 commit
  53. 04 Aug, 2014 1 commit
  55. 30 Jun, 2014 1 commit
  57. 24 Jun, 2014 1 commit
  59. 18 Jun, 2014 1 commit
  61. 13 Jun, 2014 2 commits
  63. 03 Jun, 2014 1 commit
  65. 27 May, 2014 1 commit
  67. 26 May, 2014 2 commits
  69. 29 Apr, 2014 1 commit
  71. 25 Apr, 2014 1 commit