- 14 Jul, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
Goal of this CL: explicit return from non-async function has position after return expression as return position (will unblock [1]). BytecodeArrayBuilder has SetStatementPosition and SetExpressionPosition methods. If one of these methods is called then next generated bytecode will get passed position. It's general treatment for most cases. Unfortunately it doesn't work for Returns: - debugger requires source positions exactly on kReturn bytecode in stepping implementation, - BytecodeGenerator::BuildReturn and BytecodeGenerator::BuildAsyncReturn generates more then one bytecode and general solution will put return position on first generated bytecode, - it's not easy to split BuildReturn function into two parts to allow something like following in BytecodeGenerator::VisitReturnStatement since generated bytecodes are actually controlled by execution_control(). ..->BuildReturnPrologue(); ..->SetReturnPosition(stmt); ..->Return(); In this CL we pass ReturnStatement through ExecutionControl and use it for position when we emit return bytecode right here. So this CL only will improve return position for returns inside of non-async functions, I'll address async functions later. [1] https://chromium-review.googlesource.com/c/543161/ Change-Id: Iede512c120b00c209990bf50c20e7d23dc0d65db Reviewed-on: https://chromium-review.googlesource.com/560738 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46687}
-
- 19 May, 2017 1 commit
-
-
dgozman authored
This refactoring makes it easier to write advanced tests and gives full control over what's happening to the test code. It also forces description for every test. BUG=none Review-Url: https://codereview.chromium.org/2891213002 Cr-Commit-Position: refs/heads/master@{#45412}
-
- 26 Apr, 2017 1 commit
-
-
yangguo authored
V8 can bundle user scripts in the start up snapshot. These are shared across contexts, and do not work well context groups. R=kozyatinskiy@chromium.org BUG=v8:6274 Review-Url: https://codereview.chromium.org/2836623002 Cr-Original-Commit-Position: refs/heads/master@{#44847} Committed: https://chromium.googlesource.com/v8/v8/+/9685cfd310a51b2b32f97223069abaaca77405a8 Review-Url: https://codereview.chromium.org/2836623002 Cr-Commit-Position: refs/heads/master@{#44897}
-
- 25 Apr, 2017 2 commits
-
-
yangguo authored
Revert of [inspector] always include user scripts in the snapshot. (patchset #3 id:40001 of https://codereview.chromium.org/2836623002/ ) Reason for revert: So that https://codereview.chromium.org/2841993002/ can be reverted. Original issue's description: > [inspector] always include user scripts in the snapshot. > > V8 can bundle user scripts in the start up snapshot. These are > shared across contexts, and do not work well context groups. > > R=kozyatinskiy@chromium.org > BUG=v8:6274 > > Review-Url: https://codereview.chromium.org/2836623002 > Cr-Commit-Position: refs/heads/master@{#44847} > Committed: https://chromium.googlesource.com/v8/v8/+/9685cfd310a51b2b32f97223069abaaca77405a8 TBR=kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6274 Review-Url: https://codereview.chromium.org/2840923002 Cr-Commit-Position: refs/heads/master@{#44868}
-
yangguo authored
V8 can bundle user scripts in the start up snapshot. These are shared across contexts, and do not work well context groups. R=kozyatinskiy@chromium.org BUG=v8:6274 Review-Url: https://codereview.chromium.org/2836623002 Cr-Commit-Position: refs/heads/master@{#44847}
-