1. 29 Apr, 2019 1 commit
    • Clemens Hammacher's avatar
      [cleanup] Use Vector::begin instead of Vector::start · 4b0f9c85
      Clemens Hammacher authored
      Our {Vector} template provides both {start} and {begin} methods. They
      return exactly the same value. Since the {begin} method is needed for
      iteration, and is also what standard containers provide, this CL
      switches all uses of the {start} method to use {begin} instead.
      
      Patchset 1 was auto-generated by using this clang AST matcher:
          callExpr(
              callee(
                cxxMethodDecl(
                  hasName("start"),
                  ofClass(hasName("v8::internal::Vector")))
              ),
              argumentCountIs(0))
      
      Patchset 2 was created by running clang-format. Patchset 3 then
      removes the now unused {Vector::start} method.
      
      R=jkummerow@chromium.org
      TBR=mstarzinger@chromium.org,yangguo@chromium.org,verwaest@chromium.org
      
      Bug: v8:9183
      Change-Id: Id9f01c92870872556e2bb3f6d5667463b0e3e5c6
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587381Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#61081}
      4b0f9c85
  2. 04 Mar, 2019 2 commits
  3. 19 Feb, 2019 1 commit
  4. 15 Feb, 2019 1 commit
  5. 07 Feb, 2019 1 commit
  6. 05 Feb, 2019 1 commit
  7. 18 Jan, 2019 1 commit
  8. 26 Dec, 2018 1 commit
  9. 05 Dec, 2018 1 commit
  10. 04 Dec, 2018 1 commit
  11. 27 Nov, 2018 1 commit
  12. 26 Nov, 2018 1 commit
  13. 25 Nov, 2018 1 commit
  14. 05 Nov, 2018 1 commit
  15. 24 Oct, 2018 1 commit
  16. 16 Oct, 2018 1 commit
  17. 21 Sep, 2018 2 commits
  18. 14 Sep, 2018 1 commit
  19. 03 Aug, 2018 1 commit
  20. 31 Jul, 2018 1 commit
  21. 25 Jul, 2018 3 commits
  22. 03 Jul, 2018 1 commit
  23. 23 Jun, 2018 1 commit
  24. 21 Jun, 2018 1 commit
  25. 31 May, 2018 1 commit
  26. 23 Feb, 2018 1 commit
  27. 13 Feb, 2018 1 commit
    • Sigurd Schneider's avatar
      Reland "[cleanup] Harden the SubString CSA/Runtime implementations." · bb282636
      Sigurd Schneider authored
      This is a reland of 6d5b54df82e27a82811a836dcdbbfe26829f0e6d
      Original change's description:
      > [cleanup] Harden the SubString CSA/Runtime implementations.
      >
      > Remove the self-healing for invalid parameters in the
      > CodeStubAssembler::SubString helper and the %SubString runtime function,
      > which is used as a fallback for the CodeStubAssembler implementation.
      > All call sites must do appropriate parameter validation anyways now that
      > the self-hosted JavaScript builtins using these helpers are gone, and we
      > have proper contracts with the uses.
      >
      > Also remove the context parameter from the CodeStubAssembler::SubString
      > method, which is unnecessary, since this can no longer throw an
      > exception.
      >
      > Bug: v8:5269, v8:6936, v8:7109, v8:7137
      > Change-Id: I19d93bad5f41faa0561c4561a48f78fcba99a549
      > Reviewed-on: https://chromium-review.googlesource.com/795720
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#49702}
      
      Bug: v8:5269, v8:6936, v8:7109, v8:7137
      Change-Id: I5e84998a2dd3990d7981505b401ffc770e0b7ac5
      Reviewed-on: https://chromium-review.googlesource.com/913130Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#51265}
      bb282636
  28. 02 Dec, 2017 1 commit
    • Mathias Bynens's avatar
      Normalize casing of hexadecimal digits · 822be9b2
      Mathias Bynens authored
      This patch normalizes the casing of hexadecimal digits in escape
      sequences of the form `\xNN` and integer literals of the form
      `0xNNNN`.
      
      Previously, the V8 code base used an inconsistent mixture of uppercase
      and lowercase.
      
      Google’s C++ style guide uses uppercase in its examples:
      https://google.github.io/styleguide/cppguide.html#Non-ASCII_Characters
      
      Moreover, uppercase letters more clearly stand out from the lowercase
      `x` (or `u`) characters at the start, as well as lowercase letters
      elsewhere in strings.
      
      BUG=v8:7109
      TBR=marja@chromium.org,titzer@chromium.org,mtrofin@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org,mlippautz@chromium.org
      NOPRESUBMIT=true
      
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: I790e21c25d96ad5d95c8229724eb45d2aa9e22d6
      Reviewed-on: https://chromium-review.googlesource.com/804294
      Commit-Queue: Mathias Bynens <mathias@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49810}
      822be9b2
  29. 29 Nov, 2017 2 commits
    • Michael Achenbach's avatar
      Revert "[cleanup] Harden the SubString CSA/Runtime implementations." · c0a4680d
      Michael Achenbach authored
      This reverts commit 99cb4d35.
      
      Reason for revert:
      https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/16445
      
      Original change's description:
      > [cleanup] Harden the SubString CSA/Runtime implementations.
      > 
      > Remove the self-healing for invalid parameters in the
      > CodeStubAssembler::SubString helper and the %SubString runtime function,
      > which is used as a fallback for the CodeStubAssembler implementation.
      > All call sites must do appropriate parameter validation anyways now that
      > the self-hosted JavaScript builtins using these helpers are gone, and we
      > have proper contracts with the uses.
      > 
      > Also remove the context parameter from the CodeStubAssembler::SubString
      > method, which is unnecessary, since this can no longer throw an
      > exception.
      > 
      > Bug: v8:5269, v8:6936, v8:7109, v8:7137
      > Change-Id: I19d93bad5f41faa0561c4561a48f78fcba99a549
      > Reviewed-on: https://chromium-review.googlesource.com/795720
      > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
      > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#49702}
      
      TBR=jgruber@chromium.org,bmeurer@chromium.org
      
      Change-Id: I2900b5f087e78f1d321724f03bd063a5ff094183
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:5269, v8:6936, v8:7109, v8:7137
      Reviewed-on: https://chromium-review.googlesource.com/796150Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49703}
      c0a4680d
    • Benedikt Meurer's avatar
      [cleanup] Harden the SubString CSA/Runtime implementations. · 99cb4d35
      Benedikt Meurer authored
      Remove the self-healing for invalid parameters in the
      CodeStubAssembler::SubString helper and the %SubString runtime function,
      which is used as a fallback for the CodeStubAssembler implementation.
      All call sites must do appropriate parameter validation anyways now that
      the self-hosted JavaScript builtins using these helpers are gone, and we
      have proper contracts with the uses.
      
      Also remove the context parameter from the CodeStubAssembler::SubString
      method, which is unnecessary, since this can no longer throw an
      exception.
      
      Bug: v8:5269, v8:6936, v8:7109, v8:7137
      Change-Id: I19d93bad5f41faa0561c4561a48f78fcba99a549
      Reviewed-on: https://chromium-review.googlesource.com/795720Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#49702}
      99cb4d35
  30. 26 Oct, 2017 1 commit
  31. 25 Oct, 2017 1 commit
  32. 18 Oct, 2017 2 commits
  33. 20 Sep, 2017 1 commit
  34. 08 Sep, 2017 1 commit
    • Benedikt Meurer's avatar
      [cleanup] Drop obsolete %StringCharCodeAt intrinsic. · 62649c8e
      Benedikt Meurer authored
      The previous %StringCharCodeAt runtime entry (and the inlined intrinsic)
      are obsolete and not used anymore (except in dedicated tests for this
      runtime function), so remove it. And rename the %StringCharCodeAtRT
      function, which is actually used to %StringCharCodeAt instead to have
      a consistent naming scheme for runtime fallbacks.
      
      Bug: v8:5049
      Change-Id: I619429ef54f6efea61fc51ab9ed1d5cfe4417f99
      Reviewed-on: https://chromium-review.googlesource.com/657719
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#47928}
      62649c8e