- 14 May, 2020 1 commit
-
-
Varun Varada authored
There should be a space between the quantity and the unit symbol as per the SI, so this commit fixes this issue. Change-Id: I3356942391d96906f3e3840c7bb802e10f29eb4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2190230 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#67789}
-
- 17 Apr, 2020 1 commit
-
-
Yang Guo authored
Fixed: chromium:986051 Change-Id: I01ef94fe43ac5c8734890706a6dccd01e008bfec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2153215Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#67204}
-
- 20 Mar, 2020 1 commit
-
-
Johannes Henkel authored
Upstream PR: "Introduce a crdtp/dispatch.{h,cc} library." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1974680 "For the shallow parse of a DevTools message, allow "params": null." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2109466 New Revision: c69cdc36200992d21a17bf4e5c2f3a95b8860ddf Change-Id: Icc447ff9ce408b24f5245c643dd2f1843da9255f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2076215 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#66813}
-
- 19 Sep, 2019 1 commit
-
-
Ulan Degenbaev authored
This adds an additional V8 API to get the backing store of an array buffer. Unlike the existing API, the backing store comes wrapped in a std::shared_ptr, making lifetime management with the embedder explicit. This obviates the need for the old GetContents() and Externalize() APIs, which will be deprecated in a future CL. Contributed by titzer@chromium.org Bug: v8:9380 Change-Id: I8a87f5dc141dab684693fe536b636e33f6e45173 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1807354Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#63883}
-
- 08 Jul, 2019 1 commit
-
-
Clemens Hammacher authored
Cpplint usually checks for non-const reference arguments. They are forbidden in the style guide, and v8 does not explicitly make an exception here. This CL re-enables that warning, and fixes all current violations by adding an explicit "NOLINT(runtime/references)" comment. In follow-up CLs, we should aim to remove as many of them as possible. TBR=mlippautz@chromium.org Bug: v8:9429 Change-Id: If7054d0b366138b731972ed5d4e304b5ac8423bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1687891Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#62551}
-
- 25 Apr, 2019 1 commit
-
-
Dave Tapuska authored
An additional wpt test (console-label-conversion.any.js) verifies that calling toString will cause exception propagation. Remove the TryCatch block. BUG=chromium:948257 R=dgozman@chromium.org Change-Id: Idaaf264b7675f7df8ead128c085ac4d4c044005d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1579541 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#61023}
-
- 03 Apr, 2019 1 commit
-
-
Dave Tapuska authored
Just rely on calling toString. This matches other vendor's implementations. BUG=chromium:948257 R=dgozman@chromium.org Change-Id: I325a12dd47712263a1ef4deee0bb2de9c4a1c656 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545124Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#60617}
-
- 31 Oct, 2018 2 commits
-
-
Alexey Kozyatinskiy authored
- introduced ValueMirror interface, this interface contains methods to generate different protocol entities, - introduced DebugPropertyIterator, this iterator iterates through object properties in the following order: exotic indices, enumerable strings, all other properties, - removed all injected script infra, e.g. closure compiler, R=dgozman@chromium.org TBR=yangguo@chromium.org Bug: chromium:595206 Change-Id: I030fdb3a80074ca6edd4749f86b39b590776ae6f Reviewed-on: https://chromium-review.googlesource.com/c/1310056Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#57181}
-
Aleksey Kozyatinskiy authored
This reverts commit 7e079c66. Reason for revert: native implementation should be ready for navigation. Original change's description: > inspector: move injected script source to native > > - introduced ValueMirror interface, this interface contains methods to generate > different protocol entities, > - introduced DebugPropertyIterator, this iterator iterates through object properties > in the following order: exotic indices, enumerable strings, all other properties, > - removed all injected script infra, e.g. closure compiler, > > R=dgozman@chromium.org > TBR=yangguo@chromium.org > > Bug: chromium:595206 > Change-Id: Idcfc04489ee52e015ad1d1d191c3474cc65e63f2 > Reviewed-on: https://chromium-review.googlesource.com/c/1308353 > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57150} TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org Change-Id: I8c5c61f4cfe5a66cd33eadd02ab4acec539cc3bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:595206 Reviewed-on: https://chromium-review.googlesource.com/c/1310055Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#57176}
-
- 30 Oct, 2018 3 commits
-
-
Alexey Kozyatinskiy authored
- introduced ValueMirror interface, this interface contains methods to generate different protocol entities, - introduced DebugPropertyIterator, this iterator iterates through object properties in the following order: exotic indices, enumerable strings, all other properties, - removed all injected script infra, e.g. closure compiler, R=dgozman@chromium.org TBR=yangguo@chromium.org Bug: chromium:595206 Change-Id: Idcfc04489ee52e015ad1d1d191c3474cc65e63f2 Reviewed-on: https://chromium-review.googlesource.com/c/1308353Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#57150}
-
Clemens Hammacher authored
This reverts commit 34686abe. Reason for revert: Compile errors on several bots, e.g. https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug%20builder/33299 Original change's description: > inspector: move injected script source to native > > - introduced ValueMirror interface, this interface contains methods to generate > different protocol entities, > - introduced DebugPropertyIterator, this iterator iterates through object properties > in the following order: exotic indices, enumerable strings, all other properties, > - removed all injected script infra, e.g. closure compiler, > > R=dgozman@chromium.org > TBR=yangguo@chromium.org > > Bug: chromium:595206 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I077c1879622aa0d9900d719b80d2ef5ba4221a22 > Reviewed-on: https://chromium-review.googlesource.com/c/1295550 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57142} TBR=dgozman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org Change-Id: I6e4ccaf1d6b151fbc0ffe4f26daa584433321c77 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:595206 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/1307432Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57144}
-
Alexey Kozyatinskiy authored
- introduced ValueMirror interface, this interface contains methods to generate different protocol entities, - introduced DebugPropertyIterator, this iterator iterates through object properties in the following order: exotic indices, enumerable strings, all other properties, - removed all injected script infra, e.g. closure compiler, R=dgozman@chromium.org TBR=yangguo@chromium.org Bug: chromium:595206 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I077c1879622aa0d9900d719b80d2ef5ba4221a22 Reviewed-on: https://chromium-review.googlesource.com/c/1295550 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#57142}
-
- 28 Sep, 2018 1 commit
-
-
Alexey Kozyatinskiy authored
New method was added to console spec [1]. This CL implements it. [1] https://console.spec.whatwg.org/#timelog R=dgozman@chromium.org,yangguo@chromium.org Bug: chromium:854474 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie5f249795979bb886cf824ae9f950c5ef78ce04d Reviewed-on: https://chromium-review.googlesource.com/1247641 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#56294}
-
- 24 Sep, 2018 1 commit
-
-
Dan Elphick authored
ToBoolean and BooleanValue cannot throw exceptions so the Maybe versions of the functions don't make sense. As such this deprecates the Maybe versions and undeprecates ToBoolean(Isolate*). It also adds BooleanValue(Isolate*). Fix up all of the v8 code to not use the deprecated functions. Bug: v8:7279, v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I50e7474d205c75baa153f0dea7f02dcf60232d1d Reviewed-on: https://chromium-review.googlesource.com/1238476 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#56163}
-
- 18 Sep, 2018 1 commit
-
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I641c72959470471747221f94da545a053dfcc0b0 Reviewed-on: https://chromium-review.googlesource.com/1228064Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55977}
-
- 23 Jul, 2018 1 commit
-
-
Ross McIlroy authored
Use the new Isolate version of the methods. BUG=v8:7754 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id4f10d23927d6ae50cb458b5cac744617fa83e53 Reviewed-on: https://chromium-review.googlesource.com/1145387Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#54613}
-
- 22 Jun, 2018 1 commit
-
-
Dominic Farolino authored
As per https://github.com/whatwg/console/issues/27#issuecomment-289312546 and https://bugs.chromium.org/p/chromium/issues/detail?id=706804 we're leaving the console timeline/timelineEnd methods out of the specification and testing that implementations do not expose them (relevant WPTs at https://github.com/web-platform-tests/wpt/blob/master/console/console-tests-historical.any.js). Their implementations should be removed from Chrome, one of the last implementers of these legacy methods. The same goes for markTimeline, as it is deprecated in Chrome and not being included in the spec. R=bmeurer@chromium.org, kozyatinskiy@chromium.org Bug: chromium:706804 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibe05848fb664d26d16eeb5bdf6f519c1eeb4b2df Reviewed-on: https://chromium-review.googlesource.com/1082112Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#53973}
-
- 09 May, 2018 1 commit
-
-
Dominic Farolino authored
Implement console.countReset() from the WHATWG Console Standard R=bmeurer@chromium.org, dgozman@chromium.org, kozyatinskiy@chromium.org Bug: chromium:839947 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8a900e9cdf3e5b08506f709cf6497476c8c6c00b Reviewed-on: https://chromium-review.googlesource.com/1044902Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#53106}
-
- 23 Apr, 2018 1 commit
-
-
Erik Luo authored
This CL whitelists Console Command Line API callbacks on the V8 side. Bug: chromium:810176 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7afdd6bd4263cb4cb18bdf02b37ab3e822ae5c96 Reviewed-on: https://chromium-review.googlesource.com/1016094 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52747}
-
- 28 Mar, 2018 1 commit
-
-
Aleksey Kozyatinskiy authored
This reverts commit 9732f422. Reason for revert. Original change's description: > [inspector] queryObjects returns result > > queryObjects command line API return array instead of sending > inspectRequest notification. > > R=pfeldman@chromium.org > > Bug: chromium:825349 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ie6c64419cb108b313c43b66eab533c5a7d5d9024 > Reviewed-on: https://chromium-review.googlesource.com/978464 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52197} TBR=pfeldman@chromium.org,kozyatinskiy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:825349 Change-Id: I90f93b96981d8218b9ad1dc0f4ebfb5a7cb671bc Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/982431Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52254}
-
- 23 Mar, 2018 1 commit
-
-
Alexey Kozyatinskiy authored
queryObjects command line API return array instead of sending inspectRequest notification. R=pfeldman@chromium.org Bug: chromium:825349 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie6c64419cb108b313c43b66eab533c5a7d5d9024 Reviewed-on: https://chromium-review.googlesource.com/978464 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#52197}
-
- 22 Mar, 2018 1 commit
-
-
Yang Guo authored
R=jgruber@chromium.org, kozyatinskiy@chromium.org Bug: v8:178 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idee461c6ff6c8a14b01229ea6448e437f3db6dab Reviewed-on: https://chromium-review.googlesource.com/973202 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52151}
-
- 01 Dec, 2017 2 commits
-
-
Erik Luo authored
Aligns console.count() behavior with spec, which says the default label should be "default" when the label provided is not defined. Bug: chromium:700624 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie58af210d300ef3151082b23187dd18e356f5de8 Reviewed-on: https://chromium-review.googlesource.com/780620 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49804}
-
Erik Luo authored
Similar to Firefox and Safari, calling console.time() repeatedly with the same label will now produce a console warning indicating that the label already exists. Similarly for console.timeEnd() as well. Bug: chromium:727514 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id644ee107b09e7f4686fff44c5f32d31c88371ad Reviewed-on: https://chromium-review.googlesource.com/794345 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49803}
-
- 15 Nov, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
We can use v8::ArrayBuffer to store struct. R=dgozman@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6c4e994e3a8b0a19ad06f89dfadf808f8c6a68e6 Reviewed-on: https://chromium-review.googlesource.com/772036Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49390}
-
- 17 Oct, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
R=dgozman@chromium.org Bug: chromium:696798 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ida60ee5fb3e3e42d15bf6d4bad84dfcfb521b74f Reviewed-on: https://chromium-review.googlesource.com/722073Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#48617}
-
- 25 Sep, 2017 1 commit
-
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=yangguo@chromium.org Bug: v8:6837 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I88e5afea1ad0fdf23a81b380e64ff356bbc20112 Reviewed-on: https://chromium-review.googlesource.com/681374Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#48138}
-
- 24 Aug, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
API resolves functions to its .prototype property to make possible queries like queryObjects(Object), queryObjects(HTMLElement), e.t.c. R=dgozman@chromium.org Bug: v8:6732 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie8dc2288fa7e59c69f9b2647a9d5e35f0ac9215f Reviewed-on: https://chromium-review.googlesource.com/630244 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#47561}
-
- 23 Aug, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
- simplify prototype traversal. - use V8InspectorClient::isInspectableHeapObject since some embedders on JavaScript heap contains not inspectable objects, e.g. wrapper boilerplates in blink. - Runtime.queryObjects takes prototype object as argument for more flexibility. R=alph@chromium.org Bug: v8:6732 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I06f0d5c987150c80c3e9b05e7f6ad195985fc539 Reviewed-on: https://chromium-review.googlesource.com/627577 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#47559}
-
- 21 Aug, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
This API generates inspectRequested call with hints.queryObjects flag. It's not possible to expose this method by itself since command line API methods can leak. R=pfeldman@chromium.org Bug: v8:6732 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3c582186f65d84a25eed910925a1b6ab36966a72 Reviewed-on: https://chromium-review.googlesource.com/622370Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47480}
-
- 02 Aug, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
My goal was to move breakpoint API to native with minimal changes around, so on inspector side we use v8::debug::BreakpointId instead of String16, on v8::internal::Debug we use i::BreakPoint object instead of break point object created inside of debug.js. There are a lot of opportunities how we can improve breakpoints (at least we can avoid some of linear lookups to speedup implementation) but I think that as first step we need to remove mirrors/debug.js APIs. Drive by: debugger-script.js and usage of debugger context in inspector code base. R=yangguo@chromium.org,jgruber@chromium.org,clemensh@chromium.org Bug: v8:5510,chromium:652939 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I0b17972c39053dd4989bbe26db2bb0b88ca378f7 Reviewed-on: https://chromium-review.googlesource.com/593156Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47091}
-
- 12 Jul, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
Console methods should never throw an exception. R=jgruber@chromium.org Bug: chromium:736302 Change-Id: I05791b366d46a43b2a78825cbb8a82bb049110e6 Reviewed-on: https://chromium-review.googlesource.com/567434Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#46573}
-
- 11 Jul, 2017 2 commits
-
-
Michael Achenbach authored
This reverts commit 82451d45. Reason for revert: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/16923 Original change's description: > [inspector] doesn't run user code to stringify console method arg > > Otherwise user code can produce an exception and we will crash. > > R=jakob@chromium.org > > Bug: chromium:736302 > Change-Id: I078150909b0348a63e8c375b508e34fc4751b4ab > Reviewed-on: https://chromium-review.googlesource.com/565628 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46566} TBR=kozyatinskiy@chromium.org,jgruber@chromium.org,jakob@chromium.org Change-Id: I6d7e06fad2ab6c1c894c199fe7b3b6afb2930734 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:736302 Reviewed-on: https://chromium-review.googlesource.com/567060Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#46567}
-
Alexey Kozyatinskiy authored
Otherwise user code can produce an exception and we will crash. R=jakob@chromium.org Bug: chromium:736302 Change-Id: I078150909b0348a63e8c375b508e34fc4751b4ab Reviewed-on: https://chromium-review.googlesource.com/565628 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46566}
-
- 22 Jun, 2017 1 commit
-
-
Jochen Eisinger authored
In most cases, I'm using ENTER_V8 which is due to the fact that the respective methods might end up executing script, either because they invoke some callback, or because they might trigger a proxy trap. Also add microtask suppression scopes in the debugger to all the places that need one according to tests. BUG=v8:5830 R=marja@chromium.org,jgruber@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I24cc3de37fc0d8156acfe86b290568e5f8f662b4 Reviewed-on: https://chromium-review.googlesource.com/519262 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#46146}
-
- 12 Jun, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
console.context(name:string) method returns console instance, this console instance fully implements console interface (including fact that any method can be called without console as receiver). Protocol.Runtime.consoleAPICalled notification contains additional context:string field: - "anonymous#unique-id" for any method call on unnamed console context, - "name#unique-id" for any method call on named console context. console.count and console.timeEnd have context as a scope. console.clear clear all messages regardless on what context instance it was called. console calls is ~10% slower with this CL since we need to store and then fetch console_context_id and console_context_name from function object. We recently (in April) made console calls twice faster so 10% doesn't sound critical and existing of console.log call in hot code is problem by itself. R=pfeldman@chromium.org Bug: chromium:728767 Change-Id: I5fc73216fb8b28bfe1e8c2c1b393ebfbe43cd02e Reviewed-on: https://chromium-review.googlesource.com/522128Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#45864}
-
- 05 Jun, 2017 2 commits
-
-
dgozman authored
Instead of going through debugger agent, this patch implements console.assert pause similar to debugger statement and OOM break. New test uncovered a bug, where pause on exceptions state mix up between different context groups. Added a TODO to fix it. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2916363002 Cr-Commit-Position: refs/heads/master@{#45711}
-
dgozman authored
This gives sessions separate remote objects space and also makes command line api respect the session it was called from. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2916803005 Cr-Commit-Position: refs/heads/master@{#45708}
-
- 01 Jun, 2017 1 commit
-
-
dgozman authored
This patch adds ability to connect multiple sessions to a single context group. This is an experimental feature, which is already supported in test harness. So far covered runtime domain with tests (and found a bug thanks to the test). More tests to follow in next patches, probably with code adjustments as well. BUG=chromium:590878 Review-Url: https://codereview.chromium.org/2906153002 Cr-Commit-Position: refs/heads/master@{#45667}
-
- 20 Apr, 2017 1 commit
-
-
kozyatinskiy authored
A lot of web sites around the world has hack which replaces native console.assert by function with fast return. Current console.assert is slow because we need to run CPP builtin but we should enter this builtin iff condition is false or omitted. BUG=v8:6175 R=ishell@chromium.org,dgozman@chromium.org Review-Url: https://codereview.chromium.org/2828933002 Cr-Commit-Position: refs/heads/master@{#44752}
-