- 22 Aug, 2019 1 commit
-
-
Peter Marshall authored
We have internal::TickSample which inherits from this, but we never use the public version in the API despite defining it there. Change-Id: I6f0ce7ee663ef821be57cfbad540c1660484a525 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745472 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63329}
-
- 24 May, 2019 1 commit
-
-
Yang Guo authored
TBR=mvstanton@chromium.org,neis@chromium.org,ahaas@chromium.org Bug: v8:9247 Change-Id: I5433c863a54f3412d73df0d38aba3fdbcfac7ebe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627973 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61830}
-
- 15 May, 2019 1 commit
-
-
Andrew Comminos authored
Permit individual calls to CpuProfiler::StartSampling to provide their own requested sampling interval, to be snapped to the profiler's sampling interval. Use the greatest common divisor of all sample rates to determine what sample rate should be chosen for the sampling thread, and dispatch samples to attached profilers based on their requested sample periodicity. Change-Id: I0b076d09761d7176f31725e112578b68ab5da54c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1484461Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#61548}
-
- 08 Jan, 2019 1 commit
-
-
Peter Marshall authored
These flakes can't be reproduced locally so we need more information when they fail. Add some logging so that we can figure out why they are breaking. Bug: v8:8649, v8:8648 Change-Id: I2fb1384bb7592c6fc68c08952505e79329f00bec Reviewed-on: https://chromium-review.googlesource.com/c/1400418 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#58641}
-
- 10 Aug, 2016 1 commit
-
-
lpy authored
This patch is based on alph's CL https://codereview.chromium.org/2128613004/. This patch makes GetStackSample propogate the register state when using simulator helper, and adds argument to avoid using register state from simulator when pass the native register state. BUG=v8:4789 LOG=N Review-Url: https://codereview.chromium.org/2189513002 Cr-Commit-Position: refs/heads/master@{#38554}
-
- 11 Jul, 2016 1 commit
-
-
machenbach authored
Revert "Move SimulatorHelper into V8 out of profiler clients." This reverts commit b8372411. Revert "Make use of v8::TickSample instead of v8::internal::TickSample in logger." This reverts commit c3a16f0a. Revert "Clean up SimulatorHelper code." This reverts commit 8ee236e1. BUG=v8:5193 TBR=alph@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2138643003 Cr-Commit-Position: refs/heads/master@{#37626}
-
- 08 Jul, 2016 1 commit
-
-
alph authored
Clients should not know about the simulator. BUG=v8:4789 Review-Url: https://codereview.chromium.org/2128613004 Cr-Commit-Position: refs/heads/master@{#37617}
-
- 06 Jul, 2016 1 commit
-
-
lpy authored
We want to eventually move the profiling functionality out of V8 as library, this patch exposes TickSample and its APIs in v8-profiler.h so that when embedders use library, they can have more details. Minor change: Rename tick-sample.[h|cc] to simulator-helper.[h|cc]. BUG=v8:4789 LOG=N Review-Url: https://codereview.chromium.org/2105943002 Cr-Commit-Position: refs/heads/master@{#37564}
-
- 08 Jun, 2016 3 commits
-
-
alph authored
Make it a part of V8 API GetStackSample function. Also expose external_callback_entry in SampleInfo to break dependency of clients on internal V8 structures. BUG=v8:4789 Committed: https://crrev.com/70acfe39c07322144f5fe9b40bb584a8b1099ffd Review-Url: https://codereview.chromium.org/2007343003 Cr-Original-Commit-Position: refs/heads/master@{#36831} Cr-Commit-Position: refs/heads/master@{#36836}
-
alph authored
Revert of Move stack trace extraction code out of TickSample::Init (patchset #1 id:1 of https://codereview.chromium.org/2007343003/ ) Reason for revert: Make MSAN arm bot flaky Original issue's description: > Move stack trace extraction code out of TickSample::Init > > Make it a part of V8 API GetStackSample function. > Also expose external_callback_entry in SampleInfo to break dependency > of clients on internal V8 structures. > > BUG=v8:4789 > > Committed: https://crrev.com/70acfe39c07322144f5fe9b40bb584a8b1099ffd > Cr-Commit-Position: refs/heads/master@{#36831} TBR=yangguo@chromium.org,lpy@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4789 Review-Url: https://codereview.chromium.org/2049903002 Cr-Commit-Position: refs/heads/master@{#36835}
-
alph authored
Make it a part of V8 API GetStackSample function. Also expose external_callback_entry in SampleInfo to break dependency of clients on internal V8 structures. BUG=v8:4789 Review-Url: https://codereview.chromium.org/2007343003 Cr-Commit-Position: refs/heads/master@{#36831}
-
- 17 May, 2016 1 commit
-
-
lpy authored
Since we are going to move Sampler as library, we creates tick-sample.[h|cc] for TickSample, in order to maintain legacy code. BUG=v8:4994 LOG=n Review-Url: https://codereview.chromium.org/1952393002 Cr-Commit-Position: refs/heads/master@{#36267}
-