- 23 Mar, 2015 1 commit
-
-
mstarzinger authored
This removes the stub-based constructor from CompilationInfoWithZone as this class is more than a pure convenience class and only by chance doesn't have an effect in the destructor. R=titzer@chromium.org Review URL: https://codereview.chromium.org/1026513004 Cr-Commit-Position: refs/heads/master@{#27376}
-
- 18 Mar, 2015 2 commits
-
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1015983003 Cr-Commit-Position: refs/heads/master@{#27274}
-
verwaest authored
Replaces StoreGlobalCell / LoadGlobalCell with NamedField variants that use write barriers. BUG= Review URL: https://codereview.chromium.org/1016803002 Cr-Commit-Position: refs/heads/master@{#27269}
-
- 17 Mar, 2015 2 commits
-
-
dcarney authored
additionally, remove unnecessary deopts when transitioning to global accessor properties from data properties R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/996133002 Cr-Commit-Position: refs/heads/master@{#27239}
-
mvstanton authored
A hydrogen code stub is not the best approach because it builds a frame and doesn't have the technology to discard roots at tail call exits. Platform-specific stubs provide much better performance at this point. R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/988653003 Cr-Commit-Position: refs/heads/master@{#27235}
-
- 10 Feb, 2015 1 commit
-
-
svenpanne authored
Several tiny changes for the upcoming TurboFan-genrated handlers/stubs: * Relaxed the type of code_stub(). * Made GetCodeKind() public, it effectly was like this, anyway. * Const-corrected GetStubType(). Review URL: https://codereview.chromium.org/915583002 Cr-Commit-Position: refs/heads/master@{#26542}
-
- 05 Feb, 2015 4 commits
-
-
loislo authored
1) The hardcoded strings were converted into DeoptReason enum. 2) Deopt comment were converted into a pair location and deopt reason entries so the deopt reason tracking mode would less affect the size of the RelocInfo table and heap. 3) DeoptReason entry in RelocInfo reuses kCommentTag value and generates short entry in RelocInfo table. BUG=452067 LOG=n Committed: https://crrev.com/c49820e45b57f128a98690940875c049f612dde6 Cr-Commit-Position: refs/heads/master@{#26434} Committed: https://crrev.com/ec42e002da03adb2db968dd5b7453341ddc59a5c Cr-Commit-Position: refs/heads/master@{#26448} Review URL: https://codereview.chromium.org/874323003 Cr-Commit-Position: refs/heads/master@{#26463}
-
bmeurer authored
Revert of Externalize deoptimization reasons. (patchset #7 id:120001 of https://codereview.chromium.org/874323003/) Reason for revert: This CL breaks RelocInfo::INTERNAL_REFERENCE (and maybe others that come after DEOPT_REASON), which is currently (mostly) unused on tip-of-tree, but will be used for jump tables soon(ish) and should therefore work. It seems to be a problem with implicitly assumptions about the number of reloc info modes. Needs further investigation. Original issue's description: > Externalize deoptimization reasons. > > 1) The hardcoded strings were converted into DeoptReason enum. > > 2) Deopt comment were converted into a pair location and deopt reason entries so > the deopt reason tracking mode would less affect the size of the RelocInfo table and heap. > > 3) DeoptReason entry in RelocInfo reuses kCommentTag value and generates short entry in RelocInfo table. > > BUG=452067 > LOG=n > > Committed: https://crrev.com/c49820e45b57f128a98690940875c049f612dde6 > Cr-Commit-Position: refs/heads/master@{#26434} > > Committed: https://crrev.com/ec42e002da03adb2db968dd5b7453341ddc59a5c > Cr-Commit-Position: refs/heads/master@{#26448} TBR=alph@chromium.org,mstarzinger@chromium.org,svenpanne@chromium.org,yurys@chromium.org,loislo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=452067 Review URL: https://codereview.chromium.org/900223002 Cr-Commit-Position: refs/heads/master@{#26457}
-
Benedikt Meurer authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/900193002 Cr-Commit-Position: refs/heads/master@{#26454}
-
loislo authored
1) The hardcoded strings were converted into DeoptReason enum. 2) Deopt comment were converted into a pair location and deopt reason entries so the deopt reason tracking mode would less affect the size of the RelocInfo table and heap. 3) DeoptReason entry in RelocInfo reuses kCommentTag value and generates short entry in RelocInfo table. BUG=452067 LOG=n Committed: https://crrev.com/c49820e45b57f128a98690940875c049f612dde6 Cr-Commit-Position: refs/heads/master@{#26434} Review URL: https://codereview.chromium.org/874323003 Cr-Commit-Position: refs/heads/master@{#26448}
-
- 04 Feb, 2015 4 commits
-
-
loislo authored
Revert of Externalize deoptimization reasons. (patchset #6 id:100001 of https://codereview.chromium.org/874323003/) Reason for revert: it broke the build Original issue's description: > Externalize deoptimization reasons. > > 1) The hardcoded strings were converted into DeoptReason enum. > > 2) Deopt comment were converted into a pair location and deopt reason entries so > the deopt reason tracking mode would less affect the size of the RelocInfo table and heap. > > 3) DeoptReason entry in RelocInfo reuses kCommentTag value and generates short entry in RelocInfo table. > > BUG=452067 > LOG=n > > Committed: https://crrev.com/c49820e45b57f128a98690940875c049f612dde6 > Cr-Commit-Position: refs/heads/master@{#26434} TBR=alph@chromium.org,mstarzinger@chromium.org,svenpanne@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=452067 Review URL: https://codereview.chromium.org/892843007 Cr-Commit-Position: refs/heads/master@{#26435}
-
loislo authored
1) The hardcoded strings were converted into DeoptReason enum. 2) Deopt comment were converted into a pair location and deopt reason entries so the deopt reason tracking mode would less affect the size of the RelocInfo table and heap. 3) DeoptReason entry in RelocInfo reuses kCommentTag value and generates short entry in RelocInfo table. BUG=452067 LOG=n Review URL: https://codereview.chromium.org/874323003 Cr-Commit-Position: refs/heads/master@{#26434}
-
mvstanton authored
The first try failed because I needed to make a better distinction between clearing ICs according to policy at GC time or unconditional clearing (say, via %ClearFunctionTypeFeedback). It was also blocked by an issue in super constructor calls. This fix (https://codereview.chromium.org/892113002/) needs to land before checking in this CL. R=ulan@chromium.org Review URL: https://codereview.chromium.org/866493003 Cr-Commit-Position: refs/heads/master@{#26420}
-
marja authored
This enables adding more language modes in the future. For maximum flexibility, LanguageMode is a bitmask, so we're not restricted to use a sequence of language modes which are progressively stricter, but we can express the language mode as combination of features. For now, LanguageMode can only be "sloppy" or "strict", and there are STATIC_ASSERTS in places which need to change when more modes are added. LanguageMode is a bit like the old LanguageMode when "extended" mode was still around (see https://codereview.chromium.org/8417035 and https://codereview.chromium.org/181543002 ) except that it's transmitted through all the layers (there's no StrictModeFlag). BUG= Review URL: https://codereview.chromium.org/894683003 Cr-Commit-Position: refs/heads/master@{#26419}
-
- 03 Feb, 2015 1 commit
-
-
ulan authored
BUG=v8:3629 LOG=N Review URL: https://codereview.chromium.org/898723002 Cr-Commit-Position: refs/heads/master@{#26396}
-
- 02 Feb, 2015 1 commit
-
-
ulan authored
BUG=v8:3629 LOG=N Review URL: https://codereview.chromium.org/892213003 Cr-Commit-Position: refs/heads/master@{#26385}
-
- 30 Jan, 2015 3 commits
-
-
dcarney authored
R=mvstanton@chromium.org BUG= Review URL: https://codereview.chromium.org/889863002 Cr-Commit-Position: refs/heads/master@{#26352}
-
Dan Carney authored
BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/885303002 Cr-Commit-Position: refs/heads/master@{#26349}
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/878263002 Cr-Commit-Position: refs/heads/master@{#26345}
-
- 29 Jan, 2015 2 commits
-
-
machenbach authored
Revert of Use a WeakCell in the CallIC type vector. (patchset #4 id:80001 of https://codereview.chromium.org/881433002/) Reason for revert: Breaks a regression test on linux isloates, and linux with gcc 4.8. Original issue's description: > Use a WeakCell in the CallIC type vector. > > This allows us to clear the IC on a more sedate schedule, just > like Load and Store ICs. > > R=ulan@chromium.org > BUG= > > Committed: https://crrev.com/bcc79d33ca6d97d9ecfcfcf110a6ea84a0225389 > Cr-Commit-Position: refs/heads/master@{#26332} TBR=ulan@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/886663004 Cr-Commit-Position: refs/heads/master@{#26334}
-
mvstanton authored
This allows us to clear the IC on a more sedate schedule, just like Load and Store ICs. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/881433002 Cr-Commit-Position: refs/heads/master@{#26332}
-
- 21 Jan, 2015 1 commit
-
-
mostynb authored
Review URL: https://codereview.chromium.org/768683006 Cr-Commit-Position: refs/heads/master@{#26187}
-
- 15 Jan, 2015 1 commit
-
-
mvstanton authored
The MISS handler was being called when the receiver was a Smi, instead, we should recognize the case and use the heap number map. BUG= Review URL: https://codereview.chromium.org/854623002 Cr-Commit-Position: refs/heads/master@{#26076}
-
- 19 Dec, 2014 2 commits
-
-
mvstanton authored
Regular ICs in MONOMORPHIC and POLYMORPHIC state now hold onto maps with WeakCells. Vector-based ICs should do the same. R=ulan@chromium.org Review URL: https://codereview.chromium.org/815953002 Cr-Commit-Position: refs/heads/master@{#25907}
-
ulan authored
BUG=v8:3629 LOG=N Review URL: https://codereview.chromium.org/812353002 Cr-Commit-Position: refs/heads/master@{#25905}
-
- 15 Dec, 2014 1 commit
-
-
adamk authored
Review URL: https://codereview.chromium.org/805523002 Cr-Commit-Position: refs/heads/master@{#25810}
-
- 12 Dec, 2014 2 commits
-
-
Michael Stanton authored
This patch finally allows running and passing tests with vector-based Load and KeyedLoad ICs. BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/767743002 Cr-Commit-Position: refs/heads/master@{#25800}
-
svenpanne authored
We managed to access the scope_ member of CompilationInfo before its containing object was actually constructed. Rule of thumb: When constructing an object, never ever pass around pointers to members which come later in the member initializer list, you simply can't see locally if this might cause trouble or not. Review URL: https://codereview.chromium.org/796363002 Cr-Commit-Position: refs/heads/master@{#25796}
-
- 25 Nov, 2014 1 commit
-
-
yangguo authored
BUG=chromium:434447 Review URL: https://codereview.chromium.org/755173002 Cr-Commit-Position: refs/heads/master@{#25500}
-
- 19 Nov, 2014 1 commit
-
-
Michael Stanton authored
Due to performance issue. TBR=danno@chromium.org Review URL: https://codereview.chromium.org/735323002 Cr-Commit-Position: refs/heads/master@{#25421}
-
- 18 Nov, 2014 3 commits
-
-
Michael Stanton authored
Code was vulnerable to different evaluation order in Clang. R=danno@chromium.org Review URL: https://codereview.chromium.org/726693004 Cr-Commit-Position: refs/heads/master@{#25397}
-
Michael Stanton authored
This reverts commit d40204f8. TBR=danno@chromium.org Review URL: https://codereview.chromium.org/735653003 Cr-Commit-Position: refs/heads/master@{#25393}
-
Michael Stanton authored
We were deopting without learning anything. BUG=v8:3417 LOG=N R=danno@chromium.org Review URL: https://codereview.chromium.org/368263003 Cr-Commit-Position: refs/heads/master@{#25392}
-
- 17 Nov, 2014 1 commit
-
-
yangguo authored
Review URL: https://codereview.chromium.org/707463002 Cr-Commit-Position: refs/heads/master@{#25367}
-
- 12 Nov, 2014 1 commit
-
-
dslomov@chromium.org authored
1. Global{Context,Scope}=>Script{Context,Scope} 2. Enable fixed tests 3. Update comments R=rossberg@chromium.org BUG=v8:2198 LOG=N Review URL: https://codereview.chromium.org/716833002 Cr-Commit-Position: refs/heads/master@{#25291} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25291 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Nov, 2014 3 commits
-
-
dslomov@chromium.org authored
R=ishell@chromium.org, adamk@chromium.org, rossberg@chromium.org, verwaest@chromium.org BUG=v8:2198 LOG=N Review URL: https://codereview.chromium.org/712973002 Cr-Commit-Position: refs/heads/master@{#25264} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25264 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
R=ishell@chromium.org, adamk@chromium.org, rossberg@chromium.org, verwaest@chromium.org BUG=v8:2198 LOG=N Review URL: https://codereview.chromium.org/696783005 Cr-Commit-Position: refs/heads/master@{#25259} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25259 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ishell@chromium.org authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/711313002 Cr-Commit-Position: refs/heads/master@{#25258} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25258 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Nov, 2014 2 commits
-
-
verwaest@chromium.org authored
Revert "Fixes for Windows and Mac builds after r25250." TBR=ishell@chromium.org Review URL: https://codereview.chromium.org/699613004 Cr-Commit-Position: refs/heads/master@{#25252} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25252 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ishell@chromium.org authored
This CL introduces LayoutDescriptor which is responsible for tracking which in-object fields are tagged and which are not. LayoutDescriptor field added to Map. Currently unboxing is disabled. R=hpayer@chromium.org, verwaest@chromium.org Review URL: https://codereview.chromium.org/391693002 Cr-Commit-Position: refs/heads/master@{#25250} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25250 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-