1. 19 Aug, 2021 1 commit
    • Ng Zhi An's avatar
      [gdbjit] Fix overlapping AddressRegion check · 5e8e2d04
      Ng Zhi An authored
      Whenever we are adding a new AddressRegion to the CodeMap, we first
      remove all overlapping regions. The logic to check for overlapping
      region is incomplete. For example, if all existing regions are less than
      the region to be added, we incorrectly remove all regions, effectively
      deleting all JITCodeEntry we have constructed.
      
      We extract this overlapping check into a helper function, so that we can
      unittest this without worrying about JITCodeEvent functionality, and also
      without dealing with V8 internals (like Isolate and SFI).
      
      The overlapping logic is rather hard to understand, has many special
      cases, it will probably be much easier to just loop through all the
      entries, rather than using lower_bound. Ideally, we can refactor this to
      use some sort of sweep-line algorithm. Hopefully the unittests catch the
      most obvious cases.
      
      Bug: v8:11908
      Change-Id: Id96975599ac59974185c3dbf64cdfceb17e98d18
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3105381
      Commit-Queue: Zhi An Ng <zhin@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#76397}
      5e8e2d04
  2. 27 May, 2019 1 commit