Commits · 590707184d1031eb959516388c97ad6fbaf2207c · Linshizhi / V8

25 Mar, 2014 29 commits

MIPS: Refactor optimized in hydrogen only runtime functions. · 59070718

plind44@gmail.com authored Mar 25, 2014

Port r20252 (d0f806b)

Original commit message:
This splits all runtime function into 3 categories:
1) RUNTIME: implemented in runtime and called from both full and optimized code.
2) RUNTIME_HIDDEN: implemented in runtime, never called directly from JS builtins.
3) INLINE: inlined in both full and optimized code
4) INLINE_OPTIMIZED: inlined in optimized code, implemented in runtime for full code.

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/211453002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20257 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

59070718

HInnerAllocatedObject hydrogen trace printed offset incorrectly. · 839588d4

mvstanton@chromium.org authored Mar 25, 2014

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/210873003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20256 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

839588d4

ARM64: block veneer pool in InstructionAccurateScope. · d334c09b

ulan@chromium.org authored Mar 25, 2014

TEST=mozilla/ecma_3/RegExp/regress-169497
TBR=alexandre.rames@arm.com

Review URL: https://codereview.chromium.org/211323003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20255 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d334c09b

Revert r20246 "ARM64: Add overflow checking support for multiplications by constant powers of 2." · d0fe2952

ulan@chromium.org authored Mar 25, 2014

Reason: mjsunit/mul-exhaustive-part4 fails in no snaphot debug.

TBR=alexandre.rames@arm.com

Review URL: https://codereview.chromium.org/211393002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20254 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d0fe2952

TransitionElementsKind() and its recursive call chain handlified. · f306341b

ishell@chromium.org authored Mar 25, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/207553005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20253 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f306341b

Refactor optimized in hydrogen only runtime functions. · f66af4fe

dslomov@chromium.org authored Mar 25, 2014

This splits all runtime function into 3 categories:
1) RUNTIME: implemented in runtime and called from both full and optimized code.
2) RUNTIME_HIDDEN: implemented in runtime, never called directly from JS builtins.
3) INLINE: inlined in both full and optimized code
4) INLINE_OPTIMIZED: inlined in optimized code, implemented in runtime for full code.

R=yangguo@chromium.org, yannguo@chromium.org

Review URL: https://codereview.chromium.org/209353006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20252 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f66af4fe

Don't convert dictionary sloppy arguments to fast double mode. · c432f716

verwaest@chromium.org authored Mar 25, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/207683006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20251 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c432f716

Revert "This implements allocating small typed arrays in heap." · cdc98127

dslomov@chromium.org authored Mar 25, 2014

This reverts commit r20244 for breaking Win64 build and webkit tests.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/208503007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20250 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cdc98127

ARM64: Minor improvement in LCodeGen::DoCheckInstanceType. · 9ae45df6

baptiste.afsa@arm.com authored Mar 25, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/207453008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20248 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9ae45df6

ARM64: Add overflow checking support for multiplications by constant powers of 2. · d0219737

alexandre.rames@arm.com authored Mar 25, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/210253002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20246 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d0219737

Add index check in DoAccessArgumentsAt. · cb0f49c1

ulan@chromium.org authored Mar 25, 2014

BUG=355523
LOG=N
TEST=mjsunit/regress/regress-355523
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/210053003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20245 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cb0f49c1

This implements allocating small typed arrays in heap. · 654b6a27

dslomov@chromium.org authored Mar 25, 2014

R=mvstanton@chromium.org, verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20240

Review URL: https://codereview.chromium.org/150813004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20244 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

654b6a27

Handlify Runtime::GetElementOrCharAt. · 95dfa17c

yangguo@chromium.org authored Mar 25, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/210723004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20243 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

95dfa17c

Revert "This implements allocating small typed arrays in heap." · 727bc215

dslomov@chromium.org authored Mar 25, 2014

This reverts commit r20240 for breaking Windows build.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/211003003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

727bc215

Allow to neuter array buffer twice in tests. · de690b65

dslomov@chromium.org authored Mar 25, 2014

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/209083005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20241 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

de690b65

This implements allocating small typed arrays in heap. · 322a474b

dslomov@chromium.org authored Mar 25, 2014

R=mvstanton@chromium.org, verwaest@chromium.org

Review URL: https://codereview.chromium.org/150813004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20240 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

322a474b

Roll ICU 239289:258359 and add support for external ICU data tables · 04eefb86

jochen@chromium.org authored Mar 25, 2014

The only binary that supports ICU data tables is d8. The location of the
data table file has to be passed via a command line switch:

  $ out/x64.optdebug/d8 --icu-data-file=out/x64.optdebug/icudtl.dat

BUG=72633,v8:3142
R=danno@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/209323014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20239 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

04eefb86

Do not left-trim arrays when concurrent sweeping is active. · 51571d8f

hpayer@chromium.org authored Mar 25, 2014

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/207613004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20238 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

51571d8f

Extend GCMole to cover ARM64 architecture. · 95f61f92

mstarzinger@chromium.org authored Mar 25, 2014

R=ishell@chromium.org
BUG=

Review URL: https://codereview.chromium.org/210973003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20237 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

95f61f92

Fix for GCMole issue. · a883bc72

ishell@chromium.org authored Mar 25, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/210963002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20234 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a883bc72

Revert "Ship promises and weak collections" · 2e1b16de

rossberg@chromium.org authored Mar 25, 2014

Reason: breaks Blink layout tests.

R=machenbach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/210853003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20233 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2e1b16de

ARM64: Optimize RegList::IsValid() to speed up simulation in (opt)debug mode. · 25fd2882

alexandre.rames@arm.com authored Mar 25, 2014

On my machine this improves the simulation speed noticeably.
| test               | base  | patched |
|--------------------|-------|---------|
| optdebug           | 15:37 | 11:07   |
| debug --quickcheck | 33:53 | 26:14   |

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/209353010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20232 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

25fd2882

Only assign environments when they are actually needed. (ia32 only) · 09753b4a

svenpanne@chromium.org authored Mar 25, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/210783003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20231 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

09753b4a

Handlify GetElementWithReceiver and GetElementWithInterceptor. · 4ca46f3c

yangguo@chromium.org authored Mar 25, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/210763003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20230 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4ca46f3c

Callers of ElementsAccessor::SetCapacityAndLength() handlified. · 0d7bdc0f

ishell@chromium.org authored Mar 25, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/210063004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20229 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0d7bdc0f

Fix issues when changing FLAG_concurrent_recompilation after init. · 793d4cb0

yangguo@chromium.org authored Mar 25, 2014

R=jarin@chromium.org
BUG=356053
LOG=N

Review URL: https://codereview.chromium.org/210363005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20228 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

793d4cb0

Reland of "FastElementsAccessor::SetLengthWithoutNormalize() handlified." · 1ad4e2cc

ishell@chromium.org authored Mar 25, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/210563003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20227 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1ad4e2cc

Reland "No longer OOM on invalid string length." · 82f630a9

yangguo@chromium.org authored Mar 25, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/210683003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20225 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

82f630a9

First implementation of store elimination. · 3c311020

titzer@chromium.org authored Mar 25, 2014

BUG=
R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/100253004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20224 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3c311020

24 Mar, 2014 11 commits

Revert the (wrong) fix of the argument index check asserion. · b765d3cd

jarin@chromium.org authored Mar 24, 2014

R=ishell@chromium.org
BUG=

Review URL: https://codereview.chromium.org/208423017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20219 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b765d3cd

Fix to get around an assertion that triggers when generating code that happens... · 56f20066

jarin@chromium.org authored Mar 24, 2014

Fix to get around an assertion that triggers when generating code that happens to be dead because the assertion is checked a bit earlier at runtime.

R=ishell@chromium.org
BUG=355486
LOG=N

Review URL: https://codereview.chromium.org/201573011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20218 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

56f20066

fix FunctionCallbackInfo ambiguity · 56649364

dcarney@chromium.org authored Mar 24, 2014

- when compiling tools that embed v8 with g++ FunctionCallbackInfo is currently ambigous
- more info: https://github.com/joyent/node/issues/7337
- original patch is here: https://codereview.appspot.com/78770045/

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/201573012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20217 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

56649364

Revert "FastElementsAccessor::SetLengthWithoutNormalize() handlified." · f888aa19

ishell@chromium.org authored Mar 24, 2014

This reverts commit r20214 for breaking debug tests on various platforms.

R=vogelheim@chromium.org

Review URL: https://codereview.chromium.org/208313015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20216 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f888aa19

MIPS: Replaced unreachable code in DoStoreNamedField by an assertion. · 3f218038

plind44@gmail.com authored Mar 24, 2014

Port r20194 (2dfda0f)

Original commit message:
This is part of the effort to assign an environment if and only if we can deopt.

Removed some related dead code on the way.

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/210023004

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20215 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3f218038

FastElementsAccessor::SetLengthWithoutNormalize() handlified. · 5e892f7f

ishell@chromium.org authored Mar 24, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/208313012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20214 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5e892f7f

ARM64: Prevent compilers to optimize away NaN negation in tests. · 688d07d1

baptiste.afsa@arm.com authored Mar 24, 2014

BUG=v8:3226
R=ulan@chromium.org, jochen@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/196173021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20213 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

688d07d1

ARM64: Fix Register and FPRegister copy constructors. · e577a18b

alexandre.rames@arm.com authored Mar 24, 2014

This issue was introduced in r19156.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/207743003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20212 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e577a18b

Ship promises and weak collections · 33be68c2

rossberg@chromium.org authored Mar 24, 2014

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/206163004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20211 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

33be68c2

ARM64: push/pop registers in stubs for safepoints · 86f53020

m.m.capewell@googlemail.com authored Mar 24, 2014

BUG=

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/209933003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20210 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

86f53020

Add support for per-isolate private symbols · ff1186c8

rossberg@chromium.org authored Mar 24, 2014

R=mstarzinger@chromium.org
BUG=
LOG=Y

Review URL: https://codereview.chromium.org/196103004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20209 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ff1186c8