Skip to content

V
V8
Switch branch/tag
  1. 09 Jul, 2019 1 commit
  3. 25 Jun, 2019 1 commit
  5. 24 Jun, 2019 1 commit
  7. 19 Jun, 2019 1 commit
  9. 18 Jun, 2019 2 commits
  11. 14 Jun, 2019 2 commits
  13. 13 Jun, 2019 1 commit
  15. 12 Jun, 2019 1 commit
  17. 06 Jun, 2019 1 commit
  19. 31 May, 2019 1 commit
    • Mythri A's avatar
      [turbofan] Allow polymorphic inlining for Array push / pop / shift · 3e90eee9
      Mythri A authored 
      Array push / pop / shift were inlined if the elements kind of the
receiver maps is the same. This cl extends it by inlining these
builtins even when the receiver maps have different elements kinds.
It still limits it to only fast elements kinds. This is required to
prevent regressions in deltablue when lazy feedback allocation is
enabled. With lazy feedback allocation we may see polymorphic
feedback more often, since we don't have allocation site feedback
till the feedback vectors are allocated.

Bug: v8:9078
Change-Id: Id4a7b84be6305b125913b6ce0fb4f3eb3e3b15ec
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632239
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61949}
      3e90eee9
  21. 28 May, 2019 1 commit
  23. 27 May, 2019 1 commit
    • Georg Schmid's avatar
      Reland "Make LoadElimination aware of const fields (Part 2; stores)" · 85f257f4
      Georg Schmid authored 
      This is a reland of e588ff10

The only change over the original CL is found in JSCreateLowering::AllocateFastLiteral. We now guard against boilerplate values for unboxed double fields that *look* like legitimate initial values, but should really be kHoleNanInt64 instead.

The underlying problem certainly existed before, but an invariant added to LoadElimination in this CL caused a Chromium layout test to fail. The change in this reland is therefore a workaround, the root cause remains to be fixed. Specifically, we find that a pointer to the undefined value oddball is sometimes reinterpreted as a double and assigned as a boilerplate value. @jarin suspects that this stems from in-place map updates.

Original change's description:
> Make LoadElimination aware of const fields (Part 2; stores)
>
> Adds const information to store field accesses and uses it in load elimination
>
> Change-Id: I00765c854c95c955dabd78557463267b95f75eef
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1611543
> Reviewed-by: Georg Neis <neis@chromium.org>
> Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
> Commit-Queue: Georg Schmid <gsps@google.com>
> Cr-Commit-Position: refs/heads/master@{#61796}

Change-Id: Ie388754890024a3ca7d10c9d4d7391442655b426
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1630676Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
Commit-Queue: Georg Schmid <gsps@google.com>
Cr-Commit-Position: refs/heads/master@{#61838}
      85f257f4
  25. 24 May, 2019 1 commit
  27. 23 May, 2019 2 commits
  29. 22 May, 2019 1 commit
  31. 20 May, 2019 4 commits
  33. 16 May, 2019 1 commit
  35. 15 May, 2019 2 commits
  37. 14 May, 2019 1 commit
  39. 13 May, 2019 2 commits
  41. 08 May, 2019 2 commits
  43. 06 May, 2019 1 commit
  45. 03 May, 2019 2 commits
  47. 02 May, 2019 4 commits
  49. 01 May, 2019 1 commit
  51. 30 Apr, 2019 2 commits