- 17 Feb, 2020 9 commits
-
-
Michael Achenbach authored
Otherwise we report a spurious difference after OOM. Bug: chromium:1052849 Change-Id: I795f7393a8061ff41178295d49bdaea411d3c461 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060307Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66292}
-
Camillo Bruni authored
Make it explicit that AddShadowingKeys might allocate. Bug: chromium:1049013 Change-Id: I938531a0324fa581422b74813518f3e85c9b3fbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2046888 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#66288}
-
Clemens Backes authored
This again improves readability and makes the code much shorter. It might also allow us to generate a scheduled graph directly in the future, for improved wrapper compile times. R=jkummerow@chromium.org Bug: v8:10123 Change-Id: I0225d685a0660adb265eedcd160dfac6b4b23c87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2060001Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66287}
-
Santiago Aboy Solanes authored
Bug: v8:6949, v8:10155 Change-Id: I0113efe2d4d3a462533c306a87ebee851b1cb85c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056853Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#66286}
-
Georgia Kouveli authored
... instead of first claiming space on the stack and then storing it, which was sometimes causing the profiler to read the uninitialised frame type slot right after it was claimed, but before it was written to. Bug: v8:9907 Change-Id: I33318aec44b6083488317ec5e226a06e59c7560c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056473Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/master@{#66285}
-
Victor Gomes authored
The arm/arm64 simulators debugger has a command "mem" that prints the content of the memory. It also prints a short summary for JS objects (SMI, Array, JSFunction, ...). That is very handy, but when trying to print incomplete initialized memory, it could raise an exception. It is useful to have a command that prints the content of the memory for non-initialized or bogus values without the risk of raising an exception. This CL adds the command "dump". Change-Id: I682f97afa30a8d9dc572fe5e9dd256eeebf79de9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056468Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#66284}
-
Santiago Aboy Solanes authored
Bug: v8:6949, v8:10155 Change-Id: I5f5b78cb57776d1022f206f09242768b3dd8d9e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056848Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:6949, v8:10155 Change-Id: Iafd6b8172a67fa1b778d163259fe8d1400b004f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056847Reviewed-by:
-
Zhao Jiazhong authored
port 9d3dc6f2 https://crrev.com/c/1914218 Original Commit Message: FunctionEntry StackChecks is one of the two cases where we generate a StackCheck bytecode. In these cases, we do stack check against the js limit (not to be confused with the real js limit). Their purpose is to be able to interrupt the running code. We can omit the FunctionEntry StackCheck by embedding its code into the InterpreterEntryTrampoline builtin. We save one bytecode per interpreted function. This change has rippling effects for optimized code, as well as the deoptimizer. Change-Id: I2ad985959a3f55dfe80fabeffee3d344c1817c88 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050055 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#66281}
-
- 14 Feb, 2020 11 commits
-
-
Vitaly Buka authored
This variable significantly slows down indexed-getter.html of blink_perf.bindings on linux-perf https://pinpoint-dot-chromeperf.appspot.com/job/136cce54620000 V8_STACK_UNINITIALIZED macro is the same as http://crrev.com/c/1974951 Bug: chromium:977230 Change-Id: I3e7e91804e13b856d6b2ba0a5d67f0354636c510 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2046872 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Frank Tang authored
This reverts commit a872c393. Reason for revert: break gc_stress Original change's description: > [Intl] Fix RelativeTimeFormat fatal > > Intl.RelativeTimeFormat constructor crash while the locale or > numberingSystem contains an "algorithmic" numberingSystem. > Fix by fallback to the locale without the nu > > Bug: chromium:1041319 > Change-Id: Ica520e8dec6ace21264504274b92cb2c3d16286f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2055970 > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66276} TBR=jkummerow@chromium.org,ftang@chromium.org,syg@chromium.org Change-Id: I2ccfda197103d7de37d704494eb03fbe9e51ccea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1041319 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2057760Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#66277}
-
Frank Tang authored
Intl.RelativeTimeFormat constructor crash while the locale or numberingSystem contains an "algorithmic" numberingSystem. Fix by fallback to the locale without the nu Bug: chromium:1041319 Change-Id: Ica520e8dec6ace21264504274b92cb2c3d16286f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2055970Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:6949, v8:10155 Change-Id: Id170bafa2a5085bee6ff5b3cff8084254c67e113 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056846Reviewed-by:
-
Frank Tang authored
Find out style from skeleton instead to reduce object size. Bug: v8:10208 Change-Id: I7d26113311f51bc64ed0b259c3df81d526d5ab1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2055660Reviewed-by:
-
Frank Tang authored
Use adoptSymbols(NumberingSystem *) API in Intl.NumberFormat to reduce string size Bug: v8:10207 Change-Id: I3163c524612b61cfdad51743d58ece08b437520a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2055567Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:10155 Change-Id: Ia2eee32bface83bedeb52eb2b214809b5c657702 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056471 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
It was using nullptr to signal that it was empty. Bug: v8:10155 Change-Id: I0844d6a2bfacb1fd35ba83c24307de86f77f4e40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2056470Reviewed-by:
-
Pengyu Chen authored
The method has been non-const since initially introduced in de070ccf. Here's a minor change to make it const, for it may/shall be, for other similar methods are, and for making it easier for future changes (accessing this method in another const method, etc.). Change-Id: I3449214fc086403fc9b24b6f502ca20ac0b1426a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2055123Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#66270}
-
Georgia Kouveli authored
Change-Id: Ied0ee7f9c343dc802dec53c3d717a0ca359b504b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050398Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
-
Dan Elphick authored
Since the size of the parameters and locals inputs is already stored on the FrameStateFunctionInfo, this skips the calls to size() and just reuses the previous values. The stack parameter can only have a size of 0 or 1 depending on whether it's a InterpretedFunction frame or not. It also extends the verifier to check that the values to match those returned by StateValueAccess::size and changes a unit test that added a TypedStateValues of size 2 to the stack input. Bug: v8:10051 Change-Id: I3693c04b4677812b9f19491c198d0551df20f817 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2047045Reviewed-by:
-
- 13 Feb, 2020 9 commits
-
-
Thibaud Michaud authored
The previous code was relying on {compilation_unit_builder_} to check if a section was after or before the code section. This only works for the first section after code section, since the compilation unit builder is then reset. Use an additional field to track this instead. R=clemensb@chromium.org Bug: chromium:1051912 Change-Id: Id1dfa803ecde2cf77f206ea781c007fc61168942 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2054099 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: -
Milad Farazmand authored
LoadTransform cannot efficiently be executed on BE machines as a single operation since loaded bytes need to be reversed to match BE ordering before any operations can take place. This CL divides LoadTransform into separate "load" and "operation" nodes on BE machines. Change-Id: Idc3f66d7f17647c189c75593e8906f8645448006 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050811 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
Bug: v8:10155 Change-Id: Ie58924fdbdb2267ec7d7e3cc63d9cd504fd4f4d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2053079 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#66263}
-
Dominik Inführ authored
Use similar strategy to scavenger when calculating number of parallel compaction tasks. Do not add task for each page but every fourth page. Bug: chromium:1051883 Change-Id: Iaba3046de9c9a3ab63c0e7afcc6e4a9c398c5a10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2054097Reviewed-by:
-
Maya Lekova authored
The GC suspect was GetAbstractPC. Fixed: v8:9990, v8:9987, chromium:1048038 Change-Id: I86a27e2098589dbf6af0808d6770c5e69987f1f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050394 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#66259}
-
Georg Neis authored
The fix in b8b60750 was insufficient. The bug is that induction variable typing does not take into account that the value can become NaN through addition or subtraction of Infinities. The previous fix incorrectly assumed that this can only happen when the initial value of the loop variable is an Infinity. Bug: chromium:1051017 Change-Id: I8c9ffb2925288b80c00e18e7bc22a556bf540733 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2051957 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#66258}
-
Georg Neis authored
Bug: chromium:1051017 Change-Id: I597363417d905bc65522d64ebfa2cbf9dde4b98f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2054086Reviewed-by:
-
Georgia Kouveli authored
This is a reland of 137bfe47 Original change's description: > [arm64] Protect return addresses stored on stack > > This change uses the Arm v8.3 pointer authentication instructions in > order to protect return addresses stored on the stack. The generated > code signs the return address before storing on the stack and > authenticates it after loading it. This also changes the stack frame > iterator in order to authenticate stored return addresses and re-sign > them when needed, as well as the deoptimizer in order to sign saved > return addresses when creating new frames. This offers a level of > protection against ROP attacks. > > This functionality is enabled with the v8_control_flow_integrity flag > that this CL introduces. > > The code size effect of this change is small for Octane (up to 2% in > some cases but mostly much lower) and negligible for larger benchmarks, > however code size measurements are rather noisy. The performance impact > on current cores (where the instructions are NOPs) is single digit, > around 1-2% for ARES-6 and Octane, and tends to be smaller for big > cores than for little cores. > > Bug: v8:10026 > Change-Id: I0081f3938c56e2f24d8227e4640032749f4f8368 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1373782 > Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66239} Bug: v8:10026 Change-Id: Id1adfa2e6c713f6977d69aa467986e48fe67b3c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2051958Reviewed-by:
-
Leszek Swirski authored
This is a reland of 453e1a3b Added canonical "empty" arrays to ScannerStream::ForTesting, for the zero-length nullptr data case. Original change's description: > [offthread] Add SFI support to OffThreadFactory > > Add support for off-thread SharedFunctionInfo allocation, which > includes UncompiledData and PreparseData allocation. > > Bug: chromium:1011762 > Change-Id: Ia10f9ce762c7d7eb1108b9e71da75131dce919b7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050393 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66246} TBR=ulan@chromium.org Bug: chromium:1011762 Change-Id: I37d2c6b9317548922913887940a0164cc2067efb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2054085Reviewed-by:
-
- 12 Feb, 2020 11 commits
-
-
Shu-yu Guo authored
R=ulan@chromium.org Bug: v8:8179 Change-Id: I9626bd070453ce1b7d4b91cf78b9f75b74dfddbe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2051605 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
A FinalizationGroup that needs cleanup should not artificially prolong its lifetime by being on the dirty list. R=ulan@chromium.org Bug: v8:8179 Change-Id: I19f102d154a9ac43b549b7d833d0c3ca7e61c6d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2051562Reviewed-by:
-
Shu-yu Guo authored
Though the task is never explicitly canceled, making it cancelable ensures that it is canceled on Isolate teardown. R=ulan@chromium.org Bug: v8:8179 Change-Id: Ic3912b7acc7249aed8397010c98dc407222e84be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2049898Reviewed-by:
-
Maya Lekova authored
Handle the undefined promiseOrCapability case in RejectPromiseReactionJob and FulfillPromiseReactionJob. Fixed: chromium:1046213 Change-Id: If6f51c28189a27476969c7b5b456741b5be829be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050399 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit 453e1a3b. Reason for revert: Makes UBSan unhappy - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/9893 Original change's description: > [offthread] Add SFI support to OffThreadFactory > > Add support for off-thread SharedFunctionInfo allocation, which > includes UncompiledData and PreparseData allocation. > > Bug: chromium:1011762 > Change-Id: Ia10f9ce762c7d7eb1108b9e71da75131dce919b7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050393 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66246} TBR=ulan@chromium.org,leszeks@chromium.org,ishell@chromium.org Change-Id: I26bc40ec1c351613f19745aed83f0c3a9fdd9a20 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1011762 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2052172Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#66247}
-
Leszek Swirski authored
Add support for off-thread SharedFunctionInfo allocation, which includes UncompiledData and PreparseData allocation. Bug: chromium:1011762 Change-Id: Ia10f9ce762c7d7eb1108b9e71da75131dce919b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050393 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Nico Hartmann authored
This reverts commit 137bfe47. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Arm%20-%20debug/13072 Original change's description: > [arm64] Protect return addresses stored on stack > > This change uses the Arm v8.3 pointer authentication instructions in > order to protect return addresses stored on the stack. The generated > code signs the return address before storing on the stack and > authenticates it after loading it. This also changes the stack frame > iterator in order to authenticate stored return addresses and re-sign > them when needed, as well as the deoptimizer in order to sign saved > return addresses when creating new frames. This offers a level of > protection against ROP attacks. > > This functionality is enabled with the v8_control_flow_integrity flag > that this CL introduces. > > The code size effect of this change is small for Octane (up to 2% in > some cases but mostly much lower) and negligible for larger benchmarks, > however code size measurements are rather noisy. The performance impact > on current cores (where the instructions are NOPs) is single digit, > around 1-2% for ARES-6 and Octane, and tends to be smaller for big > cores than for little cores. > > Bug: v8:10026 > Change-Id: I0081f3938c56e2f24d8227e4640032749f4f8368 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1373782 > Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66239} TBR=rmcilroy@chromium.org,mstarzinger@chromium.org,neis@chromium.org,georgia.kouveli@arm.com Change-Id: I57d5928949b0d403774550b9bf7dc0b08ce4e703 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10026 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2051952Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#66242}
-
Seth Brenith authored
The list of forward declarations required in the generated file bit-fields-tq.h is already somewhat unwieldy and will run into serious problems when we attempt to use enums that are defined within classes, such as JSDateTimeFormat::DateTimeStyle. After a brief discussion today, the cleanest solution we arrived at is to generate macros instead. Change-Id: I654e10efbab5a1a0a340fa565c51ff1da34badaa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050830Reviewed-by:
-
Georgia Kouveli authored
This change uses the Arm v8.3 pointer authentication instructions in order to protect return addresses stored on the stack. The generated code signs the return address before storing on the stack and authenticates it after loading it. This also changes the stack frame iterator in order to authenticate stored return addresses and re-sign them when needed, as well as the deoptimizer in order to sign saved return addresses when creating new frames. This offers a level of protection against ROP attacks. This functionality is enabled with the v8_control_flow_integrity flag that this CL introduces. The code size effect of this change is small for Octane (up to 2% in some cases but mostly much lower) and negligible for larger benchmarks, however code size measurements are rather noisy. The performance impact on current cores (where the instructions are NOPs) is single digit, around 1-2% for ARES-6 and Octane, and tends to be smaller for big cores than for little cores. Bug: v8:10026 Change-Id: I0081f3938c56e2f24d8227e4640032749f4f8368 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1373782 Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Reviewed-by:
-
Dominik Inführ authored
Enable --always-promote-young-mc by default. This enforces that the young generation is empty after a full GC to simplify the implementation of some features. For example array buffer sweeping already assumes that this flag is enabled. Bug: v8:10064 Change-Id: I9d3873b9eb7bec4de897c5c95bdc514d165265d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2051943Reviewed-by:
-
Leszek Swirski authored
Clean-up a couple of CAS loops to avoid loading after a compare_exchange (which updates the old value), and to loosen the memory ordering to acquire-release to avoid unnecessary fences. Change-Id: Ifb8e5e5136f687ca5a71417a5d131a7023add054 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050390 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#66235}
-
